GitLab

PAGE_ACTION also added as a new possible SourceUI value to both proto file enum and code enum.

BUG=613883

Review-Url: https://codereview.chromium.org/2075523002
Cr-Commit-Position: refs/heads/master@{#406769}

We used to have a complicated dependency between the notifications and push
messaging permissions and content settings. The push messaging content setting
will no longer be used (the setting will be deleted in a follow up CL). Since
the permissions are essentially the same now, we reuse the same
PermissionContext class for both, with some very slight behavioral differences
for push messaging.

Behaviorally, this change will mean that if a user happened to have
CONTENT_SETTINGS_TYPE_PUSH_MESSAGING set to block for a particular origin,
they will fall back to their CONTENT_SETTINGS_TYPE_NOTIFICATIONS setting for
that origin. Note that it's very unlikely that any users do have
CONTENT_SETTINGS_TYPE_PUSH_MESSAGING set, as it seems like this setting
was never actually exposed to users on stable. More details can be found here:
https://docs.google.com/document/d/1-Vny4paBx6gFZuCeLX2Gq9ztkF-JhNYM_uqvrQDj-6M/edit#heading=h.h99sppup43dn

BUG=628058

Committed: https://crrev.com/4f82b403f397fbad2e44fe287c05956fcb7cf282
Review-Url: https://codereview.chromium.org/2149883002
Cr-Original-Commit-Position: refs/heads/master@{#406225}
Cr-Commit-Position: refs/heads/master@{#406768}

Review-Url: https://codereview.chromium.org/2157363006
Cr-Commit-Position: refs/heads/master@{#406767}

PermissionUmaUtil::PermissionIgnored is previously called with nullptr passed for the profile parameter.

BUG=613883

Review-Url: https://codereview.chromium.org/2069343002
Cr-Commit-Position: refs/heads/master@{#406766}

This CL removes the last code in //ui/gl that depends on //ui/ozone. It
then inverts the dependency so that //ui/ozone depends on //ui/gl and
each OzonePlatform can override GL specific classes.

GLImageOzoneNativePixmap is moved into a new target //ui/ozone/gl. This
is only possible now that the dependency problem has been fixed.

There is an issue with tests for GLImageOzoneNativePixmap. They are
still located in //ui/gl:gl_unittests as they depend on
//ui/gl:test_support. Moving the tests into //ui/ozone:ozone_unittests
has additional dependency problems. A new ozone_gl_unittests target
could be added in the future to avoid this but the remaining tests are
currently disabled anyways.

This is the finally CL in step 2 of the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2102443003
Cr-Commit-Position: refs/heads/master@{#406765}

Currently, the call to
RenderWidgetHostViewAura::ChangeTextDirectionAndLayoutAlignment is only
routed to the tab's RenderWidge; which happens regardless of the
currently active widget. This CL will modify the code so that this IME
call is always routed to the active widget obtained from
TextInputManager. The CL also adds a unit test.

BUG=578168,602723

Review-Url: https://codereview.chromium.org/2161043002
Cr-Commit-Position: refs/heads/master@{#406764}

BUG=607028

Review-Url: https://codereview.chromium.org/2164783002
Cr-Commit-Position: refs/heads/master@{#406763}

R=dschuyler@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2165893005
Cr-Commit-Position: refs/heads/master@{#406762}

1- This makes sure we can send the GpuHostMsg_Initialized message ASAP, since
it's in the critical path
2- This makes sure we don't start handling mojo requests if the GPU process is
about to exit (dead_on_arrival_ case)
3- This ensures that by construction GpuProcessControlImpl and
GpuArcVideoService won't access GpuChildThread before it's initialized
4- This ensures log messages caused by those are not lost

BUG=None

Review-Url: https://codereview.chromium.org/2158423004
Cr-Commit-Position: refs/heads/master@{#406761}

Both computed section and platform fonts should not be shrinkable.

BUG=none
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2171653002
Cr-Commit-Position: refs/heads/master@{#406760}

The following change moved the location of our IPC test channels to the
home directory which is why we were seeing left-over crud there when the
tests were cancelled:
Change 4e752e10
https://codereview.chromium.org/2003753002

My change moves the location from the home directory, which can cause
problems for local development to the temp directory which should work
for both local devs and trybots.  I've also included other posix based
OSes in this change since their IPC channels use UDS as well (Windows
should not be changed since it still uses named pipes).

BUG=621995

Review-Url: https://codereview.chromium.org/2161013003
Cr-Commit-Position: refs/heads/master@{#406759}

https://chromium.googlesource.com/skia.git/+log/3fb87201a104..0c902473d64e

$ git log 3fb87201a..0c902473d --date=short --no-merges --format='%ad %ae %s'
2016-07-20 mtklein Correct sRGB <-> linear everywhere.
2016-07-20 msarett Revert of Refactor parsing and storage of SkGammas (patchset #8 id:280001 of https://codereview.chromium.org/2117773002/ )
2016-07-20 reed Have MakeFromImage fission the SkImage into a raster or a texture (patchset #1 id:1 of https://codereview.chromium.org/2167813002/ )"

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2167983002
Cr-Commit-Position: refs/heads/master@{#406758}

They should be the same color as other links and have no underline on
:hover.

R=hcarmona@chromium.org
BUG=630067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2165183002
Cr-Commit-Position: refs/heads/master@{#406757}

+ Implement a more stable way to check if the dialog is fully loaded before choose the sink, instead of hardcoding the waiting time.

+ Also increase the timeout for stopping session.

Review-Url: https://codereview.chromium.org/2166433003
Cr-Commit-Position: refs/heads/master@{#406756}

tl;dr - the style loading order matters, action_link.css must come
before <style include="settings-shared">.

R=hcarmona@chromium.org
BUG=630067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2167043002
Cr-Commit-Position: refs/heads/master@{#406755}

Specification:
https://www.w3.org/TR/payment-request/#updatewith

BUG=629461

Review-Url: https://codereview.chromium.org/2163193002
Cr-Commit-Position: refs/heads/master@{#406754}

This is plumbed around but doesn't seem to be used in practice except for a
couple of EXPECTs in a unit test. This CL deletes it.

BUG=none
TBR=reveman@chromium.org for trivial exo change.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2167713002
Cr-Commit-Position: refs/heads/master@{#406753}

Cr-Commit-Position: refs/heads/master@{#406752}

This changes the way that descriptions are displayed when an item is
selected. Previously both the label and the description were wrapped
individually. With this change the two <span> elements are combined
and will now wrap as one message.

BUG=418195
TEST=tested "Clear Browsing Data" dialogs manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2158403003
Cr-Commit-Position: refs/heads/master@{#406751}

Both Mojom interfaces and Mojo type-converters need security review.

Review-Url: https://codereview.chromium.org/2154303003
Cr-Commit-Position: refs/heads/master@{#406750}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cda131c42ac8..6e428a2e9411

$ git log cda131c42..6e428a2e9 --date=short --no-merges --format='%ad %ae %s'

BUG=630017,628836

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2168813002
Cr-Commit-Position: refs/heads/master@{#406749}

I ended up moving the aura parts directly into
accelerator_controller_delegate_aura as it didn't seem worth an extra
file as the code is always compiled (and isn't that much).

BUG=626869
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2168733002
Cr-Commit-Position: refs/heads/master@{#406748}

Swiping away the Chrome activity does not cause the process to be killed
if a Chrome Custom Tab is open somewhere. In this case, when Chrome is
started again, the CipherData static still has the old Activity's
incognito key stored in it and the tabs are unexpectedly restored.

This changes the start-up behaviour to explicitly ignore incognito tab
state files when no bundle is passed to the activity's onCreate.

BUG=626629

Review-Url: https://codereview.chromium.org/2166943002
Cr-Commit-Position: refs/heads/master@{#406747}

BUG=626869
TEST=none
R=jamescook@chromium.org,reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2163253003
Cr-Commit-Position: refs/heads/master@{#406746}

Reason for revert:
Looks like this broke gyp: https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/892 https://build.chromium.org/p/chromium.mac/builders/Mac%20GYP%20%28dbg%29/builds/1249

The issue seems non-trivial to fix (may need an angle roll), so reverting.

Original issue's description:
> Roll gtest.
>
> The change in directory structure requires the checkout to be moved to
> a different directory, and some dummy header files that re-direct to the
> new location.
>
> TBR=juliatuttle@chromium.org
>
> Committed: https://crrev.com/4266a7d49d60d3af744bfb513cbdeb716b0b6782
> Cr-Commit-Position: refs/heads/master@{#406741}

TBR=phajdan.jr@chromium.org,agrieve@chromium.org,juliatuttle@chromium.org,amistry@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2171663002
Cr-Commit-Position: refs/heads/master@{#406745}

BUG=624136

Review-Url: https://codereview.chromium.org/2161423002
Cr-Commit-Position: refs/heads/master@{#406744}

BUG=615157

Review-Url: https://codereview.chromium.org/2172463003
Cr-Commit-Position: refs/heads/master@{#406743}

This adds a |ProcessExpectStaple| method to TransportSecurityState that
implements reporting for Expect-Staple, using contents of SSLInfo and
OCSPVerifyResult. No report is sent if a valid staple is provided, or if
the remote host is not on the Expect-Staple preload list. This method is
not currently called by any socket implementation.

BUG=598021

Review-Url: https://codereview.chromium.org/2144693004
Cr-Commit-Position: refs/heads/master@{#406742}

The change in directory structure requires the checkout to be moved to
a different directory, and some dummy header files that re-direct to the
new location.

TBR=juliatuttle@chromium.org

Review-Url: https://codereview.chromium.org/2163573002
Cr-Commit-Position: refs/heads/master@{#406741}

Make sure the key events received by the aura::WindowTreeHost instance goes
through the IME, so that text input works correctly.

BUG=629596

Review-Url: https://codereview.chromium.org/2166863002
Cr-Commit-Position: refs/heads/master@{#406740}

Revert of Support early associated interface binding on ChannelMojo (patchset #5 id:80001 of https://codereview.chromium.org/2163633003/ )

Reason for revert:
Lots of browser_tests failures.

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/266272

Original issue's description:
> Support early associated interface binding on ChannelMojo
>
> Changes the associated bindings implementation for ChannelMojo
> such that remote interfaces can be acquired immediately upon
> ChannelMojo construction rather than having to wait for connection
> on the IO thread.
>
> Simplifies the Channel bootstrapping process, removing a round-trip
> Init message (and in fact the entire IPC::mojom::Boostrap interface)
> since there's no need to actually exchange associated interface handles
> over the pipe. Instead both sides can assume the other will use a fixed,
> reserved endpoint ID for their IPC::mojom::Channel interface.
>
> This also removes the restriction that associated interfaces must be
> added to a Channel after Init. Instead the same constraints apply as
> with AddFilter: an associated interface, like a filter, may be added
> at any time as long as either Init hasn't been called OR the remote
> process hasn't been launched.
>
> The result of this CL is that any place it's safe to AddFilter,
> it's also safe to AddAssociatedInterface; and any place it's safe to
> Send, it's also safe to GetRemoteAssociatedInterface and begin using
> any such remote interface immediately.
>
> Remote interface requests as well as all messages to remote interfaces
> retain FIFO with respect to any Send calls on the same thread. Local
> interface request dispatch as well as all messages on locally bound
> associated interfaces retain FIFO with respect to any OnMessageReceived
> calls on the same thread.
>
> BUG=612500,619202
>
> Committed: https://crrev.com/e1037f997da9e1d44ca3b09d4ff32f0465673091
> Cr-Commit-Position: refs/heads/master@{#406720}

TBR=yzshen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612500,619202

Review-Url: https://codereview.chromium.org/2167973002
Cr-Commit-Position: refs/heads/master@{#406739}

This patch makes |CompositeEditCommand::moveParagraph()| to abort when
destination of paragraph becomes invisible.

This patch also changes |assert_selection()| test utility to handle no BODY
element document to support attached test.

BUG=620873
TEST=LayoutTests/editing/execCommand/apply_style/justify_full_without_body_crash.html

Review-Url: https://codereview.chromium.org/2131113002
Cr-Commit-Position: refs/heads/master@{#406738}

(Attempted to put this in the "gpu" category but ran into
http://crbug.com/630030 .)

This will help in the creation of TBMv2 WebGL benchmarks.

BUG=catapult:#2446

Review-Url: https://codereview.chromium.org/2163373005
Cr-Commit-Position: refs/heads/master@{#406737}

Includes test. Screenshot in bug.

BUG=626119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2092763004
Cr-Commit-Position: refs/heads/master@{#406736}

The current path does a conversion from YUV to an RGBA SkImage, then
paints that to another Skia canvas and does a CopyTexImageCHROMIUM to
the WebGL texture.

We can optimize this by removing the paint to the canvas and doing a
copy directly from the SkImage to the WebGL texture.

BUG=625900

Review-Url: https://codereview.chromium.org/2127053004
Cr-Commit-Position: refs/heads/master@{#406735}

BUG=629932

Review-Url: https://codereview.chromium.org/2160983007
Cr-Commit-Position: refs/heads/master@{#406734}

SecureOriginWhiteListTest.UnsafelyTreatInsecureOriginAsSecure currently marks
2 insecure origins as secure. This state leaks to other tests such that those
origins are treated as secure in those tests. This CL cleans up the state by
resetting SchemeAndOriginWhitelist after the test.

BUG=629499

Review-Url: https://codereview.chromium.org/2157363004
Cr-Commit-Position: refs/heads/master@{#406733}

In case a gpu query is not required to check if overlay
resources have been released, we can release overlay
resources used by the previous frame on swap-ack instead
of waiting until the next swap buffers call.

BUG=b/29430506
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2166973002
Cr-Commit-Position: refs/heads/master@{#406732}

BUG=625315

Review-Url: https://codereview.chromium.org/2159133003
Cr-Commit-Position: refs/heads/master@{#406731}

Remove enable_priority_dependencies from HttpNetworkSession::Params and from
SpdySessionPool.  Remove priority_dependencies_enabled_ from SpdySession.

BUG=564228

Review-Url: https://codereview.chromium.org/2165023002
Cr-Commit-Position: refs/heads/master@{#406730}