- 21 Aug, 2018 40 commits
-
-
Sadrul Habib Chowdhury authored
The fix from the original change is to share the shared-memory handle with the child process only if a child process is actually launched. There can be configurations where a child-process is not launched (e.g. for in-process gpu etc.), and in such cases, it is not necessary to create a separate PersistentMemoryAllocator, since there already is an existing one for the browser process. Original change's description: metrics: Initialize persistent metric allocator early. The PersistentMemoryAllocator in the gpu (and other) process is created asynchronously. If any uma-histogram is reported before that time, then those Histograms are not stored in the shared memory. This has some implications: . If the process crashes (which is common for the gpu process on android), then these metrics are lost. . If the process stays alive, then the metrics are reported periodically, but because it is buffered, it doesn't match up correctly with the other metrics that are reported in the shared memory. The allocator is created in response to a message from the browser, which includes the handle for the shared memory to use for the allocator. The browser waits until the process has been launched and connected. So this happens much later, compared to other messages which are sent from browser over mojo without waiting for the connection to have been established first. Therefore, change this so that the browser immediately shares the shared-memory segment with the gpu process. mojo takes care of waiting for the process-launch etc. BUG=865179, 778749, 875640 Change-Id: Ieffc014ae711d4bc922cda8034bc4a05fd861bde Reviewed-on: https://chromium-review.googlesource.com/1182041Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#584642}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I564642174a6ceee6002c6e041b0f32e5d5adf7b5 Reviewed-on: https://chromium-review.googlesource.com/1182942Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#584641}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5b10a4c713fb..b2b00c31f48c git log 5b10a4c713fb..b2b00c31f48c --date=short --no-merges --format='%ad %ae %s' 2018-08-20 tsepez@chromium.org Use UnownedPtr<> in JBig2_GrdProc.h 2018-08-20 tsepez@chromium.org Use UnownedPtr<> in CXFA_GEColor. 2018-08-20 tsepez@chromium.org Use UnownedPtr<> in CPDF_ObjectWalker. 2018-08-20 tsepez@chromium.org Use more UnownedPtr<> in CPWL_Wnd::CreateParams. 2018-08-20 thestig@chromium.org Fix nits in CXFA_Node. 2018-08-20 thestig@chromium.org Clean up CXFA_Graphics::SetLineDash(). 2018-08-20 thestig@chromium.org Fix reversed arguments to GenerateResourceDict(). 2018-08-20 thestig@chromium.org Simplify CPDF_InterForm::GenerateNewResourceName(). 2018-08-20 thestig@chromium.org Avoid an integer overflow in CFX_RTFBreak. 2018-08-20 thestig@chromium.org Use more consts in CFX_Break. Created with: gclient setdep -r src/third_party/pdfium@b2b00c31f48c The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875282 TBR=dsinclair@chromium.org Change-Id: Ib1dfc7139886c5721ccd3180cb512b04ce4c293f Reviewed-on: https://chromium-review.googlesource.com/1182641Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584640}
-
Jeremy Klein authored
The PWA install API always needs the experiment URL params for now, but the service worker logic can never have those or stuff breaks. This change resolves that discrepancy. Also switch the staging url to point to one that doesn't require uberproxy because the PWA install API doesn't play well with URLs that have redirects. This still points to the same actual Messages code, though. R=azeemarshad@chromium.org Bug: 870072 Change-Id: I23f6f0c4d375f2301cfd1b8efb94d36bf88581cf Reviewed-on: https://chromium-review.googlesource.com/1182868Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#584639}
-
Timothy Loh authored
Since we have crostini_pref_names, the kCrostiniRegistryPref for the Crostini registry should be in there instead of being separated. Change-Id: Ia89192dc2ac11c9cd38bf79725fc3951e3d99211 Reviewed-on: https://chromium-review.googlesource.com/1179510Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#584638}
-
Alexander Alekseev authored
min-height/min-width => height/width if(getAttribute) => if(hasAttribute) Bug: 864686 Change-Id: If179f64af2d3ced1f2902a6c1b205a37558f709c Reviewed-on: https://chromium-review.googlesource.com/1182502Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#584637}
-
Artur Khachatryan authored
Handle the case where args.GetSize() > 1. This happens when the first arg is a printf-style format string. We previously return the first arg format string to the test client. Now, we return all args separated by spaces. The oroginal author of this change was sblancov84@gmail.com Bug: chromedriver:669 Change-Id: I9d1f3389baf967108858254df847c358ec1a35c2 Reviewed-on: https://chromium-review.googlesource.com/1179069Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584636}
-
Eric Karl authored
We currently populate a |current_surface_size_| variable in Render... WidgetHostViewAndroid via frame sizes in SubmitCompositorFrame. In Viz mode we don't get SubmitCompositorFrames, so we miss these udpates. This variable is used for fullscreen transition improvements and general frame-readiness checks. This value is present in RenderFrameMetadata, and can be populated from there in the Viz case. Bug: 871774 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6892cbb35590e03e2b8a7d2d822a7b29308f7439 Reviewed-on: https://chromium-review.googlesource.com/1180517Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#584635}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/820ebd0f6616..bcdf5f1a944e git log 820ebd0f6616..bcdf5f1a944e --date=short --no-merges --format='%ad %ae %s' 2018-08-20 buildbot@webrtc.org Roll chromium_revision c092e144..e247d795 (584376:584490) 2018-08-20 aluo@chromium.org Default runner to junit4 Created with: gclient setdep -r src/third_party/webrtc@bcdf5f1a944e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:868610 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5fb236891fecb882f247195ee49737cfe1bfa7eb Reviewed-on: https://chromium-review.googlesource.com/1182203Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584634}
-
rbpotter authored
settings.pages is used outside of pages_settings.js for 3 reasons: (1) To send page numbers to the PDF plugin (2) To set the page count in the print header (3) To set the page count in the print ticket During the development of the N-up printing feature it has become clear that the n-up pages need to be used in place of the original document page indices in all 3 of these locations, so we should set settings.pages to the n-up values. Note that the print preview ticket still needs to use the page indices for the original document, in order to know what pages should be included in the preview. However, since PrintPreviewHandler expects this setting to be in ranges format, the print preview ticket uses settings.ranges, which this CL keeps the same as before (i.e. using the original document's page numbers). Bug: None Change-Id: Ieaad8d75e5125c0dac185f407c665b336aaf4334 Reviewed-on: https://chromium-review.googlesource.com/1174704Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#584633}
-
braveyao authored
The IOSurfaceCapturer for MacOSX has great experiment results on all channels. So move on to next step to enable it by default on TOT before enabling it 100% everywhere. Bug: 840597 Change-Id: I99f0dd64c3ce280173f89cb73012bbd3077f54a2 Reviewed-on: https://chromium-review.googlesource.com/1181921Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584632}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d744124a6f8..ca0cdef06349 git log 8d744124a6f8..ca0cdef06349 --date=short --no-merges --format='%ad %ae %s' 2018-08-21 enne@chromium.org Add flush_on_framebuffer_change workaround 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 f26b27e29535..d20e80b840e4 (1 commits) 2018-08-20 bungeman@google.com Improve name table handling. 2018-08-20 csmartdalton@google.com ccpr: Rename GrCCPathParser to GrCCFiller 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 robertphillips@google.com Remove occluded rrect blur benchmark 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 robertphillips@google.com Change drawPathWithMaskFilter to drawShapeWithMaskFilter Created with: gclient setdep -r src/third_party/skia@ca0cdef06349 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 829614 TBR=fmalita@chromium.org Change-Id: I53a902631a3e1f5d1048232bc64016304574109b Reviewed-on: https://chromium-review.googlesource.com/1182682Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584631}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f8268f7ccb65..4b9089142927 git log f8268f7ccb65..4b9089142927 --date=short --no-merges --format='%ad %ae %s' 2018-08-21 vapier@chromium.org tree_status: remove unused modules 2018-08-21 vapier@chromium.org pylintrc: document deprecated-modules field 2018-08-21 vapier@chromium.org pylintrc: ban exit & quit builtins 2018-08-21 xixuan@chromium.org cbuildbot: Let SkylabHWTestStage run any suite. 2018-08-21 xixuan@chromium.org cbuildbot: Add ASyncSkylabHWTestStage for skylab. 2018-08-21 xixuan@chromium.org autotest: Enable '--use-fallback' for Skylab suites 2018-08-20 manojgupta@google.com chromeos_config: Start testing ubsan builds. 2018-08-20 chrome-bot@chromium.org Update config settings by config-updater. 2018-08-20 bmgordon@chromium.org chromeos_config: Add grunt to pi pfq Created with: gclient setdep -r src/third_party/chromite@4b9089142927 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I179a70c432a655ae5535f02484371bf03fd333af Reviewed-on: https://chromium-review.googlesource.com/1182681Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584630}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f26b27e29535..d20e80b840e4 git log f26b27e29535..d20e80b840e4 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 tobine@google.com More EGL validation refactor Created with: gclient setdep -r src/third_party/angle@d20e80b840e4 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ib6fb43baf13622ddebe23aacd54d381cf196a7ec Reviewed-on: https://chromium-review.googlesource.com/1182262Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584629}
-
Xianzhu Wang authored
The bug no longer reproduces. Remove the failure expectation, rename it to scrolling-neg-z-index-descendants.html because there is no repaint needed for the composited neg-z-index layer, and update the baseline. Bug: 702006 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I87f2f2d93b8024a21aed5929f1fe601065db9806 Reviewed-on: https://chromium-review.googlesource.com/1181522 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#584628}
-
Anand K. Mistry authored
At the same time, fix up two outstanding TODOs: 1. A potential memory leak due to lack of callback data ownership. 2. Not correctly reporting unmount errors on a multi-parition device. Also add some tests for UnmountDeviceRecursively. BUG=873903 Change-Id: I3e99afa4e0185b18c1d7077a5c65fc225a5751b3 Reviewed-on: https://chromium-review.googlesource.com/1179421Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584627}
-
Sam McNally authored
For DriveFS, most operations are handled as native file operations. However, some operations require special-casing; for those we need a custom filesystem implementation to override those implementations. Bug: 874314 Change-Id: I91fffdfb260d6dc53241eed13b734f2df8354f8a Reviewed-on: https://chromium-review.googlesource.com/1180829 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584626}
-
Yoshifumi Inoue authored
The test should use better way to compare floating point numbers to handling below case: ../../content/browser/renderer_host/input/fling_controller_unittest.cc:303: Failure Expected: (last_sent_wheel_.delta_x) > (0.f), actual: -0.121721 vs 0 TBR=sahel@chromium.org,dtapuska@chromium.org Bug: 836996, 875777 Change-Id: Ib9eab4988b1809a753068f7cc2da5815ee7780f1 Reviewed-on: https://chromium-review.googlesource.com/1182713Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584625}
-
Eugene But authored
-[CRWWebController setDocumentURL:] will have a DCHECK when new document URL does not match last committed URL in WKBasedNavigationManager. This DCHECK will help to diagnose possible URL spoofing bugs in Slim Navigation feature. Mocking WKWebView.URL will prevent that DCHECK from firing in CRWWebControllerTest.CurrentUrlWithTrustLevel. Bug: 1171671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I19e317079859306948fa6a925bd37d2157987876 Reviewed-on: https://chromium-review.googlesource.com/1182320Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#584624}
-
Bo Liu authored
Also ensure members are initialized so the move constructor doesn't use uninitialized values. Bug: 871604 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9ab800fec100ccf7ec4de3dd63dfcd28b1e5c5df Reviewed-on: https://chromium-review.googlesource.com/1178302Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584623}
-
Emircan Uysaler authored
Bug: 326740 Change-Id: I08e30219e436c6be1216b6b94e9d7c5ed5b611d0 Reviewed-on: https://chromium-review.googlesource.com/1179253Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584622}
-
Karan Bhatia authored
This CL consolidates the code to use base::span to pass indexed ruleset data buffer, doing away with FlatRulesetIndexer::SerializedData. It provides for more readable code. BUG=696822 Change-Id: I382eec8328fb82af74bbd49e483304329d8c4bf7 Reviewed-on: https://chromium-review.googlesource.com/1152869Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#584621}
-
Orin Jaworski authored
Images for all suggestions were being prefetched, but only the few most relevant were being shown. This was not only wasteful but also damaging to the user experience because the image cache was getting overwritten, causing entity suggestion images to flicker while reloading. This CL fixes the problem by limiting the prefetch to only the first N, most relevant results, where N is the maximum number of match results to be shown (default N = 6). Bug: 866580 Change-Id: If04013be9b2801e7ce6a6177dbc973f4c3fd884f Reviewed-on: https://chromium-review.googlesource.com/1176165 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#584620}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8859c10c2823..ec5364ee5d5a Created with: gclient setdep -r src-internal@ec5364ee5d5a The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If73597c1c9ca1c9e738b38032f78cf4e32df0f8d Reviewed-on: https://chromium-review.googlesource.com/1182263Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584619}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I3477f29dd75fa5eff8cbb3d031b67bdfe24140a4 Reviewed-on: https://chromium-review.googlesource.com/1182378Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#584618}
-
Jeremy Klein authored
This will limit Magic Tether hosts to devices that have gone through Better Together Setup. Bug: 870072 Change-Id: I9fe120f4b8d07f831ebe84aeb28267ff379f2e82 Reviewed-on: https://chromium-review.googlesource.com/1180473Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#584617}
-
Adrienne Walker authored
The current tests time out quite a bit when using swiftshader. I suspect that this is due to shader compilation on a per-blend mode basis, as reducing pixels rastered did not seem to make any difference. The goal here is to reduce the maximum length of any one test so that fewer tests time out and these tests keep causing flakiness and getting disabled. This test breaks up each individual blend mode test into parameterizing by blend mode and rastering what used to be a single column in a larger image into its own image. Instead of saving out a million data pngs, instead this modifies the test framework to use expected pngs as well. This assumes that Skia's blend modes work properly and verifies that software and gl renderer match the output of those blend modes on an SkCanvas. In terms of total time of the test, splitting each test up into 16 different tests on Linux debug for me has each individual test completing in 1/4 of the time of the original (1/4x * 16 = 4x increase overall). However, when running the entire test suite in parallel, this patch speeds up running cc_unittests from ~70s to ~60s overall. So, I think this is overall a win, both in terms of individual and total test time. Bug: 870326,872733 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4791a0a2369f9f17af7bb2a6ba95d7f29dee8b42 Reviewed-on: https://chromium-review.googlesource.com/1180570Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#584616}
-
Xianzhu Wang authored
For SPv1, we don't fragment a composited or squashed layer, but should create a single fragment for it under the parent fragment where the layer's border box starts. Previously we used overflow box to determine fragments causing the composited/squashed layer to be placed in wrong parent fragment when the layer has overflows. Now use border box rect in the case. Bug: 854192 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib05e8629f423b3a1960de1fc8f3989c42f54766f Reviewed-on: https://chromium-review.googlesource.com/1180377Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584615}
-
Joshua Bell authored
Fix in a string logged if a renderer sends a bad message. TBR=pwnall@chromium.org Change-Id: I02555b07c696d4f9f9f1bdc8a39dbc4423e428e2 Reviewed-on: https://chromium-review.googlesource.com/1182602Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584614}
-
James Cook authored
We need to distinguish between MultiProcessMash, SingleProcessMash and both (aka IsUsingWindowService). Clean up some usage in login and accessibility. Bug: 874468 Change-Id: Ibf9694f45114491bf54b232a906b6a5a390e3f05 Reviewed-on: https://chromium-review.googlesource.com/1180344 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#584613}
-
Karan Bhatia authored
This CL bumps the Docserver version to 3.58.0. r578728 introduced the onActionIgnored event to the web request API. However, the documentation changes are not yet reflected in the extension docs (due to an underlying Docserver bug). Force a version bump for now, which should help reflect the new changes. BUG=513780, 111700 Change-Id: I5ef403922b4e5d0c4af0d136b9ea0b8fecf528bc Reviewed-on: https://chromium-review.googlesource.com/1182420Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#584612}
-
Balazs Engedy authored
Bug: 847985, 849323 Change-Id: I818ab8eabac6dbb96edceefa5d28f6d28031d15f Reviewed-on: https://chromium-review.googlesource.com/1181574Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584611}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I37de43ae8e743f49b588a08417912a8993bff5e9 Reviewed-on: https://chromium-review.googlesource.com/1182459Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#584610}
-
Darren Shen authored
Two UMA metrics were added as cl/209072881. This patch adds corresponding histogram descriptions in Chromium. Bug: 856198 Change-Id: Ie987e261ec52d6750f1566f499726695e628f671 Reviewed-on: https://chromium-review.googlesource.com/1179103Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#584609}
-
Sergey Ulanov authored
Scenic Ozone platform doesn't support GL. InitializeGLOneOffHelper() was crashing in that case. Bug: 874533 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I696847b292f015030f2ae32a7044ba8234e0b6a5 Reviewed-on: https://chromium-review.googlesource.com/1178754Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584608}
-
David Bienvenu authored
With VC++ marking a function as non-optimized with MSVC_DISABLE_OPTIMIZE would prevent it from being inlined, however with clang-cl that does not work, leading to confusing crash stacks. The fix is to remove MSVC_DISABLE_OPTIMIZE; these functions were already marked as NOINLINE. Bug: 873359 Change-Id: I00995a17463572545933956cdec0e7e13825abe7 Reviewed-on: https://chromium-review.googlesource.com/1182302Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584607}
-
Andres Calderon Jaramillo authored
This CL creates a base::Feature flag in content to guard the implementation of decode acceleration of JPEG images (as opposed to camera captures) in Chrome OS using the VA-API. Bug: 868400 Change-Id: I103a78bc9547862620fea59fb423582226f03d59 Reviewed-on: https://chromium-review.googlesource.com/1180292 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#584606}
-
David Black authored
Conversation starters are suggestions that show when Assistant UI is launched. They transcend Assistant sessions in that they are pre-cached and held in memory until needed. To accomplish this, this CL: - Adds AssistantCacheController/AssistantCacheModel(Observer) - Adds support for conversation starters to SuggestionContainerView. Still TODO: - Limit to four conversation starters. - Conversation starters should be centered horizontally. - Conversation starters should be cached from the server. In the future, we can also use this new cache for engagement cards and other growth initiatives. See bug for mock/demo. Bug: b:111694337 Change-Id: Ic280d7e39a5b61c9400448f883fce147a889d908 Reviewed-on: https://chromium-review.googlesource.com/1179365Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#584605}
-
Peter K. Lee authored
Rolling both material_components_ios and material_internationalization_ios Bug: 873293, 785484 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If1e80bf46644a2f907b8fd2017f793f9e73d0f3c Reviewed-on: https://chromium-review.googlesource.com/1174556 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584604}
-
Tom Anderson authored
Fixes an error of the form: ../../chrome/common/media_router/discovery/media_sink_internal.cc:191:1: error: function 'media_router::DialSinkExtraData::DialSinkExtraData(media_router::DialSinkExtraData&&)' defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification '' DialSinkExtraData::DialSinkExtraData(DialSinkExtraData&& other) noexcept = ^~~~~~~~~~~~~~~~~ ../../chrome/common/media_router/discovery/media_sink_internal.cc:202:1: error: function 'media_router::CastSinkExtraData::CastSinkExtraData(media_router::CastSinkExtraData&&)' defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification '' CastSinkExtraData::CastSinkExtraData(CastSinkExtraData&& other) noexcept = ^~~~~~~~~~~~~~~~~ The code was ill-formed according to 11.4.2 (3.2): https://timsong-cpp.github.io/cppwp/n4659/dcl.fct.def.default#3.2 Change-Id: I8d54c83856ecbf427ea1e72c409c7df0d1147291 Reviewed-on: https://chromium-review.googlesource.com/1181761Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#584603}
-