- 12 Jun, 2019 40 commits
-
-
Simon Que authored
CI/try builders migrated: - linux-gcc-rel / linux-gcc-rel - linux-jumbo-rel / linux-jumbo-rel - linux-ozone-rel / linux-ozone-rel - linux-tcmalloc-rel - linux_chromium_component_updater - linux-annotator-rel / linux-annotator-rel - linux-blink-animation-use-time-delta - linux-blink-heap-concurrent-marking-tsan-rel / linux-blink-heap-concurrent-marking-tsan-rel - linux-blink-heap-unified-gc - linux-blink-heap-verification / linux-blink-heap-verification-try - linux-chromium-tests-staging-builder - linux-chromium-tests-staging-tests - linux-code-coverage Bug: 950413 Change-Id: Ie5d3e31e943cc81aec8ecce5e7c128f65286bd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650304 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#668572}
-
Cameron Womack authored
Users should be able to bring up the full app list view by touching any area near the expand arrow icon. Bug: 906858 Change-Id: I4c39ddbbeb2bf6b7ac529aa758d161f54e67d8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652619Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Cameron Womack <camw@google.com> Cr-Commit-Position: refs/heads/master@{#668571}
-
rbpotter authored
This prevents focus from disappearing (since signing in opens, and later closes, a new tab). Bug: 924921 Change-Id: I5fbab1a8bec1b0623fca33dc889f401099499ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654354Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#668570}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/92219cfc..6a51e613 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3fab1905482e8ab6e227cddaa27c71c638afe19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656388Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668569}
-
rbpotter authored
Bug: 924060 Change-Id: I828620e627ccda10e685fb2e8342e35451ecef7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652694Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#668568}
-
Peng Huang authored
The backing (vkimage) of WrapperSkImage could be still used by some submitted but not finished vulkan tasks, when the WrapperSkImage is being destroyed. So we need use VulkanFenceHelper to release the backing. Bug: 968727 Change-Id: I8750cb9e0ddc9daea5a04bba3335e81554e45f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651034 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#668567}
-
Bill Orr authored
The page uses viewport scaling, which was removed. Change-Id: I40c6c2c65bcf6fa1a3c831a339bfdd2071bd7084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656380Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#668566}
-
Chris Lu authored
This change will move the position of a newly selected match to the bottom of the screen as opposed to the top so that it does not get covered up by any webpage toolbar on AMP pages. Change-Id: I95fa390c2ebb4fccc12e5609234e28a440aabca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653845 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#668565}
-
Matt Reynolds authored
The HID gamepad backend uses heuristics based on the button and axis usages present in the HID report descriptor to identify devices that may be gamepads. Misidentifying a non-gamepad as a gamepad is problematic because Chrome only supports a maximum of four connected gamepads. When a non-gamepad occupies one of these slots, it prevents a real gamepad from using that slot. This CL adds a blocklist containing device IDs for devices known to be mis-identified by the HID gamepad heuristics. These devices will be skipped during enumeration. BUG=972260 Change-Id: I7279e032033b47902ea9fc046c0ab12a4370d376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652508Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#668564}
-
Rahul Arakeri authored
This CL adds a new mode to the ScrollOffsetAnimationCurve that can be used to create a cc auto-scroll animation when interacting with the scrollbar. The curve is linearly increasing and its duration depends on the auto scroll velocity. A new linear timing function has also been added. Bug: 969203 Change-Id: I648cb3ca289c0457699d221ebd89124a6e8853fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639561 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#668563}
-
Mehran Mahmoudi authored
Bug: 957992 Change-Id: I9b4e801afa12a5c9adc1b8cbab0384654b98f828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655385Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#668562}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d3cc16c8bbec..156622513ffc git log d3cc16c8bbec..156622513ffc --date=short --no-merges --format='%ad %ae %s' 2019-06-12 robertphillips@google.com Add Ganesh support for RGBA_16161616 and RG_half 2019-06-12 rmistry@google.com Add tip on patching to G3 bot 2019-06-12 mtklein@google.com expand unit tests, fix extract 2019-06-12 mtklein@google.com test and fix that we cover the right inputs Created with: gclient setdep -r src/third_party/skia@156622513ffc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@google.com Change-Id: I3fe2831d6576888870f3df11efed66ae3e95b7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656352Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668561}
-
Yi Gu authored
If an animation has been started on main thread, there is no need to try running it on the compositor at the moment. We plan to support the transition from main to compositor (tracked via crbug.com/972691). Bug: 962174 Change-Id: I766a4a87a6a0ae8c4360b54fbd15348cf3c11259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656019Reviewed-by:
-
Matthew Jones authored
Bug: 973550 Change-Id: I65db611c07f035d657db1b54de12fe82df347762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656468 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#668559}
-
Kevin Marshall authored
Stages a CIPD package containing a number of prebuilt test suite FAR files, with a manifest listing the included suites. Bug: 943728 Change-Id: I2d03f778cbd4ab379007fd07740d693a72b0935a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650721Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#668558}
-
Eric Aleshire authored
This lets test log information be sent from the test to the app, so that the app logs can contain test context. This improves the usefulness of app logs for debugging. BaseEGTCAppInterface is created instead of something like LoggingUtilAppInterface due to the scope of this method; it is unlikely that more test<->app logging helpers will be added, so scoping this clearly to BaseEGTC seemed more appropriate. Bug: 922813 Change-Id: I7c3d56a358fdf9760193b24130a7f881d313551d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652571 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
-
Steve Kobes authored
This controls the degree of region granularity snapping that occurs in JankTracker when the sweep line algorithm (JankTrackingSweepLine) is enabled. Previously, the sweep line feature disabled all granularity snapping. The default param setting, kHigh, matches the degree of granularity snapping that is performed without the sweep line algorithm. Bug: 581518 Change-Id: I75a5264b9625349572e6a7f8a7249852e2a8304a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655984 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#668556}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/85035be3e2bb..f9411ce30f13 git log 85035be3e2bb..f9411ce30f13 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 sugoi@google.com Fixed writing to a2b10g10r10 2019-06-12 thomasanderson@chromium.org Move libvk_swiftshader.lds from sources to inputs Created with: gclient setdep -r src/third_party/swiftshader@f9411ce30f13 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:964411 TBR=swiftshader-team+autoroll@google.com Change-Id: I9665e44e543e0b92c04f21d03ba713eec430a43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656351Reviewed-by:
-
Andrew Xu authored
AppListView::OnWindowBoundsChanged fills the corners by translating AppListBackgroundShield when AppList shows in HALF state and the virtual keyboard is enabled. However, AppListView::Layout may be called after AppListView::OnWindowBoundsChanged (the side effect of crrev.com/c/1547051) and it resets the view's transform. As a result. the rounded corners show again. Fix this issue by modifying AppListView::UpdateAppListBackgroundYPosition which is always called by AppListView::Layout. Bug: 968698 Change-Id: I7a0852115ea4363c44a51e299af93fc6bc1c4623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656161 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Anton Bikineev authored
This will be needed for concurrent sweeper. The patch also adds some tiny trivial style changes. Bug: 967258 Change-Id: I8164564464a3e575008f1accf0733885b2ec81d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651461 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#668553}
-
Xiaocheng Hu authored
Change-Id: I91a5f56a1124df0ee70c957c145b65b341da1518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656069 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#668552}
-
Robert Liao authored
BUG= Change-Id: I9520dc6a6932f41be7a57428d2c96550e30738f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653901 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#668551}
-
Kristi Park authored
Swap the tiles on "toggleMostVisitedOrCustomLinks". If most visited is enabled, build the tiles as most visited tiles and switch the blacklist notification to the most visited style. Otherwise, build the tiles as custom links and use custom link notifications. Screencast: https://drive.google.com/open?id=1CfEfNDfJxl_0WV7ffKxuqNC8SZcEn0hw Bug: 953822 Change-Id: Ie423bbc6f4f99aeea205fbc15b9f41237b93674e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653083Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#668550}
-
Nate Fischer authored
Docs only, no change to production code. This removes backticks on "Install depot_tools" to render better in the table of contents (gitiles strips code-formatted text from TOC) and have more sensible fragment link anchors. This updates all markdown files dependent on the link anchor. Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: Id8ec00af6a796212bbc6ceebd5c3d20ca80da920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656375 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#668549}
-
Avi Drissman authored
They are only logged with suffixes, never alone, so mark them as such. BUG=963747 Change-Id: Id1a990d0c50ffdfaca955029fe4903846c52457f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655671 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#668548}
-
Mei Liang authored
This CL sets up SelectableItemView for TabSelectionEditor. All properties for a SelectableItemView bind in TabGridViewBinder#onBindViewHolder(), as well as its views update. Change-Id: I427e2e45c3f93abcdc35fcd34291ba0d7eb29e16 Bug: 972276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648671 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#668547}
-
Anders Hartvoll Ruud authored
Bug: 972388 Change-Id: I916bdd5d7aaccb192c68951f097f92a70479bc3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653020 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#668546}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d04981cdea4b..491e16e8569b git log d04981cdea4b..491e16e8569b --date=short --no-merges --format='%ad %ae %s' 2019-06-12 saklein@chromium.org chroot_lib: Add some common functionality to the chroot class. Created with: gclient setdep -r src/third_party/chromite@491e16e8569b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I803f1e13ad65664a8706de45a0c0fb03281b030d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656350Reviewed-by:
-
Anupam Snigdha authored
Since we are explicitly calling TryShow/TryHide APIs in Chromium, TSF's focus interferes with the focus initiated by these APIs. Due to this race condition in input service, sometimes we see Soft Input Panel being raised and dismissed inconsistently and in an unexpected way on Excel online. This also affects scrolling an edit control into view. This patch sets the input pane's display policy to manual in TSF so it doesn't interfere with the focus initiated by TryShow/TryHide APIs Bug: 972261 Change-Id: I8ce64760e1602b184f59a30fb130a07a0cc7c5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650509 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#668544}
-
Ian Vollick authored
This broke a couple of test targets. Bug: None Change-Id: I6c7077451bf5fd2ff1c13a9d40763b891d825851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655094Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 037c69d0. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 723f9a78 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." 51060891 "[UserTimingL3] Replace SyntaxError with TypeError." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: msisov@igalia.com: external/wpt/webvtt NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I7abbdecb3ef14762e71550a7a9c33107b4921e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656162Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668542}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/dcfa9d06a134..bd60de41e396 git log dcfa9d06a134..bd60de41e396 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 google-shaderc-autoroll@skia.org Roll third_party/googletest 076b7f778883..89656ddbe62f (1 commits) (#694) Created with: gclient setdep -r src/third_party/shaderc/src@bd60de41e396 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I79634c110ddc9231da1f8977184505aa2bdfe1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655891Reviewed-by:
-
Michael Giuffrida authored
This is a reland of ecb3164a Original change's description: > Revert "Use AddLocalizedStringsBulk() on version_ui to reduce code size." > > This reverts commit 7d8834bd. > > Reason for revert: Crash in ui::ReplaceTemplateExpressions (crbug.com/972995) > > Original change's description: > > Use AddLocalizedStringsBulk() on version_ui to reduce code size. > > > > Refactored to use AddLocalizedStringsBulk() instead of > > source->AddLocalizedString() to reduce code size and separated > > data strings from localized strings. > > Follow up of changes https://crrev.com/c/1591712 and > > https://crrev.com/c/1628757 > > > > Bug: 957201 > > Change-Id: I9f9e01468ac8eedfbaf035b03f9bacbd7e4efcf2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630467 > > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#667625} > > TBR=droger@chromium.org,thestig@chromium.org,michaelpg@chromium.org > > Change-Id: I7cfd452ad6176d657cfddfe1de78585e6c98a33b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 957201,972995 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653313 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#668465} Bug: 957201, 972995 TBR=droger@chromium.org,thestig@chromium.org,michaelpg@chromium.org Change-Id: I10b28dc04010878c41d52fbf5fab1fd7fc56e7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656024 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#668540}
-
Patrick Noland authored
Bug:973607 Change-Id: I2910d5608917545043f763f1e23c885af0a39ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651934 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
Lucas Tenório authored
With this change, we are showing the Supervision Onboarding screens right after the ARC ToS screen. We are also skipping any screens that show after a successful Supervision Onboarding. This change also removes the ExitFlow() method for the WebviewHost interface. Since this data was just looping back to the WebUI implementation, we can just add a new C++ interface that bypasses the JS bridge. TBR=ochang@chromium.org Bug: 958995 Change-Id: I340c3899e8ca3d0bdb493ca487e682600467212a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653388 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
Previously, when users who navigated the dialog via the keyboard (i.e., using the Tab key) pressed Enter on the connect and/or disconnect button, focus would be lost. This was due to the fact that the UI actually had 2 buttons (connect and disconnect), and one is hidden when the other is visible. Thus, when users would click one button, it would immediately become hidden and its focus would be lost. This CL fixes this issue by having both connect and disconnect share a single button which remains visible and retains focus after the Enter key is pressed. Bug: 971213 Change-Id: Ifd5c29946ab86ce95548fe6d95e5c3c6738f4976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655977 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#668537}
-
John Chen authored
NOTRY=true Change-Id: I74bbe79587c3fada031bc3f645a6169b73cbb948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656113 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#668536}
-
Yuke Liao authored
This CL does two things: 1. Replace the SI count check with a whitelist check. 2. Add InstrProfilingRuntime.cc to the whitelist because coverage build needs it and it is ONLY used on coverage build. This change only applies to Linux platform, and in order to make Mac platform work, a separate CL is required to change //tools/mac/dump-static-initializers.py to have the same output format as //tools/linux/dump-static-initializers.py. Bug: 956591 Change-Id: I54119676bea59a8f1e6fdba470bbeac32b121c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653319Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#668535}
-
Alex Newcomer authored
It has very low usage, and can result in a lot of bad system UI. It is hypothesized that the shortcut is mainly executed by accident (based on UMA). If we get complaints, we will return the shortcut. Bug: 939570 Change-Id: I2940f60053cfb531ffe67654df17f1407beb8c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610752 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#668534}
-
Joshua Pawlicki authored
Bug: 926234 Change-Id: Ifcd0a9148f9488f57cde0e24acbcd46b3728eb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656348 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#668533}
-
