GitLab

Switches the SkiaRenderer Dawn builders to use the 'gpu_tests' mixin
instead of 'gpu_fyi_tests', as the FYI version causes them to attempt
to build ANGLE conformance tests. These tests aren't necessary on this
configuration, and are currently failing to build.

Bug: 1046947
Change-Id: I7aed86f11f359de966bc47a896c392f247812246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028739
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737059}

In |AssistantInteractionController::OnOpenAppResponse| we forgot to call
the callback if it is invoked outside of a valid conversation.
This blocks the entire |AssistantInteractionSubscriber| mojom pipeline,
causing the Assistant UI to become unresponsive.

The fix was easy (call the callback), but I used this opportunity to add
the first unittests for the |AssistantInteractionController|.

Bug: b/146227377
Change-Id: I705aed3d4cabf3761de339d7d1c8a1ce6178b90d
Tests: New ash_unittests AssistantInteractionController*
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029607Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#737058}

https://chromium.googlesource.com/angle/angle.git/+log/d9884d3e7123..c8e486b1df0d

git log d9884d3e7123..c8e486b1df0d --date=short --first-parent --format='%ad %ae %s'
2020-01-30 ynovikov@chromium.org Roll chromium_revision e1633af6..8ffb18d0 (724302:736949)

Created with:
  gclient setdep -r src/third_party/angle@c8e486b1df0d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: tobine@google.com
Change-Id: Ie5d433148187528c00f1f4642fcc7b1444e97e8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032004Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737057}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/305542ea70b1..ae510e8f08e8

git log 305542ea70b1..ae510e8f08e8 --date=short --first-parent --format='%ad %ae %s'
2020-01-30 fmayer@google.com Do not crash for non URL (i.e. SSH) remotes.

Created with:
  gclient setdep -r src/third_party/depot_tools@ae510e8f08e8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I75445faa3de41db326a865689ac32cca4c13ddd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031618Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737056}

Bug: 985142, 1046865
Change-Id: I19ef1095fdd9af8e3d05b0f5d024fe424a8b779a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029169
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737055}

IsInsecureCapturingInProgress() will now report capturing in progress
if the whole desktop, the window for Chrome, or the specific tab is
being captured. Adds UpdateTarget() to specify the actual target being
captured, so that the code can check if the tab this is being called
for is actually the target, not just the tab doing the recording.
Default target is still the tab doing the recording.

Also updates Clear Key CDM so that every response to
QueryOutputProtectionStatus() generates a 'keychange' event for
a dummy key ID. If capturing reported, then the key status is
'output-protected'. If no capturing reported, key status is 'usable'.

Adds additional output protection tests that use the fake UI to select
capturing of the monitor, window, or browser window. Previous tests
ran with kUseFakeUIForMediaStream not specified, which defaulted to
"any".

Bug: 856276
Test: new EME browser_tests pass, capturing tested manually as well
Change-Id: I50df86380cfc115a218d92ba54027294f6bb3b54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987271
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737054}

This change introduces a system modal dialog that is displayed when a
user changes the resolution of an external display. The majority of the
logic is encapsulated in a more generic DisplayChangeDialog so that
behavior can be reused for a future RefreshRateChangeDialog.

Mocks: go/cros-displays-split
Test: ash_unittests
Change-Id: Iaca64bbabbe4f831a3578012aac148fee95f3066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979137
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737053}

These tests are no longer flaky
 conformance/ogles/GL/exp2/exp2_001_to_008.html (WebGL 1 and 2)
 conformance2/textures/canvas/tex-3d-rg16f-rg-float.html

Bug: 923080
Change-Id: Ibc0e4b488779a0843a787acacac6c9544e34c50f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029260
Auto-Submit: Austin Eng <enga@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737052}

bundletool.py calls the java bundle tool but also prints its output to
stdout. This is noise in the build log [1] which should only contain
errors and warning and should be empty otherwise.

[1] eg: building monochrome_public_minimal_apks outputs the entire
bundle manifest to stdout.

Change-Id: I2449c7bb5c93398afc18204932566801e385e4e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031965Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737051}

Specifically add BUILD.gn boilerplate (generated with a local script)
for:

 - Auto-generating Polymer 3 versions for each file.
 - Type checking auto-generated files.

Known issues:
 1) Generated code is not yet included in the build. This will happen
    at later stages along with porting tests to Polymer 3.
 2) js_type_check() targets are commented out, because JS type
    checking is not passing yet.
 3) Some polymer_modulize(), js_modulize() target are commented out
    because they cause the auto-generation tools to throw errors.

2 and 3 will be fixed in follow up CLs, either by modifying the
auto-generation tools, or by modifying the source code.

Bug: 1026426
Change-Id: I6e90ec6af32ce59242795bb7d5e8aa6486f0de55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021191
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737050}

This CL changes video fullscreen tests to wait on one frame being
painted, in an attempt to make them more reliable. The CL also updates
the test expectations.

Bug: 1025291
Change-Id: I80de51215b1d009f6e5ae99e2808c9223cb89ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025932Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737049}

Before this CL, autofill payment apps are always ranked below other
types of payment apps, including just-in-time installable (but not yet
installed) service-worker based pyament handler.

This CL introduces a new payment app ranking order behind a feature flag
such ranks payment apps first by types:
1. Installed 3rd-party payment handlers
2. Complete autofill instruments
3. Just-in-time installable 3rd-party payment handlers
4. Incomplete autofill instruments

Within each group, payment apps are sorted by frecency as before.

Bug: 1046875
Change-Id: I34ed0fec1f7b6fc4fbf8c6984d0893c3fad73443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028740
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737048}

There are various "indices" and hence the name |index_| is somewhat
ambiguous. Instead, let's be consistent with the class type it refers
to, which is TitledUrlIndex.

Change-Id: I0f2c38fdfe7b0a98d9d0b63c2526605c82bfaf40
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030769Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737047}

if mohnstrudel (#webui-tab-strip) is enabled.

Mohnstrudel (#webui-tab-strip) will enabled on krane from M81 and other
boards from M82. So window dragging from top and tab dragging will be
disabled on krane from M81 and other boards from M82.

Bug: 1041928
Change-Id: I1b071a190a669374906ff6ec16493dbec879d2d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031668Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737046}

https://pdfium.googlesource.com/pdfium.git/+log/60ca7defc0eb..cf899c949229

git log 60ca7defc0eb..cf899c949229 --date=short --first-parent --format='%ad %ae %s'
2020-01-30 tsepez@chromium.org Remove unused CPDF_TextState::GetShearAngle(), GetFontSizeV()
2020-01-30 tsepez@chromium.org Null out CXFA_FF* layout item reference in layout item dtor.

Created with:
  gclient setdep -r src/third_party/pdfium@cf899c949229

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1042915
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I9caf79477e70d79c4558e69ec3f17b7840bed12f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031611Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737045}

On Android, the virtual views in web content mimic their corresponding
Android classes, and that includes returning the name of an Android
class name as a string.

This change fixes the class name for a static text node - it should
correspond to an android.widget.TextView. That will enable the Accessibility
Scanner to detect color contrast issues.

Bug: 1046651
Change-Id: Ia579b83dafa0ce814be059282c594136a37bf33d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026670Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737044}

This migrates all of the code in chromecast/ to use
blink::WebMessagePort instead of directly manipulating
Mojo pipes, and manually encoding messages. It preserves the
existing APIs so that downstream dependents can migrate. A
further CL will rip out the deprecated API.

BUG=803242

Change-Id: I6f3b03dd982e4093804a63f8ad6086f14c2b58b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028148
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737043}

Bug: 1006806
Change-Id: I8cf16db179f7fc215db5f2a1bec81ce982663b37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031670Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737042}

When OverlayProcessorAndroid tries to create the gpu thread part of
processor, wait at the initialization to make it synchronous.

R=khushal

Bug: 979788, 1044671
Change-Id: I6f9c65a6710d7af30a096958b471f250b156722f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025643
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737041}

Currently on Android, there is only one button on the password
reuse warning dialog, so only saved passwords are supported.

It can be expanded to other types of passwords after another button
is added.

Bug: 1045495
Change-Id: I0570a3907c0ed3ef91228119ca5e73281198aaf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026593Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737040}

Previously, CQ would pass if extractor.py failed at parsing the C++
declaration. With this CL, parsing errors make CQ turn red (to avoid
committing code that will make linux-annotator-rel fail).

Also, always rerun extractor.py when there's an error to get stderr
contents. Previously, when running with --error-resilient, it wouldn't
re-run the Clang tool. This saved several minutes on CQ, but didn't
report a useful error message. Since extractor.py is _much_ faster,
the tradeoff is different: the error message is more important than
the couple of seconds saved.

Finally: slightly improve extractor.py's error reporting when it fails
to parse the annotation declaration. This makes it more actionable and
gives better context to the CL author.

TESTED=traffic_annotation_auditor_unittests, extractor_test.py,
    annotation_tokenizer_test.py

Bug: 1046794
Change-Id: Id397dcfcced39fbebf72ffcdc6d6549c66c2910f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028707
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737039}

Ties are broken between rules with the same priority based on the action
type. Add a test for this.

Bug: 1026733
Change-Id: Ie5fcdad3c8843ba535619b0cb3ac4956bdd5a818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025082
Commit-Queue: Theodore Dubois <tbodt@google.com>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737038}

Bug: 1047347
Change-Id: I0a2579e3c8458541b5800af9c1d45c2190296b06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031558
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737037}

Two WPT use CSSNumericValue.parse() to parse CSS pixel values, which
makes the tests basically Chrome-only. This patch changes them to use
parseFloat() directly so that other browsers can pass.

Bug: 441925
Change-Id: I01d6d2999cf4266bd6d3bda521d2bdfc8732ab7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031932Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737036}

On macOS in particular, WebGL contexts allocated with alpha:false use
RGBA textures bound to IOSurfaces behind the scenes, and on Intel
GPUs, multisampled RGBA renderbuffers rather than RGB (the
disable_webgl_rgb_multisampling_usage workaround). When the dynamic
GPU switching handling logic for integrated -> discrete transitions
reallocates the multisampled renderbuffer, clear its alpha channel to
1.0, as is done during framebuffer resizing.

Add a new Pixel_WebGLLowToHighPowerAlphaFalse test which catches this
bug, and make the previous Pixel_WebGLLowToHighPower test more correct
and robust.

Bug: 1034019
Change-Id: Ifb45cdad5a1b88f04700b429b774b6c4f49c6d35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024279
Auto-Submit: Kenneth Russell <kbr@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737035}

After this commit:
 * For non-webstore policy force-installed extensions, write
 computed_hashes.json on installation.
 * If (according to computed_hashes.json) extension's resource is
 detected corrupted, this extension will be disabled and  reinstalled.
 This applies only for policy force-installed extensions, and for
 webstore extensions it worked before this commit.

This commit will NOT change behavior for already-installed extension.
So, if some (non-webstore) extension was already corrupted, it will not
be detected. The reason for this is that there is no source of truth for
resources of already-installed non-webstore extension. It's possible to
reinstall all previously-installed non-webstore extensions, but it's out
of scope of this commit. See the bug for more details.

Bug: 958794
Change-Id: Ie9c014e7fd998f4eae6e852a59bd692d57ff7d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012964
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737034}

This simplifies the steps of ArCoreInstallHelper by:
* Simplifying methods for steps that are not currently needed
* Removing wrapper methods that only called one JNI method
* Removing callbacks to private member methods, rather than having the
  Java-called-back method directly handle the result

Bug: 1043224
Change-Id: I4f27ebe215ac3e3c8efa9b2ac80d56e46afa108a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029187
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737033}

This change promotes the WebUSB chooser and notification interaction
metrics to never expire as they are key indicators of how users are
interacting with this feature.

The WebUSB detector initialization time metric is retired as it is no
longer measuring anything useful.

Bug: 1037415
Change-Id: I528073e75548ee0abd4ff9cd2d955659df8cc5c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028855
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737032}

Bug: 1047082
Change-Id: I27478217a1723ff0b62ec7fa64e9ac2092554e38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031535
Auto-Submit: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737031}

On tablet mode start, update target app list visibility if app list is
in show or showing state, and home should not be considered visible
(e.g. because it's behind an app window).

This handles an edge case where the app list starts showing in clamshell
mode, and tablet mode switches before the app list animation finishes
(i.e. before the app list gets focus). Given that there is no focus
change when the app list view moves behind the app window, we do not
update the app list visibility, and app list controller keeps thinking
the home screen is visible (until the next focus change).

BUG=1047430

Change-Id: I283fe9748dbd6fe83635babc9a141d7020f09f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029997
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737030}

This test is no longer flaky.

Bug: 846547
Change-Id: Ia8062aa23eca080a7904a6ced767ffff888ff39f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029493
Auto-Submit: Austin Eng <enga@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737029}

Gaia ID was incorrectly reported previously:
1. It was stored as an int when the obfuscated Gaia ID cannot be
   converted to an int.
2. It was then converted to an int64 in the proto.

The proto symbol for Gaia ID will be deprecated and it's identifier will
be reserved for future use.

Removing the Gaia ID prior to deprecation.

Bug: 1045967
Change-Id: I4c3477005788046408e3ae81f8ee37cfc1df17d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028211
Commit-Queue: Zach Trudo <zatrudo@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Auto-Submit: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#737028}

This reverts commit f5a4e592.

Reason for revert: Relanding with memory issues addressed

Original change's description:
> Revert "[Tab Groups] Implement time to switch histogram."
> 
> This reverts commit 19b7b019.
> 
> Reason for revert: Likely causing failures for TabHoverCardBubbleViewBrowserTest.WidgetNotVisibleOnClick 
> TabHoverCardBubbleViewBrowserTest.WidgetNotVisibleOnMousePressAfterTabFocus on Linux MSan
> 
> Bug:1047172
> 
> Original change's description:
> > [Tab Groups] Implement time to switch histogram.
> > 
> > Records the amount of time in ms from the cursor entering the tabstrip
> > to tapping on a tab to switch.
> > 
> > Bug: 1040657
> > Change-Id: I438f53c3d3a83cead9a3feb0c62356e1322cf1c6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023396
> > Reviewed-by: Jesse Doherty <jwd@chromium.org>
> > Reviewed-by: Connie Wan <connily@chromium.org>
> > Commit-Queue: Charlene Yan <cyan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#736721}
> 
> TBR=jwd@chromium.org,cyan@chromium.org,connily@chromium.org
> 
> Change-Id: Iff213feb375e247f59ce79c72616abaf164a35d1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1040657
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030664
> Reviewed-by: Ioana Pandele <ioanap@chromium.org>
> Commit-Queue: Ioana Pandele <ioanap@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736842}

TBR=jwd@chromium.org,ioanap@chromium.org,cyan@chromium.org,connily@chromium.org

Change-Id: I6ebcffc8f0b0307ce0a3ff5598fab64a870af43b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1047172, 1040657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031562Reviewed-by: Charlene Yan <cyan@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737027}

Rebaseline to fix a few web test failures on MacOS 10.14, due to added
padding to input text related types introduced by r736729, which was
submitted before MacOS 10.14 became a default trybot.

TBR=wangxianzhu@chromium.org

Bug: 1028242
Change-Id: I707514ef4cfd3e24cf6bbccf4d44b66c41a29772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031708Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737026}

SplitSettingsSync will allow the user to opt-out of browser sync.
However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has
consented to browser sync. Assistant has its own consent. Drive
doesn't have (or need) consent separate from Google account creation
and sign-in. Switch to using the "unconsented" primary account,
which exists whether or not the user has consented to browser sync.

See go/cros-sync-mock and go/cros-primary-account for details.

Bug: 1042400
Test: updated existing unit tests
Change-Id: Ib368939c3a25ebd21db62955c1394197bf4f8d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023304Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737025}

1. Use const and pass by reference when appropriate.
2. Convert NULL to nullptr in the modified files.
3. Fix some file formatting to match clang.
4. Use default and explicit constructors where they should be
5. Remove unused SetCrtc overload.

BUG=987274
TEST=HardwareDisplayControllerTest, HardwareDisplayPlaneManager*Test

Change-Id: Ic0f019bfa862a5160805ecbfd22dc391e6f9f418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031864
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Auto-Submit: Mark Yacoub <markyacoub@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737024}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2f79dd4c2c7..7ea79fbc6f6f


Created with:
  gclient setdep -r src-internal@7ea79fbc6f6f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1046904
Tbr: jbudorick@google.com
Change-Id: Idd406a06ebca19bfc23792133c4664a237ac3d0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031636Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737023}

https://webrtc.googlesource.com/src.git/+log/670af2692e5d..8e998f17e0ce

git log 670af2692e5d..8e998f17e0ce --date=short --first-parent --format='%ad %ae %s'
2020-01-30 srte@webrtc.org Fixes stall in SimulatedProcessThread
2020-01-30 ilnik@webrtc.org [VP9] Shift spatial layers on RTP level to always start from 0.

Created with:
  gclient setdep -r src/third_party/webrtc@8e998f17e0ce

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I4308d855a0fcc1f34504cdad5d4768e01d7aaa22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031635Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737022}

This change is a follow up to this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2018094

1. We remove the tree_id() method from the TreeWrapper and use
GetTreeID() instead.

2. We use wrapper->GetNodeFromTree() instead of
wrapper->tree()->GetFromId().

3. We overload GetNodeFromTree to take fewer parameters.

Change-Id: Icb2dd678ca10f1faf67ddc536351f1b51728f02b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028734
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737021}

PaymentRequest.TransactionAmount.[Completed|Triggered] UMA metric records
transaction amounts after converting them to USD and mapping them to one
of the following three categories: 0$, <= 1$, or > 1$
This cl adds UKM for the same metric to enable analyzing transaction
categories per origin.

Bug: 970597
Change-Id: I6de11b41e4af4cf59a8c1422a39a17fb391ea4e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025872Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737020}