GitLab

Bug: b:69899077
Change-Id: I84c1083869ce6fc7f4579ae22271ea2a344e459c
Reviewed-on: https://chromium-review.googlesource.com/c/1283478
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601004}

The enum GL_QUERY_RESULT_AVAILABLE_NO_FLUSH_CHROMIUM_EXT was not being
handled, and as a result we were doing a check before the result was
available and causing a flush.

R=piman@chromium.org

Bug: 896830,894200
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic4dc1ec22b2768d7d47ee63c61cc410554be563e
Reviewed-on: https://chromium-review.googlesource.com/c/1289958Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601003}

When scanning the stack we're really just checking if any element in
the vector is true. We can replace this O(n) check with O(1) if we
keep track of the number of true elements in the vector.

Bug: 894505
Change-Id: I378cffe80212277a7fa8ad414e15a5cf3c9824c8
Reviewed-on: https://chromium-review.googlesource.com/c/1289329
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601002}

https://chromium.googlesource.com/catapult.git/+log/7c50ac5ddf5b..cedb2de8832d


git log 7c50ac5ddf5b..cedb2de8832d --date=short --no-merges --format='%ad %ae %s'
2018-10-18 bpastene@chromium.org devil: When fetching HealthyDevices, retry a configurable amount of times.


Created with:
  gclient setdep -r src/third_party/catapult@cedb2de8832d

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:892670
TBR=sullivan@chromium.org

Change-Id: I742f07e46dc22cb354eeda835ca13341cdc912ac
Reviewed-on: https://chromium-review.googlesource.com/c/1289891Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601001}

In the combined CronetChromeWebView framework, Cronet may be started
first, resulting in ignored command line flags set in
web_view_global_state_util.mm.

Change-Id: I1b65558d9042d726f634a87ac5ea1e1bd8df0a9c
Reviewed-on: https://chromium-review.googlesource.com/c/1290193Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601000}

InProgressCache is no longer being used as we are switching to in-progress db.
Remove the class and its usage

BUG=894978

Change-Id: I1309de54c265e60f6e707765f67b7a1666b0e9f9
Reviewed-on: https://chromium-review.googlesource.com/c/1289167
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600999}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=scottmg@chromium.org

Bug: 681136
Change-Id: I64f5b45d9f9d378578c3d0f2d80deb675fe3aa6a
Reviewed-on: https://chromium-review.googlesource.com/c/1288341Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600998}

When a sync user confirms to sign out after trying to turn
off the signin-allowed toggle, the toggle is now turned off.

Additional change:
 - The code related to the sign-out dialog in settings is
 extracted into its own element and refactored.

Bug: 892745
Change-Id: I9d638d8c77b1f4318fc592cc88f4be95e5eab7c8
Reviewed-on: https://chromium-review.googlesource.com/c/1280542Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600997}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=battre@chromium.org

Bug: 681136
Change-Id: Ie31e3afbb761c43dded20d7b15da8354e167014a
Reviewed-on: https://chromium-review.googlesource.com/c/1288490Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600996}

DownloadItem should know whether it is created from history.
No need to keep DownloadHistory::WasRestoredFromHistory.

BUG=895597

Change-Id: If8aa8c5e07a5d4d4e35edff9e37b98adefe77df7
Reviewed-on: https://chromium-review.googlesource.com/c/1289084Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600995}

BUG=896814

Change-Id: I07d4e0895862874347422661d7a3963e25216440
Reviewed-on: https://chromium-review.googlesource.com/c/1289514Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600994}

https://pdfium.googlesource.com/pdfium.git/+log/4754adaf70d8..1ee77bd42da6


git log 4754adaf70d8..1ee77bd42da6 --date=short --no-merges --format='%ad %ae %s'
2018-10-18 thestig@chromium.org Roll v8/ 41562c7c5..c623fabe5 (96 commits)
2018-10-18 tsepez@chromium.org Expand CJS_Document::mail{Doc,Form}() parameters
2018-10-18 tsepez@chromium.org Remove PrintParams object.
2018-10-18 thestig@chromium.org Do IWYU for core/fxcrt/xml headers.
2018-10-18 thestig@chromium.org Remove unused form of CFX_Matrix::TransformRect().
2018-10-18 thestig@chromium.org Do more IWYU in fxjs/.
2018-10-18 thestig@chromium.org Remove some useless calls to the CFX_XMLNode ctor from subclasses.
2018-10-18 thestig@chromium.org Do IWYU in core/fxcrt/css and fix lint errors.


Created with:
  gclient setdep -r src/third_party/pdfium@1ee77bd42da6

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I0b6fe6f33750436ddb7e560e6fe5ac112946330e
Reviewed-on: https://chromium-review.googlesource.com/c/1289655Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600993}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=kmackay@chromium.org

Bug: 681136
Change-Id: I6f95a419588a54b279da8516096bff1f65daf05d
Reviewed-on: https://chromium-review.googlesource.com/c/1288340Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600992}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=petewil@chromium.org

Bug: 681136
Change-Id: I9ee910da99a5c3d34039be1e61d9eb44819cddee
Reviewed-on: https://chromium-review.googlesource.com/c/1288492Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600991}

Bug: b/116166191
Test: Manual Test
Change-Id: Ife16fef544879aff09e02f4822e7f6a7d9b4b085
Reviewed-on: https://chromium-review.googlesource.com/c/1283943
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600990}

The new line in TestExpectations is for an old WPT test that checks
for the old behavior.

BUG=884588
R=eae@chromium.org

Change-Id: I560e8d240d773536d084b598ac76261f9ecef81a
Reviewed-on: https://chromium-review.googlesource.com/c/1285109
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600989}

When a default URL scheme is updated after URL validation, it is counted
as a user action. This causes "Undo" to revert the URL scheme update
instead of the user's add/update action.

Add an additional parameter to CustomLinksManager::UpdateLink in order
to distinguish between internal and user changes. Internal changes will
not update the previous state that is restored when
CustomLinksManager::UndoAction is called.

Bug: 896143
Change-Id: I643679fab5e546fac7e41214af6ff8a4ba9c8b53
Reviewed-on: https://chromium-review.googlesource.com/c/1287259
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600988}

This also add check to ensure that legacy system health stories which already
have a newer version must be disabled within smoke testing.

Finally, this CL also shorten the names used in _DISABLED to simplify the job of
disabling a system health story.

Bug: 878390, 893615
Change-Id: Ife447c9e5935c960ea7e1818adfcaef0ccaeb59a
Reviewed-on: https://chromium-review.googlesource.com/c/1289686Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#600987}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=jochen@chromium.org

Bug: 681136
Change-Id: I2de6838cb20e249234f820aa84d996311acc58c1
Reviewed-on: https://chromium-review.googlesource.com/c/1288345Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600986}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=chrishtr@chromium.org

Bug: 681136
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib2e84f9aef18ed801d27f74520edeb7e41eda54b
Reviewed-on: https://chromium-review.googlesource.com/c/1288494Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600985}

This CL updates the accessory bar to the newest icons and design.
Currently behind the AutofillManualFallback feature flag.

[Current: https://drive.google.com/file/d/1x60dQkNt0B88Srlo0v-vNyNXHDs_nu_F/view?usp=sharing]
[New: https://drive.google.com/file/d/1Sf_WMeI83g-viW6x065hZXO3PUXcgBj0/view?usp=sharing]

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4a97a254a1e8c9918c1db23ddfcfb93faf734aec
Reviewed-on: https://chromium-review.googlesource.com/c/1289679
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600984}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=oysteine@chromium.org

Bug: 681136
Change-Id: Ide55f05c47a2572da354617a83c9b6727633f61f
Reviewed-on: https://chromium-review.googlesource.com/c/1288495Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600983}

Bug: chromedriver:1404
Change-Id: Ic4c23921a253584f9b3b29deb7a02398f43f574e
Reviewed-on: https://chromium-review.googlesource.com/c/1289690Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600982}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=zmo@chromium.org

Bug: 681136
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I05d68bcadcd0b152962ae6828fc8af66687e46d3
Reviewed-on: https://chromium-review.googlesource.com/c/1288510Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600981}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fff636607ed5..3102c9b3cef9


Created with:
  gclient setdep -r src-internal@3102c9b3cef9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I2f9c2ddef9adf37cf4bd3cad425a26becb3a08ba
Reviewed-on: https://chromium-review.googlesource.com/c/1289657Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600980}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=jyasskin@chromium.org

Bug: 681136
Change-Id: I59478d51c2b81e5d856319871ebc76b9d2401697
Reviewed-on: https://chromium-review.googlesource.com/c/1288514Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600979}

This is in preparation of referencing this type from the code
generated by third_party/inspector_protocol/code_generator.py.

My overall WIP change is in here, and happy to explain more:
https://chromium-review.googlesource.com/c/chromium/src/+/1244719

Bug: chromium:891377
Change-Id: I66f75e2b53f30944fecbfdc22c396799c15593b8
Reviewed-on: https://chromium-review.googlesource.com/c/1280555Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600978}

Bug: 883496
Change-Id: If98ab4445ef5ee1a02d7c6bb1e5f4e3e770cfeba
Reviewed-on: https://chromium-review.googlesource.com/c/1287205Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600977}

This fixes a bug that was causing the system to add insets to the table
view when jumping between fields. This inset was the same as the one
other scroll views get when the keyboard appears. Setting
|contentInsetAdjustmentBehavior| to never is not enough, and the
inset gets added anyway.

Bug: 878388
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I305395fc691301a467523755d006277687a35c1d
Reviewed-on: https://chromium-review.googlesource.com/c/1273041Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600976}

This reverts commit adb22130.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 600928 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWRiMjIxMzBjMTI5MTI1NDYxODU3ZWFmZTY2MzQyMjA5OTM5YjcxYgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4268

Sample Failed Step: network_service_browser_tests on Ubuntu-16.04

Sample Flaky Test: DataUseMeasurementBrowserTestWithDataSaverEnabled.CheckServicesDataUseRecorded

Original change's description:
> NetworkService: Report data use of URLLoader to browser process
> 
> When the requests complete, the total received and sent bytes are sent
> to browser process. ChromeDataUseMeasurement records metrics on Chrome-services
> data usage and updates metrics service.
> 
> Subsequent CLs will record more metrics and also report this to data
> reduction proxy settings page.
> 
> When NetworkService is disabled, DataUseMeasurement will get network
> delegate callbacks and record metrics.
> 
> Bug: 808498
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I113e480e4e1c67a65ff7461eb5ae2166a6b038d2
> Reviewed-on: https://chromium-review.googlesource.com/c/1274202
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600928}

Change-Id: I6fdfa077e01fb3ae0693be88eb58361a6bb17a13
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 808498, 896942
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/c/1290137
Cr-Commit-Position: refs/heads/master@{#600975}

We've seen this test pass intermittently on Linux and now MacOS so
I am adding an expectation for it until the test owner can investigate
and fix.

TBR=npm@chromium.org

Bug: 896765
Change-Id: Icc45010eb16f298a5587404b9530853fca55349a
Reviewed-on: https://chromium-review.googlesource.com/c/1289961Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600974}

BUG=814528

Change-Id: Iacdefc02c01d04079d7c1d62368bd7aaabaf2e8c
Reviewed-on: https://chromium-review.googlesource.com/c/1289707Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600973}

Opt-in dialog should be hide/show correctly when switching users.

Bug: 812010
Test: Manual Test
Change-Id: I2a880974e22d1179c564891fc3f46f562de865f2
Reviewed-on: https://chromium-review.googlesource.com/c/1289685Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600972}

R=kariah@chromium.org

Change-Id: I9b0adc0413e502b9e324ef929b11757c21b68d03
Reviewed-on: https://chromium-review.googlesource.com/c/1289753Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600971}

This is a pure interface so it can inline the dtor and doesn't need to
hide the ctor.

Bug: none
Test: compile
Change-Id: Idbf3cd3ca8397b3c0883f5e7759151ff9d29ab55
Reviewed-on: https://chromium-review.googlesource.com/c/1283476
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600970}

When marking the first line box dirty, this patch checks
if the line box exists.

Normally NGBlockLayoutAlgorithm suppresses box fragment
if no line boxes exist. However, NGColumnLayoutAlgorithm
may generate box fragments for column boxes.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie5697a524cd6fc1067fc4c03466e88fa8d5da68b
Reviewed-on: https://chromium-review.googlesource.com/c/1288769Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600969}

Input device node names always start with exactly "event".

Bug: none
Test: compile

Change-Id: I7e332f16901fa979eff7b1553ae6439a0806b9fd

Reviewed-on: https://chromium-review.googlesource.com/c/1287103
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600968}

In local testing, there are two separate reasons for flakes:
(i) Histogram tester does not return correct values even though
the relevant code has already logged the histogram values
correctly.
(ii) The via header value is set too late by the unittest.

The first problem is sort of solved by waiting for the histogram
to populate. The second problem is solved by setting the via header
value in the test constructor.

Bug: 760294
Change-Id: I9ae23e4b704f6eaa51fd9c37f76491008c6cb1c6
Reviewed-on: https://chromium-review.googlesource.com/c/1289689Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600967}

Users of Chromevox may need to touch explore the webpage, and for
things to remain consistent, we should disable hiding top-chrome
with gesture scrolls as long as Chromevox is enabled.

R=sky@chromium.org
BUG=857331, 896514
TEST=Added a new browser test.

Reviewed-on: https://chromium-review.googlesource.com/c/1284289Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600408}
Change-Id: I388bc5056f956bea2edffc7127dcab533824e56b
Reviewed-on: https://chromium-review.googlesource.com/c/1287510
Cr-Commit-Position: refs/heads/master@{#600966}

Adds a context menu item to take a "Sneak peek" at a link using the overlay panel.
This provides an ephemeral tab to view a linked page (once fully implemented.
Currently the menu item has no effect when selected.)

See go/ephemeral for a detailed design.

BUG=894619

Change-Id: I3856e1524d37f82d065d9f8322cebda972d269a0
Reviewed-on: https://chromium-review.googlesource.com/c/1286097
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600965}