GitLab

Refactors layout-specific state (document size, rotation) from
PDFiumEngine into a separate DocumentLayout class. This will allow new
layouts to be computed without disturbing the current layout.

As a side benefit, this should be another step towards simplifying
PDFiumEngine to be less of a grab bag of concerns.

Bug: 885110
Change-Id: Ieabde78d8acdcb2f83aac980d03f6fd8f28295a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716158
Commit-Queue: K Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681422}

Release MachineLearningDecisionServiceProvider before tearing
down ash to fix the crash.

Bug: 987687
Change-Id: Ice42d1c50b0534d5f8386038087b74a84bd6969c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719447Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681421}

This CL adds two metrics. The first is an UMA histogram tracking how
often we try to use an element-id based fragment and succeed vs fail.
Note that if the TextFragmentAnchor feature is enabled, we won't count
this metric if the fragment successfully parses to a |targetText|
anchor.

The second metric measures how often we see a hash ("#") character in
the fragment. This is technically an invalid URL but we'd like to
evaluate how often it happens in practice. Similarly to above, if
targetText is enabled, we won't count cases of ##targetText as being
part of this metric.

Bug: 987027
Change-Id: Ic3b6cf1a85e590449af12c131edc60b13bad0dfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719651Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681420}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/23a204c3872e..22762d94d758


git log 23a204c3872e..22762d94d758 --date=short --no-merges --format='%ad %ae %s'
2019-07-26 jclinton@chromium.org Mark mistral experimental


Created with:
  gclient setdep -r src/third_party/chromite@22762d94d758

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel

TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I171b442b739138a76439c96f4c84a2b16ea54c7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720924Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681419}

Since some layout objects don't have Nodes (ie they are anonymous),
we need to still properly detect if they are in locked subtrees. To
that end, this patch adds LayoutObject version of NearestLocked*
functions which first find the nearest node and then call the appropriate
Node versions.

R=chrishtr@chromium.org, rakina@chromium.org

Bug: 986827, 987724, 987816
Change-Id: I7f8011bc0182f99cdcb032303ad6e1851cb9b897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720736Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681418}

This change implements the reveal button for <input type=password>.
The button is added using same pattern as the clear/cancel button for
<input type=search> except that instead of using -webkit-appearance to
draw the button, we use svgs defined in controls-refresh.css.

A keydown handler is added to support Alt-F8 hotkey to reveal/obscure
password and logics are added to make sure the reveal button only appears
with direct user input. If the password is not empty in the first place
(ex. autofill or value=xxx) or the control loses focus and regains focus,
or the value is changed by script, the reveal button won't show.

Note we are using -internal-reveal as the pseudo element id, so there is
no way for authors to customize or hide the reveal button. This might be
changed after a consensus over what id to use is reached, or after the
button gets standardized.

Tests are added in web_tests/fast/forms/controls-new-ui/password.

Change-Id: Ib2b37771b8ca246c7401eea65bfd20be6cc73f1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708748
Commit-Queue: Alex Keng <shihken@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681417}

These tests are for an edge case that is resolved[1] to be
undefined in CSS Writing Modes Level 3, and the new behavior
is defined in Level 4.

We don't have a plan to implement Level 4 yet. These tests
will be moved back when it starts.

[1] https://github.com/w3c/csswg-drafts/issues/4139

TBR: eae@chromium.org
Bug: 987976
Change-Id: I08056a2d3f49ec04ade3aa1ced848b8a418cc51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720866Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681416}

This change updates the logic for setting DSP model based on different locales.
See the linked bug for more details.

Bug: b/134125220
Test: local compile and manually test.
Change-Id: If4f33cf038f373853e8a9ff3b0fa1b3885320d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648832
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681415}

This is part of phase 4.8 in the design doc [1].

[1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/

Note that, in order to eliminate calls to classes not available to
blink yet, a blink::Platform method was added - namely,
GetWebRtcSignalingTaskRunner().

Also, in order to make this class reside in blink/renderer from
the beginning, a factory method was added to [2] - namely
CreateWebMediaStreamRendererFactory.
Also, [2] was moved to [3] so that the implementation of this
method could reside in renderer/modules/mediastream, where it
needs to call a class from (MediaStreamRendererFactoryImpl).

[2] public/platform/modules/mediastream/web_media_stream_renderer_factory.h
[3] public/web/modules/mediastream/web_media_stream_renderer_factory.h

Note that the switch from using std::string to WebString in
WebMediaStreamRendererFactory is done in a follow up CL already up for
review, https://crrev.com/c/1715310/

BUG=704136
R=guidou@chromium.org, haraken@chromium.org

TBR=jam@chromium.org

Change-Id: Ia8b7d00328a77159318964abfa715004d60dcdcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715418Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#681414}

Turn off convert types and pretty print.

Use default value of no convert value, no device data and includes user
policies.

Bug: 983174
Change-Id: I8815e4f66c5b7326cf337fb610a2dfbebc4d3f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721078Reviewed-by: Yann Dago <ydago@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681413}

Screenshots:
https://drive.google.com/file/d/14ssIg6-tvLU_yAa8RTZEPHNsvbfGYgTa/view?usp=sharing

This CL split the original FeedNewTabPage, FeedNewTabPageMediator and StreamLifecycleManager
into multiple classes, but we do not expect visible changes on FeedNewTabPage.

This CL also fixed the dummy FeedNewTabPage which was broken by
https://chromium-review.googlesource.com/c/chromium/src/+/1709731

Bug: 982018
Change-Id: I933cb01789d5eda8a196de00e4bf279bb7d6d785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715410Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681412}

This CL shares the common code of the WebUI of
chrome://password-manager-internals and chrome://autofill-internals. This
enables simpler development of follow-up features such as reporting
active experiments.

Bug: 928595
Change-Id: I7d4bda4f2a1b643ed4e5cfa0056ae843a4d1eedb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710653Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681411}

This reverts commit 67eba1f6.

Reason for revert: Responsible for compile failures on https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/12897, which were warnings on previous builds.

Original change's description:
> Enable fatal linker warnings on cros/arm builds.
> 
> The references bug was closed long ago, and we're on a completely different
> toolchain now.
> 
> Bug: 356580
> Change-Id: I92b1a0c2ddd33a18775a72347ac996a4320d173c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721249
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681379}

TBR=vapier@chromium.org,thakis@chromium.org

Change-Id: I946510c52c36d1488c48c220ef3c88bb0b0ae076
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 356580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721032Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681410}

Bug: 795291
Change-Id: I17cdb24f7b98e43323fd40f86af445509632bd0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695290
Auto-Submit: Matthew Cary (CET) <mattcary@chromium.org>
Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681409}

Left click is the most useful click type. Upon re-enable, autoclick
type should always be left click.

Also don't draw the scroll icon when disabled.

Bug: 988020,988007
Change-Id: I5f92376ac2f26bde0ecceea401c573a2f306a47f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721510
Commit-Queue: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Auto-Submit: Katie Dektar <katie@chromium.org>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#681408}

This CL replaced a bunch of element_->GetLayoutObject() calls with
GetLayoutEmbeddedContent():

https://chromium-review.googlesource.com/c/chromium/src/+/1597534

However, those two calls are not equivalent if the LayoutObject is not
a LayoutEmbeddedContent. This patch restores the calls to
element_->GetLayoutObject().

I was unable to reproduce the crash, even using the clusterfuzz tools,
so I can't write a test.

BUG=982214
R=bokan@chromium.org

Change-Id: If2dee39a235ee961d7f27258e7a04e8165d2ab3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719911Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681407}

https://pdfium.googlesource.com/pdfium.git/+log/6e3a40600f24..e5bc2758b312


git log 6e3a40600f24..e5bc2758b312 --date=short --no-merges --format='%ad %ae %s'
2019-07-26 tsepez@chromium.org Mark CPDF_DocPageData::Clear() as private
2019-07-26 tsepez@chromium.org Remove some other virtual dtors.
2019-07-26 tsepez@chromium.org De-virtualize CFWL_FontManager and CFWL_FontData.


Created with:
  gclient setdep -r src/third_party/pdfium@e5bc2758b312

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: Iaea4c41e612e6d260f45f237f1a3acacc2d8d59d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720739Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681406}

Because the preferences on this screen are loaded asynchronously, the
default RecyclerView animations delay the preferences first appearing,
so we disable them here to reduce animation jank.

A long-term solution for disabling preference animations is being
tracked here: https://crbug.com/986401

Bug: 986241
Change-Id: I0ea833d79a49c15bf602d6374080f65d32586555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717323Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681405}

The "browser_action_hidden" preference hasn't been used since the
Extension Toolbar Redesign launched (several years ago). Remove the
preference, add it to the list of obsolete prefs to be cleaned up
in the ExtensionPrefs, and remove the corresponding histogram.

Bug: 975789

Change-Id: I427629ef6f3741d672af71aa7892beae4f6527ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719970Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681404}

This CL adds some properties that were missing at PlatformWindow level as well
as code to convert Widget::InitParams into PlatformWindowInitProperties in
DWTHPlatform.

Bug: 789065
Change-Id: Ie224c3ae3434afce0ecdd6d4b044ca9f75f29aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718456
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681403}

This patch changes HtmlLinkElement to use LowerASCII instead
of DeprecatedLower.

DeprecatedLower has partial Unicode conversions, such as
converting U+212A to 'k', but lowering only ASCII should be
sufficient for most web platform usages.

Currently, there are 6 usages of AtomicString::DeprecatedLower
and 37 usages of String::DeprecatedLower. This patch reduces
one of the 6 usages.

Bug: 627682
Change-Id: I8b94712275ec94b5cc21f8941049864e5b66e384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720819
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681402}

Cleans up various aspects of the GPU pixel tests, such as adding
docstrings, renaming, and generally making them more readable.

Bug: 985007
Change-Id: I2f179db7dca9b209881d09f40b5750db36f6f62e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718782
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681401}

This reverts commit 89eb64aa.

Reason for revert: Suspect this breaks the Mac display.

Original change's description:
> viz: Merge CA Overlay Validator into a Subclass of Overlay Processor
> 
> CA Overlay Validator has simple logic and could be easily merged into
> a subclass of overlay processor.
> 
> R=​rjkroege
> 
> Bug: 963597
> Change-Id: Ia6334b82a8826740098ad279b74cd044ff4d8d42
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664973
> Commit-Queue: weiliangc <weiliangc@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681186}

TBR=rjkroege@chromium.org,weiliangc@chromium.org

Change-Id: Icd40d3893d1fa71d09764864536eb442a733c0d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 963597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721496Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681400}

This mirrors location for the header file in ios/web/public/navigation

Bug: 942244
Change-Id: I685a5dca3c073bf0a90f95e857e2155e884ac2ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716337
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681399}

This reverts commit 2501fdde.

Reason for revert: See crbug.com/976696

Original change's description:
> Add web tests virtual suite for audio service
> 
> This CL creates a new virtual suite that runs web tests with the audio
> service running on a sandboxed utility process.
> It also adds expectations for audio-related tests already in expectations
> files.
> 
> Bug: 976696
> Change-Id: Ia25ff740fb4735db0d3ae4ea9d08787e6818da5b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715811
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Armando Miraglia <armax@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681297}

TBR=guidou@chromium.org,armax@chromium.org

Change-Id: I47379ecd5c0c726f69b6254e5f22de667394c5d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 976696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721180Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681398}

There's a non-zero number of instances where the references are
invalid.  We should fix them.  We'll keep the metric to monitor
the fix.

Bug: 986497
Change-Id: I3f518e20b0079992e9532841d9d85ab9efecc08d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719858
Auto-Submit: Sean Kau <skau@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681397}

Fully qualifying Preference classes in XML is unnecessary, and not
recommended by the Android Settings docs.

https://developer.android.com/guide/topics/ui/settings.html

Bug: 986924
Change-Id: I5e80931507d983fe33e5c0306546837372520380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717699
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681396}

The global resource scheduler observes the total number of in-flight
requests issued by all resource scheduler clients.

Add a method to record the global in-flight request information to UMA.

Change-Id: Ib35f7365956b7dacc40bfe5463047d4a7f94d434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720149
Commit-Queue: Jianfeng Wang <jfwang@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681395}

This patch changes LayoutQuote to use LowerASCII instead of
DeprecatedLower.

DeprecatedLower has partial Unicode conversions, such as
converting U+212A to 'k', but lowering only ASCII should be
sufficient for most web platform usages.

This case matches to a static set of lang-code, which are all
in ASCII. There will be slight behavior changes, such as
U+212A no longer matches to 'k', but such conversion should
not be expected.

Currently, there are 6 usages of AtomicString::DeprecatedLower
and 37 usages of String::DeprecatedLower. This patch reduces
one from the former.

Bug: 627682
Change-Id: I4bf36ffa4ad2e88bfcbd5b47e5bb836131003123
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721075
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681394}

This feature flag will enable a separate widget for the UnifiedMessageCenter.

Bug: 95802
Change-Id: I5b60ab5272e9ca3c444bfdf142059c2a5795217f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719470Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681393}

This CL contains the following changes:
- removed the clear button and spinner buttons from the in-page UI for
date, datetime-local, month, week and time types
- updated the calendar-picker-indicator to use a calendar icon for
date related types

For time the calendar-picker-indicator will be updated when popup
support will be introduced for this type.

Bug: 987050
Change-Id: Ic7849a323ebb3723c5b6a467463a8604058f72ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716161
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681392}

Add the redirect URL port number to the redirect learning table.
Next CL will use the value of the port number for preconnect.

Change-Id: I1bd53ff9ab1486a5a6f3a36a51667bc36faf76b2
Bug: 983234
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719832Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681391}

This reverts commit 9a2b5dd0.

The assignment on line 45 was overwriting the parameter `src`, which
then would result in the for-loop on line 44 to traverse into the wrong
directory. Renaming the assignment to variable `new_src` resolves that
issue.

Confirmed working locally by commenting out the `if symlink exists`
branch and ran it on my Linux machine. (I could reproduce the error by
simply commenting and can confirm that it is now working with the fix)

TBR=luoe@chromium.org

Change-Id: Idc3dbddd9db620169f7e9fbd60e306755eb1b4c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715303Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@google.com>
Cr-Commit-Position: refs/heads/master@{#681390}

Disabled ListView items should be ignored by TalkBack if they don't
contain any text. However, while testing on Android Q, I noticed that
TalkBack highlighted the dividers and announced them as "disabled."

To fix this, I added importantForAccessibility="no" to the divider's
FrameLayout.

Bug: 987839
Change-Id: I12592e1b9f98a7b4750983afd12104e0fca89e45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719829
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681389}

Bug: 976671
Change-Id: I4727f890dcc5bc77e9d80ac97c4bdece9260a69b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720829
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681388}

It influences the number of navigations we keep a record of for sending
the referrer chain.

R=holte

Bug: 969981
Change-Id: I07d3d711020b948f995befb9db437ab3e8320704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719918
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681387}

The primary button needs to be updated according to current state of
ChromeSigninViewController.
Bug introduced with crrev.com/c/1695411

Bug: 987985
Change-Id: Idfbfbaa48b62fead98d23d2ba464fc46c3285e62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720836Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681386}

PlayStateInternal returns a value for the play state of an animation
that is not to spec. It includes a pending state that is not a valid
value for the play state. This CL is part of a series of patches to
bring the implementation of web animations in line with the spec.

Bug: 958433
Change-Id: Ifd189641e83972e63d474cd99db391aad3dff406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715764
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681385}

Depending how early EXO is initialize the Screen object may have already
initialized its display state. When CastWMHelper adds its display
observer it will not get a OnDisplayAdded() event by default. Query the
list and initialize the observer to ensure state is correct.

Bug: b/138247323
Test: Manually on device to verify OnDisplayAdded() is called before EXO
clients call to ask for display info.

Change-Id: I473185fda846e64907eebb808141d51f281fbdde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720993
Auto-Submit: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681384}

Bug: 924194
Change-Id: Icfaa9d1d9390ec1c3aa524ff4d139cd4959a600a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715772Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681383}