- 11 Nov, 2017 6 commits
-
-
danakj authored
See https://chromium-review.googlesource.com/c/chromium/src/+/760558#message-83efb689457770dfabb6d7371847f06f8091dfd7 and https://bugs.chromium.org/p/chromium/issues/detail?id=783087#c24 for explanations, but tl;dr this check would break caching, and shouldn't be there. Before it was used to skip render passes regardless of caching, but incorrectly, and the unittest in https://chromium-review.googlesource.com/c/chromium/src/+/760558 demonstrates that, and fails with that check. This removes the check from the caching block. R=enne@chromium.org, wutao@chromium.org Bug: 782044, 738190, 782042, 783087 Change-Id: Idc5baea6da5e6d663da9c1aa23ce81a55e61168d Reviewed-on: https://chromium-review.googlesource.com/763710 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#515757}
-
Herb Derby authored
Change-Id: I2fa873e63695195ee01d0d67c61430a4d0afb565 Reviewed-on: https://chromium-review.googlesource.com/764629Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Herb Derby <herb@chromium.org> Cr-Commit-Position: refs/heads/master@{#515756}
-
Donn Denman authored
Speculative fix for an assert reported by a developer. Update an overly aggressive assert recently landed in ContextualSearchTabHelper when reparenting. BUG=783225, 775813 Change-Id: Ib8f54e0b5bfcf8dde785e0c25098771b21c1b420 Reviewed-on: https://chromium-review.googlesource.com/764667Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#515755}
-
Takumi Fujimoto authored
This CL implements the WiredDisplayMediaRouteProvider, which is responsible for making wired displays available as media sinks. As of this CL, WiredDisplayMRP creates a MediaRoute when a presentation starts but not the actual presentation window. LocalPresentationManager keeps track of displays with MR dialogs, and WiredDisplayMRP observes LocalPresentationManager to be notified when that information changes. In another CL, we will make MediaRouterDesktop own WiredDisplayMRP, like how it owns ExtensionProxyMRP. Bug: 777650 Change-Id: I0c882826a5e3c79bf58a2d9dd49a3e070ef2e861 Reviewed-on: https://chromium-review.googlesource.com/691150 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#515754}
-
Will Chen authored
This converts a batch of tests from the old test framework (html file) into the new test framework (js file). Most of it was done through an automated transformation script, with a small amount of manual clean-up. R=einbinder@chromium.org Bug: 667560 Change-Id: I0ea80058d847affbdf654658b4873351a9843ad2 Reviewed-on: https://chromium-review.googlesource.com/759418Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515753}
-
Mathieu Perreault authored
Allows navigating to it with VoiceOver (or equivalent) Bug: 781581 Test: VoiceOver, then out/Default/browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive --dialog=CardUnmaskPromptViewBrowserTest.InvokeDialog_expired Change-Id: I52382b2c462d43f86207587cd69693a02c0d8334 Reviewed-on: https://chromium-review.googlesource.com/763768Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#515752}
-
- 10 Nov, 2017 34 commits
-
-
Chris Harrelson authored
The stack allocation is just to initialize the object and stick it into a heap-allocated vector entry. Instead allocate the entry and initialize it on the heap. Bug: 781301 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I58af3fdc18d19950d7f8911910ee33d1b0d445af Reviewed-on: https://chromium-review.googlesource.com/764405 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#515751}
-
Joel Einbinder authored
Bug: 771578 Change-Id: I4928067b157e6297b652761d09955910b574fc73 Reviewed-on: https://chromium-review.googlesource.com/738327Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#515750}
-
Dave Schuyler authored
This CL mimics some of the styling of MD history side nav so that the UI is more consistent between history and extensions. Bug: 780949 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I75665607686daf1618752c7e13c229efde23d93f Reviewed-on: https://chromium-review.googlesource.com/762388Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#515749}
-
Nektarios Paisios authored
Changes AXPosition to include affinity when computing leaf text positions and simplified line boundary calculations 1. When converting text positions, such as those in a text field, to either a tree position or a leaf text position, we should take affinity into consideration. When there are two equivalent resulting positions, one at the start of a child node and one after the previous child node, we should return the former when affinity is downstream and the latter when affinity is upstream. 2. Line breaks are not always used to separate lines in content editables. Modifies logic that detects if we are at the end of a line to ensure that if there is some white space at the end of the line, then we would detect it as a line separator in addition to a line break. 3. Simplifies logic for finding next and previous line boundaries by relying on AtStartOfline and AtEndOfLine methods, thus creating a smaller piece of code that deals with boundary detection. R=dmazzoni@chromium.org Bug: 731056 Tested: existing unit tests, manually with Gmail textareas and content editables Change-Id: Ic936122ef19f66fcb4a1cc88cd001f4376e34346 Reviewed-on: https://chromium-review.googlesource.com/745724 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#515748}
-
Vlad Tsyrklevich authored
This change introduces a ProtectedMemory container class intended to store dynamically resolved function pointers for cross-DSO calls that must be exempted from Control Flow Integrity indirect call checking. These function pointers can not be checked by cfi-icall, instead we place them in read-only memory and set them writable only when they need to be initialized. ProtectedMemory is only suitable for storing data in global/static variables, a follow-up change will introduce a container class that allows dynamically allocating multiple instances of a given type. ProtectedMemory currently only works on Linux and macOS, its use is a no-op on other platforms. This change also introduces two helper macros to easily call function pointers stored in ProtectedMemory containers without cfi-icall checks applied in order to avoid sprinkling no_sanitize("cfi-icall") attributes throughout the source code and encouraging its misuse. Bug: 771365 Change-Id: Ic9433095d9550ae8478ad9931ec5e3c37edb23ec Reviewed-on: https://chromium-review.googlesource.com/706859 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#515747}
-
Alexei Filippov authored
It allows collect the sample in all the running CPU profilers. BUG=721099 Change-Id: I8c80c9543bb826b67b8f7ddf6b2984cb54d61fbb Reviewed-on: https://chromium-review.googlesource.com/764793Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#515746}
-
Lei Zhang authored
The PDF parsing code changed, and now the sample PDF fails to load. Previously, it would load, but have inaccessible pages, which is what triggered the crash in the first place. A suitable replacement test PDF cannot be easily found, so give up and remove the regression test. If the crash fix regresses, it will show up on the crash server again. The same PDF parsing code also changed another PDF that should fail to fail consistently. Adjust the test expectations accordingly. BUG=648981,782402 Change-Id: I27f1484996f3f6c584fedb8d53e61fd2299327af Reviewed-on: https://chromium-review.googlesource.com/762134 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#515745}
-
Daniel Cheng authored
Bug: 763980 Change-Id: Ib0598e788a11995d1eb31cda4c3fe13c5a425103 Reviewed-on: https://chromium-review.googlesource.com/763168Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#515744}
-
chrome://flagsJoy Ming authored
Enable feature "enable downloads foreground" by default in chrome://flags to test for M64. Bug: 747563 Change-Id: I34a1cdd85a89864fd495fc7d403cbcfbb0d54d0b Reviewed-on: https://chromium-review.googlesource.com/758622Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#515743}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/89738c9c..fbb038b8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Icd105312ec304e6f1c2b1cf28d22d5079c72e640 Reviewed-on: https://chromium-review.googlesource.com/764630Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515742}
-
Francois Doray authored
OnWindowTransforming() is renamed to OnWindowTargetTransformChanging() to highlight the fact that it is only called when the target transform of a window changes (i.e. not called multiple times during animation). It is called from the same place as before. OnWindowTransformed() keeps its name, but it is now called whenever a new value is set for the transform of a window, with or without going through aura::Window::SetTransform (e.g. https://cs.chromium.org/chromium/src/content/browser/web_contents/aura/overscroll_window_animation.cc?l=74&rcl=6f58658d4a324bd8781bf91027a2a81be4c278ea and https://cs.chromium.org/chromium/src/ash/wm/window_animations.cc?l=140&rcl=9fc521cbe571957d8d1d600797e090791ecdbb09) aura::WindowOcclusionTracker will use OnWindowTransformed() to know when the transform of a window changes, with or without an animation. Bug: 738387 Change-Id: I914315cc3bdcc7d3fc05689a0f0a038a3792e04f Reviewed-on: https://chromium-review.googlesource.com/700619 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kelvin Poon <kelvinp@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#515741}
-
Joel Einbinder authored
ArrowDown moves the cursor the right, so it needs to accept the autocomplete otherwise the cursor will be to the right of the ghost text. Bug: 783090 Change-Id: I862fb2ae37d79dcd5f507087717d16899220419a Reviewed-on: https://chromium-review.googlesource.com/762880Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#515740}
-
Hans Wennborg authored
It was unintentionally disabled as part of disabling the new Clang warning -Wtautological-constant-compare. Bug: 767059, 783204 Change-Id: I621f002f319cb395ecc30ca7ff9f132cefe0e5d4 Reviewed-on: https://chromium-review.googlesource.com/764035 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#515739}
-
Evan Stade authored
This reverts commit ebb92497. This relands commit c4ea951f Original issue description: Serialize more of message_center::Notification for mojo. Adds NotificationType and (partial) RichNotificationData. Now you can see progress bars in download item notifications on Chrome OS when using --enable-features=NativeNotifications TBR=tsepez@chromium.org,jamescook@chromium.org,sky@chromium.org Bug: 578868 Change-Id: I80c5666bef28133a22f8416263246ff813e49371 Reviewed-on: https://chromium-review.googlesource.com/763569Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515738}
-
Avi Drissman authored
This reverts commit ac4c8a25. Reason for revert: This appears to be bug 782033. Original change's description: > Revert "Re-land "Switch Mac to use time_exploded_posix.cc."" > > This reverts commit af2ab97d. > > Reason for revert: > > This breaks the "ios-simulator" trybot on my CL. See https://chromium-review.googlesource.com/c/chromium/src/+/590273 and failed trybots runs at > > https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/337162 > https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/337212 > > which has TimeTest.TimeT/0 failing: > TimeTest.TimeT: > ../../base/time/time_unittest.cc:134: Failure > Expected: tms.tm_hour > Which is: 14 > To be equal to: exploded.hour > Which is: 22 > > > Original change's description: > > Re-land "Switch Mac to use time_exploded_posix.cc." > > > > Original review: > > https://chromium-review.googlesource.com/c/chromium/src/+/754079 > > Reverted here: > > https://chromium-review.googlesource.com/c/chromium/src/+/760116 > > > > Previously, we would use a CoreFoundation-based version of these > > functions implemented in time_mac.cc because time_t on Mac was > > capped at year 2038. However, with 64-bit that is no longer the > > case and we can just use time_exploded_posix.cc. > > > > From UMA sampling profiler data (see bug), we know that the > > CoreFoundation versions of these functions are slow and currently > > account for around 80ms cost during startup. After this change > > is submitted and makes it to Canary, we can see how the POSIX > > versions of these functions perform - hopefully much faster than > > the CoreFoundation ones. > > > > Some code in net/ had assumptions around the min and max years > > that are supported on different platforms by these functions. To > > make that logic a bit cleaner, this CL introduces two constants > > in time.h specifying the platform-specific limits - so that > > downstream code like net can use them instead of baking their > > own assumptions. Some net error codes are changing as a result > > of this clean up - which can be seen in the updated net tests. > > > > BUG=781601 > > > > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: I5d10a06dd5b0073bfd943f58af08f67980227d4a > > Reviewed-on: https://chromium-review.googlesource.com/760443 > > Reviewed-by: Matt Mueller <mattm@chromium.org> > > Reviewed-by: Yuri Wiitala <miu@chromium.org> > > Reviewed-by: Mark Mentovai <mark@chromium.org> > > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#515370} > > TBR=miu@chromium.org,mattm@chromium.org,asvitkine@chromium.org,mmenke@chromium.org,mark@chromium.org > > Change-Id: I4a582e11d4fd8490cf22cc37d4d746b4c3731957 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 781601 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/764868 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515727} TBR=avi@chromium.org,miu@chromium.org,mattm@chromium.org,asvitkine@chromium.org,mmenke@chromium.org,mark@chromium.org Change-Id: Ieaf3bab463fb46f65054111d26c8bef3d0b8292e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 781601 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/764581Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515737}
-
Xianzhu Wang authored
Fix overflow/composited-scroll-overlap-test.html and paint/invalidation/subpixel-shadow-included-in-invalidation.html They were broken when we changed layer tree dump format. We also created bad baselines at that time. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I38fbf8638eecb5fa630088a79c6a4dbe3644b4d9 Reviewed-on: https://chromium-review.googlesource.com/764568 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515736}
-
Joy Ming authored
There was a crash in SystemDownloadNotifier caused by not checking whether DownloadInfo was null before trying to get the ContentId of the download in the updateDownloadNotification method. This CL fixes that by making the null check and no longer using a hash map that indexes based on the value of the ContentId. Bug: 783608 Change-Id: Ia4ea592c6ea111b432d126b59a812fd7c0e98ca8 Reviewed-on: https://chromium-review.googlesource.com/763811 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515735}
-
Ian Vollick authored
With this change, I introduce the notion of element bounds. Previously, the only non-inherited geometric info an element owned was its size. Now we also store its position. The non-inherited, local size and transform are stored jointly in a bounds rect. I've also made the updating of layout a non-virtual function that calls out to a virtual layout function in order to guarantee that the UiElement has an opportunity to update its bounds following the layout of its children. Bug: None Change-Id: Ia6bb9bda6008a8aaf9e5dc4c70940dec2f7d73b7 Reviewed-on: https://chromium-review.googlesource.com/763650 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#515734}
-
Will Chen authored
This converts a batch of tests from the old test framework (html file) into the new test framework (js file). Most of it was done through an automated transformation script, with a small amount of manual clean-up. Bug: 667560 Change-Id: Ib2e2837fe91e7ed38be5cc2acfececfed81c805f Reviewed-on: https://chromium-review.googlesource.com/757876Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Will Chen <chenwilliam@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515733}
-
Mostyn Bramley-Moore authored
Avoid jumbo build symbol collisions due to this version of RunSoon being defined in multiple source files. We may as well just inline these one-line function calls (and change from Bind to BindOnce while we're at it). Note that service_worker_storage.cc and service_worker_version.cc both still have versions of RunSoon, but with different prototypes so this is not a problem. Bug: 746953,714018 Change-Id: I7c80e909b94b154d58d7f808078a367454bd9584 Reviewed-on: https://chromium-review.googlesource.com/760357 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#515732}
-
Nathan Bruer authored
This patch disables cache when request interception is enabled. R=caseq BUG=760316 Change-Id: I15e05766bee3a4c666150fbf15b5da2604a98a0d Reviewed-on: https://chromium-review.googlesource.com/764516Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#515731}
-
Gabriel Charette authored
TBR=thestig@chromium.org Bug: 781352 Change-Id: I8204f68dae7b360cfa8b9efa573c428e4ac863fd Reviewed-on: https://chromium-review.googlesource.com/763730Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#515730}
-
Francois Doray authored
With this CL, aura::WindowObserver::OnWindow(Bounds|Opacity)Changed() have a new argument that indicates whether the property was set directly or by an animation. The goal is to allow the upcoming aura::WindowOcclusionTracker to know when animations start without calling ui::LayerAnimator::IsAnimatingOnePropertyOf(). TBR=sky@chromium.org Bug: 738387 Change-Id: I91634a61f3abe99bb2240d4039c9f9fc5affbc65 Reviewed-on: https://chromium-review.googlesource.com/753706 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515729}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/225bfa950a80..38d92b59c4b7 $ git log 225bfa950..38d92b59c --date=short --no-merges --format='%ad %ae %s' 2017-09-13 yizhou.jiang Workaround Intel driver bug on D3D when renderering with no render target 2017-09-27 jiajia.qin ES31: Add BUFFER_VARIABLE and SHADER_STORAGE_BLOCK program interfaces Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I429f233ecb5251843573ce1d920949216059f08b Reviewed-on: https://chromium-review.googlesource.com/764543Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515728}
-
Avi Drissman authored
This reverts commit af2ab97d. Reason for revert: This breaks the "ios-simulator" trybot on my CL. See https://chromium-review.googlesource.com/c/chromium/src/+/590273 and failed trybots runs at https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/337162 https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/337212 which has TimeTest.TimeT/0 failing: TimeTest.TimeT: ../../base/time/time_unittest.cc:134: Failure Expected: tms.tm_hour Which is: 14 To be equal to: exploded.hour Which is: 22 Original change's description: > Re-land "Switch Mac to use time_exploded_posix.cc." > > Original review: > https://chromium-review.googlesource.com/c/chromium/src/+/754079 > Reverted here: > https://chromium-review.googlesource.com/c/chromium/src/+/760116 > > Previously, we would use a CoreFoundation-based version of these > functions implemented in time_mac.cc because time_t on Mac was > capped at year 2038. However, with 64-bit that is no longer the > case and we can just use time_exploded_posix.cc. > > From UMA sampling profiler data (see bug), we know that the > CoreFoundation versions of these functions are slow and currently > account for around 80ms cost during startup. After this change > is submitted and makes it to Canary, we can see how the POSIX > versions of these functions perform - hopefully much faster than > the CoreFoundation ones. > > Some code in net/ had assumptions around the min and max years > that are supported on different platforms by these functions. To > make that logic a bit cleaner, this CL introduces two constants > in time.h specifying the platform-specific limits - so that > downstream code like net can use them instead of baking their > own assumptions. Some net error codes are changing as a result > of this clean up - which can be seen in the updated net tests. > > BUG=781601 > > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I5d10a06dd5b0073bfd943f58af08f67980227d4a > Reviewed-on: https://chromium-review.googlesource.com/760443 > Reviewed-by: Matt Mueller <mattm@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515370} TBR=miu@chromium.org,mattm@chromium.org,asvitkine@chromium.org,mmenke@chromium.org,mark@chromium.org Change-Id: I4a582e11d4fd8490cf22cc37d4d746b4c3731957 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 781601 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/764868Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515727}
-
John Rummell authored
Currently MojoCdmFileIO and CdmAdapter run on the same thread. So it's possible that file read/write could block audio/video decoding. Adding a UMA to log the actual time taken, so we can understand if the IO takes too long on actual user machines and should be moved to a seperate thread. BUG=774160 Change-Id: I25a98e2124b431707c7e9efcdbf4da4cbdfccd2f Reviewed-on: https://chromium-review.googlesource.com/758458Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515726}
-
John Abd-El-Malek authored
The first fix is to stop using WebContentsObserver::DidGetResourceResponseStart which only works with ResourceDispatcherHost code path (i.e. non-network-service). Use DidFinishNavigation which provides the same information. The second fix is in the tests, to stop navigating in SetUpOnMainThread. With the network service, the host resolver changes aren't synced until after that method returns. The related previous cl r515579 plumbed the socket address into NavigationHandle for downloads. Bug: 769401 Change-Id: Idd007fd61dd6e31da63c0b01e8d4182f02cf1042 Reviewed-on: https://chromium-review.googlesource.com/763874Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515725}
-
Peter Kotwicz authored
This CL correctly escapes '&' in the "test WebAPK configuration". BUG=None Change-Id: Ic73c87293fe763db9e52cc080e21fdbfb34cc9de Reviewed-on: https://chromium-review.googlesource.com/764631Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515724}
-
Jenny Zhang authored
Bug: 776549 Change-Id: If46e0636001c1d8b03a09d69aff7777248e549b0 Reviewed-on: https://chromium-review.googlesource.com/762141Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515723}
-
Jose Dapena Paz authored
Still it is not much important as Chromium does not support MathML, but at least this way we identify math contents as such. Bug: 783441 Change-Id: I14b07315e07d3c8717c904dcc787bcd5d3be616f Reviewed-on: https://chromium-review.googlesource.com/762196 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#515722}
-
Ahmed Fakhry authored
Make the chrome.system.display setDisplayLayout() and getDisplayLayout() work while in Unified Desktop mode, converting the given layout (if valid) to a display matrix and vice versa. BUG=752767 TEST=Covered by tests Change-Id: I55d498ca0fd203c635036eb4bfb9eaa074723d77 Reviewed-on: https://chromium-review.googlesource.com/749690Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#515721}
-
Eric Roman authored
Change-Id: I04ea915cd164a50d03f441c65b4a6b6c7f7cefe5 Reviewed-on: https://chromium-review.googlesource.com/764409 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#515720}
-
Benjamin Shaya authored
Previously, creating a StreamMixerInput with a different playout channel would set the playout channel, but not revert upon closing. Bug: b/69137033 Test: cast_audio_backend_unittests Change-Id: I950831c9ccbc059b17a0ab15d79997dc41e3c9c4 Reviewed-on: https://chromium-review.googlesource.com/762867Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Benjamin Shaya <bshaya@google.com> Cr-Commit-Position: refs/heads/master@{#515719}
-
Lei Zhang authored
BUG=735628 Change-Id: I2eb4b87c86fbbd06c73ed6d1602c030b35d90d2a Reviewed-on: https://chromium-review.googlesource.com/762876 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#515718}
-