- 19 Aug, 2020 40 commits
-
-
Fan Yang authored
R=dschinazi@chromium.org Change-Id: I954d49604fef3be1b7a50205db5d08441f4226a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360232 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799479}
-
Kent Tamura authored
According to the HTML standard, 'align' attribute for a LEGEND element should be mapped to justify-self property. Our layout code handles text-align for LEGEND, and doesn't handle justify-self. We'd like to investigate possibility to change the behavior. This CL has no behavior changes. Bug: 880822 Change-Id: I86427f172d7ee317d13f60fa78d5478135543174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362487 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799478}
-
Hirokazu Honda authored
The commas are forgot in the kVaapiFunctionNames initialization. Thus it initializes the first element and the second or later element is nullptr. SIGSEGV is caused in attempting to log the name because the char's pointer is nullptr. Bug: b:162962069 Test: video_encode_accelerator_tests on atlas Change-Id: Ifbb081b8e92350df5b83510087a042b7213bc377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362378 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#799477}
-
Hajime Hoshi authored
TBR=sandersd@chromium.org Bug: 1117613 Change-Id: If6ea1284f6733f490f8510c73f09040dbaac0605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362069Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799476}
-
Xinghui Lu authored
Currently HelpAndFeedback is not modularized, so a modularized fragment is not able to use it due to circular dependency. In this CL, create a feedback module and introduce two interfaces as a workaround: * HelpAndFeedbackLauncher, which is used to launch a help and feedback page in an activity. HelpAndFeedback implements this interface. * FragmentHelpAndFeedbackLauncher, which is used to inject HelpAndFeedbackLauncher to a fragment. Any fragment that needs to launch a help page implements this interface. The safe_browsing module will depend on this new module to launch a help page. Bug: 1115758,1117343 Change-Id: I3d9d76f0ba87db26ae5bbe853f7b6cc38eb9353a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359749 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#799475}
-
Sinan Sahin authored
This CL renames default_text_color_tertiary to default_text_color_disabled and replaces any uses that aren't disabled with default_text_color_secondary. It also updates TextAppearance.*.Tertiary and its uses accordingly. Bug: 1097357 Change-Id: Ib14fdfbaa3941f4c4ab3aaa6ee8175d25758a565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360559 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
-
Daniel Hosseinian authored
This is a reland of crrev.com/799230, which was rolled back due to a mismatch between the OS_CHROMEOS macro and the |isChromeOS| WebUI constant on Lacros. (crbug.com/1111985). Use grit preprocessing instead. Add a deprecation warning message for the "Save to Drive" destination under the destination select. Screenshot of change: https://imgur.com/ix1GjIB Bug: 1112581 Change-Id: Icf3caa35b0efce83f440f8c8583edbf96a209290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364000Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#799473}
-
Noah Rose Ledesma authored
The global media controls UI displays the audio devices connected to the system. This change allows the UI to refresh the devices it shows as availability changes. Because of an existing bug in device update processing on linux (crbug.com/1112480) a new class for monitoring these changes was created. The implementation for linux will poll the system whereas the implementation for all other OSes will be notified of changes. Bug: 1113944 Change-Id: I0d285ff0486fc1fb1307b5d78a5a998dcde131ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341181 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799472}
-
Hajime Hoshi authored
This reverts commit 132e1deb. Reason for revert: Android ASAN bot compilation failures: https://ci.chromium.org/p/chromium/builders/ci/Android%20ASAN%20%28dbg%29/26489 Original change's description: > Add -noverify to build commands to improve runtime (local builds only) > > The flag is guarded by treat_warnings_as_errors=false so that it > will apply only to local developer builds. > > Results from //tools/android/build_speed/benchmark.py base_java_sig: > With change: > base_java_sig: 68.0s avg (68.8s, 67.2s) > base_java_sig: 68.4s avg (68.6s, 68.2s) > > Without change: > base_java_sig: 69.4s avg (69.3s, 69.5s) > base_java_sig: 69.7s avg (69.7s, 69.7s) > > time out/Debug/bin/run_base_junit_tests: > With Change: > real 0m22.741s > real 0m23.543s > > Without change: > real 0m23.176s > real 0m24.328s > > Bug: 1117222 > Change-Id: I4bfd742165468bf9538e6fa0dc8f35daa9e0f23f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313299 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799285} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: I82f411e5dab89c361a30c33e9103bd8561f19765 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1117222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362493Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I171b3d6aafc73c402f7b287cf0293363c72f9f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363261Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799470}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/abf77f1b3891..58468984dc04 $ git log abf77f1b3..58468984d --date=short --no-merges --format='%ad %ae %s' 2020-08-18 renjietang Copy cached transport parameters and application states instead of using pointers in QUIC 0-RTT setup. 2020-08-18 quiche-dev CL generated by 'ykats' via Upkeep (go/upkeep). Resolves the following technical debt issues: Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Bug: 1116526 Change-Id: Ia74cb3499997f24e8678290bd1d6474daaceec18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363723 Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
-
wutao authored
This patch adds strings to search for album page. Also changes some strings from ambient mode to screen saver based on UX writer. Bug: b/163421198, b/163417826 Test: manual Change-Id: I10759ef626ca3ec23e227ced1f687e0a1cc3fb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350334Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#799468}
-
Alex Ilin authored
New colored avatars use the following colors: - Background color is equal to the frame color - Stroke color depends on whether the background color is dark: * If the background color is dark, the stroke color is white * Otherwise, the stroke color is computed from the background color by decreasing the lightness by 0.5 Bug: 1100835 Change-Id: I40d77064cf4baef339c931211eb12153e2f6e0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362592 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799467}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5cff4e3b5cf3..25f1303ed83e 2020-08-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I8b4781c4e42ba0e56927cf41ccb8b9966895716d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364089Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799466}
-
Hiroki Sato authored
Without this change, ChromeVoxBackgroundTest.NoFocusTalkBackEnabled was passing regardless of TalkBack toggled status. This is because MockFeedback runs all of the callbacks when replay() is called, and when utteranceInQueue is called in the test, any action has not been invoked yet. This change moves the utterance check after executing replay(). AX-Relnotes: n/a. Bug: none. Test: ChromeVoxBackgroundTest.NoFocusTalkBackEnabled, fails if TalkBack is disabled, and passes if TalkBack is enabled. Change-Id: Ide42b8811a7cb91d82d7dfb242ae318c4cf0c760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362488 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#799465}
-
Thanh Nguyen authored
1. Create a white circle background vector icon for launcher chip. 2. Use vector icon for file launcher chips instead of pngs. 3. Remove resources that are no longer required. Bug: 1067326 Change-Id: I1a18e7c6c8458f84f50930ce47ac87dfcd94e1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354373 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#799464}
-
My Nguyen authored
Bug: 1117498 Change-Id: I09c348442df6a23143c1bbdadbf1f5ecbb1add0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362239 Commit-Queue: My Nguyen <myy@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Donn Denman authored
The server returns no pronunciation in some languages. This formats poorly - with a trailing dot. This is due to the formatting code relying on the mid-dot to determine if the card is a definition or not. Now we pass in the card type which is authoritative. BUG=1112792, 1117684 Change-Id: If9a4a4ddba9800a8a77212e1cf9d2d1296424dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358450 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#799462}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/59a3c3be94f0..81eabce6a3af 2020-08-19 bungeman@google.com SkCustomTypefaceBuilder to set SkFontStyle If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: Ic089cd585906fa42e3a1ff0f947f2a62765795fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363969Reviewed-by:
-
Mike Wasserman authored
Use the active window-placement repo url and name instead. Leaves some mentions that are still abstractly applicable. Copy Screen TODO from third_party/blink/renderer/core/frame/screen.h Bug: 897300 Change-Id: I134516e21a74f0cec5f543306efa39fad6d76dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358134Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#799460}
-
Peter Kasting authored
* Make more things constexpr and/or make it possible to do so later * Inline SaturatedAdd/Sub(), FromDouble(), FromProduct() * Order the FromUnits{,D}() pairs together * Init members in declaration * Briefer implementations of various functions * IWYU * Fix declared-but-not-defined issue for FromTimeSpec() w/OS_FUSCHIA * Use more specific DCHECKs * No else after return * Omit needless qualifiers * EXPECT -> static_assert where possible * <atomic> is legal now * Don't handle DCHECK failure The inlines don't hurt size: this saves 4 KB off chrome.dll in my local release build. Bug: none TBR: stevenjb@chromium.org Change-Id: I269d6426ac1587569e7a4c785250a4dd5e95d5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358997Reviewed-by:Peter Kasting <pkasting@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799459}
-
Ionel Popescu authored
This CL addresses an issue where the users where not able to enter data into the text fields of the color picker when the elements are inside a cross-domain iframe. For the top-level page and for same-domain iframes, when a char event is received while a popup is open, the event is routed from RenderWidgetInputHandler to WebViewFrameWidget shim, which hands it to the WebView. WebViewImpl::HandleCharEvent has code to check for an open popup and the event is sent to the popup if one exists. For the cross-domain iframe case, the RenderWidgetInputHandler hands the event to WebFrameWidgetImpl, but WebFrameWidgetImpl::HandleCharEvent doesn't check for an open popup, so the event goes to the page containing the popup. This CL adds the same popup check to WebFrameWidgetImpl as the one that WebViewImpl::HandleCharEvent already has. Bug: 1114052 Change-Id: I33f2b10b4ae5aa538ebb0d22c1d55f5d97019216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364008Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799458}
-
Yu Han authored
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/Jdw3VWbKvLY/m/0YBXYr-lBwAJ Bug: 869308 Change-Id: I75cab8d0c7c117ce67a8962a903b534e11620f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358608Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799457}
-
Sky Malice authored
This reverts commit 80207c25. Reason for revert: Flaking tests, see crbug.com/1117683 Original change's description: > Redesign ATrace integration > > Chrome and WebView have supported basic Android ATrace tracing, but the > current approach has some shortcomings: > > 1) Android R changes the way atrace session activations are broadcast, > breaking the code in WebView listening for activations > (OnTraceEnabledChangeListener). This means you can't trace a running > WebView app with atrace. > > 2) Neither Chrome nor WebView record early startup events to atrace, > which means all events before the native library has loaded are > lost. > > 3) It's not possible to specify trace categories via atrace, which means > we need more cumbersome alternative solutions (i.e., command line > flags) for startup tracing. > > 4) Writing ATrace events is only supported in WebView. > > This patch reworks the ATrace integration to resolve these problems and > to align the Chrome and WebView implementations. In short, ATrace > session management is moved to the common (TraceEvent) layer, and Chrome > and WebView only differ by which trace tags they listen to (APP vs. > WEBVIEW). > > We also add a way to declare trace categories through per-app tags: > > $ atrace -a org.chromium.chrome,org.chromium.chrome/<category_filter> > > (Note that the plain package name without any category filters must > always appear in the list on its own.) > > Multiple categories can be separated with a double colon: > > $ atrace -a org.chromium.chrome,org.chromium.chrome/cat1:cat2 > > Or by specifying the the app several times to get around the 91 > character limit for each entry: > > $ atrace -a org.chromium.chrome,\ > org.chromium.chrome/cat1,\ > org.chromium.chrome/cat2 > > Finally, to capture Java startup events into a tracing session > controlled by the system's Perfetto service instead of atrace, a > special "-atrace" category can be used to only write events into > Chrome's own tracing service instead of atrace. This way when we > connect to Perfetto later in the startup sequence and establish > the real tracing session, startup-related events can be flushed > into that session without emitting duplicate events into ATrace. > > # Basic trace while Chrome is running. Generates ATrace with Chrome > # events. > TEST=atrace -a org.chromium.chrome > > # Ditto for WebView. > TEST=atrace webview > > # Startup trace -- open Chrome after running this. Results in an ATrace > # with Chrome pre- and post-startup events. > TEST=atrace -a org.chromium.chrome > > # Ditto for WebView. > TEST=atrace webview > > # Trace with custom categories. Results in a ATrace with only > # "cc" events from Chrome. > TEST=atrace -a org.chromium.chrome,org.chromium.chrome/-*:cc > > # Ditto for WebView, using GMail as a test app. > TEST=atrace -a com.google.android.gm,com.google.android.gm/-*:cc webview > > # Chrome-only trace. No Chrome events written in the resulting ATrace. > TEST=atrace -a org.chromium.chrome,org.chromium.chrome/-atrace > > Bug: 1095587, b/160768681 > Change-Id: Ia0bee252ce398804c00be8a4179241b75479bf5e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332664 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Bo <boliu@chromium.org> > Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798791} TBR=boliu@chromium.org,skyostil@chromium.org,agrieve@chromium.org,eseckler@chromium.org,nuskos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1095587, 1117683 Bug: b/160768681 Change-Id: Iffcaebb70c6eb92da1cb3080e8034ea5c36e5394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363564 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#799456}
-
Miguel Casas authored
This reverts commit 9881e6cd. Reason for revert: Needs a follow up crrev.com/c/2362068, but the code is still faulty because it'd hit a DCHECK. Let's revert this one and land a correct CL instead. Original change's description: > media/gpu/vaapi: use new |va_buffer_for_vpp_| for Vpp/BlitSurface() > > ToT VaapiWrapper uses |va_buffers_| for internal Vpp uses and also for > external VEA/JEA use. This CL starts refactoring these VABufferIDs > lifetime, by splitting the Vpp VABufferID out of |va_buffers_| and > into a ScopedID |va_buffer_for_vpp_|. > > Bug: b:162962069 > Change-Id: Ic54d0d26f5d17ea49fe896cf7ca5e1c931d07e0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352522 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799410} TBR=mcasas@chromium.org,hiroh@chromium.org Change-Id: I2b13e096fb7fce00c4dbbaed64bd4d231de34d15 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:162962069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363798Reviewed-by:
-
Sundoo Kim authored
Explicitly remove the copy constructor and assignment operator with the delete keyword. Bug: 1010217 Change-Id: I8fc2a1e0e44808fc356a1cf370afed5d62528827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362350Reviewed-by:
-
Orin Jaworski authored
This CL adds `kn, ko, lt, lv, ml, mr, ms, nl, pl, pt-BR, pt-PT, ro, ru` to the set of languages supported by Pedals. Bug: 893183 Change-Id: Ib942aa1b3ef8d55727c66538a221c840ae004919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363709 Commit-Queue: Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#799453}
-
Jao-ke Chin-Lee authored
BUG=crbug:1062407 TEST=./decode_test -video=bear-vp9.ivf -profile=vp9profile0 -out-prefix=bear/frame on nautilus Change-Id: I3dad8056acb44c9e3e8424be3175b0f017f098f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296874 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Bug: 1084281 Change-Id: I9086434a4f95f820da89c998ee9a652741398b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358908 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#799451}
-
Christopher Cameron authored
Add a temporary, to-be-deleted method, gfx::DisplayColorSpaces:: GetScreenInfoColorSpace, which returns the particular gfx::ColorSpace that would have been in blink::ScreenInfo. With this in place, the next sequence of patches can carefully handle each instance of GetScreenInfoColorSpace more appropriately. In particular: - LayerTreeHost::SetRasterColorSpace will use gfx::DisplayColorSpaces directly (and will change raster color space appropriately based on content). - GetColorSpaceGamut::GetColorGamut can operate directly only the DisplayColorSpaces. - The video-related "target space" will need to be replaced with the relevant information (which is most likely a single bit about HDR support). Bug: 1116870 Change-Id: I796c720cfc6796b3bb285cee27b98ae77650ea18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360549Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#799450}
-
Jing Wang authored
This is required as we want to rollout finch experiment to beta. Bug: 1042084 Change-Id: I7921f0434192f51b6942e13fc2307badf3c21c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359789 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#799449}
-
Dan Harrington authored
See bug. I was unable to reproduce the error, it's likley due to some experiment. I suspect it may be related to instant start, as this line would result in creating the wrong feed if the coordinator is made too soon: https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSurfaceCoordinator.java;l=223 For now, just DCHECK if this happens. Bug: 1117680 Change-Id: Iecc2690698b34a04151b62b684a6b8b955055fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363809Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#799448}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597773485-0de81363c6e29d47e12bedb85e74c4f66df8cd46.profdata to chrome-mac-master-1597795195-73a3893f6ac2e232e6f2551f9490f3476218900c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I67f9a7ad31c101f84051e5182898a6ddbf355429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364088Reviewed-by:
-
tby authored
Most search result data is stored in a SearchResultMetadata object, which is synced between the ash and chrome objects representing results. One exception is the ash::SearchResultType enum which, confusingly named, is only used for metrics. Currently this enum is available via a virtual method on the chrome-side only. To fix a race condition in the impressions system, we now need to treat it like other search result data. This CL adds methods to SearchResultMetadata, deletes the old chrome getter, updates all ChromeSearchResult subclasses to correctly set the metadata. The ChromeSearchResult subclass updates are mostly trivial, these have slightly more logic: - chrome_search_result itself - arc_app_data_search_result - omnibox_result Bug: 1076270 Change-Id: I1b1da0e3248031df3f31c2cd8b622dfb0487e390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352256Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#799446}
-
Zhenyao Mo authored
This is Windows only. DWM won't consider a swap chain as an overlay candidate unless it's updating at high enough fps with full damages. So we need to force full damage when the actual damage is closer to full damage in order to promote the main back buffer as an overlay. This CL also added the bit to allow viz to make sure swap chain's buffers always have up to date pixels inside or outside damage rects. This enables us to force full damage. BUG=1117185 TEST=manual R=sunnyps@chromium.org,magchen@chromium.org Change-Id: Idff7a90952c810a07992df0ace040be92b63e4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359730 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799445}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I6de3fb6e0c3130e3b9736498a1fa531b988fabb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363919Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#799444}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/df143e8b..6a992541 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0409b008138e655fae909cef8643af7227038641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362336Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799443}
-
Yi Gu authored
Bug: None Change-Id: I3557fcc552ca4e5505226dd20f978949bbae0de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363491Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799442}
-
Bettina authored
These histograms are needed because we can know how often synced account passwords are used and how often both synced and non-synced passwords are changed in comparison to how often they're reused. Bug: 1117113,1117111 Change-Id: I1ab9d79196f28fadeabbe9177052f85bf8523064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358595Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#799441}
-
Tommy Li authored
This CL replaces the placeholder English strings with their internationalized equivalent. Bug: 893183 Change-Id: I62f828c6db7fb40a421feb2352fb4f49a5fa1738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363641 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#799440}
-
