- 17 Aug, 2020 40 commits
-
-
James Hawkins authored
Also convert the types in NetworkListTypes as well since they are trivial and NetworkListItem depends on them. Bug: 1045266 Test: NetworkNetworkListItem* Change-Id: Iabe3a94bd80a9269215f1298c30e154442014003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359397 Commit-Queue: James Hawkins <jhawkins@chromium.org> Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#798826}
-
Victor Costan authored
Change-Id: I3673a9a4411c00b72a3e96b405ce726c9632ca4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359235 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#798825}
-
Josh Karlin authored
Change-Id: I35718eeeee57947b54a3e65348af9b1de1ac084c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354305Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798824}
-
Shimi Zhang authored
This CL uses a set::find overload to use the uint32_t type to find the object to avoid construct another object. By following the style guide, added a comparator struct. "For example, if your type doesn't have a natural ordering, but you want to store it in a std::set, use a custom comparator rather than overloading <." https://google.github.io/styleguide/cppguide.html#Operator_Overloading Bug: None Change-Id: Ic8b9f51a3b3a50601b1ecfa1ba8039ecf16a22ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358449Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#798823}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ic0dad7aa12b1e1c1e71e500ecddf2f2ce656fe85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360263Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798822}
-
Brian Geffon authored
Bug=CHROMIUM:973963 Change-Id: Ib2fe85abd4fbe5dee7c6da48f7f1f5c25dd17a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359740Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#798821}
-
Jan Wilken Dörrie authored
In order to make BasicStringPiece API compatible with C++17's std::basic_string_view this change removes the ends_with() API and updates call sites to use base::EndsWith instead. In order to keep this callsites concise, base::EndsWith's case_sensitivity parameter now defaults to CompareCase::SENSITIVE. TBR=dcheng Bug: 1049498 Change-Id: Ie10332e84ae8cc96524c4bf47e5f472a6215eaa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358831 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798820}
-
Jae Hoon Kim authored
Add missing mock for |ObjectProxy::WaitForServiceToBeAvailable| in order to unittest |ObjectProxy| when this method is called. BUG=b:164310699 TEST=unit_tests Change-Id: I0071e6d3987b5881841d3e38432ade6ceaf5eb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358131Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#798819}
-
Owen Min authored
cloud.png and success.png under chrome/browser/policy is not used by any source code. Change-Id: I13e8a5f56b927de7fb455408e088afb162050cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356671Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798818}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ffd805115ed6..21b36f736809 2020-08-17 rharrison@google.com Roll 4 dependencies (#1131) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ied6c561def4ebc0c16c279da171809877eaa5b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360298Reviewed-by:
-
Fred Mello authored
https://docs.google.com/document/d/1wXOKcgVy5YuGRFWUlBv75bl7j5gNK5bzc-ETr5GVBJw Bug: 1112872 Change-Id: Ie90cfe5dbb4efbb28e6b9407358556f6b1919cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359747 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Clark DuVall authored
This adds basic support for building WebLayer as an isolated split in WebView. A new gn arg "weblayer_in_split" is added which will move WebLayer Java code to it's own DFM if true. Supporting isolated splits required some client changes in WebLayer, so I added a check in WebLayerFactoryImpl.isClientSupported() to make sure isolated splits aren't used with an unsupported client. This also adds the ability to write the version_name and version_code of a bundle module to the build_config, which allows DFMs to match the base module version info (an error is thrown if these don't match). This makes it easy to share version info, since computing WebView version_code is pretty complicated. The bundle with isolated splits won't install correctly with the current version of bundletool we have in Chromium, but I'm working in parallel on fixing bundletool. Bug: 1105096 Change-Id: Id5522b42e283dc813fa84aaedc806f7519b586ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353378 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#798815}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/064bbf297d37..d63bca58a085 2020-08-17 cclao@google.com Vulkan: Add test for RGB texture not break renderpass 2020-08-17 jmadill@chromium.org Update commit ID when the git ref changes. 2020-08-17 cnorthrop@google.com Capture/Replay: Fix 1010102 vertex attrib type name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: Capture and replay first 1200 frames of COD. Change-Id: I60d25236d52abf81f0e25ccbfc02f275bae323ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359158Reviewed-by:
-
Russ Hamilton authored
Change-Id: I711966f27f5d3b317b8ea565117fff27d863ed57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354948 Commit-Queue: Russ Hamilton <behamilton@google.com> Reviewed-by:
-
Maksim Moskvitin authored
In order to perform more careful rollout this CL disables SyncTriggerFullKeystoreMigration, that was enabled by default. Bug: 1094326 Change-Id: I981a4ae364d8f2b807e251e679bc781f9e990c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359084Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#798812}
-
Emily Stark authored
This reverts commit f2af1ee6. Reason for revert: I unfortunately suggested the wrong approach for this CL. When we exclude enterprise-enrolled devices in code, these users (including Googlers) can't test the feature even by manually enabling the flags. Instead, we'll exclude enterprise users from the Finch config for this feature. Original change's description: > omnibox: Exclude enterprise-enrolled devices from simplified domain display > > For a 1% experiment with simplified domain display, we should exclude > enterprise enrolled devices to not disrupt enterprise environments when > collecting data. > This CL includes the following settings to achieve that purpose: > - Added a IsEnterpriseManaged() virtual method to OmniboxViewViews, in order to > filter whether a device is enterprise enrolled or not > - Added |is_enterprise_managed_for_testing| variable to toggle during > testing. It is by default FALSE, so, it should not affect previous > tests > - Added a SetEnterpriseManagedForTesting() method in TestOmniboxView to manually toggle the > |is_enterprise_managed_for_testing| flag, which is used in an overrode version of IsEnterpriseManaged() > - Add an special test to validate that URL is not unelided even when > field trials are enabled but the device is enterprise managed > > Bug: 1109243 > Change-Id: I79b47374de6c9eb780b5e56bef6408d3130c4168 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348578 > Commit-Queue: Ernesto García <ernestognw@google.com> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797930} TBR=tommycli@chromium.org,carlosil@chromium.org,ernestognw@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1109243 Change-Id: I68309155086541d34a3a953437a6ef0224d5f2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359743Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#798811}
-
Jan Wilken Dörrie authored
This change makes the following base::BasicStringPiece APIs constexpr: * substr() * front() * back() Bug: 1049498 Change-Id: I4e8694cec4b26b9f677175cb1fe135d8f9d42d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358671Reviewed-by:
-
Russ Hamilton authored
This is part of the identifiability study. Bug: 973801 Change-Id: Iea741169b1066dcfc4db8bd5abdd0e0e44263101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357513 Commit-Queue: Russ Hamilton <behamilton@google.com> Reviewed-by:
-
Peter Wen authored
Also remove unnecessary severity="Error" attributes since we always call lint with -Werror. Bug: 1116130 Change-Id: Ib9214668ea3e095d358a46daba6bf6df3203f6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354833 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#798808}
-
Fabrice de Gans-Riberi authored
A bug was introduced in https://crrev.com/c/2355924 leading to |semantics_manager_for_test_| being left unitialized, resulting in a crash in release builds. Bug: 1117070 Change-Id: I249c232e616145a21edf380077bcd58a1571c085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360315 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798807}
-
nancylingwang authored
Some Arc app icons are pixelated, e.g. spotify. The reasons is the background/foreground icon image fetched from the Arc side is pixelated. The Arc side cl:12384305 modifies the Arc side implementation to fetch the high quality raw icon foreground/background image: https://googleplex-android-review.git.corp.google.com/c/platform/vendor/google_arc/+/12384305 This CL implements the chromium side change to generate the adaptive icon in Chrome OS. 1. The raw foreground/background icon size is not the requested icon size. So modify ArcAppIcon, adding a flag, extract_subset_allowed_, to allow other size image to be forwarded to AppService for the foreground/background image. (Note: Arc default app icons may have different size background/foreground as well, but the case should be rare, because we just enable the flag for 1 week. Also most time the default app icons should match the size. If there are cases that the current Canary release is updated, and the default add icons are wrong due to the migration from last 1 week version, we can suggest disable/enable the Arc play store to refresh to the new image size.) 2. Modify AppService Arc icon handling to generate the adaptive icon using the raw background/foreground icon images. The Arc raw background/foreground image has padding for all 4 sides. So if the foreground/background icon image doesn't match the requested size, chop paddings and resize image_rep to the appropriate size. Then combine the foreground/background images, and apply the mask. This CL and the Arc side cl:12384305 work together to resolve the Arc app icons pixelated issue. This CL should be submitted first, and this CL is backward compatible. BUG=1114771 Change-Id: I70af928f5b6c81c28f71c54efa102b7b1c617a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359311 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#798806}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597665194-0d53ac1a851921d9b7ac1e88ae497b998bf9af0d.profdata to chrome-mac-master-1597687171-f7ac758bbaa5d412cea42dd6434f8391401d2bbb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I0e39d56622952181f47565a6ff937de26aeef67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360264Reviewed-by:
-
James Hawkins authored
Bug: none Test: browser_tests Change-Id: I392453663d7abe558c65a4f75e3e3c4080ce39f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359391 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
Yi Gu authored
crbug.com/1024598 was closed as wont fix because there is no intention to add UMA for that purpose. Bug: None Change-Id: Id3da27a9035eda136a340341fbb1ecc720e5a132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334348Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798803}
-
Sophie Chang authored
Add support for sentinel tuning version that is used for "control" optimizations where the type should be disabled for the navigation Bug: 1113287 Change-Id: Id82122c8f2918300bedc151b93b58d5aa9abb1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357558 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#798802}
-
Tomasz Wiszkowski authored
This change enables trybots to validate the Adaptive and Reactive suggestions. Bug: 1046863, 1056503 Change-Id: Ifc48bf2b3c120141b8ad4f3b37dfbed77babb1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354722 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#798801}
-
Robbie McElrath authored
Replace 'whitelist' and 'blacklist' with 'allowlist' and 'denylist' in //chrome/browser/supervised_user This CL leaves all user-facing or risky uses in place, and leaves them for followup CLs where they can get more close scrutiny. The remaining uses are: 1. SupervisedUserWhitelistInstaller, which lives in //chrome/browser/component_udpater. This is tracked in http://crbug.com/1097254 2. The "whitelist" key in the json content of the serialized whitelist file. I left this as-is for now because a simple rename would prevent existing whitelist files from loading correctly. 3. ManagedUserWhitelistSpecifics, which is a Message in the protobuf used for syncing. I believe this can be renamed without issue, but that would be done in a followup. 4. ManagedUsers.Whitelist.Count, ManagedUsers_Whitelist_Added, ManagedUsers_Whitelist_Removed, metrics. We can't rename these without decoupling them from their historical data. We may be able to create a formula to merge the old and new names, and base any alerts/dashboards on the formula. 5. "BlacklistOnly" trial group in the "SafeSites" field trial. It's unclear if this can be safely renamed. 6. "blacklist-20141001-1k.bin" is a file downloaded from gstatic with the default denylist. We can rename this once we copy the file in gstatic to a new filename. 7. "su-blacklist.bin" is the path of the denylist file that's stored in the user's data directory. Renaming this will require us to support both paths in the future. This also left as a followup. 8. "Blacklist active", "Blacklist", "Whitelist" in about:supervised-user-internals. This can be done in a followup due to it being a user-facing change. 9. "install-supervised-user-whitelists" switch, which is supposedly only used for testing. This can be done in a followup. Bug: 1097253 Change-Id: I7637c1f16a49e1dd7836a3fbe81122a69961270d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316889 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:Aga Wronska <agawronska@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798800}
-
David Black authored
Flakes were due to race condition in restoring clipboard buffer. This doesn't solve the issue that we still have a race condition, but should make the race condition less flaky. Bug: 1116530 Change-Id: Id0683fc408d48ed6daf795d5ab80ac1095c033d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360222Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#798799}
-
Fan Yang authored
R=dschinazi@chromium.org Bug: 1116812 Change-Id: Ib1b9f7f1c6c03fa790a1bd3f9b01f0261586f2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359551Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798798}
-
Jan Wilken Dörrie authored
This change adds the algorithms from [alg.lex.comparision] and [alg.permutation.generators] to //base/util/ranges and adds appropriate tests. Bug: 1071094 Change-Id: I9f353dfed0c0c2378686bfacdc2564bab4e4b43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358830 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798797}
-
Thomas Anderson authored
This reverts commit 3558d80a. Reason for revert: Suspected cause of build failure on android-official: https://ci.chromium.org/p/chromium/builders/ci/android-official/1056 [13692/25621] SOLINK ./libaudio_unittests__library.so FAILED: libaudio_unittests__library.so libaudio_unittests__library.so.TOC lib.unstripped/libaudio_unittests__library.so lib.unstripped/libaudio_unittests__library.so.map.gz /b/s/w/ir/cipd_bin_packages/cpython/bin/python "../../build/toolchain/gcc_solink_wrapper.py" --reade...(too long) ld.lld: error: undefined hidden symbol: base::(anonymous namespace)::g_discardable_allocator (.llvm.16724700302094337840) >>> referenced by run_all_unittests.cc:0 (../../media/test/run_all_unittests.cc:0) >>> thinlto-cache/llvmcache-3F27182A7CE8A475288094E8A454CB68C4740658:(TestSuiteNoAtExit::Initialize()) Original change's description: > Proactively purging discardable memory on Desktop > > This CL adds a way for ClientDiscardableSharedMemoryManager to discard > unlocked discardable memory locally. To achieve this, it keeps track > of all locked and unlocked, unpurged instances. These are then purged > all at once when ReleaseFreeMemory() is called. > > This is guarded by a new feature which is disabled by default, and as > such there is no behaviour change by default. > > Bug: 1109209 > Change-Id: I7755d714ff354e831557627fda401751384392b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321400 > Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Reviewed-by: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798630} TBR=penghuang@chromium.org,lizeb@chromium.org,thiabaud@google.com Change-Id: I39ddd002be3753d1339501c74df866d898ad53a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360121Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798796}
-
Ken Rockot authored
See bug for details. It's possible for the IO thread to unsafely access a NodeChannel after it's been destroyed on the UI thread. This fixes the issue by ensuring the NodeChannel is always destroyed on the IO thread. Fixed: 1081874 Change-Id: I1fc4eaa0cef20f036c85fee3ed7976f518fbf60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357451 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#798795}
-
Jonathan Mengedoht authored
Integrate ChangePasswordUrlService in WellKnownChangepasswordTabHelper. Bug: 927473 Change-Id: I7a836f1946e18fa434873d0b112e85015659bac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358741 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#798794}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22e7f7a0d7d7..699711c7e3cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I535e3c24df7a7959c7853103cdc2751e914fe568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359739Reviewed-by:
-
Cammie Smith Barnes authored
We also add the base::Feature kV8PerAdFrameMemoryMonitoring in order to experiment via Finch to find a suitable memory polling interval. In a followup CL, we will implement the OnV8MemoryMeasurementAvailable method and create and populate memory data histograms. Bug: 1117176,1116087 Change-Id: Iee3ca57247c85285af9d293f2da6bfe38574f64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323505 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#798792}
-
Sami Kyostila authored
Chrome and WebView have supported basic Android ATrace tracing, but the current approach has some shortcomings: 1) Android R changes the way atrace session activations are broadcast, breaking the code in WebView listening for activations (OnTraceEnabledChangeListener). This means you can't trace a running WebView app with atrace. 2) Neither Chrome nor WebView record early startup events to atrace, which means all events before the native library has loaded are lost. 3) It's not possible to specify trace categories via atrace, which means we need more cumbersome alternative solutions (i.e., command line flags) for startup tracing. 4) Writing ATrace events is only supported in WebView. This patch reworks the ATrace integration to resolve these problems and to align the Chrome and WebView implementations. In short, ATrace session management is moved to the common (TraceEvent) layer, and Chrome and WebView only differ by which trace tags they listen to (APP vs. WEBVIEW). We also add a way to declare trace categories through per-app tags: $ atrace -a org.chromium.chrome,org.chromium.chrome/<category_filter> (Note that the plain package name without any category filters must always appear in the list on its own.) Multiple categories can be separated with a double colon: $ atrace -a org.chromium.chrome,org.chromium.chrome/cat1:cat2 Or by specifying the the app several times to get around the 91 character limit for each entry: $ atrace -a org.chromium.chrome,\ org.chromium.chrome/cat1,\ org.chromium.chrome/cat2 Finally, to capture Java startup events into a tracing session controlled by the system's Perfetto service instead of atrace, a special "-atrace" category can be used to only write events into Chrome's own tracing service instead of atrace. This way when we connect to Perfetto later in the startup sequence and establish the real tracing session, startup-related events can be flushed into that session without emitting duplicate events into ATrace. # Basic trace while Chrome is running. Generates ATrace with Chrome # events. TEST=atrace -a org.chromium.chrome # Ditto for WebView. TEST=atrace webview # Startup trace -- open Chrome after running this. Results in an ATrace # with Chrome pre- and post-startup events. TEST=atrace -a org.chromium.chrome # Ditto for WebView. TEST=atrace webview # Trace with custom categories. Results in a ATrace with only # "cc" events from Chrome. TEST=atrace -a org.chromium.chrome,org.chromium.chrome/-*:cc # Ditto for WebView, using GMail as a test app. TEST=atrace -a com.google.android.gm,com.google.android.gm/-*:cc webview # Chrome-only trace. No Chrome events written in the resulting ATrace. TEST=atrace -a org.chromium.chrome,org.chromium.chrome/-atrace Bug: 1095587, b/160768681 Change-Id: Ia0bee252ce398804c00be8a4179241b75479bf5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332664Reviewed-by:Eric Seckler <eseckler@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#798791}
-
Taylor Bergquist authored
This reverts commit b25056de. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1116917 Original change's description: > Reland "Tab strip only occupies the space needed for its tabs." > > This is a reland of b6c0ca2a > > The only change is a line in tab_scrubber_browsertest.cc that ensures > that any invalid layout are laid out after modifying the tabstrip. > > Original change's description: > > Tab strip only occupies the space needed for its tabs. > > > > Bug: 1093972 > > Change-Id: I0ca6cc1a7dad9240b85745fefb39ac4f52eb9355 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300993 > > Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> > > Reviewed-by: Connie Wan <connily@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#793270} > > Bug: 1093972 > Change-Id: I4ded68fde336b14b38ad862cd63118ebc9fc7a72 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336296 > Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> > Reviewed-by: Connie Wan <connily@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797853} TBR=pbos@chromium.org,tbergquist@chromium.org,connily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093972 Change-Id: I3de1d647a4fbba593ce3ef52f59127b6495e5ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358591Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#798790}
-
Lei Zhang authored
Add a method to query the focus state of the PDF plugin. This information will be used to implement focus changes in the PdfAccessibilityTree. This CL is partially based on code borrowed from https://crrev.com/c/2230804/21. Bug: 1015350 Change-Id: I3475010b8aec146f258d5f481ec2d60133d1acda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351721 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798789} -
Martin Kreichgauer authored
FidoDiscoveryFactory ownership and lifetime currently is a bit muddled. "Regular" instances are owned by AuthenticatorRequestClientDelegate, of which AuthenticatorCommon instantiates one per request. The virtual authenticator environment that manages the WebAuthn testing API can install and uninstall discovery factory overrides for a particular frame node. The lifetime of these overrides is decoupled from WebAuthn request lifetime, which is conceptually problematic (see e.g. crbug/1087158). Lastly, ReplaceDefaultDiscoveryFactoryForTesting() is another avenue for injecting a long-lived FidoDiscoveryFactory that we use extensively in unit and browser tests. To simplify, limit FidoDiscoveryFactory lifetime to a single WebAuthn request and put ownership into AuthenticatorCommon next to the FidoRequestHandler. To accomplish this, break VirtualFidoDiscoveryFactory, which implements the WebAuthn testing API, into a long-lived part that handles testing API configuration and a now short-lived discovery factory. As an exception, overrides injected by ReplaceDefaultDiscoveryFactoryForTesting() remain long-lived and owned outside of AuthenticatorCommon. They should probably be broken up in a similar fashion, but that involves changing many unit tests, and this CL is already a bit large. Change-Id: Ie7da2b3cca4eea78b541eb341708b113ad43a905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350026Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#798788}
-
Jan Wilken Dörrie authored
This change adds the algorithms from [alg.min.max] and [alg.clamp] to //base/util/ranges and adds appropriate tests. Bug: 1071094 Change-Id: I14d8c3c15fe2b6e2dab8a37afb931562a8c54984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358969 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
