- 20 Feb, 2018 40 commits
-
-
Michael Giuffrida authored
Like the unit tests, but these can test more robust browser activity. Bug: 784639 Change-Id: I65ef78d56143d65811a05e7b8a1088e2ce9c372e Reviewed-on: https://chromium-review.googlesource.com/905688 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#537830}
-
Majid Valipour authored
KeyframeModel::is_controlling_instance() is explicitly meant to convey which model is actually the impl side one. We should use that instead of overloading |events| nulliness with being on impl side (or not). The latter is brittle and not readable. |KeyframeModel::is_controlling_instance_| is correctly set true for impl only animation. In this case there is only a single animation instance which is by definition the controlling instance. The CL fixes this. See also: https://codereview.chromium.org/1151763011 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I4380228084fd9ed7199c66e949229e0936cf4fc3 Reviewed-on: https://chromium-review.googlesource.com/914704 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537829}
-
https://webrtc.googlesource.com/src.git/+log/645898a45433..6bd3cddcef0c $ git log 645898a45..6bd3cddce --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I719e0ac6fc58fa82790c44842245525ae8986868 Reviewed-on: https://chromium-review.googlesource.com/926704Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537828}
-
Eugene But authored
Comments explain the reason for recursive LoadHtml retry. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icd2b9a93e127500759c61a7e051e92ddc02df727 Reviewed-on: https://chromium-review.googlesource.com/926574 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#537827}
-
Anthony Vallee-Dubois authored
This CL fixes a crash in Incognito where the Payment Request IdentityProvider attempted to register an Observer on a null SigninManager. It also brings Payment Request in line with Autofill, where previously PR was displaying the Original Profile's Autofill data but wasn't able to unlock cards because the IdentityProvider was invalid in Incognito. Bug: 813275 Change-Id: I3fb43ba45404f8884a300d77fda7f8fe0f8364af Reviewed-on: https://chromium-review.googlesource.com/926563 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537826}
-
Michael Giuffrida authored
It's apparently possible for BrowserList::SetLastActive(Browser* browser) to be called before |browser| is added to the BrowserList. This might happen, e.g., if a BrowserView's widget receives an activation event before CreateBrowserWindow() returns. This will cause WindowActivityWatcher's UpdateMetrics() helper function to dereference the null pointer at browser->window(). Bug: 811243,811191 Change-Id: Ia377a810b73494f88d1cd2b4532367950f35b1f7 Reviewed-on: https://chromium-review.googlesource.com/924353 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#537825}
-
W. James MacLean authored
Prior to https://chromium-review.googlesource.com/905273, ScrollingCoordinator did not update touch event rects for OOPIF subframes. To make sure that touch handlers in OOPIFs remained functional, the code had a hack to set the entire root layer layer of an OOPIF to be a touch event rect if the OOPIF contained any touch handlers at all. Now ScrollingCoordinator should be handling these rects for OOPIFs, so this CL removes the hack. Bug: 680606 Change-Id: I6a1b7badca7c9752c298a97ab17cbe28775e0eb8 Reviewed-on: https://chromium-review.googlesource.com/923583Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#537824}
-
Bence Béky authored
This is a test-only change. Change ConstructSpdyDataFrame() to take a base::StringPiece argument instead of separate data and length. To prevent headaches while writing unittests if one forgets to change the length and has a hard time figuring out why mock data does not make any sense. Also move |content| local variable from heap to stack in multiple tests. Also use std::string::data() instead of std::string::c_str() where substrings are constructed in tests. Also replace some potentially politically incorrect text with more neutral text of the exact same length. Bug: 810752 Change-Id: Ib22f9ab5c12be8e2c95bd68205995547fda4e9ba Reviewed-on: https://chromium-review.googlesource.com/926421Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#537823}
-
Christopher Grant authored
This change follows up on the namespace change, to relocate files, and address some of the presubmit warnings stirred up by that move (mainly BindRepeating/Once updates). BUG= NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ieb4d0ad3fd039e5e85b0a8cf2204d1141d3438d9 Reviewed-on: https://chromium-review.googlesource.com/921924 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#537822}
-
Francois Doray authored
The log statements were added by error by https://chromium-review.googlesource.com/c/chromium/src/+/867511 TBR=wittman@chromium.org Bug: 668690 Change-Id: Iefaa5d6cf254762230d8dd4bf04b903689d36777 Reviewed-on: https://chromium-review.googlesource.com/926782Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#537821}
-
Aga Wronska authored
--enable-demo-mode switch turns on new demo mode feature that is under development. Ctrl+Alt+D shortcut opens new demo mode setup flow from OOBE (sign in screen). It is used for development and might change in the future. Change-Id: Ie3c0d954cd7d3d82f030873b9472debb1ebb2a1d Bug: 812460 Reviewed-on: https://chromium-review.googlesource.com/914846Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#537820}
-
Robert Liao authored
This allows for easy migration to the views version of ExtensionPopup. BUG=728174 Change-Id: I2c9085952cd351247aeefa4247cef7fefa974c40 Reviewed-on: https://chromium-review.googlesource.com/924682Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#537819}
-
David Tseng authored
Bug: 793754 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia452a9c25fbd35b0ccc91ac6572e3e5c11dc8418 Reviewed-on: https://chromium-review.googlesource.com/926221Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#537818}
-
Scott Violet authored
. Content moves loading from PreCreateThreads() to PreEarlyInitialization() (or right after calling BrowserMainParts::PreEarlyInitialization() . This necessitated a change for cast to have content not init FieldTrials. . Moves creation of FieldTrial in tests from TestBlinkWebUnitTestSupport to UnittestTestSuite. This is so code run after that (but before TestBlinkWebUnitTestSupport) has the FeatureList setup. BUG=800357 TEST=none Change-Id: I50e121f4c5654288571715b0e72bf04db340daf1 Reviewed-on: https://chromium-review.googlesource.com/925685Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#537817}
-
Mike Wasserman authored
Shelf Model sync allows Chrome to use a separate shelf model from Ash. This functionality is required for the Chrome OS shelf to work in Mash. This config has been running fine on stable for a couple milestones. Remove the switch and flag to disable the functionality. Bug: 557406 Test: No behavior changes; ShelfModel sync still works. Change-Id: I6f1488dd983b7140c72934fa3ac27c26d4a48028 Reviewed-on: https://chromium-review.googlesource.com/923429Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#537816}
-
Pavol Marko authored
These .cc files have been included accidentally. Include the header file instead. Bug: 713138 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If9ee44765e1bbd7d4d4d5c4a6367457dc62fd01f Reviewed-on: https://chromium-review.googlesource.com/926583Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#537815}
-
Alexei Svitkine authored
This reverts commit b9aa7421. Reason for revert: Reverting temporarily to get canary data, as we suspect this CL might have regressed Omnibox.CharTypedToRepaintLatency. Original change's description: > Fix rlz disabling breakage on CrOS > > Revert of "Cache the brand code to avoid hundreds of repeated reads." > commit 04749717. > https://codereview.chromium.org/2890943005 > > Disabling RLZ is communicated through an empty brand code. Thus the > value of the brand code must not be cached before RLZ is initialized. > > BUG=793162 > TEST=none > > Change-Id: I7f9e223a9a39d19408f364f6aad95cb8c86f6d79 > Reviewed-on: https://chromium-review.googlesource.com/824363 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Thiemo Nagel <tnagel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524012} TBR=pkasting@chromium.org,tnagel@chromium.org,borisv@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 793162 Change-Id: Ifba1cd02df27c950416cc6433f0c4cba00d2cf47 Reviewed-on: https://chromium-review.googlesource.com/926622Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#537814}
-
Tommy C. Li authored
This prototypes the idea of uneliding when the user affirmatively places the caret within the existing URL or makes a partial selection. The partial selection can be made either via double-click or by dragging. The unelision happens on mouseup. It feels pretty good. Change-Id: I5522a7b6dc8d94fe84c39c8b71995abc5007651a Reviewed-on: https://chromium-review.googlesource.com/910110Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#537813}
-
Torne (Richard Coles) authored
The WebView stub needs to be able to override this to Monochrome's application class name. Bug: 809636 Change-Id: Icbc68f84ce76a8cb2d3ed8ec11d0cca0e00e33e3 Reviewed-on: https://chromium-review.googlesource.com/926724Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#537812}
-
Eugene But authored
There is no unit test for tapping OK and Cancel buttons, because it's something that is very hard to test in unit test (buttons are not tappable unless the UI got synchronized). This CL adds "Start New Download?" dialog when user attemps to create a download while another download is in progress. UI mock: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2b7a689b42_0_196 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icde65bf68d4ee0ff4181165a4d812f9e16e8de9e Reviewed-on: https://chromium-review.googlesource.com/924750 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#537811}
-
Charles Harrison authored
Bug: 813643 Change-Id: I6cea489ba38ee181c49b54cb87b747db64a5ee63 Reviewed-on: https://chromium-review.googlesource.com/925622Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#537810}
-
Sylvain Defresne authored
Move all the code related to clearing browsing data to IOSChromeBrowsingDataRemover after remarking that method -removeIOSSpecificIncognitoBrowsingDataFromBrowserState:.. is unnecessary as -removeBrowsingDataFromBrowserState:... clear exactly the same data is BrowserState is incognito. Refactor some method clearing browsing data to accept a closure (those that are asynchronous). Bug: none Change-Id: I7dfbb7040b87343fdd3df3b473a7d4c2046d4c46 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/919264 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537809}
-
Francois Doray authored
The command line is initialized before TaskScheduler on non-iOS platforms. That allows TaskScheduler to read configuration flags on the command line. Bug: 726937 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I43e430aecbfa88927244f6db94bcb0b81e608426 Reviewed-on: https://chromium-review.googlesource.com/924375Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#537808}
-
Fabio Tirelo authored
BUG: 800507 Change-Id: I979dc51418f494bc1aa11fcf6954b78ceffdc075 Reviewed-on: https://chromium-review.googlesource.com/924319 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#537807}
-
Evan Stade authored
Chrome OS should know its own name. This allows us to move one more reference to MessageCenter from the Chrome process to Ash. Unlike chromium_strings.grd/google_chrome_strings.grd, the branded and unbranded strings both live in ash_strings.grd. This should be OK because the split grd files are both part of the src checkout, and are probably only separate because google_chrome_strings.grd used to be in src-internal. Bug: 578868 Change-Id: If7da91e2e291c7d9b467aa9a51b5af671a54b98f Reviewed-on: https://chromium-review.googlesource.com/923559Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#537806}
-
sczs authored
Creates a TableContainerViewController that contains a ChromeTableViewController. Adds it to showcase. Screenshot: https://drive.google.com/open?id=1kCC5xDoreepzp2Y-uQmVUxMUP_Vae_Y_ Bug: 805013 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5f5d58eab32a8c13cbcc8ed32f4a6d5cbc7b7598 Reviewed-on: https://chromium-review.googlesource.com/923408 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#537805}
-
https://chromium.googlesource.com/angle/angle.git/+log/697bf65c1107..029e8ca77884 $ git log 697bf65c1..029e8ca77 --date=short --no-merges --format='%ad %ae %s' 2018-02-16 oetuaho Add a constexpr constructor for TFunction Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I82f3edcb8d9eacf406e97c9dd93d4d9d2a65be5d Reviewed-on: https://chromium-review.googlesource.com/926502Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537804}
-
Majid Valipour authored
Reduce Animation API surface exposed to the effect. In particular it enables WorkletAnimation to also be a client and it futures enabled constructs such as GroupEffect whose child effects are not attached to an Animation. Changes in this patch: - Introduce a new interface AnimationEffectOwner implemented by Animation. - Update AnimationEffectReadOnly to depend on this interface. - SampledEffect no longer access Animation directly but it relies solely on effect. This still leaves some access to the underlying animation instance in the following cases: - KeyframeEffect uses it mostly to pass it to CompositorAnimations. - EffectStack uses it to check if it is in the suppressed set. - Animation uses it to detach the effect when moving an effect from one animation to another. These are tracked for clean up here: http://crbug.com/812410 Change-Id: I4fa78ce8c5369d2de1432e0bc032e88ce7ee3595 Reviewed-on: https://chromium-review.googlesource.com/900210 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#537803}
-
Justin Cohen authored
This reverts commit e56e2bba. Reason for revert: Breaking downstream device tests: Using Xcode version 9.2 build 9C40b at /b/swarm_slave/w/ir/Xcode.app/Contents/Developer Traceback (most recent call last): File "src/ios/build/bots/scripts/run.py", line 228, in <module> sys.exit(main()) File "src/ios/build/bots/scripts/run.py", line 73, in main return 0 if tr.launch() else 1 File "/b/swarm_slave/w/ir/src/ios/build/bots/scripts/test_runner.py", line 489, in launch result = self._run(cmd=cmd, shards=self.shards or 1) AttributeError: 'DeviceTestRunner' object has no attribute 'shards' Original change's description: > Implement iOS test sharding with multiple simulators on test_runner. > > Details in doc: > https://docs.google.com/document/d/1QaAZgmYuEImL1wAYJQxPcbex-fPLVd3rx8oMMKIgZX8/edit# > > Bug: 808267 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I55fc27fcf31120a7c9d39e8953f72a39dd6394a7 > Reviewed-on: https://chromium-review.googlesource.com/917309 > Commit-Queue: Menglu Huang <huangml@chromium.org> > Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537731} TBR=sergeyberezin@chromium.org,huangml@chromium.org Change-Id: I6a8e30d1fa5e9e1f5e2d7af3f620f967841cddcb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 808267 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/926822Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#537802}
-
Evan Stade authored
This is a follow up to 309d7b01 Bug: 795331 Change-Id: I2765f13bf66e2fd0f1a0cce94c7a4c84fd237c3c Reviewed-on: https://chromium-review.googlesource.com/923356Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#537801}
-
Miguel Casas authored
vaapi_video_decode_accelerator.* have three inner classes for H264, VP8 and VP9 decoding. To reduce the size of the file(s), this CL extracts those into their own files. No new code is introduced in those new files, but VideoDecodeAccelerator needs to make 3 methods public in order for those not-anymore-internal classes to work (idea for next CL would be to make those into an interface that VaapiVDA implements). Test: Compile and run in simplechrome on soraka. Ran h264, vp8, vp9 videos of crosvideo.appspot.com, verified GpuVideoDecoder engaged. Bug: 717265 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I054b39a330f3876031fd30d6e3e36878322d9036 Reviewed-on: https://chromium-review.googlesource.com/922811Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#537800}
-
Dominik Röttsches authored
While we do support variations, our format specifier support was not updated yet. Move all of that to FontCustomPlatformData and add a WPT test to cover common supported format specifiers. Test: external/wpt/css/css-fonts/format-specifiers-variations.html Bug: 804466 Change-Id: I06d7af65cf74e13cec49dc279efb8ffc2b56dda9 Reviewed-on: https://chromium-review.googlesource.com/926007Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#537799}
-
https://pdfium.googlesource.com/pdfium.git/+log/e53460ff2697..8c0a80087c42 $ git log e53460ff2..8c0a80087 --date=short --no-merges --format='%ad %ae %s' 2018-02-20 dsinclair [formcalc] The if token is a keyword and should not be made an identifier 2018-02-20 dsinclair Tighten up assignment instructions in formcalc. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I52a4aacf8113ad5b0186f3f62fa153c39a65a24f Reviewed-on: https://chromium-review.googlesource.com/926573 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537798}
-
Xi Cheng authored
Test coverage is also added. Bug: 734095 Change-Id: Id0fa36d078aa68ccbe4d2b820d55838303bbfdd9 Reviewed-on: https://chromium-review.googlesource.com/896743Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#537797}
-
https://webrtc.googlesource.com/src.git/+log/52e58524b67a..645898a45433 $ git log 52e58524b..645898a45 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ied8aa6fbb5051eb6a956e0b822a47e80140503c4 Reviewed-on: https://chromium-review.googlesource.com/926501Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537796}
-
https://skia.googlesource.com/skia.git/+log/7f583c933032..cefc1b97405d $ git log 7f583c933..cefc1b974 --date=short --no-merges --format='%ad %ae %s' 2018-02-19 fmalita Pass Viewer touch events to slides 2018-02-15 egdaniel Change createWrappedTextureProxy for render targets to use lazy proxies. 2018-02-20 kjlubick Remove XSAN blacklist 2018-02-16 mtklein loop over all color and alpha types 2018-02-20 borenet [recipes] More hackery to work around old depot_tools Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I8ffa51ad11abaeb10384a480126867363f02f8e6 Reviewed-on: https://chromium-review.googlesource.com/926562 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537795}
-
sunxd authored
Mask layer's occlusion is actually its render surface's occlusion in the contributed parent surface space. However, when tiling a solid color mask layer, we used to adopt the logic from normal picture layers: overwrite the occlusion's transform with the layer's draw transform. This is problematic because mask layer's draw transform is to the render surface that owns the mask. In this way, we can generate the wrong visible quad rect and result in blanks when rendering. Since solid color mask layer does not do anything but cannot be fully avoided in the current code base, we should never apply an occlusion to it. Any occlusion to the masked content can still take effect by applying itself to the owning render surface. Bug: 811143, 810820, 808372 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I821492c107c2abadb9b9e6986369c9f6262d0ad4 Reviewed-on: https://chromium-review.googlesource.com/916625 Commit-Queue: Xianda Sun <sunxd@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#537794}
-
Pavol Marko authored
On user session start, only request the chrome process to be restarted if site isolation policies effectively change between the sign-in screen and the user session. The DeviceLoginScreenSitePerProcess and DeviceLoginScreenIsolateOrigins policies map to --site-per-process and --isolate-origins command-line flags passed to the sign-in screen chrome process by session manager (see CL:924421). The user session should respect SitePerProcess/IsolateOrigins user policies instead. Replace special handling of the site isolation flags with placing them between --policy-flags-begin and --policy-flags-end sentinels. This makes sure that chrome is restarted exactly when the user session flags don't match the login screen flags. Background: chrome decides if it should be restarted by comparing the parts of the current command line with parts of the target command line. Specifically, the parts between flags and policy sentinels are compared. Also, evaluate the user policies mapped through user Profile prefs instead of local_state. Reason: When login_manager starts chrome with site isolation flags, the prefs are set by ChromeCommandLinePrefStore. TBR=xiyuan@chromium.org Bug: 800117 Test: browser_tests --gtest_filter=*SiteIsolationFlagHandlingTest* Change-Id: I85d47bd2a4da9155e9c6ad338284e1bfed5b478e Reviewed-on: https://chromium-review.googlesource.com/924147 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#537733} Reviewed-on: https://chromium-review.googlesource.com/926370 Cr-Commit-Position: refs/heads/master@{#537793}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e87c0fb4..056e8283 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I23440c5a5c265d827dffc6a147f797264d2192ce Reviewed-on: https://chromium-review.googlesource.com/926422Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#537792}
-
Vladislav Kuzkokov authored
This is a reland of 53ccd0b5. TBR=thestig@chromium.org,mnissler@chromium.org Original change's description: > ARC Print > > This allows container to use native printers. > > Bug: 625126 > Change-Id: Idb1b1de9a11877fdfa9e9eb4e9ec87d4bf089ef7 > Reviewed-on: https://chromium-review.googlesource.com/648979 > Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> > Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536784} Bug: 625126 Change-Id: I569a36ee57e6495525efcc44820b65f03146dc26 Reviewed-on: https://chromium-review.googlesource.com/925481Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#537791}
-