- 08 Dec, 2020 40 commits
-
-
Ian Barkley-Yeung authored
Gives the browser the ability to tell the renderer that it wants stack traces on error-level console messages. Useful if we are sending error reports about those messages back to Google. Empirically, both console.error messages and unhandled exceptions get stack traces; unhandled promise rejections do not. Bug: chromium:1121816 Change-Id: I63768696dbd120522d7b5fb1e7133d8c233b213c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556008Reviewed-by:
dstockwell <dstockwell@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#834561}
-
chrome://flagsElaine Chien authored
Bug: 1145666 Change-Id: Ieb06cd829b7c7eb0170a1af5de121661a430f4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575430 Commit-Queue: Elaine Chien <elainechien@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#834560}
-
Alexander Timin authored
Back-forward cache is in the process of being shipped and under active further development, so this flag is going to be useful for the foreseeable future. R=fergal@chromium.org Change-Id: I5c72a74dd7f7f7ed015ef4dd2942eb75718f9733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574983 Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834559}
-
Nancy Wang authored
This reverts commit bc24c252. Reason for revert: <INSERT REASONING HERE> It looks like this CL breaks below tests: GpuDataManagerImplPrivateTest.FallbackFromVulkanToGL GpuDataManagerImplPrivateTest.VulkanInitializationFails GpuDataManagerImplPrivateTest.FallbackFromVulkanWithGLDisabled GpuDataManagerImplPrivateTest.GpuStartsWithVulkanFeatureFlag https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/5190 https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel Original change's description: > Disable Vulkan for LACROS > > Bug: 1155622 > Change-Id: I8def57cef648ec4881f666aec614200d13eac972 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577815 > Auto-Submit: Peng Huang <penghuang@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834507} TBR=penghuang@chromium.org,rjkroege@chromium.org,erikchen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I249afa54900b08acbd75b37ac3e15d853b6bb32c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578418Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#834558}
-
Alan Screen authored
Incorporate support for retrieving a printer's semantic capabilities and defaults from the utility service instead of within the browser process. This protects the browser from potential crashes as well as reducing jank by not having the UI thread blocked waiting on the call to return. Bug: 809738 Change-Id: I900939877679fe09a245b4796e6b1bb0110eec71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441668Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834557}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3b055d329e60..5c5f0baa72f1 2020-12-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-12-08 nodir@chromium.org Revert "[dirmd] Roll dirmd" 2020-12-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-12-08 sokcevic@google.com Add change HEAD cli option to gerrit_client 2020-12-08 nodir@chromium.org [dirmd] Roll dirmd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1154541 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib66c98267321fb14b9f4bb477c4edc3aa198c2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578160Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834556}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I0b653cc0888a98faa504656b288f6c2c4ad1502c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578163Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834555}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/529b25929c85..f639a24c5041 2020-12-08 michaelludwig@google.com Consolidate quick reject / paint bounds logic into helper function If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I1ba96658bd5cc996166d3d1f609b3ce21dd8ccb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577551Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834554}
-
Jasmine Chen authored
This CL fixes an issue where the scoped_ref base::ObserverListThreadSafe isn't initialized, causing chrome to crash immediately following CameraHalDispatcherImpl::AddActiveClientObserver(). It also adds a unittest to make sure the observer works. Bug: 1155159 Test: Create an observer in camera_hal_delegate.cc and verify that the observer is registered and receives updates. \ (DUT) $ capture_unittests --gtest_filter='*Dispatcher*' Change-Id: I54a8a77a2b48eb328ca2c1f0a2fb3ce057f66b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575297Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#834553}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I342e1ca6cef8b69bafae5de2d4b446a1eacd6f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564980 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834552}
-
Ryan Keane authored
This CL defined the PushBufferQueue class, which sits in between the CmaBackendProxy (which feeds in data when it gets a PushBuffer command) and the CastAudioDecoderChannel (see https://chromium-review.googlesource.com/c/chromium/src/+/2509046) which pulls data out (via GetBufferData()). Bug: b/167426091 Change-Id: I7e155f4d121bef31855c48d2c7f037bafd626a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509338 Commit-Queue: Ryan Keane <rwkeane@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834551}
-
Shimi Zhang authored
TBR: michaelbai@chromium.org Bug: 1156419, 1156418 Change-Id: Ia22d84a21c606418b595f2d1e421eb24a1a4742c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578131Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#834550}
-
Daniel Cheng authored
Bug: 1154141 Change-Id: I8996510a69ca1fe1b6d4f1affca9a431961ac1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577762Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#834549}
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_ShowScriptedPrintPreview message to ShowScriptedPrintPreview() in mojom::PrintManagerHost. Bug: 1008939 Change-Id: I28a6b7a9b21f7ce0b0dab1147946d39ac56cd69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569567Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#834548}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ded1d94cebd..f7af16c5f6fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nancylingwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1156327 Tbr: nancylingwang@google.com Change-Id: I7a104acbd6ce5e099e01d24220a7672fe3fc93f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577959Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834547}
-
Julie Jeongeun Kim authored
This CL cleans up resource_request_detector.{cc,h} and ServicesDelegate::ProcessResourceRequest() along with all the production and test code related to it. Bug: 1059639 Change-Id: I353b6beecee4e6c00b06fdc8612f4ca2c00b459f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560185Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#834546}
-
Keishi Hattori authored
When BackupRefPtr is used for HeadlessWebContentsImpl::browser_context_, the destruction order of the fields causes a null dereference. HeadlessWebContentsImpl::RenderFrameDeleted() gets called in ~HeadlessWebContentsImpl(), so the HeadlessWebContentsImpl is half destroyed and browser_context_ is null when it is called. Bug: 1080832 Change-Id: I8ca260f175cc3a31115c63ecf62b05f1c1f7bc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563515Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834545}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/57c86890de5f..5921e781cd6d 2020-12-08 cjamcl@chromium.org [Lighthouse] Roll Lighthouse 6.5.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:772558 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9d3f3f0110906905e433ce096fc268b36b0c8361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577961Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834544}
-
jchen10 authored
This makes 'WebCodecs' follow the naming rule as other modules like 'WebSocket', 'WebGL', otherwise it would lead to unusual names like 'webgl_web_codecs_video_frame.h'. Bug: 1142754 Change-Id: I2280e3340be9adf04cd51d426a61f51b590493da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570395Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#834543}
-
Lukasz Anforowicz authored
This CL removes network::CrossOriginReadBlockingExceptionForPlugin and content::RenderProcessHostImpl::AddCorbExceptionForPlugin (and any other code these removals transitively enable). The CL also needs to adjust how the test plugins work: 1. Changing PluginServiceImpl::FindOrStartPpapiPluginProcess to use the NetworkService::AddAllowedRequestInitiatorForPlugin mechanism for the test plugin (the same mechanism that is used for the PDF plugin). This is needed to make sure that the test plugin continues passing request_initiator_origin_lock checks and CORB checks. This change requires that FindOrStartPpapiPluginProcess always sees a non-null `origin_lock` - this is accomplished by isolating all non-NaCl plugins in IsOriginIsolatedPepperPlugin (also avoiding isolation in presence of the --ppapi-in-process switch used by some tests). 2. Removing CORB/Flash-specific tests and supporting test code, or tweaking them to simulate PDF-related functionality. Fixed: 1134401 Change-Id: Iac3579b2f3c66ac434583fcbb3119ac6857ec436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560827Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#834542}
-
Jiewei Qian authored
SWA has it's own logic for managing windows for OS Settings SWA. SettingsWindowManager should only be used for legacy OS Settings. This CL stops notifying observers about creation of SWA OS Settings windows. This is safe because the only use case is SettingsWindowObserver, which is only initialized if legacy settings window is used (but never initialized if SWA is used). See chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc. This CL is a preparation for https://crbug.com/1154540, where we implement a new LaunchSWA API. The new API uses AppService to launch the app, and won't return the Browser object hosting the app window. Bug: 1154540 Change-Id: I7ba5d4bc1ab6928168b0bc17016ab6684ca1f2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568340 Commit-Queue: Jiewei Qian <qjw@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#834541}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607363880-fd3f1baf2a5dc6b74a86d40eb9ec18d09a3815d8.profdata to chrome-linux-master-1607385573-c353d00fc8fe8bd6d284b3c59bd857ed5fa10770.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I582eb9c045068b91c28268e30b0099b2a88ed97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834540}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/042184128efe..8a73e1876dbd 2020-12-07 enga@chromium.org Add MSL support for UseTintGenerator toggle If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Id6d7321af3d00665c28d7e84ccd6664ad5674d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577552Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834539}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dea86294537c..8b4990bbd621 2020-12-08 cnorthrop@google.com Capture/Replay: Fix capture of GL_EXT_debug_label If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: Seven Deadly Sins MEC Change-Id: Ied2726619c579c00aa6aa0049a69c20e826267d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834538}
-
Kevin Marshall authored
Produces ERROR logging and invokes error closure if the ApiBindings service disconnected before AttachToFrame() was called. Bug: 1071863 Change-Id: I4e514118f6f6227b38a976a49185f46531934804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577934 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834537}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I5100597a1444b530b2f3fef58af7493499ba12de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556637 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#834536}
-
Fergal Daly authored
https://crbug.com/1146573#c31 involves a frame that where must_be_replaced() and IsRenderFrameLive() are both true. This shouldn't happen. This CL adds a DWOC and NOTREACHED to catch when this happens. The DWOC triggers off render_frame_created_ rather than IsRenderFrameLive since that also depends on the process state but regardless of the process state, these 2 should never be true and the CQ run indicates that we have no test cases where it is true. Also adding routing id and process id to be double-sure that we are talking about the same frames when we are looking at 2 different dumps from the same client. Bug: 1146573 Change-Id: Iec6d36e424673abd92f8fdc7fab94c203e912ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574119 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#834535}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1502e7972cb..3bf980426002 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie6a4a21b1a72d7777a76c546f6a96dcdf53bbbea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834534}
-
Leonid Baraz authored
Bug: 1078512 Change-Id: I8809b5c6b4a55f3440d20830e456cec8063f7190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578017 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Zach Trudo <zatrudo@google.com> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#834533}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3efbe10ffd42..3bf980426002 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7c06cf23d1ade8856c70f396198b6c7c55a369a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578198Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834532}
-
James Cook authored
Per discussions with product and legal, we want to continue to use a single metrics reporting / crash upload consent on Chrome OS, for both the OS and the lacros browser. Notes at go/lacros-crash-consent Per design doc at go/lacros-metrics-consent, the initial value is sent as part of LacrosInitParams, which is available early in lacros startup. Lacros then registers itself over mojo as an observer for future changes. The observer is fired immediately when added to avoid a possible race condition. Future CLs will implement: * lacros -> ash communication if the user disables metrics in browser settings * Better interactions with device vs. user policy controls Bug: 1148604, 1143851 Test: added to unit_tests and lacros_chrome_browsertests Change-Id: Ib6431d33acab6cb8d4e95584a7d95288dc52ea27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570045Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#834531}
-
kouhei authored
This CL adds a loading telemetry benchmark that measures performance of agents heavy web-sites, which the MBI team currently targets optimization. The added benchmark is for an internal team use, and not yet scheduled on the perf waterfall (thus UNSCHEDULED_ prefix). Bug: 1051790 Change-Id: I96b9305bc8200153fa8587de338824d56bc47459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576056Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#834530}
-
Sammie Quon authored
For all modes for either rotation/bounds change: - End current drag - Redraw capture session layer - Reposition capture label and capture bar Additionally for region: - Reset selection region if rotation changes - Clamp the selection region to root window bounds if size changes Also fixes a bug where the user can select a large region on a display, exit and then enter capture mode on a smaller display. This CL will ensure the initial region is clamped to size of the smaller display. Fixed: 1154465 Test: manual + added Change-Id: I4dde6b97af9532d08f7e53348d7a8a28c0c38714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568669 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#834529}
-
Mila Green authored
Bug: 1148839 Change-Id: I79e98003e07ad15fbdf507e03aecd8699ee9d826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569103Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834528}
-
Gabriel Charette authored
R=dmurph@chromium.org Bug: 1064645 Change-Id: I09c8e8fdf7a1555b6de5584d9b1d6ea04c273807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576631 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#834527}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607363880-e91185c7ee902dd489788046475ba4c3a284e8fb.profdata to chrome-mac-master-1607385573-20176c861cfdd390234dbdfc41d000ee505c292a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6aaa4d8354f3907de9dc0522ed5bd2d9dbd51a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577950Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834526}
-
Curt Clemens authored
Some error states are best resolved by trying again, so add that message to those error strings. On error, replace the white "Cancel" button with a blue "Close" button to help indicate that the process is finished and closing the dialog is the only way forward. Also update the info string on the discovery page. Bug: 1148581 Change-Id: Id8070de2fdc59a56a7d83d2196bc288452e558b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570337 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#834525}
-
Hirokazu Honda authored
This adds av1 10 bit streams decoding support to VaapiVideoDecoder. Bug: b:172223934, b:172217032 Test: video_decode_accelerator_tests --use_vd bear-320x180-10bit.av1.ivf Change-Id: I1c50516dba300fbe5e4b1056e931fb7da7264ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563183 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
David Staessens <dstaessens@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#834524}
-
Zhaoyang Li authored
The experiment has ended. Removing ios-simulator-code-coverage, ios-simulator-coverage-exp and ios-simulator-full-configs-coverage-exp from try builder list. chromium/tools/build: crrev/c/2578177 Bug: 1090188 Change-Id: I2c6c0a96bbb76c18afa58a5d853e3c09fbbd80a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577626Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#834523}
-
Yaron Friedman authored
Stopped when I hit TabObserver but this covers most of the clients BUG=783819 Change-Id: I499c6105c7c64f09d65bc07436cdb7c2112e7dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572244Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#834522}
-