GitLab

Also sprinkle in some OVERRIDEs.  It's not strictly necessary in this
case since it's a pure virtual method, but it doesn't hurt and may help
for future refactorings.

BUG=23581


Review URL: http://codereview.chromium.org/7461136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91734
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/7585019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95662 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95661 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses leaks introduced with r95607 related to BrowsingDataQuotaHelper.  More suppressions.

BUG=91836
TEST=Valgrind and HeapCheck bots turn green.
TBR=tzik@chromium.org

Review URL: http://codereview.chromium.org/7585018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95660 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/7541050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95659 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95658 0039d316-1c4b-4281-b951-d872f2087c98

984:
Avoid specifying multiple conditional entries when the value is the same for all
configurations.

985:
mac/make: Use libtool -static instead of ar crs to create static libraries. Faster.

BUG=none
TEST=none
TBR=evan

Review URL: http://codereview.chromium.org/7491064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95657 0039d316-1c4b-4281-b951-d872f2087c98

The Remoting Host plugin is built for Linux but not ChromeOS.  This is a
temporary fix until we can update the stage_build script to deal with this
missing file on official ChromeOS build.

This is a partial revert of r95103.

BUG=91549
TEST=Official ChromeOS build (staging) no longer fails.

Review URL: http://codereview.chromium.org/7589001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18740
TEST=Add "--skip-oauth-login" in command line and focusing on user pod should stay, i.e. no auto switching to Gaia.

Review URL: http://codereview.chromium.org/7583010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95653 0039d316-1c4b-4281-b951-d872f2087c98

R=rvargas@chromium.org
Review URL: http://codereview.chromium.org/7491061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95652 0039d316-1c4b-4281-b951-d872f2087c98

R=rvargas@chromium.org
Review URL: http://codereview.chromium.org/7550038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95651 0039d316-1c4b-4281-b951-d872f2087c98

This brings back the arrow-tip infobar, but it is fixed-with and will not grow
all the way to the omnibox decoration if the bookmark bar is open.

XIB changes:
* Make the animatable view and gradient view 48px tall.
* Move the text view up 1 px.

BUG=76381
TEST=Look at infobars.

Review URL: http://codereview.chromium.org/7461134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95649 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses leaks introduced with r95572 related to BrowserAccessibilityManager.

BUG=91845
TEST=Valgrind and HeapCheck bots turn green.
TBR=dtseng@chromium.org

Review URL: http://codereview.chromium.org/7541048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95645 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 18937a8c9073784b527527c7d7506ae12a248964.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95644 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95643 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses leaks introduced with r95607 related to BrowsingDataQuotaHelper.

BUG=91836
TEST=Valgrind and HeapCheck bots turn green.
TBR=tzik@chromium.org

Review URL: http://codereview.chromium.org/7585014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95642 0039d316-1c4b-4281-b951-d872f2087c98

- don't allow un-uninstallable apps to be trashed
- fade effect when dragging over trash

BUG=90894
TEST=manual

Review URL: http://codereview.chromium.org/7572041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95640 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91843
Review URL: http://codereview.chromium.org/7584009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95639 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7550026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95638 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppressions for leaks introduced with r95607.  Reordering suppressions.

BUG=91816
TEST=Valgrind and HeapCheck bots turn green.
TBR=tzik@chromium.org

Review URL: http://codereview.chromium.org/7582013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95636 0039d316-1c4b-4281-b951-d872f2087c98

If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current.

BUG=90140
TEST=repeatedly select items in an open file dialog in column mode; no crash

Review URL: http://codereview.chromium.org/7572031

TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/7541043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95631 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95629 0039d316-1c4b-4281-b951-d872f2087c98

Note: This was a TODO for tc.

BUG=None
TEST=None

R=tony@chromium.org

Review URL: http://codereview.chromium.org/7585001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95628 0039d316-1c4b-4281-b951-d872f2087c98

R=agl@chromium.org
BUG=91458
TEST=none

Review URL: http://codereview.chromium.org/7572043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95627 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Manually on chromebook


Review URL: http://codereview.chromium.org/7569006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95626 0039d316-1c4b-4281-b951-d872f2087c98

It makes the refresh button on the file manager working in intuitive manner. Also now it's possible to set a bookmark to a specific directory or enter directory path in the omnibox.

BUG=chromium-os:17787
TEST=None


Review URL: http://codereview.chromium.org/7584004

TBR=serya@chromium.org
Review URL: http://codereview.chromium.org/7550035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95625 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppressions for leaks introduced with r95607.

BUG=91816
TEST=Valgrind and HeapCheck bots turn green.

Review URL: http://codereview.chromium.org/7491060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95624 0039d316-1c4b-4281-b951-d872f2087c98

Move actual tests out of chrome/tests,
closer to code being tested.

Remove empty directory.

BUG=90905
Review URL: http://codereview.chromium.org/7576018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95623 0039d316-1c4b-4281-b951-d872f2087c98

This is a fix needed for experiments with using unpatched sqlite.

BUG=22208

Review URL: http://codereview.chromium.org/7575027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95622 0039d316-1c4b-4281-b951-d872f2087c98

It makes the refresh button on the file manager working in intuitive manner. Also now it's possible to set a bookmark to a specific directory or enter directory path in the omnibox.

BUG=chromium-os:17787
TEST=None


Review URL: http://codereview.chromium.org/7584004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95621 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7464040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95620 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rvargas@chromium.org
Review URL: http://codereview.chromium.org/7582007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95619 0039d316-1c4b-4281-b951-d872f2087c98

R=rvargas
Review URL: http://codereview.chromium.org/7461141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7491059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95617 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95616 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7541041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95614 0039d316-1c4b-4281-b951-d872f2087c98

If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current.

BUG=90140
TEST=repeatedly select items in an open file dialog in column mode; no crash

Review URL: http://codereview.chromium.org/7572031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95611 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eroman

BUG=91799
TEST=NetInternalsTest.NetInternalsPrerenderView
Review URL: http://codereview.chromium.org/7491058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95610 0039d316-1c4b-4281-b951-d872f2087c98

This replaces a lot of custom code with an implementation that reuses the
architecture of the menubar Bookmarks menu.

This CL introduces two minor regressions (bugs pending):
* Hover state is lost after menu is opened. Mousing out/back over fixes.
* The off-the-side menu contains all items from the bookmark bar.

BUG=78151
TEST=Click on a bookmark folder button. A menu opens.

Review URL: http://codereview.chromium.org/7465090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95609 0039d316-1c4b-4281-b951-d872f2087c98