- 18 Jul, 2019 40 commits
-
-
Kent Tamura authored
For many keywords, this CL just apply blink::Deprecation to existing counters. Exceptions: * Split ButtonForOthers into three - ButtonForBootstrapLooseSelector - ButtonForSelect - ButtonForOthers2 and deprecate the second one. * Add ListboxForOthers and MeterForOthers counters, and deprecate them. They are capped by kCSSValueAppearanceNoImplementationSkipBorder Approved intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/1d9FpHEVI64/VSELVHzbAQAJ Bug: 981720 Change-Id: Iec89d2bce70d2d86fd4630fb35d34798aac72af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705274Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#678588}
-
Michael Lippautz authored
This reverts commit 9f60900b. Reason for revert: Likely breaks webgl2_conformance_tests. Bug: 985185 Original change's description: > heap: Enable concurrent sweeping > > Bug: 967258 > Change-Id: I322882558aed37154f2cb2ff655b11c8337b10a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702265 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678406} TBR=haraken@chromium.org,mlippautz@chromium.org,bikineev@chromium.org Change-Id: Iac25b3bd59ac3561b98576a463959f8e1726e7d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 967258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707350Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#678587}
-
Yang Guo authored
R=luoe@chromium.org Bug: chromium:973782 Change-Id: I233a4c8d971396247c9a4391f399eaf0ad1f662b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702268 Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#678586}
-
Kunihiko Sakamoto authored
This fixes a bug where set_disconnect_handler() was called on invalid PendingReceiver. Now the parser is created using BundledExchangesParserFactory. TBR=rsesek@chromium.org Bug: 984918,984950,984980,984991,985159,985191 Change-Id: I7d628a084291077186d42fa7191255429d9c190c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707950 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#678585}
-
Takuto Ikuta authored
This reverts commit b97111cd. Reason for revert: culprit for https://ci.chromium.org/p/chromium/builders/try/linux-rel/144771 Original change's description: > [Code health] Explictly add include_rules in cc/paint/DEPS > > Right now the include rules for cc/paint is written in BUILD.gn, this CL > write it in DEPS file to make it more clear. This CL should not cause > any behavior change. > > Bug: None > Change-Id: I6654d784fa135cc8e397f852388b6c2cbbd1cad1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707251 > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678510} TBR=danakj@chromium.org,khushalsagar@chromium.org,xidachen@chromium.org Change-Id: Id83217c14cd1651728ef7d21fbdaabc128e54a41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707811Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#678584}
-
Paul Dyson authored
Top Cat requires more features to be passed through to the training/logging method. This allows the Train methods to receive that data. Bug: 899123 Change-Id: I3a92f54a80e98e9e233350eebc80594b95668155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697062Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#678583}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/48d10febadb0..9f5c4c13d2b1 git log 48d10febadb0..9f5c4c13d2b1 --date=short --no-merges --format='%ad %ae %s' 2019-07-18 chrome-bot@chromium.org Update config settings by config-updater. 2019-07-18 saklein@chromium.org unittests: Fix tests to run outside the chroot. Created with: gclient setdep -r src/third_party/chromite@9f5c4c13d2b1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ieb6fd3e8356b20af7f07b958b9c09e5f1cf0c7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707924Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678582}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ff62841deff..66e7c10c0ea9 Created with: gclient setdep -r src-internal@66e7c10c0ea9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=pdr@google.com,grt@google.com Change-Id: Ibf7305e34bc9011eaf53170a0b5cc596f30bad07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707923Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678581}
-
Eric Willigers authored
LaunchService is a keyed service that handles launching of both BMO web applications and extension-based applications. Note that the Launch Service is intended to merge later into the App Service. See `//chrome/services/app_service/README.md` Bug: 966288 Change-Id: I68e66ff5996cdae00fa01b57d73e76f39a58b5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695421Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#678580}
-
Yoichi Osato authored
This patch decreases logging level so that `content_shell.exe --enable-logging --single-process --use-angle=gl` doesn't always print the error message 20ish times at the start. You can still print the message with `--enable-logging --vmodule=memory*=2` option. Change-Id: Icb4c672fc1c149218c12a49b2d1eccbb11d9230d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692701Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#678579}
-
Yue Li authored
This cl migrates kAssistantDisabledByPolicy preference from assistant_pref_util.h to assistant_prefs.h Also, removes the file assistant_pref_util.h and updates related tests. Detailed design doc: https://goto.google.com/assistant-prefs Bug: b/110211045 Test: Run existing tests Change-Id: Id41932cc6aeb9dc9ac5926dd764ca8c468412341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705109 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#678578}
-
Takashi Toyoshima authored
DataPipeProducer could take a DataPipeProducer::Observer instance to monitor any read operations. But this feature can be delegated into a specialized DataSource implementation. This patch introduces FilteredDataSource for such purpose. It can takes any other DataSource instance to handle read operations, and takes an FilteredDataSource::Filter instance to monitor and to modify read operations. Currently, FileURLLoader{Factory} is only the call site, and probably it can be much more simplified if it utilizes the FilteredDataSource possibility. But this change just keeps the original design and make changes as small as possible. Bug: 983023 Change-Id: I11df8be4da26c44b0caf5867fc21ecae57f850d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699801 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#678577}
-
Yuwei Huang authored
FtlSignalStrategy deletes underlying messaging client and other members with a 5-second delay to allow session-terminate message to be sent after deleting the signal strategy. The current implementation doesn't work well at shutdown. When the sequence itself is being deleted, all pending tasks will be deleted on an arbitrary thread. This will cause a race condition in gRPC executor since it tries to delete unique_ptrs bound into the closure. Unlike CL 1692736 This CL provides a different way to solve this issue. Currently only mobile clients use short-lived FtlSignalStrategy, so this CL moves the delay destruction logic into ChromotingSession. Mobile clients don't do any cleanup at shutdown, so they won't experience crash at shutdown even if the app gets killed right after a session is terminated. ChromeOS enterprise IT2ME host still has a risk of session-terminate not being sent at shutdown, but this is probably fine since the host can't initiate a session termination (i.e. no disconnect window) AFAIK. Bug: 979398 Change-Id: Ie12f48257e6f9c59391a7ed15224987ffdc879ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707592 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#678576}
-
Sergei Datsenko authored
Bug: 948446 Change-Id: Iea4d98b54b20960126f96d17ba8cfa34562f902c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707134 Auto-Submit: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#678575}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0efe516eeaef..e9111885702e git log 0efe516eeaef..e9111885702e --date=short --no-merges --format='%ad %ae %s' 2019-07-18 syoussefi@chromium.org Vulkan: Optimize texture upload barriers Created with: gclient setdep -r src/third_party/angle@e9111885702e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: Ibc832a1e4d0a16fd85754c600188b97a8a2f1172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708055Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fcf3a87cedf4..42343b820c37 git log fcf3a87cedf4..42343b820c37 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5f1aeb93..59bca7b0 (678364:678465) Created with: gclient setdep -r src/third_party/webrtc@42343b820c37 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id9ae24098bd44132b8a2786d4ce7e51bcc715539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708053Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/68185ac0410b..48d10febadb0 git log 68185ac0410b..48d10febadb0 --date=short --no-merges --format='%ad %ae %s' 2019-07-18 chrome-bot@chromium.org Update config settings by config-updater. 2019-07-18 eashanbhatt@google.com cros_test_unittest: Clean Up Parser Tests 2019-07-18 vapier@chromium.org gerrit: include general CL status when displaying Created with: gclient setdep -r src/third_party/chromite@48d10febadb0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Idb1684340f28d1b67355e4cf77774d1aee06cba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708052Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Mojo JS Lite Bindings were recently renamed to align with the new C++ names. This CL changes usage of the old names with the new ones. See bug for more details. Bug: 968369 Change-Id: I7ffbbf85e508fc81fc93b8f21a95e35f27699375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705831Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/49b659419343..1ff62841deff Created with: gclient setdep -r src-internal@1ff62841deff The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=pdr@google.com,grt@google.com Change-Id: I6a0a2f9683566fe435563598e03d9566abfc048e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708054Reviewed-by:
-
Andrew Grieve authored
I was hoping this would remove NativeLibraries.getTestRunnerClassNameForTesting() but it doesn't look like it does :(. Still - this way of creating the file brings it in line with how we create R.java and BuildConfig.java. Bug: 984573 Change-Id: Iebeaa9970ac9c47ea13f81f05b71d5ccb5247205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704315 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678569}
-
Jinsuk Kim authored
BottomSheet animation from hidden to peek state was not working due to multiple calls to set the sheet state cancelling the previous one that enables animation. This CL adds a few more checks to make the subsequent calls no-op if we're already in the requested state or in the middle of animation toward the state. Bug: 937946 Change-Id: I48f3e2ca20746bc1f976ce58de774276cb227998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701131 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#678568}
-
Miyoung Shin authored
This is a reland of 1b39b8b1 Original change's description: > Rename traits and mojo directory in //components/autofill/ > > This CL renames interfaces to mojom and *_struct_traits.* > to *_mojom_traits.* in //components/autofill/. > > *_struct_traits.* => *_mojom_traits.* > components/autofill/content/common/ => components/autofill/content/common/mojom > > Bug: 806965 > Change-Id: Ie24626259372bacf83399c48f2c1fadbef66aabc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703477 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678167} Bug: 806965 Change-Id: I0f6e5a33d7963d5384066a88367744eb385fe742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705914 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#678567}
-
Donna Wu authored
This CL uses mojo type UsbDeviceInfo in UsbDevice instead of the custom type UsbConfigDescriptor and adjusted related code. TBR=thestig@chromium.org Bug: 716557, 699790 Change-Id: Ibade21adacc1c12fbebedad8271ea162bc6ef0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703473 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678566}
-
Jacques Newman authored
This was causing a build break for ARM64 windows jumbo builds. windowsx.h defines GetFirstChild as GetTopWindow. I think it makes sense to add an undef to GetFirstChild here. Bug: 984909 Change-Id: I63f92f8e7a14e92db64e49cb5e84fb2850c44b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704990 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#678565}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I0161bcd469d04a0ec2fe5c412c8ef58664540b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707835Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#678564}
-
Andrew Grieve authored
* extra_chrome_shared_library_deps * extra_chrome_shared_library_configs These were used for orderfiles, but this logic has now been upstreamed. Change-Id: I816fd48db22a2fecad2036f46c80bd5055a8b883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704384Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#678563}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/74426f7570fd..9f2236e58ed0 git log 74426f7570fd..9f2236e58ed0 --date=short --no-merges --format='%ad %ae %s' 2019-07-18 cepheus@frii.com Build: shut up warning to add unnecessary parens. Created with: gclient setdep -r src/third_party/glslang/src@9f2236e58ed0 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,geofflang@chromium.org Change-Id: I4285ef17b4671ce6c81f1da64d4b853a9bd56289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708048Reviewed-by:
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/58ac6508f78f..13750a860a35 $ git log 58ac6508f..13750a860 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 bnc Implement blocked decoding in qpack_offline_decoder. 2019-07-17 bnc Move PRIORITY frame constants into http_frames.h. 2019-07-17 dschinazi Update QUIC transport parameters for draft-22 2019-07-17 wub gfe-relnote: Allow client to enable QUIC bbr2 congestion control on server. Protected by --gfe2_reloadable_flag_quic_allow_client_enabled_bbr_v2. 2019-07-17 dschinazi Update QUIC TLS salt for draft-22 2019-07-17 fayang Automated g4 rollback of changelist 257008406. 2019-07-17 bnc Add http3_constants.h for HTTP/3 and QPACK unidirectional stream types and settings identifiers. 2019-07-17 renjietang Move priority frame's exclusive bit from bit #7 to bit #4. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I833c72f77e98738733de80cdc01d64a1ea611333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707490 Auto-Submit: Bence Béky <bnc@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#678561}
-
pliard authored
Previously devices would only be visible in ARCVM after a USB connect event which didn't allow already connected devices to be visible on startup without disconnecting and reconnecting them again. Bug: b:123374026 Test: unit_tests --gtest_filter='*CrosUsbDetector*' Test: Login with USB device already connected and run lsusb in Android Change-Id: Ifc4e708f9244fb7e2fae06f2086232a282f9d8e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686930 Commit-Queue: Philippe Liard <pliard@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#678560}
-
Khushal authored
The OverlayProcessor removes damage from the overlay from the total damage on the main plane to avoid unnecessary updates to the main plane when all damage in a frame is completely consumed by the overlay. The damage needs to be in the space in which the OutputSurface does its rendering, which includes the display transform. However, since the OverlayCandidateValidator removes this transform prior to damage tracking, we were not subtracting correct damage from the overlay in step. R=ericrk@chromium.org Bug: 983310 Change-Id: I74058810d8375b9350058da15d7d90787ee1802d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707310 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#678559}
-
Sam Goto authored
In the current architecture, SmsService is owned by SmsKeyedService which is owned by Profiles. SmsReceiverImpl is owned by SmsServiceImpl and the StrongBindingSet, which has no connection (from a memory perspective), to RenderFrameHosts. There are no guarantees that the mojo clients are going to outlive the RenderFrameHosts, so we run into possible cases where SmsReceiverImpl is handling requests after the RenderFrameHost was destructed (@see bugs). To address this problem, and make the architecture consistent with other comparable features, this cl makes the SmsService a subclass of FrameServiceBase, which is responsible for managing its lifecycle and memory based on events dispatched by the lifecycle of the RenderFrameHost. We keep the SmsProvider owned by the BrowserMainLoop, which is effectively a singleton. To facilitate BrowserTest testing, we expose a BrowserMainLoop::SetSmsProviderForTesting static method. Design Doc: https://docs.google.com/document/d/1dB5UM9x8Ap2-bs6Xn0KnbC_B1KNLIUv4W05MunuXYh0/edit# Bug: 979265,982370,979418 Change-Id: Ic2b0a9b35fa1f5a3e28c84d77d78c22d41b09ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691683Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
-
Tarun Bansal authored
Treat WiFi connection same as 4G when computing the ECT. Change-Id: I5d1ed46227b1d19b50a30996b2e3e8a551b82b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706871Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#678557}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/34f3be0173a3..f8c5b19aa40a git log 34f3be0173a3..f8c5b19aa40a --date=short --no-merges --format='%ad %ae %s' 2019-07-17 achuith@chromium.org Disable testCommandLineOverriding on cros guest browser. Created with: gclient setdep -r src/third_party/catapult@f8c5b19aa40a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:985125 TBR=sadrul@google.com Change-Id: I099b4918298dac0d5790db859037aa0d81c04353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707256Reviewed-by:
-
Regan Hsu authored
Change-Id: Ida5a4a12042d2b8845294f8630d951b99b45c6bc Bug: 968182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695692 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#678555}
-
Kristi Park authored
Increase height to prevent fakebox placeholder text from being chopped when min font size is increased. Screenshot: http://screen/cxX7edHXjpO.png Bug: 983036 Change-Id: I6e2d5f6d2b1e4d98e0e71fa067426d3facc069ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707406 Commit-Queue: Kristi Park <kristipark@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#678554}
-
siyua authored
The flag is enabled only on Linux, Windows, Mac. Replace flag with a platform build config wherever it is needed. Bug: 905393 Change-Id: I55a23b3583a248680ba6bb87db28b0a0eb9cb4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702383Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#678553}
-
Matt Falkenhagen authored
These pass now that appcache on UI is supported, and other fixes. Bug: 824858, 824856 Change-Id: Iaaedd108065df68b28bc243bab078ee5a6b70c25 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707749 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b04e2561be34..fcf3a87cedf4 git log b04e2561be34..fcf3a87cedf4 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 magjed@webrtc.org Android: Expose setting custom visible fraction values for video layout Created with: gclient setdep -r src/third_party/webrtc@fcf3a87cedf4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I207e9991701520973f0defd26256a227c964dc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706400Reviewed-by:
-
vikassoni authored
1. Update 2 pixel video tests to use dimensions within the actual physical device limits. These tests were using the video player and test rectangle width which was overflowing the actual physical device width. Hence we were getting assert when taking a screenshot of the video and cropping it with the test rectangle because the test rectangle width was more than the screenshot width. 2. Update the color expectations for 4 tests accordingly. 3. Add viewport metadata for this page to scale correctly on mobile devices. 4.This CL fixes 2 tests on android - Pixel_Video_MP4_FourColors_Rot_90 and Pixel_Video_MP4_FourColors_Rot_270. Remove the test expectations from pixel_expectations.txt. 5. This CL updates 2 tests running on windows - Pixel_DirectComposition_Video_MP4_FourColors_Rot_90 and Pixel_DirectComposition_Video_MP4_FourColors_Rot_270. Bug: 925744 Change-Id: I3d15256675b538b6be5a4c8f5318c1949c0ab271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699145 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
liberato@chromium.org authored
Previously, CodecImageGroup forwarded image destruction to any interested parties. MaybeRenderEarlyManager used this to know when to try early rendering. However, with image pooling, early rendering isn't always caused by image destruction; the same image can be reused. This CL adds a NowUnusedCB to CodecImage that is called when the CodecImage won't be used for display anymore. Early rendering uses this signal, rather than destruction, to check for rendering. Also, it removes the image from the CodecImageGroup once it's unused, since the image no longer depends on the output surface. Note that the CodecImageGroup still uses CodecImage destruction to keep track of images; it's not necessary to remove them from the group like MaybeRenderEarlyManager does. This guarantees that the CodecImageGroup will track images properly, even if the MaybeRenderEarlyManager is destroyed first. This can happen if, for example, the decoder is destroyed while VideoFrames are outstanding. Also note that the NowUnusedCB is only called during image destruction right now. A future CL will allow it to be triggered at other times. Change-Id: Id26e6eb11e178586fac17ead0a585ed6bbfef854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707190Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#678549}
-
