- 18 Feb, 2020 40 commits
-
-
Vikas Soni authored
A CL has been landed to fix software decode video path on vulkan - https://chromium-review.googlesource.com/c/chromium/src/+/2045130. So enabling the media tests now which are passing on pixel2 skia vulkan bot. TBR=ynovikov@chromium.org Bug: 985387 Change-Id: Iac61d31ccb12e35586e238e6c7780011385d86e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057540Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#742305}
-
Long Cheng authored
Adding default page break too early will cause the default page break gets deleted immediately. Now move the installation of default page break after ChromeOS settings app is installed. Bug: 1031410 Test: Manual Change-Id: If8d6522993518ccc109ac0bf368cdd077a97f301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056578Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#742304}
-
Brandon Wylie authored
When returning to the NTP after native is initialized, the native init observer registration has no effect. This adds a check to for this and triggers the colorful mic behavior immediately if native is already initialized. Bug: 1052073 Change-Id: I229ddebb16ddeb418219275874552e54fb64646e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055389 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#742303}
-
Nina Satragno authored
This patch allows users to try again when an authenticator with internal user verification reports a failure to read their biometrics on GetAssertion requests. Summary of changes: * Rename pin::RetriesRequest to pin::PinRetriesRequest and add pin::UvRetriesRequest. * Have GetAssertionRequestHandler handle CTAP2_ERR_INVALID_PIN, get uv retries, and signal to the dialog that the user needs to retry. * Add a sheet with a new fingerprint icon asking the user to try again and informing them of the number of retries. * Pull up the error label code from AuthenticatorClientPinEntrySheetView into AuthenticatorRequestSheetView and simplify it by having it be sent by a method on the model rather than a delegate callback. TBR'ing grt@ as per chrome/app/OWNERS Tbr: grt@chromium.org Bug: 1042779 Change-Id: I9d5db9da93a7119c3c2f3d005dbcc474045e586f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005369 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#742302}
-
Greg Thompson authored
This avoids an interesting bug in Windows as per the code comment. BUG=933975 R=brucedawson@chromium.org Change-Id: I11c18e9706520d1c52238914dfac87039b45138b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058815 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#742301}
-
Christopher Cameron authored
When the color conversion pass is added for the first time, ensure that there is full damage for the intermediate pass. If this is not performed, then there will be uninitialized sections of the screen. Similarly, add full damage when the color conversion pass is removed. This turns out not to be completely necessary, because DirectRenderer will call Reshape, and add full damage there. But there's no harm in adding the damage in SurfaceAggregator, and it is easier to follow. Add tests. Bug: 1037954 Change-Id: I8272034547d2744f3ebeabf854ca78770034163b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060661Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#742300}
-
Rahul Arakeri authored
Some tests in the virtual suite threaded-prefer-compositing will fail when the feature is turned on by default since they run with smooth scrolling enabled. The easy fix here would have been to simply add the arg "--disable-smooth-scrolling" to the test suite but that will not work since some tests under fast/scroll-behavior rely on smooth scroll being enabled. Additionally, disabling animated scrolling by using javascript only works on the main thread (see bug for more info) so that isn't an option either. This CL fixes the issue by allowing for adequate time to finish animating by using waitForAnimationEndTimeBased. Bug: 1038542 Change-Id: Ia5081a504cd99b3f10105f8ac20ad77ab966f063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986899 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742299}
-
Nektarios Paisios authored
Ensures that BrowserAccessibilityManager and its subclasses stop observing changes to AXTree upon destruction Inspired by the seemingly unnecessary need to clear all observers in the AXTree's destructor that I noticed while reviewing https://crrev.com/a37b994a406b8a900f60a0b2314d50c932411297 This patch ensures that: 1. BrowserAccessibilityManager and its subclasses stop observing all tree changes upon their destruction. 2. Subclasses of BrowserAccessibilityManager are disallowed from replacing the observed AXTree or its associated AXEventGenerator. R=aleventhal@chromium.org, dmazzoni@chromium.org Change-Id: Ib76612f4fabc095db942756bd876e9bc8da077d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058003 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#742298}
-
Toni Barzic authored
This fixes TabletModeTransitionHistogramsSnappedWindows test with kHideShelfControlsInTabletMode enabled. The test verifies that snapped windows do not animate when transitioning in and out of tablet mode. The bounds animation was getting prevented using WindowState::ScopedBoundsChangeAnimation in TabletModeWindowState::LeaveTabletMode(), though the bounds animation override was not being taken into account when updating bounds due to display work area changes (which becomes relevant if display work area when leaving tablet mode is different from display works area when entering tablet mode). What changes with the kHideShelfConrtolsInTabletMode feature enabled is the timing of work area (shelf size) changes when entering tablet mode - change in the shelf button visibility causes the shelf config update when entering/exiting tablet mode, which was not previously being triggered for the display bounds in the test (though, it probably should, as the actual shelf bounds do change during tablet mode transition). When entering tablet mode, shelf config is updated during OnTabletModeStarting, which happens before tablet mode window state gets detached for tablet mode transition, and thus, it won't match the display work area when tablet mode exits. This means that on tablet mode exit DefaultState::AttachState will detect display work area change, and send the associated VMEvent to the test window state, which will update the bounds with animation. (With the feature disabled, work area changes happen after test window's tablet mode state is set up, so display work areas when normal window state is attached and detached match, avoiding extra bounds update). Note that this happens only if one of the display dimensions is < 600 dip (i.e. not in general case, where work area gets updated in OnTabletModeStarting due to a shelf config update). Fix this by respecting the IMMEDIATE bounds change animation override when animating window bounds for display metrics changes. BUG=1051714 Change-Id: I88454f79bd88e06ab47677336b59650dac5a5864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057866 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742297}
-
Avi Drissman authored
BUG=1023913 Change-Id: I6c581846479edd6f7938ab039bef38f3c38eb251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036492Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742296}
-
Anders Hartvoll Ruud authored
This CL rewrites @support parsing, with a more obvious one-to-one correspondence with the productions listed in the spec. This is because I want to try to add support for the "unknown" value logic [1], in which e.g. "not unknown(1)" becomes "false", and not "true" like it does today. In order to do that, the parser need to return two results so I can use-count when they differ: one which treats "unknown" as false (like we do today), and one which treats it as "unknown" until the top-level (i.e. per spec). [1] https://drafts.csswg.org/mediaqueries-4/#typedef-general-enclosed See note on Kleene 3-valued logic. Change-Id: I709805a303495ee3b3d41c25c914d2ac8496ce8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054143 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#742295}
-
Mike Frysinger authored
Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: Idf9c94a82e9bcd692b80b280295893c169281313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045334Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#742294}
-
Sean Gilhuly authored
Most of the functions in ContextFactoryPrivate are keyed on ui::Compositor* to modify something for a specific display compositor. The implementation forwards these calls to the corresponding viz::mojom::DisplayPrivate. Instead, give Compositor a pointer to the DisplayPrivate and make the calls directly. Make VizProcessTransportFactory a ContextFactoryPrivate implementation so that HostContextFactoryPrivate can be deleted. For InProcessTransportFactory, move these calls into the PerCompositorData object, which implements DisplayPrivate. Bug: 1042259 Change-Id: I64f93e2024e2db74bd04da0ff4e4a2f7c82409d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050892 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#742293}
-
Rahul Arakeri authored
Root cause for the test failure was fixed in: https://crrev.com/c/1865529 Change-Id: I513c8948803be3e432a4331920e5454b717f9ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059048Reviewed-by:
-
David Van Cleve authored
This CL adds boilerplate for initializing a Trust Tokens store in the network service. The control flow is almost exactly the same as that for initializing a cookie store: if NetworkContext gets a path in its params, it constructs a disk-backed store; if it doesn't, it constructs a store in memory. by the 50K per engineer-week rule of thumb, not be cost-effective to refactor away. The remainder is split quite widely among methods with a median cost of perhaps 400 bytes each. I looked at the optimization advice in the docs and did not find that a substantial amount of the binary size increase corresponded obviously to any of the main patterns mentioned in the docs. Binary-Size: Out of the 18.5K increase, 5K is proto files which would, Bug: 1042962 Change-Id: I3fe48d9cad1b36bb9424b5d2f1d50b5942e407df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044651Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#742291}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2883de942283..8def9063c4fd git log 2883de942283..8def9063c4fd --date=short --first-parent --format='%ad %ae %s' 2020-02-18 cwallez@chromium.org Only call updateBorders on ranges that can be cubemaps. Created with: gclient setdep -r src/third_party/swiftshader@8def9063c4fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ibb598cd9bec0d32f7946c37ab908e2a016d4fe58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062728Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742290}
-
Lijin Shen authored
Clean up feature flag of tab switcher long-press menu. Bug: 1046558 Change-Id: Iad0f443caf2c4e3dbc29f2eb30f608e50496dc21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057757Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742289}
-
Toni Barzic authored
Make sure that home screen is not visible while split view is active (similar to overview mode), to prevent home UI flashing behind split view when one side transitions to/from overview. BUG=1052502 Change-Id: Iffd215143463b41f1c4079b7ac0c7cf148f1fad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060665Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742288}
-
Friedrich Horschig authored
The address filling study was removed in favor of directly setting the respective parameters in a multi-arm experiment. This change should therefore not have any effect at all. Bug: None Change-Id: I9536bae8441032285f6103749b6c62ff0603b702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056803 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#742287}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d247eaa8..f3d47a2e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9717a2733db2d51b0d9201c678bf1e552ddc2348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063068Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742286}
-
Peter Beverloo authored
Bug: 1052988, 1052989, 1053113 Change-Id: I95827164f73158e7cd3cff3ac2ef338a58a4d2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062330 Auto-Submit: Peter Beverloo <peter@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Meilin Wang authored
This CL adds a new flag in chrome://flags to enable/disable the Ambient Mode feature. Bug: b/149244227 Test: manually. Change-Id: I7f07020db81fc61962bbe923c62ce1837634d94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053037 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742284}
-
Sam Bowen authored
This is a reland of 38b34519 There are no changes in this reland. The fix is in: https://crrev.com/i/2566200/3 This is part of a 2-sided patch which will be submitted just before the above change. Original change's description: > Move entity and property mojo types to //components. > > We will use these types from both blink and //content and from code > inside //components. > > This patch affects Clank downstream and will be submitted together with > a patch in that repo to avoid breakage. Clank CL: > https://crrev.com/i/2545991 > > See discussion in design doc: > https://docs.google.com/document/d/1ZA-1EMq4d40K5qfsZoeMIhJmZA6-AXaSibD3SsqZjfU/edit# > > Bug: 1044252 > Change-Id: Id658caa422bedbcb6d2275a8ccdd76f73bf955c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051363 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Sam Bowen <sgbowen@google.com> > Cr-Commit-Position: refs/heads/master@{#741227} TBR=beccahughes@google.com,haraken@chromium.org Bug: 1044252 Change-Id: Ib37ff0cfa3913fa1c7c4dc7a956c8efff04b0b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057740 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#742283}
-
Rouslan Solomakhin authored
Before this patch, payment app class name was called "instrument". This patch renames PaymentInstrument.java into PaymentApp.java in accordance with https://bit.ly/cross-platform-pay-app-factory. The old PaymentAppFactory.java is no longer used anywhere and is removed. The PaymentInstrument.java file is an empty subclass of PaymentApp.java for temporary backward compatibility. The Java integration tests have been updated to install mock payment apps via PaymentAppService.java instead of PaymentAppFactory.java. The mock payment app factory now takes care of filtering mock apps by payment method name and calculating the answer to canMakePayment(). To avoid confusion, test app constants such as HAVE_INSTRUMENTS and DELAYED RESPONSE have been renamed and converted into Android style enums, which helps avoid mistakes by checking parameter types at compile time. After this patch, payment app class name is called "app". Bug: 1022512, 769851 Change-Id: I3f35693fb4f77eee205f3c8ca08b8f6ffe23248d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050784 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#742282}
-
Maggie Chen authored
The crash reports show that the third party software (the Vulkan loader and the Vulkan driver) crashes during vkDestroyInstance() or UnloadNativeLibrary(vulkan_library). To work around it, don't explicitly unload the DLL. Instead, GPU process shutdown will unload all loaded DLLs. Bug: 1047440,1048373 Change-Id: I58483fd373396cdec7344bb82e38056ca51340be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056890 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#742281}
-
John Abd-El-Malek authored
Change-Id: Icd7b96a48049116d9738fd826892c589ce467f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053088 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#742280}
-
Alex Cooper authored
Updates goldens for several VR tests which seem to have changed from displaying the full URL to just the origin recently. TBR=bsheedy@chromium.org Change-Id: I705e222e4fc3ec579785eed3f5329d6c9103b27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062753Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#742279}
-
danakj authored
R=avi@chromium.org Change-Id: I38f495d81f028a4a4afefd2cc7f8b718a3bbd68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062795Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#742278}
-
Demetrios Papadopoulos authored
Bug: 1026426 Change-Id: I9ec2b7e60d2aa1f86907e5535e3ace1d82431932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056566 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#742277}
-
Miguel Casas authored
Add a note that assert(is_linux) includes is_chromeos and also remove an if(is_linux) since it's implied. The other mod is due to presubmit. No new functionality intended, just cosmetic changes. Bug: 1006266 Change-Id: Ib18350bf595678a28372f120b9f27e6c79943233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062873 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#742276}
-
Dave Tapuska authored
Address post review comments from danakj after https://chromium-review.googlesource.com/c/chromium/src/+/2044764 was submitted. BUG=1046424 Change-Id: I8331fceb29ff12d2ec9eda28df9f8b147811de27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062758Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3c4a9d347da1..2e941d00c837 git log 3c4a9d347da1..2e941d00c837 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 fmalita@chromium.org [skottie] Store scalar keyframe values inline Created with: gclient setdep -r src/third_party/skia@2e941d00c837 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I88bc5a162db5a1aa53f23499dd2caaf602e88b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062768Reviewed-by:
-
Michael Sun authored
Stop displaying the dialog window when user initiated connection failed. If the device status changing from "Not Connect" to "Connecting" and then to "Not Connected", it is very clear to the user that previously initiated connection was not succeeded. Displaying a pop-up dialog showing connection failed is disturbing and unnecessary since a failure notification is shown. BUG=b/147671276 Change-Id: I2a27ea6c14225dd8cd0249559dda3228d1ec0f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031600 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#742273}
-
Michael Sun authored
Chrome OS Bluetooth stack generated KEY_PLAYCD for media control versus keyboards use KEY_PLAY. Modify Bluetooth specific key into existing keyboard's one. BUG=b/147366099 Change-Id: I9cb060a1942a71ab16d40095a4e7fe7a542149df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031999Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#742272}
-
Mia Glaese authored
Change-Id: Id8a6ff85d690d406feb46310d0e3a1925564e965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036361Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#742271}
-
Xing Liu authored
When resuming a download, the suggested path can be content URI. This will hit a DCHECK in CreateReservation. Bug: 1045642 Change-Id: I61c452afafbbc9606f747c84ff18e6b9dc9a0fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062759Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742270}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ef17447d64b..01663f71bc87 Created with: gclient setdep -r src-internal@01663f71bc87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1052560 Tbr: jbudorick@google.com Change-Id: I6ca06f08d187d7f6adb49de1011e3a794a5efdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062730Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742269}
-
Gil Dekel authored
This CL sets the cursor to remain visible during and after the privacy screen is toggled via the keyboard key. Bug: b:147451643 Change-Id: Idb9bf7332d3fea48d015e4acee1d6652f54df754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063108Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742268}
-
Michael Sun authored
- Provide DOM |code| mapping for MediaPause, now that it has a distinct evdev code from Pause. - Map DOM |code| MediaPause to DOM |key| MediaPause in the US English layout data. - Map DOM |key| MediaPlay and MediaPause to custom VKEY values in POSIX builds, so that Chrome can handle them as accelerators. BUG=b/148560217 Change-Id: Ifad05827d91df74b5f0ef8e60ff8eb125716f0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029291 Auto-Submit: Michael Sun <michaelfsun@google.com> Commit-Queue: Michael Sun <michaelfsun@google.com> Reviewed-by:
-
Sebastien Marchand authored
Bug: 1030399 Change-Id: Iae8a083d00e95c4214e360303f30bd2d7dea45e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056107 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#742266}
-
