- 16 Jun, 2020 40 commits
-
-
Haiyang Pan authored
This is to help debug the timeout issue as tracked in crbug.com/1093602 Bug: 1093602 Change-Id: I41457d827f9792deb62a94567039e3a03a9e9190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246189 Commit-Queue: Haiyang Pan <hypan@google.com> Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#778962}
-
Wenyu Fu authored
Bug: 1094938, 1094926 Change-Id: Ib62d93d8d1ea668eb1a2542df3c54b234798fa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248546 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#778961}
-
Ben Joyce authored
Bug: 1005891 Change-Id: I0e7b9fe291ebca3b797a27cd7db6dfbe788d2645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247122Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778960}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7af453fb3f8ae8c5de3b46f3d649c6d5fa466444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248171Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#778959}
-
Lin Sun authored
- Remove fixed suppressions that are related to closed bugs. - Add driver tag for the Intel driver issues that are fixed on new graphics driver. - Add more detailed tags for some suppressions to restrict the failure condition. Bug: 602688, 1018028, 1021428, 1048861 Bug: 1060012, 1063472, 1081973, 1081978 Bug: 1082533, 1084864, 1082525, 1082565 Bug: angleproject:2291, angleproject:3469 Bug: angleproject:4417, angleproject:4242 Change-Id: I44688fcf483e6c74d1f2bd0f7233bb50340819d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240891 Commit-Queue: Lin Sun <lin.sun@intel.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#778958}
-
Ben Joyce authored
Bug: 1005891 Change-Id: Idd6ec5663f1dae158579a59ae05e93f6657d4bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248541Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778957}
-
Ben Joyce authored
Adds androidx_test_runner_java as dep to cronet_sample_test_apk. Bug: 1005891 Change-Id: I7a06afd3174451915c7ed277f6d4ca7dd7b6e001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245688Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778956}
-
Ben Joyce authored
covers chrome/android/javatests/e* through chrome/android/javatests/p* Bug: 1005891 Change-Id: I0599b86528a9a506453c3777a375e7e9f705a1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248544Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#778955}
-
Vikas Soni authored
Make ImageReaderGLOwner::ScopedHardwareBufferImpl safe to be used on any thread. This does not make this class thread safe in the sense it can not be used by multiple threads in parallel. It is made safe to be accessed/destroyed on any thread. Bug: 1091945 Change-Id: Ibbf3abde59fbc15770bd6175015c7a9bd6662ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247265Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#778954}
-
Nigel Tao authored
JSONReader::Read is a static method, but JSONReader::GetErrorMessage is not. If invalid JSON is passed, GetErrorMessage() will not return anything useful. Bug: 1070409 Change-Id: Ib83396c7c3824235e36273a0a7bfbe8f9c6c4103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247924Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#778953}
-
Vladimir Levin authored
This patch ensures that when we increase the size of elements to determine whether we should descend into them to find a deep anchor, we avoid descending into elements with layout and paint containment that are otherwise off-screen. In other words, we don't adjust their size because any overflow would not be visible. R=chrishtr@chromium.org Change-Id: Id06e4db3625ded3ad43c5e57aeb5b2e40c7ed68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245186 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778952}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/002fa6dcfa6a..959037e082f6 2020-06-16 jmadill@chromium.org Vulkan: Preserve RPs on XFB changes when possible. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I2c3f78ddd766c563f2dfb6d0cff88db255256afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248438Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778951}
-
Sebastien Marchand authored
This reverts commit bf9634ae. Original change's description: > Revert "Remove support for Tab Freezing" > > This reverts commit d0332c34. > > Reason for revert: Introduced failure on browser_tests DiscardsTest.All > > First failure here: > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19162 > [9313:9313:0615/094609.344774:INFO:CONSOLE(1065)] "Running TestCase DiscardsTest.All", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1065) > [9313:9313:0615/094609.353925:WARNING:CONSOLE(34)] "Error: Assertion failed: Unsupported sort key: canFreeze > at assert (chrome://resources/js/assert.m.js:26:19) > at assertNotReached (chrome://resources/js/assert.m.js:64:3) > at compareTabDiscardsInfos (chrome://discards/discards_tab.js:73:3) > at chrome://test/discards/discards_test.js:42:22 > at Array.forEach (<anonymous>) > at Context.<anonymous> (chrome://test/discards/discards_test.js:41:10) > at callFn (file:///b/s/w/ir/third_party/mocha/mocha.js:5342:21) > at Test.Runnable.run (file:///b/s/w/ir/third_party/mocha/mocha.js:5334:7) > at Runner.runTest (file:///b/s/w/ir/third_party/mocha/mocha.js:5990:10) > at file:///b/s/w/ir/third_party/mocha/mocha.js:6108:12", source: chrome://resources/js/assert.m.js (34) > [9313:9313:0615/094609.364579:ERROR:CONSOLE(49)] "Mocha test failed: discards CompareTabDiscardsInfo > Error: Assertion failed: Unsupported sort key: canFreeze > at assert (chrome://resources/js/assert.m.js:26:19) > at assertNotReached (chrome://resources/js/assert.m.js:64:3) > at compareTabDiscardsInfos (chrome://discards/discards_tab.js:73:3) > at chrome://test/discards/discards_test.js:42:22 > at Array.forEach (<anonymous>) > at Context.<anonymous> (chrome://test/discards/discards_test.js:41:10) > ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) > > Original change's description: > > Remove support for Tab Freezing > > > > This feature has been abandoned. > > > > Bug: 844426 > > Change-Id: I777dcb72edd7941778374cc2fbff1e2c966bdac1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239374 > > Reviewed-by: Will Harris <wfh@chromium.org> > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#778280} > > TBR=avi@chromium.org,kenrb@chromium.org,fdoray@chromium.org,asvitkine@chromium.org,wfh@chromium.org,sebmarchand@chromium.org > > Change-Id: I3dafddea7f11bffea171cd8a80ea51368943dd83 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 844426 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246920 > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778411} TBR=avi@chromium.org,flackr@chromium.org,kenrb@chromium.org,fdoray@chromium.org,asvitkine@chromium.org,wfh@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because this is a reland. Bug: 844426 Change-Id: I40be29e8c38f4af699537b62cd5b7176721b6bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246865Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#778950}
-
Matt Menke authored
The NetworkIsolationKey is used for DNS lookups and proxy connection sharing. content/ still needs to be updated to pass in the correct NetworkIsolationKey. Bug: 1085022 Change-Id: I3e56fdf19e32d71a659e2961a5327e9262870aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241613Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#778949}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592318647-c846006b87aca0f87b5615080933ac03d3857a36.profdata to chrome-win64-master-1592324603-595a5101027449adb0c10d8dfc4b4a112ba8b2ae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I66a6386b334bfbab262cd9e9e1d6d2276162f15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778948}
-
Justin Miron authored
This replaces instances of blacklist, whitelist with blocklist and allowlist, respectively to make wording more inclusive. BUG=842296. Change-Id: Ibd90877dff886830ebe569095ccea16b291b3e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240049 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#778947}
-
Mohamed Amir Yosef authored
Screenshot: https://screenshot.googleplex.com/NdctJthyEtR Bug: 1044038 Change-Id: I32a70d3ab46302c1fd2311f79b48c8558fee2e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220048Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#778946}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ea290a9b84bc..f35e50b0e8f3 2020-06-16 rslawik@google.com Improve performance of time_in_state event query 2020-06-16 hjd@google.com Merge "ui: Show more detailed status during loading" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:157216280 Tbr: perfetto-bugs@google.com Test: Test: tools/diff_test_trace_processor.py Change-Id: Iae00c7385d426e06cf7c25c7bad09914ab44e361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248442Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778945}
-
Rakib M. Hasan authored
These expectations will eventually go the AndroidNeverFixTests file. Bug: 1050760, 1050754 Change-Id: I133d29b4a8c47c903ca46cbf80f801506b5510b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248540Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#778944}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f82b08b1e252..d4872ceba46e 2020-06-16 nodir@chromium.org Roll rdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib26b033c87adcf675082eb617e6c644de316f315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248445Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778943}
-
Aya ElAttar authored
Bug: 1092469 Change-Id: If7404d29dd38d571d4b18ef87e3324632398de9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246688Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#778942}
-
Eric Roman authored
* Link to priority rubric * Link to bug dashboards * Link to subcomponent owners spreadsheet NOTRY=true Change-Id: Iadcff03ad252eb1d276e9e7d97b5e7056044409d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248066 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#778941}
-
Eric Roman authored
NOTRY=true Change-Id: I083b5ee85f6906c40cdbd0d361b9d2aca06737fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247083 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#778940}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/fefb452f2969..3fe84b5b33b7 2020-06-16 natlee@microsoft.com Fix AssertAndIgnoreDeviceLossError to handle errors injected by fuzzer 2020-06-16 brandon1.jones@intel.com Fix fuzzer hang when waiting for fence signal after device loss 2020-06-16 jiawei.shao@intel.com Clean up CopyTests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1094448 Tbr: cwallez@google.com Change-Id: I9c8a666576aa2684da5b2a4fed5b118e557de1da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247084Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778939}
-
Kenneth Russell authored
conformance/textures/canvas/ tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html conformance2/textures/canvas/ tex-2d-rgb10_a2-rgba-unsigned_int_2_10_10_10_rev.html Failing intermittently with the validating command decoder. Bug: 1095679 Change-Id: I832e3b5c14bc0a5839af1cd296d5e4f0739d0d92 Tbr: shrekshao@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247777Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778938}
-
John L Chen authored
The histogram is still needed as there's not enough data. Bug: 1052972 Change-Id: I53eb969b08250fe970fac60811d1edc469dedc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247979 Auto-Submit: John L Chen <zuan@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#778937}
-
Eric Roman authored
NOTRY=true Change-Id: Ib201ec5f1c37f4fe577ca11affce05bcafda1a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248341 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#778936}
-
W. James MacLean authored
Prior to this CL, when a CrossProcessFrameConnector is created for an OOPIF, SetView() has not yet been called, so when the constructor calls RenderWidgetHost::GetScreenInfo(), it defaults to calling DisplayUtil::GetDefaultScreenInfo(), which will retrieve the information for the primary display. If the primary display has a different device_scale_factor than the display on which the OOPIF is rendering, then (initially) the OOPIF will render with the wrong scale. As noted in the associated issue, the OOPIF renders correctly after OnSynchronizeVisualProperties() has been called ... this is because it propagates the screen_info from the root view down to all the OOPIFs. This CL makes a simple modification in forcing the constructor to get its initial screen_info from the root RenderWidgetHost, which presumably has a correctly attached view by the time OOPIFs are being created. Bug: 1076450 Change-Id: Ic85f0b099e2a8fb7aa1e8b579dbcddcdcac3e757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247749 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#778935}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592308721-1b82af9218c1227df371704a4e2d7009912d341c.profdata to chrome-mac-master-1592330368-995f9d40f9200b48ea66f14ee9d22a1bdedc987c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5a278ec35ffc6768122a00b8fad3e0f241a90521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778934}
-
Frank Liberato authored
This reverts commit 441c07ab. Reason for revert: may be causing test failures on: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/26119 Change-Id: I34333c1edd483f33e8cd82f23506c91908b7f62b TBR: tsepez,beccahughes,steimel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248128Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#778933}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5423eaa2b1cce8ea0db2ebee5ab7afd7d2c4c0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778932}
-
Mugdha Lakhani authored
These are modified from chrome/browser/prefetch/prefetch_browsertest.cc to pick the tests applicable to WebLayer and use WebLayer-specific set-up. Bug: 1057771 Change-Id: I7771854d981e2892406f497c191b2ac606cdf516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241536Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#778931}
-
Andrew Xu authored
ShelfConfig::app_icon_group_margin_ is the smallest distance between hotseat and other shelf components (such as status area widget). Currently, this margin is set inside scrollable shelf view through |base_padding_insets_|. It complicates the code. This CL ensures that the gap between shelf components is set correctly by ShelfLayoutManager. The code related to Scrollable- ShelfView::|base_padding_insets_| is erased and ScrollableShelfView:: |extra_padding_insets_| is renamed. Bug: 1095678 Change-Id: I24d285a0e405f21788628a148f6f67fc8505d8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245659 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#778930}
-
Yue Zhang authored
When conditional tab strip is enabled, the length of the current tab card is smaller than other cards. This is because that when the entering animation is created, the code thinks the bottom control is still showing. However, bottom control is later hidden when OverviewModeObserver#onOverviewModeStartedShowing signal is dispatched. Without adjusting any existing call ordering, this CL fixes this issue by adding a feature-specific fix which hard-codes the assumption that the bottom control will eventually be hidden when entering stack tab switcher for conditional tab strip. Bug: 1092316 Change-Id: I7b0df80ef7741ffeca23e81ced6d99341ee477b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246738Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#778929}
-
Sam Bowen authored
Bug: 1064751 Change-Id: If9b53316c9ad4c92f7fa6f44ce8d785b039a390c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241947Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#778928}
-
Daniel Nicoara authored
aura::Window defines the root window as the window that has a WindowTreeHost associated with it. Since this gets the window from WindowTreeHost, it is getting the root window. Calling GetRootWindow() on the root window will return the same window. Bug: None Test: Ran cast_graphics_unittests Change-Id: If2ec69710fa94e6f0ac44342f51ea89e47c414bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248158Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#778927}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ic34496375f6deba180de886fdbb24bb516951107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248539Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778926}
-
Sven Zheng authored
Adds an ignore=1 key/value pair to the JSON uploaded as part of the gtest-based pixel tests. This will cause the results to be ignored in Gold, which has the effect of preventing new images from triggering automated comments on CLs. Bug: 1081962 Change-Id: Ic9341bf8a3bfe9f4011036f46f5ac66b84f5f9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242251 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#778925}
-
Bruce Dawson authored
This change updates the toolchain package used to build Chromium with the 10.0.19041.0 (2020-04) SDK and VS 16.6.1. The d3dcompiler_47.dll DLLs for x86 and x64 were swapped out for the 10.0.17134 versions (as usual). The Debuggers directory was not swapped out this time because the problem with loading dbghelp.dll on Windows 7 (https://crbug.com/1021650) has been resolved. The output for the cdb copy step was updated because one additional UCRT DLL is now copied. Packaging was done on a Windows Server 2019 VM, cleanly created for this purpose. The package was created by downloading the VS Professional 2019 installer from https://visualstudio.microsoft.com/downloads/ (free trial, not preview) and then running the installer like this: $ PATH_TO_INSTALLER.EXE ^ --add Microsoft.VisualStudio.Workload.NativeDesktop ^ --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ --includeRecommended --passive Then the latest Windows 10 SDK was downloaded and installed from https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk/ Then the packaging script was run like this: python3 depot_tools\win_toolchain\package_from_installed.py 2019 -w 10.0.19041.0 Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid shipping that (https://crbug.com/920704) the final packaging step was to unzip the package, copy over the two copies of that DLL from the previous toolchain's win_sdk\Redist, and then repackage the toolchain with: > python3 package_from_installed.py --repackage=<full-path-to-toolchain-dir> UWP and ARM64 support and Python 3 compatibility were previously added to package_from_installed.py. Future changes will require the new SDK, but for now the previous SDK can also be used to build Chromium. The failures on the win*msvc* bots are unrelated. This was proven by creating crrev.com/c/2245914 which is a NOP toolchain test. The existing toolchain was repackaged with a single text file added and that caused identical failures. Bug: 920704, 1014701, 10216507, 1089996 Change-Id: Ie496354582458aa8c1292ed4ef63d949ee2eb15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225224 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#778924}
-
Garrett Beaty authored
The overview consoles currently appear in the middle of the console list mixed in with all of the per-master consoles. This will change it so that consoles that specify a title will be sorted before consoles that do not specify a title, which will move the overview consoles to the top since they specify a title and the per-master consoles do not. Change-Id: I5bd4d872f4edf435ab8af70946da9d96e51ce8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242232Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#778923}
-