GitLab

TabsApiUnitTest overrides display::Screen and it left a screen
overridden after execution. When next test (not TabsApiUnitTest) from
current batch is executed and it uses display::Screen::GetScreen(),
it gets broken screen.

Bug: None
Change-Id: I15d3f0193b8980cc06ea0b5232e393e071738a7d
Reviewed-on: https://chromium-review.googlesource.com/963961Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544301}

This is a reland of [1] which got reverted in [2] because the
former actual broke the internal official build of Clank.

It turns out that instead of removing |app_as_shared_library = true|,
for the monochrome apk template, it should be turned into
|shared_resources = true|.

Apart from that, see description of the change in the original
CL, everything still applies.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/957095
[2] https://chromium-review.googlesource.com/c/chromium/src/+/968461

R=agrieve@chromium.org,yfriedman@chromium.org,estevenson@chromium.org,trevordixon@chromium.org

Bug: 820459
Change-Id: I6f6e71c3a13a388c67b68b684c733cd549a2cef0
Reviewed-on: https://chromium-review.googlesource.com/968870Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544300}

Previously CopyCachedSubsequence() called SetCurrentPaintChunkProperties()
which always reset id.fragment, causing multiple fragments to have the
same id. Now call SetCurrentPaintChunkPropertiesUsingIdWithFragment()
which doesn't reset fragment.

Bug: 823029
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibf34f7bb5fba798f96a755ba89fddf848c5f8656
Reviewed-on: https://chromium-review.googlesource.com/969961
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544299}

BUG=762641
TBR=jennyz@google.com

Change-Id: Ic45259e8ce23a72d362727328c1b0d58afeba000
Reviewed-on: https://chromium-review.googlesource.com/970167
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544298}

This patch rebaselines text-only failures that have matched images,
from the following bot result on ToT.
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_layout_tests_layout_ng/4283

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia72ac034523c01a6c5ac10047ed1340a13af2595
Reviewed-on: https://chromium-review.googlesource.com/970188
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544297}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/65e67b8ab181..94a6180a8f51

$ git log 65e67b8ab..94a6180a8 --date=short --no-merges --format='%ad %ae %s'
2018-03-19 gmeinke cbuildbot: fix firmware key-id query

Created with:
  roll-dep src/third_party/chromite


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib1f7c6bd30fdb05e91863a0f0eb8ef5f78277bae
Reviewed-on: https://chromium-review.googlesource.com/969960
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544296}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I20f71fe079b8281eb1cf5c4b40157c9a6bc2d555
Reviewed-on: https://chromium-review.googlesource.com/970166
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544295}

This CL adds early-returns to mojom::AutofillAgent override functions
when |element_| is null. Now |element_| can be null anytime after
DidCommitProvisionalLoad is called (https://chromium-review.googlesource.com/c/chromium/src/+/939224),
checking whether |element_| is null is reuiqred.

Bug: 822649
Change-Id: Id49cc32edf4bb5edbd93da2af9fe5a3fb7205b90
Reviewed-on: https://chromium-review.googlesource.com/968045
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544294}

WebContents in app windows require certain prefs to be set. This
happened in OpenApplication, but there are multiple ways for a
WebContents to end up in an app window and also a WebContents that
started in an app window could later move to regular tab. So, in some
cases, a WebContents could end up in an app window without the necessary
prefs or a WebContents could end up in a regular tab with app prefs set.

Before, when an app window was opened through OpenApplication,
OpenApplication would set app-specific prefs in the new app's
WebContents. Now, HostedAppBrowserController sets the prefs when the
WebContents is added to the tab strip. Before, nothing would unset the
app-specific prefs when a WebContents was moved from an app window.
Now, HostedAppBrowserController unsets the prefs when the WebContents
is detached.

Bug: 808901
Change-Id: I6b21e7e9090133755d8e45de7a216e4c5a5e1379
Reviewed-on: https://chromium-review.googlesource.com/958790
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544293}

The function is both queued as a task, and called synchronously. It makes the
assumption that there exists a next request, but there are race conditions that
could cause there to be no next request.

Bug: 821177
Change-Id: Id0abf1b07bca812ad976184de87cc22d42fb18b9
Reviewed-on: https://chromium-review.googlesource.com/966481
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544292}

Due to adding more tests.

BUG=813151
TBR=eyaich@chromium.org

Change-Id: I8f17a4e6f6ed3fd682507b9c612557aeb30559ca
Reviewed-on: https://chromium-review.googlesource.com/969634Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544291}

This CL folds the method VaapiWrapper::CreateUnownedSurface() into its
only caller. This nicely cuts the amount of lines, reduces the scope
of the |va_lock_|, and improves error mgmt by only having one place
for VA_SUCCESS_OR_RETURN (because the VASurface ctor cannot fail).

Also vavda's CloseGpuMemoryBufferHandle is moved to the unnamed
namespace.

Bug: 822346
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7aa690e3d3976540f2edf07600511ca65f76b6f0
Reviewed-on: https://chromium-review.googlesource.com/964591
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544290}

platform/ and public/platform/ are the lowest layers in Blink, and any
code in Source/ can include them.  Source/DEPS should have entries for
them.

This CL has no behavior changes.

Bug: 565932
Change-Id: Iacd3baa5838d9e7195f4a57a8f8c3dcd4749815b
Reviewed-on: https://chromium-review.googlesource.com/970043Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544289}

This patch changes LineBoxList, a class used to maintain a list
of InlineFlowBox in LayoutInline and LayoutBlockFlow, so that
LayoutText can use it to maintain a list of InlineTextBox.

LayoutNG uses fragments instead of InlineBox tree. By unifiying
this class, it becomes easier to make the change to LayoutText
and LayoutInline.

To share the logic, Next/PrevInlineBox and Next/PrevTextBox are
renamed to Next/PrevForSameLayoutObject. We have a few other kinds
of next/prev, such as NextOnLine. This clarifies next/prev of what
list better.

This CL also adds a few range operators to use range-based loop.

There is no behavior change in this CL.

Bug: 636993, 792242
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9cca3bed636661058e9be6da4c1ad37de75d6bfc
Reviewed-on: https://chromium-review.googlesource.com/968101
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544288}

This is a sibling patch of crrev.com/c/965882, adding script-generated
test cases of LocalCaretRect in bidirectional text at line logical
boundaries.

Test cases are named in format:

In{Ltr,Rtl}BlockLine{Begin,End}{NestedRunInfo}

where NestedRunInfo indicates the number of nested runs at the
caret position, and the direction of the lowest level in these
runs.

See https://goo.gl/fV2sSN for more details about test generation.

Bug: 822575
Change-Id: I34b3633ee8fe62ab4f7c7dacf4b96d19f0d72879
Reviewed-on: https://chromium-review.googlesource.com/969886Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544287}

std::memcmp() comes from <cstring>, so stop relying on it being included
indirectly by other headers. This does not work with GCC and libstdc++ 7.3
at least.

Change-Id: I439cef4e83fed14bbf9885576084daa176d0dc47
Reviewed-on: https://chromium-review.googlesource.com/968526
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544286}

blink-dev i2s thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/8RBFue7RMXQ/discussion

Bug: 735518,782381,816661
Change-Id: Ic7c8a6a0eaf323d3ab736ac8e3ad2d23104ae0cb
Reviewed-on: https://chromium-review.googlesource.com/969407Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544285}

Using wpt-import in Chromium cf4e4370.
With Chromium commits locally applied on WPT:
23aafba1 "[url] Properly treat '#' as marking the start of the fragment in data URIs"
84f77307 "Revert "[url] Properly treat '#' as marking the start of the fragment in data URIs""


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14221

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=kereliuk

No-Export: true
Change-Id: If0a39caa04a72a57381b6c4566e91544a6699803
Reviewed-on: https://chromium-review.googlesource.com/969970
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544284}

Change-Id: I130db573fcc2ccbda3ce58c9d2bac845218ab1d9
Reviewed-on: https://chromium-review.googlesource.com/961549
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544283}

Jpeg Encode Accelerator (JEA) was implemented and ready to be used from
ChromeOS side. This CL adds IPC between ChromeOS and Chromium so that
camera HAL in ChromeOS can take advantage of JEA.

BUG=819847
TEST=Together with
https://chromium-review.googlesource.com/c/chromium/src/+/917932,
verified that encoding a YUV image successfully with HW JEA on Chromium
side.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I639cdf1c5947c33b0d0f9a5b1b00bd685bb596d8
Reviewed-on: https://chromium-review.googlesource.com/917932
Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544282}

RefreshDevicePolicy stores saved device policy in the session manager.
E.g. it is unusable for tests to set specific device policies.

BUG=chromium:819657
TEST=FakeAuthPolicyClientTest.RefreshDevicePolicyStoresPolicy

Change-Id: Id90e090453da27ffa4527ed810bc1f45c5337a3a
Reviewed-on: https://chromium-review.googlesource.com/955842Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544281}

This CL introduce "ClipboardCommand.cpp" with moving |ClipboardCommands|
member into it. Make EditorCommand simpler for improving code health.

Bug: 818552
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Icede39fc714367fe57e886f0f9ef23e1989f7518
Reviewed-on: https://chromium-review.googlesource.com/948243Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544280}

https://chromium.googlesource.com/angle/angle.git/+log/daedf4d234eb..aa5d883e0215

$ git log daedf4d23..aa5d883e0 --date=short --no-merges --format='%ad %ae %s'
2018-03-16 courtneygo Update KHR header to avoid compiler issue.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I2cbbe39d7371645a269ced52e15ff38c7a5ef61a
Reviewed-on: https://chromium-review.googlesource.com/969948
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544279}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/5978d7dd749e..65e67b8ab181

$ git log 5978d7dd7..65e67b8ab --date=short --no-merges --format='%ad %ae %s'
2017-10-09 bhthompson Add HW tests to KBL paladins

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:772430


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I3aef2ab6b741a4d8b60e18edfeb3a9f46b315339
Reviewed-on: https://chromium-review.googlesource.com/969822
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544278}

This change moves time.mojom from //mojo/common to //mojo/public/mojom/base.
Corresponding typemap and struct traits file were also moved. Unit tests for
Time, TimeDelta and TimeTicks were updated to use SerializeAndDeserialize() from
//mojo/public/cpp/test_support/test_utils.h and moved to mojo_unittests.

Bug: 799482,806965
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I080ca0628167a1be705f923a329b7e0986536b83
Reviewed-on: https://chromium-review.googlesource.com/962872
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544277}

https://skia.googlesource.com/skia.git/+log/cb88470d82d6..ec77963bf32e

$ git log cb88470d8..ec77963bf --date=short --no-merges --format='%ad %ae %s'
2018-03-19 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 3761dc7bf..daedf4d23 (3 commits)
2018-03-19 liyuqian Make consistent isRadiusIncreasing decision
2018-03-19 caryclark remove imageinfo flatten altogether
2018-03-19 bsalomon Revert "Revert "New read pixels implementation that is simpler but does all conversions on CPU.""
2018-03-19 bsalomon Remove deprecated versions of YUV texture SkImage factories
2018-03-19 ericrk Allow SkTraceMemoryDump to exclude wrapped objects
2018-03-19 hcm Fix go syntax for Debian compile
2018-03-19 bsalomon Remove SkSurface::MakeFromBackendTexture variant that doesn't take SkColorType
2018-03-19 ethannicholas fix switch fallthrough warning
2018-03-19 liyuqian Fix concentric 2pt conical gradient in GPU where r1 < r0

Created with:
  roll-dep src/third_party/skia
BUG=chromium:795358


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: I83f77a4beed619b2bc27becaafe1224131abb3d1
Reviewed-on: https://chromium-review.googlesource.com/969800Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544276}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I7334d112f3aa5619170be0ef8e6e20d268a364cf
Reviewed-on: https://chromium-review.googlesource.com/969885Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544275}

As a drive-by, adds the light blue hover state to the console sidebar

Change-Id: Ie4ac958c8feb6d8907e2574db53a5d89ada54eb2
Reviewed-on: https://chromium-review.googlesource.com/907793Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544274}

This reverts commit 52e03fa8.

Reason for revert: Some mac builders are broken. e.g. https://ci.chromium.org/buildbot/chromium.fyi/Mac%20Builder%20%28dbg%29%20Goma%20Canary/3941

Original change's description:
> AppShell: Suppress context menu in webviews
> 
> AppShell doesn't support context menus, but still needs to provide a
> WebViewGuestDelegate to handle the context menu. Otherwise, we reach a
> NOTREACHED() in WebContentsViewChildFrame::ShowContextMenu().
> 
> Also removes a WebViewGuestDelegate function that is unused (see
> https://codereview.chromium.org/2836973002).
> 
> Bug: 820604
> Change-Id: I0760d397384908a490704f23388e11c4eef113a5
> Reviewed-on: https://chromium-review.googlesource.com/957596
> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Lucas Gadani <lfg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544136}

TBR=michaelpg@chromium.org,lfg@chromium.org

Change-Id: Ib3691d13fb6a787b487c0e11a73e9c0bdaad5b8b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820604
Reviewed-on: https://chromium-review.googlesource.com/969723Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Commit-Queue: Shinya Kawanaka <shinyak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544273}

OOPIF frames do not have names on some versions of Chrome.
Recognize such cases and do not raise errors.

Bug: b:75302857
Change-Id: Ib5cce47de560d2a1d39c654e1e566572b0f8247e
Reviewed-on: https://chromium-review.googlesource.com/969788
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544272}

After user dragging the scrollbar thumb, we should snap to the closest
snap position of the container.

Bug: 819769
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9d383d61a4f171d02c339064392216e0f4eae2ca
Reviewed-on: https://chromium-review.googlesource.com/953647
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544271}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3d6608ce..d811a187

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ibb729c6452938284f24893ce3fe82e79b234c68b
Reviewed-on: https://chromium-review.googlesource.com/969637Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544270}

CopyOutputRequests must be taken from CompositorFrameSinkSupport before
SurfaceAggregator::copy_request_passes_ is populated. This broke at
http://crrev.com/99f8d9a.

Bug: 823393
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I2ee6130e66be5b0a0943df87cd22b40d4e9217c1
Reviewed-on: https://chromium-review.googlesource.com/969503
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544269}

  In order to roll GN a0a05a85..ee966518 (r533513:r544233) and pick up
  the following changes:

  dcba727e GN: Don't crash when mutating the list in a foreach.
  3325da9a GN: Correct Git Bash removal of leading "/" of "//" labels
  36773f30 Improved GN code related to resolving paths.
  1252d9cd gn clean: Don't delete and recreate the build directory.
  2caa6c11 Update GN docs.
  6783e46f Correct off-by-one in `Tokenizer::CanIncrement`.
  1bcad90d GN: Force normal subprocess task priority on Windows
  a3ec9fb7 GN: Fix Mac bootstrap compile error
  bbc17a39 GN: Make sure print function flushes stdout to avoid output delays caused by buffered pipes.
  99637d39 Remove reference to deleted sequenced_worker_pool
  4416579b Rename buildflag_header targets in base for consistency
  cf54d20b gn: Write no stamp files for action inputs.
  00eba186 Fix gn reference in build.ninja after bootstrapping
  c986c354 Support for JSON input conversion
  b46dd8be Only run "gn check" on binary targets.

TBR=brettw@chromium.org

Change-Id: Ic42ce6dc48e39772fd88f009e7e50459a64e740b
Reviewed-on: https://chromium-review.googlesource.com/969982
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544268}

Background: A sequence (also called stream) has multiple command
buffers, and runs tasks like Flush in the order in which they're
received. Therefore, sequences are effectively flush ordered internally,
but can run out of order with respect to other sequences.

SyncPointManager ensures that there are no sync token wait deadlocks by
assigning an order number to each IPC message. When a command buffer
waits on a sync token, we enqueue the wait, and the order number of the
waiting message (Flush) with the releasing command buffer's sequence
("release" sequence). If the releasing command buffer does not retire
the sync token, we will still retire it once we go past the waiting
order number in the release sequence, or if there are no more messages
in the release sequence. This is to handle malicious renderers sending
the browser sync tokens that aren't retired, and prevent the browser
from hanging forever. It should also prevent deadlocks incorrect client
logic.

With the scheduler, we prevent a sequence from running if its next
message has sync token waits that aren't resolved yet. We do this by
adding sync token dependency hints in the Flush message. This is to
avoid unnecessary context switching caused by executing a command buffer
just to encounter a wait immediately. However, these dependencies are
just hints, and we don't rely on them for correctness, i.e. it's
possible for the Flush message to contain no hints, but still have sync
token waits in the command buffer.

In this bug, we encounter a cyclic dependency graph between sequences,
where sequence A waits on sequence B with order number X which is less
than the order number of B's next task, and sequence B waits on sequence
A with an order number P which is greater than the order number of A's
next task (which is X). This is caused by a client error that we haven't
figured out yet, but we should still be resilient to it.

However, this does not work as expected because the scheduler
deschedules both sequences, and asks SyncPointManager to notify when the
waits are resolved. SyncPointManager cannot resolve cyclic dependencies
until one of the sequences runs. The logic to retire pending waits runs
either when you start or finish a message with order number X.
SyncPointManager doesn't know what the next order number in the task
queue is. This worked correctly when we didn't have sync token
dependency hints, and we would run one of the sequences in the cycle
first. In the above example, the wait from A to B is invalid because B
doesn't have a task with order number less than X. Only after starting
to run the next task can SyncPointManager know to retire A's pending
wait on B.

To fix this, SyncPointManager would need the queue of order numbers for
each sequence, and use that to invalidate any waits before the next
order number. In the above example, A's wait on B would be deemed
invalid because SyncPointManager can look ahead and see that the next
task order number on B is greater than X. Ironically, the scheduler has
this information in its tasks_ list, but doesn't use it because we
wanted sync point manager to be the source of truth to support both
scheduler and non-scheduler code paths over a year ago.

This has been a bug since M63. Maybe we didn't hit it because the client
started doing something incorrectly recently. One possibility is that
the client is sending sync tokens to another process, but without the
synchronous IPC to "verify" or confirm that an order number is assigned
before sending it to another process.

The short term fix is to add a queue of order numbers to
SyncPointOrderData which is SyncPointManager's state about a sequence.
Today, we have unprocessed_order_num_ which is the back of this queue,
processed_order_num_ which is the last order number popped off the
queue, but what we really want is the front of the queue (next task
order number) any time a wait is enqueued.

Long term, we may want to make the Scheduler the source of truth for
sync tokens.

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I87c2680b14ccb04b5ba58ab329db683c400f45b3
Bug: 797137
Reviewed-on: https://chromium-review.googlesource.com/969639
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544267}

https://pdfium.googlesource.com/pdfium.git/+log/c49f39dff730..b3a5240832fc

$ git log c49f39dff..b3a524083 --date=short --no-merges --format='%ad %ae %s'
2018-03-19 ralf.sippl Calculate AP for multi-line markup annotations correctly
2018-03-19 thestig Roll DEPS for Clang to 7d56ff90.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3519f4d3ca31557ab8a613027c610c20d592f60f
Reviewed-on: https://chromium-review.googlesource.com/969829Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544266}

This CL introduces Editor::IsCommandEnabled(), so WebLocalFrameImpl can
use it instead of Editor::CreateCommand().IsEnabled() to avoid the
dependence of Editor::Command in WebLocalFrameImpl.cpp.
It's preparation of CL [1], because after that patch, we will not need
to use "core/editing/commands" outside "core/editing/".

[1]: http://crrev.com/c/958623Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I5936157927665dbef19735ab6f7aac5789325a8e
Reviewed-on: https://chromium-review.googlesource.com/964034Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544265}

When an archive file (.rar) on Drive cache is already marked as mounted,
it doesn't change the cache state but still need the cache file path.

Bug: 798024
Test: manually verified as noted in the bug
Test: unit_tests --gtest_filter=FileCacheTest.*:FileSystemTest.*
Change-Id: I44984dfe4ae4aa25885239b221d723fa3ba70866
Reviewed-on: https://chromium-review.googlesource.com/896765Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544264}

LayoutTestHelper isn't related to layout tests.
so it's renamed and moved in core/testing/.

Bug: 461929
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icd3cd98b96bf97538475b43c356a756ba0797cd1
Reviewed-on: https://chromium-review.googlesource.com/914213
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544263}

Content verification mode is currently dependent on flag + field trial
+ os + google branded-ness. This means using flags to control
verification mode from tests isn't going to produce desired outcome.
Provide a way for tests to override this mode instead and use them
in browser_tests.

Bug: 822970
Test: No visible change.
Change-Id: Ie764684d9acd56f3479d8d38f14fd02335160434
Reviewed-on: https://chromium-review.googlesource.com/967055
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544262}