- 03 Apr, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71c0e9422038..c9eeab3d85b9 git log 71c0e9422038..c9eeab3d85b9 --date=short --no-merges --format='%ad %ae %s' 2019-04-02 bungeman@google.com Remove Skia version number. 2019-04-02 mtklein@google.com update some FM flags 2019-04-02 michaelludwig@google.com Do not lose existing paint shaders when drawing alpha images 2019-04-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c9eeab3d85b9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@chromium.org Change-Id: If235ea3d381769cda7f130fa246b5a5e342af6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549959Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647083}
-
Karan Bhatia authored
This CL changes the flatbuffer schema to store a vector of URLPatternIndex instead of storing each index corresponding to an action individually. This will help to make the code more concise once more actions are added. This CL introduces no behavior change. BUG=947591 Change-Id: I65ca96c8f5dc17fa6e464783eee6ab53c78c2d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545362 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#647082}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1c88f3d7. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296 "Revise tests for datachannel ID handling" 80389713 "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Icf8dd67e51f993229d29e3c539b83b389c09f23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549571Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647081}
-
Dan Beam authored
Screenshots: https://imgur.com/a/r7vGHp9 R=rdevlin.cronin@chromium.org BUG=937159 Change-Id: I6c2ed201928cbe9a7974797a1aced1d049387a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546763 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
rajendrant authored
Bug: 935010 Change-Id: I5f8011a0564527b6ceb095a4e0a05534085088c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547962Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#647079}
-
Owen Rodley authored
This was added in https://crrev.com/c/1534342 for use by codesearch, and the script added in https://crrev.com/c/1542379 will process the resulting annotations. Bug: 615202 Change-Id: Ie6d3157361e01991693b6255f62a93ed4b91b33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546793Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Owen Rodley <orodley@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#647078}
-
Jinsuk Kim authored
Moves the app ID associated with a Tab out to manage it as UserData. It also observes IME event to update the present id, so helps break down the ImeEventObserver into more relevant classes. Bug: 925242 Change-Id: I16637e98b52a07bf5199240c780c62990315b7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532137 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#647077}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2884953d..ba99d428 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2279849aa09e4d5f6e79cd20ddd9be61ae45c516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549902Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647076}
-
Alex Cooper authored
There were a couple of things that were happening that were blocking our ability to return inline sessions. The first thing that was happening was that initial promises would end up hanging. This is because while we have a mojo reference to the server, the browser side had nothing so we would get a disconnect error, which we didn't notify any pending promises after. The second issue was that we were always rejecting sessions if we didn't have a service (i.e. because we hit an error earlier and caused it to get disconnected). Finally, we weren't guarading against the service being null, and could therefore crash after receiving a disconnect error. Bug: 944285,936264 Change-Id: I252361877243e9762ba438763ca54b902ee05b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548365 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#647075}
-
Anand K. Mistry authored
If the dropdown only contains a few (1 or 2) elements, the dropdown's height prevents any element below the dropdown items from being clicked on. BUG=943417 Change-Id: I8aa8446317a2aecb4ca33f2ba17415818e922710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535926Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#647074}
-
Karan Bhatia authored
This CL fixes an incorrect DCHECK in OnDynamicRulesFetched. The DCHECK ignores the possibility that ReadJSONRulesResult::Status::kSuccess can be returned together with an empty rules list. Also add tests for the same. BUG=930961 Change-Id: I9570e406b885baa8dfc5ee9973edfdfac7cdaddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546870Reviewed-by:
-
Brandon Wylie authored
Switching from having each ImageFetcher-derived class owning its own singleton to a factory pattern. Moved resizing logic to the bridge. Bug: 944520 Change-Id: Ib4315d042aa4b38f46469c8b6367fb77e5dfb34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534793 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#647072}
-
Collin Baker authored
When the frame color changes, a tab strip repaint is scheduled. When the new tab button is not painting to its own layer, this indirectly results in a repaint of the new tab button. However, when it has its own layer, it won't get repainted since layers paint independently. This adds a SchedulePaint() call on the new tab button for this case. Bug: 946777 Change-Id: Id8c9ec016bffb81a69332b5199ae116e3816f68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549928 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#647071}
-
Dominic Mazzoni authored
Promote katie to an owner of nearly all accessibility code. She's always free to delegate or decline if she's not the best reviewer. Add jamescook as an owner of the aura and views accessibility code, because we need an additional reviewer for mash accessibility work who's familiar with both mash and accessibility. Bug: none Change-Id: I1f820bf186538a5a3eb92d05603497f21bb53bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549883Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#647070}
-
Rakib M. Hasan authored
Bug: chromium:698902 Change-Id: I26642411cc6ff1ac879188cc5fe6b4b61374c923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549617Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#647069}
-
Karan Bhatia authored
r609787 changed the web request API to require host permissions to the initiator and added the Extensions.WebRequest.InitiatorAccess2 histogram. The change landed in M72 and the histogram values look as expected - in only around 0.77% cases the extension doesn't have access to the request's initiator given it has access to the request url. Deprecate the histogram since it should no longer be needed. BUG=948330 Change-Id: I0ae27db39dc4d6e05c36d360a4213ff407eaac03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548598Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#647068}
-
James Darpinian authored
This fixes WebGL conformance test: incompatible-texture-type-for-sampler.html ES 3 implementations don't like us specifying unsized formats GL_RED/GL_RG as the internalformat for 3D and ARRAY textures. We need to specify sized formats such as GL_R8 or GL_RG16F instead. Bug: 947236 Change-Id: I628d79e8ceb4262ef42d5eed9f031e457cab78aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545512 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
-
Azeem Arshad authored
The "Get Data Connection" toggle in the Mobile Data settings section toggles Instant Tethering. Clicking the label seems to be working but clicking the toggle button directly is broken since the toggle component stops propagation of click events from it. This CL fixes this by adding an on-change listener for the toggle as well. Bug: 947300 Change-Id: I1bafe1573722c12c874b402e4fd6c5e9a9beee6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549747Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#647066}
-
Andrey Kosyakov authored
This explicitly disables DevTools interception for data: URLs to maintain the existing behavior for DevTools clients following other kinds of interception being enabled for data: URL navigation by https://chromium-review.googlesource.com/c/chromium/src/+/1541086 Change-Id: I93c7eb76236f00128688629c1aec3429b0000659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549884 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#647065}
-
Xianzhu Wang authored
Because of floating point errors, the fast path and slow path can't always create the same result. Previously we tolerated non-empty cases, now also tolerate empty cases. Bug: 947803 Change-Id: I3b444ea1bb58ede0daa4546be6d161a65d6b4907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548546Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#647064}
-
Tarun Bansal authored
The two fields are custom_proxy_use_alternate_proxy_list and alternate_rules. These fields were added to support proxying different types of requests through different types of Data Reduction Proxies (DRP). e.g., only some of the DRP proxies supported video compression. However, these specific proxying rules are not required anymore. Change-Id: If4d1d8eff11013b979d882590a3d498434b834dd Bug: 945364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546641 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#647063}
-
James Darpinian authored
Looks like all video tests are potentially flaky on Android. Luckily, flakes are relatively rare. TBR: kbr@chromium.org Bug: 948894 Change-Id: I988321c905799630df018596ea01d54629d3a785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549889Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#647062}
-
Xiaohui Chen authored
Remove use of IdentityManager::GetPrimaryAccountInfoDeprecated(). Now check the email address instead of hosted domain. Bug: None Test: locally build and run Change-Id: I3cf55fdebfb8a8104686ff32e4388a3ef21391d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549891Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#647061}
-
Scott Chen authored
Bug: None Change-Id: I2ae4e095e0ed7ec8c0f18712570e576315970778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549694Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#647060}
-
Yuly Novikov authored
conformance/extensions/oes-vertex-array-object.html conformance2/vertex_arrays/vertex-array-object.html Fixed by https://chromium-review.googlesource.com/c/angle/angle/+/1545009 Bug: 920033, 920265 Change-Id: Idb3f5706dff468ecfe593e95c2d9689d90755435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546681 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Raymes Khoury authored
This feature has been enabled by default for several milestones. Change-Id: Iafafde408d3163bc5f09b13e08079e780369d6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531890 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#647058}
-
Alex Moshchuk authored
NOTRY=True TBR=cmp@chromium.org Bug: 947667 Change-Id: I8b6ea8ffb34d56305e78ab3c657ba66a8fe3eb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549989Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#647057}
-
danakj authored
These tests already fail with the legacy codepath that was bitrotting and deleted, they timeout now. But can be fixed when/if android layout tests get prioritized. TBR=piman@chromium.org Bug: 947542 Change-Id: I2758ffb8ff281b12e97a89071c103af72d04b57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545168Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#647056}
-
Tarun Bansal authored
Clean up the code around: 1. Probing aka Connection robustness 2. Not bypass on missing via headers This does not do the full cleanup. So, there are still some places that can be cleaned up. Change-Id: I3f49ae2b9b0a547470a031ba302879bb23200ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547067Reviewed-by:
-
Lan Wei authored
In test_driver actions API, for mouse clicks, if the two clicks' time interval and two click location range is small enough, we will set the click count to 2 and generate double click event. This CL fixes these tests: webdriver/tests/perform_actions/pointer_pause_dblclick.py webdriver/tests/perform_actions/pointer_dblclick.py Bug: chromedriver:1897 Change-Id: Id147cbb83cb7e39b8240ce126e87fd217e25d263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549561 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#647054}
-
Min Qin authored
The test fails because we call DownloadManager::GetAllDownloads() too fast. Change the ordering for the dangerous download to start first, then call DownloadManager::GetAllDownloads(). BUG=948223 Change-Id: I60a73eb138598fc90afaed9fc991e634b30f52dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546065Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#647053}
-
Lukasz Anforowicz authored
Bug: 948434 Bug: 948433 Bug: 948702 Change-Id: I69b9cb6295d553b61a0044064d62388999bd12cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549890 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
rbpotter authored
Some interactive_ui_tests were disabled on all platforms, but are in fact only flaky on Windows due to https://crbug.com/711256. Re-enable these tests on other platforms. Other Web UI tests are still enabled but continuing to flake on Windows for the same reason; disable these tests on Windows also. Modification to original: Keep CrExtensionsOptionsPageTest.All disabled on all platforms, since it appears to still be flaky. Note: If tests begin flaking after this CL lands, please disable only the flaky tests if possible, rather than reverting the entire CL, so that the test coverage being restored by this CL can be retained. Bug: 711256, 945630 Change-Id: I6a3026a9f152d29515c39a94fafe4c526096909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547958 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
David Bertoni authored
Bug: 946604 Change-Id: Ie2afed378e47f366fd6e48c12a46966f75a38e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545501 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#647050}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I0626f90d9803af20c2d6c6fc1367ac76267af70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549568Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#647049}
-
Nate Fischer authored
This CL includes miscellaneous fixes/improvements to remove_preinstalled_webview.py. First, this modifies the remove_preinstalled_webview.py script to provide actionable error output when using it on an emulator (these have the special requirement that they're started with the '-writeable-system' flag). This adds logic to catch the case where the script fails (for whatever reason) to uninstall a WebView APK. This also fixes a bug where we didn't correctly uninstall app updates, since we would return early if 'com.android.webview' was not either not updated or not installed, rather than continuing forward to uninstall 'com.google.android.webview'. This fixes another bug, where the script specifies directory paths for preinstalled APKs, but actually needed full paths (including the APK's filename at the end). This also updates the script to use a new Devil API (device_utils.SetWebViewFallbackLogic()) and uses common logging configuration. Bug: 922228, 929892 Test: Manual Change-Id: I074cd4b53b0dc57e214489aba54fd63d1c54a73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545684Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#647048}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/66ae531590ae..1af744b57c87 git log 66ae531590ae..1af744b57c87 --date=short --no-merges --format='%ad %ae %s' 2019-04-02 jgilbert@mozilla.com Windows SDK includes need to be lowercase for MinGW builds. 2019-04-02 syoussefi@chromium.org Vulkan: glClearBuffer* implementation 2019-04-02 jonahr@google.com Ignore flaky dEQP failures on Windows Created with: gclient setdep -r src/third_party/angle@1af744b57c87 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ib48d5a4316d367d77de366ef6b71cfa8bd6989c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549349Reviewed-by:
-
rbpotter authored
The plugin was made non tab focusable due to https://crbug.com/455552. This bug no longer exists even with a tab focusable plugin in the new Print Preview, since the overlays are now modal cr-dialogs, and keyboard users currently cannot access the zoom/fit to page fab buttons in the PDF viewer in Print Preview. Make the plugin tab focusable to fix this issue. Also ensure that fab button strip becomes visible when focused. Bug: 892675 Change-Id: Id2860a48c9c9eb64a591d8318c4f1e0390554099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548146Reviewed-by:
-
Jason Chase authored
When the HTML imports feature is only enabled by origin trial (i.e. the the runtime flag is disabled), import links are processed correctly in the main document. However, import links inside an imported document were not processed. This CL addresses a number of issues: - In HTMLLinkElement::LinkResourceToProcess(), rel=import would actually be handled as CSS, if HTML imports was not enabled. - In HTMLLinkElement::LinkResourceToProcess(), the OriginTrialContext was not yet created in imported documents, so enabled checks would always fail. - Imported documents are not expected to have trial tokens, so the features would not be enabled. Bug: 939465 Change-Id: Ibf6985ffba7311bf90f7449ff9a065e7b84fdc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546420Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#647045}
-
Ian Wells authored
This change adds new fields to the pages and thumbnails tables. Bug: 841516 Change-Id: I79144f0debb3d4ffdc067ee9299b5bb6af4bfe9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549687 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#647044}
-
