- 18 Oct, 2019 40 commits
-
-
Bailey Berro authored
This change improves the metrics for IPP Printer queries. The result is broken up in to two separate boolean enums: - Printing.CUPS.IppAttributesQueryResult captures whether we were able to successfully query the printer. - Printing.CUPS.IppAttributesSuccess captures whether the request for attributes was successful, given that we were able to reach the printer Bug: 1012437 Change-Id: If11ae1b03c3f2f76618d91eef8f49f1aefdb75d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864022Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#707234}
-
sangwoo.ko authored
When BrowserRootView is being destroyed, we shouldn't call callbacks from DropTarget. It might be already destroyed. Bug: 1001942 Change-Id: Id4a0550e1266e40822c6b77d6848e73432d07e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849749 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#707233}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I10fa95860e79cb9b7690cdde94bdc4dc39206173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868330Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707232}
-
Sajjad Mirza authored
Bug: 1013808 Change-Id: I3b16f6dc8d4cc6499c9eb596942f8c28c199a602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867851Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707231}
-
Sumit Sahrawat authored
This PR makes the ImageToggleButton class fire a kCheckedStateChanged event on state changes instead of kAriaAttributeChanged. This fixes an issue where NVDA was not announcing the state change. The kCheckedStateChanged event is also handled in AXPlatformNodeWin::MojoEventToUIAProperty. We map it to UIA_ToggleToggleStatePropertyId, which makes Narrator announce the state changes as well. Tested locally: * Narrator works with --enable-experimental-ui-automation. * NVDA works both with and without the experimental flag. * MacOS VoiceOver works. Bug: 1013835 Change-Id: I925aad65925aadc34468651198bed39c2ba8776a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861915Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sumit Sahrawat <Sumit.Sahrawat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707230}
-
Takashi Toyoshima authored
To record CORS related errors in both CORS modes, this patch renames the CheckAccess to CheckAccessInternal, moves it inside an anonymous space, then calls it from the new CheckAccess and CheckPreflightAccess. Bug: 1008693 Change-Id: Ib1a02e52470de89d082002213665464389b70ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864756 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#707229}
-
Ovidio Henriquez authored
This change add a fuzzer for the following methods: * EncodeIndexedDBKey() * EncodeIndexedDBKeyPath() * DecodeIndexedDBKey() * DecodeIndexedDBKeyPath() Bug: 654810 Change-Id: Iadc850bdc750f0f1b80b7d70b90deed298ece808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857605 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707228}
-
Takashi Sakamoto authored
[android] Report the highest private memory footprint of a renderer process after the first navigation start. Also report the number of web pages (ie. Page::OrdinaryPages().size()) and the peak RSS when the highest private memory footprint is observed. Design doc: https://docs.google.com/document/d/1TPL2DBEWP6goZJBYKmRyU-hP73etQ5nigjBbVx71kik/edit?usp=sharing Change-Id: I0f732fb812ca9772745d273985d411e61d251817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687391Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#707227}
-
Elly Fong-Jones authored
This change removes all the remaining "easy" cases in cbui. ~All of these are simply static strings, or static strings returned by a controller/model/delegate/etc. As such they aren't individually listed below. Bug: 1011446 Change-Id: I7a004d84bb78cd3f1dc3458a6b80416f540bc94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865401 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#707226}
-
Christos Froussios authored
These histograms are extended PasswordManager.LinuxBackendMigration.TimeIntoEncrypted PasswordManager.LinuxBackendMigration.AttemptResult PasswordManager.LinuxBackendMigration.Adoption We are seen occasional failures, which may be related to the migration, therefore we are keeping the metrics until we determine the cause. These histograms are no longer being used PasswordManager.LinuxBackendMigration.TimeIntoNative Bug: 1006983 Change-Id: Ie9c98f0ae5bdbaa04ac1e2382e9b3c2986b16a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831812 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Bo Liu authored
Bug: 995543 Change-Id: Iabbb018ed0b2d2bcaab4e42436b9feae2c15fa31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855379 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/16af35606f4d..fcde3ba0a657 git log 16af35606f4d..fcde3ba0a657 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 erikchen@chromium.org Store up to 30000 packet log lines for git fetch. Created with: gclient setdep -r src/third_party/depot_tools@fcde3ba0a657 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ic392c5fa823224b0fbf3ba4557402064836934f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867989Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707223}
-
David Bokan authored
This CL fixes a bug when scrolling from outside the root scroller hierarchy. The root scroller is the "main" scroller on a page. On Android, this can be designated on an element other than the document. However, it's still possible to scroll a chain of elements outside of the root scroller subtree. For example, from a sibling of the root scroller or from a |position: fixed| element. In these cases, when the scroll chains to the root, we still want to scroll the visual viewport so that we support panning around if the user is zoomed in. We don't do this on the main thread prior to this CL. Typically, the VisualViewport is scrolled by using the RootFrameViewport class. However, in this case we can't use it since that would cause scrolling in the root scroller (and thus change behavior based on whether the page is viewed using a UA that supports root scroller). This CL adds a special case to Node::NativeApplyScroll. When we construct a chain that doesn't end at the root scroller, we'll always add the root LayoutView to the scroll chain. When scrolling it, we'll attempt to scroll the visual viewport if the document itself can no longer scroll. Note: we have an equivalent special case in LayerTreeHostImpl::ApplyScroll where we can pass a bool to viewport()->ScrollBy() to specify that we should scroll only the visual viewport. This behavior is somewhat more natural in CC since the scroll chain walks the ScrollTree which contains the visual viewport. Blink's scrolling code assumes all scrollable nodes are DOM nodes which isn't true of the visual viewport; hence the need to make this a special case of the root document node. This was implemented in CC in https://crrev.com/c/1752866. At the time, it was assumed this case would be exceedingly rare on the main thread so it was left unimplemented. However, fixing bug 1011866 will result in this case becoming more common. Bug: 977954, 1011866 Change-Id: I7d2d9cb70b66b54a8c972af4bdc6d69978fe690b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859940Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707222}
-
Thanh Nguyen authored
This CL adds metrics to records error type when doing inference. Bug: 1006133 Change-Id: I30d1956cf409c5d13506d262678469c42ddd70f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851371Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#707221}
-
Ayu Ishii authored
This change marks obsolete UMA histograms for the SMS Receiver API. Because the API no longer accepts timeout values,these histograms are no longer needed. The code using these histograms have been removed here [1] and are not expected to be used in the future. [1]https://crrev.com/c/1783227 Change-Id: I492f26b4a4bc6a76c5901ab8b0082c791cd2638a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829565Reviewed-by:
-
Philip Rogers authored
This patch removes ScrollingCoordinator::IsForRootLayer as well as the declaration for ComputeShouldHandleScrollGestureOnMainThreadRegion. This patch also fixes some minor typos and removes some unnecessary includes. Change-Id: I500d77e657fcc0bf86d029ed4a50b5d3b4628ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866872 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707219}
-
Dan Beam authored
Fixed: 1015685 Change-Id: Ie5241e62ccf06c854a578634cda968a55c21ea80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867850 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#707218}
-
John Lee authored
- Add |alertStates| as property on |TabData|, sent from C++ - Move fade in and fade out animations out from CSS to JS to allow wrapping them within Promises, so that TabElement can reliably tell when there are AlertIndicator elements in the DOM. - Fix tests such that SVGs load from chrome://tab-strip instead of chrome://test. Screencast in attached bug. Bug: 1004983 Change-Id: I32cb6c91169646c244070826875a8317b8c9b296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861124Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#707217}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5fcfcea4a937..6dee176c8d7d git log 5fcfcea4a937..6dee176c8d7d --date=short --no-merges --format='%ad %ae %s' 2019-10-17 tobine@google.com Vulkan:Roll vulkan layers and headers Created with: gclient setdep -r src/third_party/angle@6dee176c8d7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:1011068 Change-Id: I27c4be48ff43a7fd293989e6c5fa4ac11870c517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867771Reviewed-by:
-
Noel Gordon authored
Reading the directory-tree.js I see the following in a few tree item classes derived from cr.ui.TreeItem: // Get the original label id defined by TreeItem before overwriting // prototype. followed by identical code to label the derived cr.ui.TreeItem By the time I'd read that 3 times I imagine we could improve the our code health by ditching this clearly duplicated code. Begin with a simple idea class TreeItem: a TreeItem that has a label and createRowElementContent() helpers, used to provide the innerHTML row content depending on mode FILES_NG_ENABLED or not. In subsequent patches, we will use this class to label all tree item classes derived from cr.ui.TreeItem, and shave off code lines. Bug: 992819 Change-Id: I30867c20c80e000f7175aaaaf1bc3bf212ae6bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866122Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#707215}
-
Alexander Timin authored
Ensure that we don't cache pages which have in-progress navigations in one of the subframes. Together with already existing check for whether the frame is active during navigation start this ensures that we never commit navigation in an inactive frame. R=arthursonzogni@chromium.org,lowell@chromium.org,alexmos@chromium.org CC=nasko@chromium.org Change-Id: I71e0b325dfefb9269af85b50c2617b7ab9a306af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860338 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#707214}
-
Robert Ogden authored
Records the number of days since any origin in the redirect chain was last visited according to the HistoryService. Bug: 995437 Change-Id: Id044f4845e353187c01eb5464173836296d5eff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850419Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#707213}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e8b962bd3c97..86d053c2db6e git log e8b962bd3c97..86d053c2db6e --date=short --no-merges --format='%ad %ae %s' 2019-10-17 mbonadei@webrtc.org Use source_sets in component builds and static_library in release builds. Created with: gclient setdep -r src/third_party/webrtc@86d053c2db6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ic7b919efcdac5840b2a0d5ebc782409d9c5b1bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867262Reviewed-by:
-
Bettina authored
Expand saved password protection experiment to add a flag on whether or not to show a list of domains in the modal warning and include a button to route the user to the first domain that the password was saved on. Bug: 1015671 Change-Id: I5e5343ea19258ff7fe54044cbdc17e85033edf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867095Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#707211}
-
Takashi Toyoshima authored
In the previous patch, renderers are changed to take a command line flag for deciding OutOfBlinkCors mode. But since the flag is passed by chrome/ code, content_browsertests run without the required flag even when the OOR-CORS is enabled. This potentially affects other chromium content embedders and may cause confusing situations. To solve this problem, I changed to use the combination of a flag and the base::Feature. Fortunately, there are only two call sites in the renderer processes, and it won't be so bothering. This fix failed content_browsertests at linux-oor-cors-rel bot. Bug: 1015289 Change-Id: I8835b0c328e23656114b4dfcb87286f6cd1d5455 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866372 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This method takes ownership of a View to use for the dialog's extra view slot. This change also has the default implementation of DialogDelegate::CreateExtraView return the view provided by SetExtraView. It then migrates some users of CreateExtraView to use SetExtraView, from their constructors if possible, by: 1) Moving their Foo::CreateExtraView method to a free function inside an anonymous namespace 2) Invoking it from their constructor, and storing a weak raw pointer to the created View if needed Further CLs will remove other uses of CreateExtraView and eventually remove it in favor of DialogDelegate pushing the extra view to DialogClientView. Bug: 1011446 Change-Id: If3a9f3ebe086122dc28b76c233193e7cfb4c0152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865597Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#707209}
-
Daniel Rubery authored
This CL adds UX for a few more WebProtect final states, as well as the logic to trigger them. It modifies the shelf to show UX for deep scanned files that were found safe, deep scanned files that were found unsafe, and both kinds of DLP violations. Screenshots: https://screenshot.googleplex.com/3QZGfkEGXOK.png https://screenshot.googleplex.com/eDfjOVJOzOw.png https://screenshot.googleplex.com/nnsGgnS6E0z.png https://screenshot.googleplex.com/cK1DzQjQ1wg.png Mocks: https://docs.google.com/presentation/d/1MH7zM5YiuCZr3jYsqkTJRC0cqtdo8wuWZOOQ66jptVk/edit#slide=id.g5d9bcde872_0_0 Bug: 980777 Change-Id: I1372fdd0395918a1352a1ecb22e01b6b301b8696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864876 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#707208}
-
Alexander Timin authored
Do not cache a page if the main resource of its main document had cache-control: no-store header. Note that it's the only set of conditions that disabled bfcache. Back-forward cache is still enabled in the following scenarios: - no-cache directive - no-store on a non-main resource (e.g. image) - no-store on a main resource of a subframe. This matches Safari's implementation of back-forward cache: https://bugs.webkit.org/show_bug.cgi?id=140302 R=arthursonzogni@chromium.org,lowell@chromium.org BUG=1014925 Change-Id: Ie1185462dc0420dc2a4b1b16f93b22a649bb67ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865337 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#707207}
-
Nate Fischer authored
This componentizes the low-memory histogram provided by AndroidMetricsProvider, leaving the rest in the chrome-layer class. This renames the Chrome-layer class to ChromeAndroidMetricsProvider to distinguish from metrics::AndroidMetricsProvider. This registers the metrics provider with WebView. This does not add integration tests because https://crbug.com/1011991 is still unresolved. Bug: 1008534 Test: Manual - observe the MetricsProvider logic is called in AW Test: out/Desktop/metrics_unittests --gtest_filter=*AndroidMetricsProviderTest.* Change-Id: Ia8fed61c071f649032f40c6945c97a53e6544c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866270 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Vincent Boisselle authored
Currently, adding the synced user's birth year and gender to the UKM report is only allowed for unittests. The feature isn't allowed for browser builds that use the UkmService base class. TBR=treib@chromium.org,eugenebutt@chromium.org, Bug: 1010936 Change-Id: Icf81cfd3468cd53ce1fbe9e8f0ae252b59a21f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835689 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707205}
-
Justin Cohen authored
Bug: 987646, 1015113 Change-Id: If62dfade0113e2502529339aef967304bd66f726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865423 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#707204}
-
Jay Harris authored
Bug: 829689 Change-Id: I525854254fd2e9fc2bad57c87ffdaa9175e452a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865740Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#707203}
-
tby authored
Two small changes: 1. Add a new metric for whether we display any Drive files or not, as a canary for our model getting into a bad state. 2. Log the zero-state launch type even when the experiment is disabled, for easier baseline comparison. Bug: 1011221 Change-Id: Id85f418063b7bf1c5faab4b012071146686807e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863054Reviewed-by:Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#707202}
-
Kent Tamura authored
* ScriptedAnimationController kicks Document::FlushAutofocusCandidates Now ScriptedAnimationController takes into account of existence of autofocus candidates. * Document::FlushAutofocusCandidates needs to call UpdateStyleAndLayoutTree() for each of candidates. IsFocusable() needs up-to-date style. UpdateStyleAndLayoutTree() was unnecessary because FlushAutofocusCandidates() was called after layout. Bug: 1015275 Change-Id: I06dcb9b3cd2564d35fba3f893e7ce4b8736c91bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863067 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#707201}
-
Xinghui Lu authored
Interstitials are only shown for GSUITE and enterprise passwords. Bug: 1012084 Change-Id: I79dd08d39168d7fb034575915243f568a77d4622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845915 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
-
Shakti Sahu authored
This CL adds support for default pagination in download home. Bug: 1014319 Change-Id: Ia42ce1166bf58fc1b3126c8cc81a2f48ff45e429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839636 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#707199}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b97e8677d349..9fdb14b94056 git log b97e8677d349..9fdb14b94056 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 mmortensen@google.com Handle platform_version in packages.GetTargetVersions. 2019-10-17 guocb@chromium.org Revert "cros_build_lib.run: drop old signal workaround (reland)" 2019-10-17 vapier@chromium.org service: sysroot: fix logic bug with None Created with: gclient setdep -r src/third_party/chromite@9fdb14b94056 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0e7f41dbd131d08bc07cd9a5a3847ec5a62996cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867320Reviewed-by:
-
Nate Fischer authored
No change to logic. This inlines strings for the Dev UI, as we don't aim to translate them anyway. Inlining strings is preferable to translateable="false" entries in GRD files (see bug for rationale). This adds lint suppressions as necessary. Bug: 1014805 Test: adb shell am start com.google.android.webview/org.chromium.android_webview.ui.CrashesListActivity Test: Manually verify the UI looks right Change-Id: I67e66ced3ae7d9adbc61e68b92751e6865e1b0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866269Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707197}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 33e3bac4. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: If12369fdd0a07b95c2b1a51c507fcde23497b8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867355Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707196}
-
Regan Hsu authored
The End of Life Message contains the End of Life date that needs to be read out to pass a11y requirements. Bug: 993828 Change-Id: I874fcee726b10e720925995804768a1b3899acf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854016Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707195}
-
