- 15 Nov, 2018 40 commits
-
-
Jun Cai authored
The browsertest changes in the following CL is moved to this CL since it is not related to the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1323658/7/chrome/browser/chrome_browser_main_browsertest.cc This CL fixes the ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange browser test which failed on the release Builder linux64 machine. For more details, please refer to the following issue link. In the release Builder linux64 machine, the intermediate connection state is CONNECTION_ETHERNET, so in the test it needs to make sure the NetworkConnectionTracker's underlying network connection state is CONNECTION_NONE before it starts to run the actual test code. Bug: 902784 Change-Id: I16866f1fb0e8834dfa621930efa83aba26aa52d0 Reviewed-on: https://chromium-review.googlesource.com/c/1336433 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608457}
-
David Benjamin authored
TLS 1.0 and 1.1 are deprecated. See: https://security.googleblog.com/2018/10/modernizing-transport-security.html https://groups.google.com/a/chromium.org/d/msg/blink-dev/EHSnAn2rucg/oiu0DoQ0CAAJ As part of that deprecation, show a console warning in DevTools and also add a Blink-level UseCounter. (We typically measure things at the connection or request level for network features, but since we're plumbing this in anyway, go ahead and add one.) I mirrored the plumbing and UseCounters for Symantec certificates. Bug: 896013 Change-Id: I9b45e6264a2119b7b68a5a9f282dfd63a372210a Reviewed-on: https://chromium-review.googlesource.com/c/1324878 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608456}
-
Jonathan Metzman authored
Improve efficient_fuzzer.md by making the following changes: 1. Get rid of static corpus instructions (just use regular corpus) 2. Add details about authenticating to use ClusterFuzz buckets. 3. Eliminate extra newlines 4. Be consistent about the example fuzzer name 5. Mention dict should be ascii encoded Improve clusterfuzz.md by linking directly to coverage page and by linking to most recent stats. Change-Id: I9990ab8ab4811445214735e65a6e8d2bd2319179 Reviewed-on: https://chromium-review.googlesource.com/c/1323272 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608455}
-
Koji Ishii authored
When WTF::StringImpl is displayed in the VisualStudio debugger, and when the string is expanded, each character should be displayed, but each character is typed as StringImpl and that code points cannot be seen. This patch fixes it for both 8bit and 16bit cases. r603419 (CL:1288930) removed (wchar_t*) because local test did not show the differences, but it was because the natvis in the DLL was prioritized over the local natvis. When both files were fixed, the symptom was fixed properly. Change-Id: I68ff0f83456a4e99db803f7140b6e0d6a7630bba Reviewed-on: https://chromium-review.googlesource.com/c/1337671Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#608454}
-
Adrienne Walker authored
The linter gets mad at this when anybody changes this file because the line is too long, but there's no way to format this properly and not wrap, so just make the test name shorter. Bug: 805798 Change-Id: I41e052843d721c8c50becdb5425a376503b8889a Reviewed-on: https://chromium-review.googlesource.com/c/1336558Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#608453}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1ff7a8e7e55f..3189731cbd9e git log 1ff7a8e7e55f..3189731cbd9e --date=short --no-merges --format='%ad %ae %s' 2018-11-15 hjd@google.com Merge "Add tools/gen_all" Created with: gclient setdep -r src/third_party/perfetto@3189731cbd9e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9955787f24243b43b112f0de195a2e1b451fdff9 Reviewed-on: https://chromium-review.googlesource.com/c/1338143Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608452}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d098799efb32..eaddc34b5d48 git log d098799efb32..eaddc34b5d48 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 cbruni@chromium.org [telemetry] Simplify rethrowing in InspectorBackendList Created with: gclient setdep -r src/third_party/catapult@eaddc34b5d48 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I51a4900e23fc25b8d35f601ee70b6cc60b52278c Reviewed-on: https://chromium-review.googlesource.com/c/1338144Reviewed-by:
-
Jonathan Metzman authored
This should slightly improve performance and provide other benefits. Bug: 883948, 905708 Change-Id: I7b00ca2b398115c9a5eb5dca47dda70be2df6cc1 Reviewed-on: https://chromium-review.googlesource.com/c/1338174Reviewed-by:
-
Christian Biesinger authored
In Jan 2015 the spec changed in https://drafts.csswg.org/css-flexbox/#change-201409-align-content-wrapping Change our code accordingly. This effectively reverts commit crrev.com/290823003 and relands crrev.com/2191683003 align-content-wrap-004 is a test for bug 641789, which was a regression from the previous attempt at landing this patch. Bug: 599828 Change-Id: I8de127c19203854922eb23a626cee4de9a772f22 Reviewed-on: https://chromium-review.googlesource.com/c/1323906 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#608449}
-
Peter E Conn authored
Web App Manifest icons can have the MASKABLE purpose specifying they were designed with all of their important content sufficiently far from the edges to allow the User Agent to apply a mask [1]. This CL just adds code to read in that purpose, which will be used in upcoming CLs. [1] https://w3c.github.io/manifest/#purpose-member Bug: 904354 Change-Id: Ib62eb7af9226d14199d0d74615cb5bbf2666abda Reviewed-on: https://chromium-review.googlesource.com/c/1329792 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#608448}
-
Xianda Sun authored
Because the hit test query fuzzer generates hit test flags and async hit test reasons independently, it sometimes triggers a DCHECK that verifies correct reasons have been set when there is an asynchronous hit testing being performed. This CL fixes it by generating non-kNotAsycnHitTest reasons only when the fuzz flags contain kHitTestAsk. Bug: 905463 Change-Id: Ibf73d7138951af93b7fe2029242d6e062ff1a11d Reviewed-on: https://chromium-review.googlesource.com/c/1338139Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#608447}
-
Matthew Cary authored
This small change removes the KitKat restriction for manual listing of tests. Bug: 905230 Change-Id: Ib66544873017fd0c5261af0ad1d57358ea97a167 Reviewed-on: https://chromium-review.googlesource.com/c/1337493Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#608446}
-
danakj authored
When RenderFrameProxy::CreateFrameProxy() is called, it will 1) Make a RenderFrameProxy 2) Make a WebRemoteFrame 3) Swap out the RenderWidget on the RenderView 4) Give the WebRemoteFrame to the RenderFrameProxy This is called from RenderViewImpl::Initialize, or from an IPC from the browser via Mojo to RenderThreadImpl::CreateFrameProxy. In the latter case, it doesn't appear to remove the local main frame from the RenderViewImpl/RenderWidget. This is done by the browser destroying/detaching the main frame separately. But since detaching sets the LocalFrame to nullptr but does not SwapOut the RenderWidget, this call is required in RenderFrameProxy to do the SwapOut. At that time we should also stop the compositor. R=piman@chromium.org Change-Id: I24da561e14eea0e23e7e16d0af38f95279a27ed2 Bug: 896836 Reviewed-on: https://chromium-review.googlesource.com/c/1335661Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#608445}
-
Jacob Dufault authored
TBR=alemate@chromium.org Bug: 905109 Change-Id: I7be1cccec0a18ee7d6a664d736aa0ab55512911b Reviewed-on: https://chromium-review.googlesource.com/c/1338219Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#608444}
-
Sorin Jianu authored
Also, do not allow negative sizes. Bug: 881076 Change-Id: I254d52258f5902d5d8740e74be35012cdf2b43e4 Reviewed-on: https://chromium-review.googlesource.com/c/1336524Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608443}
-
Min Chen authored
Set the gesture event as handled if it can not be used to drag the window during window drag. Browser window is special since it has its own logic to handle the drag. Bug: 900959, 877976 Change-Id: I6a9416505da7fc92306ad5c364f4be04213dd992 Reviewed-on: https://chromium-review.googlesource.com/c/1332289 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#608442}
-
Sky Malice authored
RefreshThrottlerTest tests broke on the day daylight savings time ended. To fix this, set a TestClock's time to a specific date so the real date will never affect tests going forward. Removed all unittest usage of Time::Now in Feed code. Bug: 901698 Change-Id: I76b0b092aa12b7c4fef65a353caa317a381f32c1 Reviewed-on: https://chromium-review.googlesource.com/c/1324414 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#608441}
-
Vasilii Sukhanov authored
- When the dropdown is shown we record if password generation is available. - The type of the chosen suggestion is recorded. Bug: 883319 Change-Id: I69ac20b4022707cbcb57164b8718feecf85ab83a Reviewed-on: https://chromium-review.googlesource.com/c/1335605 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Shawn Gallea authored
Move keyboard extension out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: I15ea4ac7f9c5cabf9470d0478cd91a409c0b5e6a Reviewed-on: https://chromium-review.googlesource.com/c/1320028 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#608439}
-
Tatiana Buldina authored
Bug: chromedriver:2655 Change-Id: I8afab41743acd2d98e53b19e0bc11835c2025590 Reviewed-on: https://chromium-review.googlesource.com/c/1330837 Commit-Queue: Tatiana Buldina <buldina@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608438}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1147fc2..8f20452 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic5665d363a86d8e381b8c244af830951636025fe Reviewed-on: https://chromium-review.googlesource.com/c/1338166Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608437}
-
Aiden Benner authored
Fix bug where all custom ErrorProne checks were not running. Introduced by: https://chromium-review.googlesource.com/c/chromium/src/+/1252006/ Changing the jar wildcard from * to *.class excluded metadata files generated by Autoservice which were needed to load the custom ErrorProne checks. This CL reverts that pattern change. Bug: 904524 Change-Id: Id452f2d797872eb306fcd52be433128c8835e015 Reviewed-on: https://chromium-review.googlesource.com/c/1331877Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Tommy C. Li authored
On Desktop, with Query in Omnibox, the URL would flicker in for a second while the search page was loading and before it got its security state. This CL fixes that by ignoring the security state while the page is loading. This is the same solution that the Android implementation has. This CL also changes the ignore_security_state flag from a member variable the caller toggles on and off to an additional parameter that's passed in when the caller retrieves the query terms. Bug: 874592 Change-Id: Ic5b8c78798b0119a63b5934c956a6395e4e6d769 Reviewed-on: https://chromium-review.googlesource.com/c/1274896Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#608435}
-
Ramin Halavati authored
To investigate a crash on ChromeOS, fail safe code and reporting are added to EventRouter dispatcher and ChromeExtensionsBrowserClient. Bug: 870838 Change-Id: I8da1a56f80e247d68f26c8d8027f1eb36cea272f Reviewed-on: https://chromium-review.googlesource.com/c/1335594 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608434}
-
Mario Sanchez Prada authored
Remove any knowledge of AccountTrackerService, FakeSiginManager[Base], FakeProfileOAuth2TokenService and FakeGaiaCookieManagerService from ProfileSyncServiceBundle, and depend solely on IdentityTestEnvironment. Bug: 886600 Change-Id: I268bc85d70c164efa3b9650565b9de13c98f4b4b Reviewed-on: https://chromium-review.googlesource.com/c/1337618Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#608433}
-
Sorin Jianu authored
Bug: 881076 Change-Id: I9f9739197c903cce7b0814b54df4314d2917b6eb Reviewed-on: https://chromium-review.googlesource.com/c/1334969Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608432}
-
Erik Språng authored
Bug: webrtc:9890 Change-Id: If468bc7001228c55c8c610d1d88444da98365be1 Reviewed-on: https://chromium-review.googlesource.com/c/1338083Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Erik Språng <sprang@chromium.org> Cr-Commit-Position: refs/heads/master@{#608431}
-
Tom Sepez authored
The server never sees it, so it can't be part of a reflected XSS. It may be part of a DOM XSS, but XSSAuditor doesn't handle these, except for a few document.write() cases that aren't likely to manifest in the wild (but are hit by tests). Bug: 877347 Change-Id: I6835c7702d0a8db829f5fde17be15015112a5e13 Reviewed-on: https://chromium-review.googlesource.com/c/1336368Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#608430}
-
Jeffrey Cohen authored
Before this CL, when autofilling addresses, the company name was always filled in if it was specified as part of a country's address fields. However, we want to remove the company field from autofill. This is being rolled out via a Flag and finch config. The initial CL that addressed this in https://crrev.com/c/1315536 did not make any changes to the Android platform, but this CL updates the bridge between C++ and Java code to filter out the company field if applicable. Bug: 890972 Change-Id: I449603a1d6e8610bcab031c31807c39e7bea9cd1 Reviewed-on: https://chromium-review.googlesource.com/c/1330791 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#608429}
-
Lei Zhang authored
It is marked for deletion and has no callers. Change-Id: Iceb00f843a300c7dcb1d6925423227e9c17d49a3 Reviewed-on: https://chromium-review.googlesource.com/c/1337010Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#608428}
-
Dmitry Gozman authored
- Inline DidFailProvisionalLoadInternal to the callsites, and carefully avoid the logic which is only needed in one place. - Move EnableViewSourceMode(false) to the most inner method which is used for error page loading, since we were missing it in some call paths. - When committing failed navigation, we use the newly constructed "failed_request" instead of taking one from the provisional loader. At some point, there will be no provisional loader to take the request from, so we might as well switch right now. Bug: 855189 Change-Id: Idf9eba3c3014c1e68a860ceff6051f1ff576062c Reviewed-on: https://chromium-review.googlesource.com/c/1332700Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608427}
-
Yi Su authored
Clean up old fashion code in find_in_page.js to make it easier to fix the bug. Bug: 228585 Change-Id: If19a58773bb3d054116afd935bfc0a72942ea4a5 Reviewed-on: https://chromium-review.googlesource.com/c/1327206Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608426}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1315333b6bfb..abaffd85abb7 git log 1315333b6bfb..abaffd85abb7 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 caryclark@skia.org bookmaker does deprecated 2018-11-15 mtklein@google.com lookup received factories directly Created with: gclient setdep -r src/third_party/skia@abaffd85abb7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Idb2583e5d7a10f1b2ddadf62c1eeb690e15410e7 Reviewed-on: https://chromium-review.googlesource.com/c/1337480Reviewed-by:
-
Mario Sanchez Prada authored
Replace usage of PO2TS APIs with calls to IdentityManager's methods. Bug: 904412 Change-Id: I0543f8e4c78a5b19915933082f9f9074dcb4d7d8 Reviewed-on: https://chromium-review.googlesource.com/c/1338082Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#608424}
-
Thiemo Nagel authored
Extend the prohibition of logging PII to user data in general and add some examples. Bug: none Change-Id: I6fc97b2e3aaf404ba5e5622037a6c748a4e470ca Reviewed-on: https://chromium-review.googlesource.com/c/1335571Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#608423}
-
Xiaocheng Hu authored
This patch changes |StartOfSentence()| to utilize |TextSegments| class to make it work with LayoutNG. Bug: 778507 Change-Id: I462e99f3a3c5cf84dfeab67cc324d985478ed570 Reviewed-on: https://chromium-review.googlesource.com/c/1335959 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608422}
-
Doug Arnett authored
Bug: 902802 Change-Id: I4bdb916804f83f16eef10125d37c29fd1469566d Reviewed-on: https://chromium-review.googlesource.com/c/1336552 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#608421}
-
Justin DeWitt authored
This makes blacklisting work even when the URL is well formed but not canonical, for example if the trailing slash is missing. Bug: 902626 Change-Id: Ibced76fd3ad19248d50fc088cc3e54f7ee5ef9af Reviewed-on: https://chromium-review.googlesource.com/c/1336511Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#608420}
-
Koji Ishii authored
This patch adds IsEmptyLineBox() function that returns whethe the line box is "empty", or "certain zero-height line box" as defined in CSS2[1] or not, and change where we used to determine it by checking if the number of children is 0. [1] https://drafts.csswg.org/css2/visuren.html#phantom-line-box Bug: 636993, 903578 Change-Id: I2b9961e1ecb743063238b39a3a5be53f15ffce8c Reviewed-on: https://chromium-review.googlesource.com/c/1332972Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#608419}
-
Joe Mason authored
R=csharp@chromium.org Bug: 830892 Change-Id: I13ef01f4194bc747b4c9ea28537a188aa9315c49 Reviewed-on: https://chromium-review.googlesource.com/c/1336067 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608418}
-
