- 11 Nov, 2020 40 commits
-
-
Thomas Lukaszewicz authored
A cached WebView's WebContents in WebUIBubbleManager may not necessarily be in a visible state that enables processing of rendering events. Call WasShown() before reloading to ensure the WebContents propagates these events and ShowUI() is eventually called. Bug: None Change-Id: I810b2e10e286e8cca1948ee6aab014efa843db86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530192Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#826148}
-
Yuheng Huang authored
This change makes close tab more efficient. According to the performance benchmark https://pinpoint-dot-chromeperf.appspot.com/job/15a9cbdd520000 It reduces close tab latency from 105ms to 37ms. Bug: 1099917 Change-Id: I987a98006d5b8788af8ab844a8871458a620b20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527625 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826147}
-
Dana Fried authored
This CL adds messages for all cases where the user keyboard focuses a tab and uses CTRL+[SHIFT+]RIGHT/LEFT to move the focused tab. Messages include: - Tab moved right/left/start/end - Tab added to/removed from group Currently there is no feedback if the tab cannot be moved. We can always add some. Note: no screenshots because these are announce-only messages. Bug: 1110426 Change-Id: I7ac14e840769a54304e128ce809823b7231f9ec2 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530733Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#826146}
-
Yoichi Osato authored
It is flaky: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome We should use async semantics rather than wait runloop at GetPlugins(). TBR=sky@chromium.org BUG=1147726 Change-Id: I003bee856004e0f7476cf008429d68284776173f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531418Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#826145}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5db9eeec2f2e..45bafa0558b1 2020-11-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4dcc83ad10e6953abcdb6edb69c5eb07b1f3e69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531068Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826144}
-
Jérémie Boulic authored
In //ui/file_manager/image_loader: - load_image_request.js - image_loader_client.js - image_loader_client_unittest.js Bug: 1133186 Change-Id: Iaef19a8bcafc298d8e91cd398b92e3fc881dda6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531335 Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#826143}
-
Findit authored
This reverts commit ee2f8113. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 825930 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWUyZjgxMTM1MTFjZTRiNzE5YzAwNTA4OTFjMzJjNGZiMWJlMzM2ZAw Sample Failed Build: https://ci.chromium.org/b/8863960967178909888 Sample Failed Step: blink_web_tests on Mac-10.15 Sample Flaky Test: external/wpt/webauthn/createcredential-resident-key.https.html Original change's description: > webauthn: move create credential tests for residentKey/credProps to WPT > > Bug: 1117630 > Change-Id: I2fa4d73b7a4cfe5e7f19fd835cb32e1bb4926d2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508878 > Reviewed-by: Nina Satragno <nsatragno@chromium.org> > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#825930} Change-Id: I54688bd7288995c66a1a361f361e6c1694e1378d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1117630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531219 Cr-Commit-Position: refs/heads/master@{#826142}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/metadata: - byte_reader.js - exif_constants.js - external_metadata_provider.js - external_metadata_provider_unittest.js - file_system_metadata_provider.js - file_system_metadata_provider_unittest.js - function_parallel.js - function_sequence.js - image_parsers.js - metadata_cache_item.js - metadata_cache_item_unittest.js - metadata_parser.js - mpeg_parser.js In //ui/file_manager/externs: - metadata_worker_window.js Bug: 1133186 Change-Id: I78221a455d67da3662cb7a0317eb12c01f7aef46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529371 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Peter Kasting authored
This seems safe and correct and hopefully fixes the ClusterFuzz issue. Also separates the failing CHECK into pieces so if this _doesn't_ fix the problem I can more easily see why. Bug: 1136149 Change-Id: Ic974940335fd03204ff1a1fee720ac85fe130f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522572 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#826140}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605020074-68960f639156f9ccbd07438455ce3664424ac683.profdata to chrome-win64-master-1605041937-1449424af661a723772729965b60b3f566868499.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I406fcc0437f499c7913a063c7f81d7de26982453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530978Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c80cb7a957ea..994d3835f535 2020-11-11 bsheedy@chromium.org [typ] Fix ResultSink unicode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1147329 Tbr: oysteine@google.com Change-Id: Ib7a7c48f3e1c1d95d57e1193095b5349aea324a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530627Reviewed-by:
-
Min Qin authored
pdf viewer If chrome is not the default pdf viewer, clicking on a pdf will trigger a download. After download completes, Chrome will invoke the system viewer to auto-open the pdf file. However, the system viewer might be chrome itself, and that will trigger downloading the file URL, and causing an infinite number of download. This CL fixes the issue by blocking the pdf download if it is a file URL. An alternative to fix the issue is to block the auto-open if Chrome is not the default pdf viewer BUG=851650 Change-Id: Ie12105408f80650463a6eae4f57cb6de23d1a875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531217Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826137}
-
Emily Stark authored
This CL adds a new Safety Tips feature flag which enables lookalike Safety Tips, specifically for the purpose of measuring how Simplified Domain Display behaves. This is necessary because multiple Finch experiments can't enable the same feature at the same time, and it's possible that we'll be running separate Safety Tips and Simplified Domain Display experiments at the same time. Ordinarily this would run the risk of muddying our data between the experiments, but since Safety Tips are only encountered very rarely, and we specifically filter out users who see multiple Safety Tipped sites in our experiment metrics (as they are outliers), we don't anticipate this to be a problem. Bug: 1146471 Change-Id: I033476e8e1cb3fb4afc2c7a1f8669ea28b2c7b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530253Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#826136}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81e9301838fc..6835e1ab1918 2020-11-11 chinglinyu@google.com Merge "traced: fix permissin check of /run/perfetto as default socket basedir" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ida4c6d855dd982d73cd1f9269884ee213635e354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531246Reviewed-by:
-
chrome://devicesrbpotter authored
The page has been behind a flag that is disabled by default since M86. By the M88 Stable release, cloud print will be turned down, so this page for adding new cloud printers will no longer be needed. Bug: 1112576 Change-Id: Ibc12a7180c268f5c91153d5c44ae615779b0f88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516245 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#826134}
-
Clark DuVall authored
Bug: 949535 Change-Id: Iec2190a535baa03e581757977310e067cde3c953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527734Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826133}
-
Chris Lu authored
Bug: 1138603 Change-Id: Ie4a57e74d125ea064368e74f2e49f7c2548bfc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527007 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#826132}
-
Adrienne Walker authored
This fixes issues from: https://chromium-review.googlesource.com/c/chromium/src/+/2446889 Bug: 1131151 Change-Id: I2d78538c1b6cd4e6cd2b1070e11fb1e024168dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530904 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#826131}
-
Josh Nohle authored
Record the furthest each discovery session progresses before ending. A discovery session starts when the share-target discovery UI appears and ends on failure, cancellation, or when a transfer completes. We also track the results of the individual steps in the discovery flow: starting discovery, finding share targets, and beginning a transfer to the share target. Bug: 1105579 Change-Id: I52e34b0a09c54a37f7d76aa1480cbce18e905d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524980 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#826130}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8da8bcdf92fb..81e9301838fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic4e30824f934a07eb1430903432cf8857725eb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530213Reviewed-by:
-
Jeevan Shikaram authored
This CL checks to see if the the payment method is supported and if there is an APK that will be able to handle the request. Bug: 1137688 Change-Id: I93508af961fade71a584b54a76b13c610f8e3a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528809 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#826128}
-
Charlie Hu authored
Previously parse of 'Permissions-Policy' HTTP header still reports parsing error with 'Error with Feature Policy: '. This CL lets parse of 'Permissions-Policy' HTTP header use a separate logger that has prefix 'Error with Permissions Policy: '. Note: Previously merge of feature policy and permissions policy was implicit, i.e. done by concatenating the two together and relying on the parsing rule that first occurrence of feature wins. This CL makes the merge explicit in |FeaturePolicyParser::ParseHeader|. Change-Id: I25f877899aa709705fb96b6a6cfe003dedd217d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514961Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#826127}
-
Yoichi Osato authored
It is flaky: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel?limit=100 TBR=rbpotter@chromium.org BUG=1147205 Change-Id: Ic17a9f40d98f18a597d7ec353d78ff3ebe5afdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530957Reviewed-by:
-
Jesse Schettler authored
Replace the string for the helper text with the newest string and update the styling to match the spec. Bug: 1059779 Change-Id: I7b2ba855f0a34107b5c62ca1cb9f7f659c2e96fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530216Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#826125}
-
Christopher Lam authored
This CL centralizes the definition of the above variables into grit_defines.gni to reduce boilerplate across the codebase. TBR=thakis@chromium.org,boliu@chromium.org,oksamyt@chromium.org,gambard@chromium.org,khorimoto@chromium.org Bug: None Change-Id: I76aba8bcdc0a6d1613de1a8c961f85e95baecbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489102Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
- Adds response to click event when no network found link is clicked in esim and psim internet subpage groups. Bug: 1093185 Change-Id: Ib37f7806c19b8cf62517909d64f0570b190d615d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515362 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#826123}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Icdf421e7d07aa3756f81d412f71f8f66eb4a9064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531296Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826122}
-
Rakina Zata Amni authored
Currently MimeHandlerView sandbox errors (trying to load in a sandboxed iframe) triggers a new navigation within a renderer, not notifying the browser until it finished committing in the renderer. We want to remove cases where the renderer starts navigations and not notify the browser until the navigation committed. See doc for more context: https://docs.google.com/document/d/1UjdxiDJ3sgVDbp0CZpsSntdwAYNMSfc2qajX4nzXfLY/edit?usp=sharing This CL moves the sandbox error navigation to be triggered from the browser side instead by checking the sandbox flags before committing. Bug: 1133115 Change-Id: I3c56574e36ac5115eb51df126ae19adc678a404b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449669 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826121}
-
Joshua Peraza authored
Bug: 1050178 Change-Id: If99330fbef9978211dae0aacd038f4c5cefb83e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825326Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#826120}
-
Nidhi Jaju authored
In this CL, the typedef for ReadableStreamReader is added to the Readable Stream WebIDL file based on the Streams API Standard[1]. In order to avoid confusion, the ReadableStreamReader class is also renamed to ReadableStreamGenericReader. This also makes more sense as the base class for the Default and BYOB Readers. Furthermore, the return value of getReader() is also changed to use the ReadableStreamReader typedef. Due to how the bindings code works, this meant that the return type of getReader in the C++ implementation also had to be changed to void and pass the ReadableStreamReader as a parameter, which is set as the returned reader. Lastly, a new function called GetDefaultReaderForTesting() is added to support calls to getReader() and read() in the various test files without having to change the return type everywhere. [1] https://streams.spec.whatwg.org/#typedefdef-readablestreamreader Bug: 1093862 Change-Id: Icbb34470f52ddcef53e9b1fa34f3dd8f27c48198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524628 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#826119}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1fe2b80dc782..7006e15df59d 2020-11-11 fmalita@chromium.org [svg] Allow clients to pass a custom SkFontMgr 2020-11-11 brianosman@google.com Make runtime effect error tests simpler / more explicit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I24246faa0927a852186a916a67c1b77f5b4247f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531244Reviewed-by:
-
Joel Hockey authored
Change-Id: I9a84bfe3d5b0261353c19fb0120cc84dbf999aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531074 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#826117}
-
Ian Kilpatrick authored
Due to a HTML specification change, the default UA stylesheet for modal dialog elements has changed: https://github.com/whatwg/html/pull/5936/files https://chromium.googlesource.com/chromium/src/+/be7281e188f22856bf9084d9f5c74a0f48eee1da Specifically for this bug - position:fixed and position:absolute have slightly different behviour when printing. This switches the internal <dialog> element back to position:absolute. Bug: 1147394 Change-Id: I8a41ef869cd6a17db0c79ba42ca3d5a5eb247d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531215Reviewed-by:
-
Jeremie Boulic authored
This reverts commit 17c5fc75. Reason for revert: Due to a mistake when rebasing, 2 CLs were submitted at the same time. Relanding those 2 CLs properly. Original change's description: > Audio player: Convert dependencies in //ui/file_manager/image_loader/ > > In //ui/file_manager/image_loader: > - load_image_request.js > - image_loader_client.js > - image_loader_client_unittest.js > > Bug: 1133186 > Change-Id: If1fa276446e2ae5a8763ca1a9bb728cb0c7ce2b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529649 > Commit-Queue: Jeremie Boulic <jboulic@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826095} TBR=lucmult@chromium.org,jboulic@chromium.org Change-Id: I11e659413196563811d843635a829d0b1a642b2d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531438Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826115}
-
Sammie Quon authored
Only for tablet mode. Like other capture mode entries, not available for login/lock/oobe. Bug: 948120 Test: manual Change-Id: I37ece1da0a48268507907fed4a713d2c4fb882fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530980 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826114}
-
Aleks Totic authored
LayoutTableSectionInterface::PrimaryCellAt was no longer used, and was removed. Bug: 958381 Change-Id: I53ca91c87db0025d077c969e75d1c66a53aa6e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528829 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#826113}
-
Dana Fried authored
CTRL+RIGHT with keyboard focus on a tab will now always move the current tab right, and CTRL+LEFT will move it left. Likewise, CTRL+SHIFT+RIGHT will always move the current tab to the right end of the tabstrip, and CTRL+SHIFT+LEFT will move to the left end. Prelude to fixing the attached bug. Bug: 1110426 Change-Id: Ib29d539db982b9b970ea192ca9edb13b18ca7d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528179Reviewed-by:
-
Moe Ahmadi authored
- takes 4px off the top padding of the tile and gives it to the bottom padding. - takes 4px off the top margin of the title pill and gives it to the top/bottom padding of the title pill. before: screenshot/4aAFKmpkL76Qjam after: screenshot/8MXKqLJgqyFSxz7 Fixed: 1147217 Change-Id: I59fcfa419c725b5c2f7ddbfefda6d233595494e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530202 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826111}
-
Tommy Li authored
In 2015, we ran an experiment called KeywordRequiresPrefixMatch = false, where we experimented with a query "wikipedia.org" being able to trigger the "en.wikipedia.org" keyword mode search engine. This experiment has been dormant since then. The TemplateURLService has a reasonably extensive amount of infrastructure to support the non-prefix matches to domain name, and this CL removes that. We are removing this to simplify the code and unblock a larger issue where we are trying to solve Sync conflicts and duplicate search engine proliferation, e.g. "amazon.com" => "amazon.com_" duplicates. Bug: 1022775 Change-Id: I9cc92f06c2fe955ddc655bdef23955ab33418faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523726 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#826110}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b4f4226d153e..cf49cb8206ba 2020-11-11 ehmaldonado@google.com [presubmit][owners] Skip owners check when Owners-Override is +1 2020-11-11 ehmaldonado@google.com [presubmit][owners] Skip owners check when Bot-Review is +1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093627 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia73086dd8f57646d67b704f31d921597d821440f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530225Reviewed-by:
-
