- 29 Oct, 2018 40 commits
-
-
Dmitry Gozman authored
1) Use blink::DevToolsAgent in WorkerInspectorController. This replaces the ad-hoc interface for communicating with worker's debugger with a mojo interface used for frames and shared/service worker's shadow pages. 2) Create WorkerDevToolsAgentHost. This is similar to other agent hosts, keeps itself alive while the corresponding worker is alive, and reuses DevToolsSession machinery for inspection. 3) Report dedicated workers to the browser process when auto attach is on. mojom::DevToolsAgentHost is now notified about child workers and gets their DevToolsAgent interfaces to debug in the future. 4) Add TargetHandler to service/shared/dedicated worker sessions, to handle communication with nested dedicated workers. 5) Retire WorkerInspectorProxy and ExecutionContextWorkerRegistry. These are covered by DevToolsAgent now, which reports to it's host. 6) Retire InspectorWorkerAgent, which is replaced by WorkerDevToolsAgentHost on the browser side. The benefits are: - unified interface for inspecting any entity including workers; - workers now support flatten mode of operations; - all inspection targets are now listed on the browser side and represented with DevToolsAgentHost, which allows for further simplification; - less abstractions - we can even get rid of InspectorSession now. Bug: 775132 Change-Id: Ib4f58677a81ce48d4c2382f05d1166f730a2e2c3 Reviewed-on: https://chromium-review.googlesource.com/c/1183589 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603652}
-
Etienne Bergeron authored
This CL is adding events from the following CL to the whitelist. https://chromium-review.googlesource.com/c/chromium/src/+/1302865 TRACE_EVENT1("ui", "QueryLinkedFontsFromRegistry", "results", logging_str); TRACE_EVENT1("ui", "CachedFontLinkSettings::GetLinkedFonts", "font_name", font_name); R=oysteine@chromium.org Bug: 867931 Change-Id: I89b62a35036a67d1f0f5bf1f490ad476f0586ca3 Reviewed-on: https://chromium-review.googlesource.com/c/1302816Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#603651}
-
Mason Freed authored
Test made flaky by --enable-display-compositor-pixel-dump NOTRY=true TBR=dmazzoni@chromium.org BUG=895912,899458,899548 Change-Id: I49448b807c1fe6b06d8c2b7ce92253b7662b36de Reviewed-on: https://chromium-review.googlesource.com/c/1306633Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#603650}
-
Daniele Castagna authored
Computing background blur at full resolution as a backdrop filter turned out not to be cheap. This patch adds a backdrop_filter_quality float to cc::Layer that can be used to reduce the size of the offscreen canvas used to compute the blur. Currently this float is not exposed on the web and can be used only from Chrome UI. Bug: 897369 Change-Id: Ia070772ba576b37a8ee399c3c70b3e2308397e41 Reviewed-on: https://chromium-review.googlesource.com/c/1300235 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#603649}
-
Theresa authored
* Move publisher line to the top * Increase leading * Increase sheet half height from 65% to 75% of screen height BUG=896950 Change-Id: I2530151064545ac89ad38b859fffdee7285f8ae3 Reviewed-on: https://chromium-review.googlesource.com/c/1302332 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603648}
-
Koji Ishii authored
One suspect for issue 896456 is where ShapingLineBreaker fails to move offset forward. If this occurs, NGLineBreaker is likely to keep adding NGInlineItemResult of zero-length until all the memory is consumed. This patch turns DCHECK to CHECK to see if it is happening. Change-Id: I8a7355ec32e823e7ab517d2a3754c2fcc2104b3a Bug: 896456 Reviewed-on: https://chromium-review.googlesource.com/c/1304182Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#603647}
-
Robert Ogden authored
Makes one reusable macro for disabling the tests on Windows and Mac, instead of having to define a new one each time. Bug: 894854 Change-Id: Ic01ec8e6bea07b76a3e0dceec62084b5c6321256 Reviewed-on: https://chromium-review.googlesource.com/c/1306398Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#603646}
-
Koji Ishii authored
This patch updates |start_index_| when there are no runs, because it is generally done when a new run is inserted. This is a speculative fix. While I hit a DCHECK because of uninitialized |start_index_| once, I cannot reproduce consistently, nor in unit tests using the string I hit in the debugger on http://switchsoku.com/soft/splatoon2/28757 . Bug: 896456 Change-Id: I6b1f65e770ebe7e8d2156a9056d7e57666d61d31 Reviewed-on: https://chromium-review.googlesource.com/c/1304276Reviewed-by:
-
Scott Violet authored
EventInjector::InjectEventNoAck() goes through EventRewriters (which is what happens when the event is received from the system). Accessibility code needs to send events in such a way that they do *not* go through rewriters. This patch adds such a function. BUG=876043 TEST=covered by tests Change-Id: I041d433ea5114420f1f98718d9d542947c11dedd Reviewed-on: https://chromium-review.googlesource.com/c/1302867Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#603644}
-
Mike Dougherty authored
The native console methods must be called in order for messages to be logged to Safari Developer Tools. Bug: 899851 Change-Id: I3c1222ad890d490cb6b2212dc6783dcadc1da7f6 Reviewed-on: https://chromium-review.googlesource.com/c/1306114Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#603643}
-
Koji Ishii authored
This patch fixes line-height quirks mode to include strut for close tags only when the end-side of the inline box is not empty. It used to include when |needs_box_fragment|, which is set under many more conditions. Normally, when the emptiness (and thus the strut) matters, open and close are in the same line. <span><br></span> or <span><div></div></span> can make this situation. It involved two more changes: 1. NGInlineItem.IsEmptyItem is used to determine the block emptiness, while NGLineBreaker had another code to determine line emptiness, using slightly different conditions. The two logics were merged, stored in NGInlineItem. 2. It revealed a problem in 'vertical-align' where it does not include inline boxes for 'top' and 'bottom' align. This is fixed in this CL. Bug: 636993 Change-Id: I2d609580c96371e702dd365737e8d704b0fcccd8 Reviewed-on: https://chromium-review.googlesource.com/c/1302173Reviewed-by:
-
Brian Osman authored
Change-Id: Iee063790e4d30b87550ee75fc0a51fa86daaff57 Reviewed-on: https://chromium-review.googlesource.com/c/1305499Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#603641}
-
Stephen Martinis authored
I was reading through the file, and I re-read this comment I know I wrote in the past, and was a bit confused. Re-write the comment to be a bit clearer. Change-Id: I71c97cddf2e4520d00aff045bc18006432b02ea3 Reviewed-on: https://chromium-review.googlesource.com/c/1302098Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#603640}
-
Robert Sesek authored
An errant or malicious process could send Mach messages with extra descriptors. While the message wouldn't be processed, it would cause the rights to leak in the browser. When handling a request, add additional checks for the msgh_id and msgh_size. If the message does not pass muster, or it is from a process that is not expected, ensure any rights contained within are destroyed. Change-Id: If333372c72cb20d99713c78d5451c04a3321113f Reviewed-on: https://chromium-review.googlesource.com/c/1305394 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#603639}
-
dpapad authored
Previously content was pushed outside of the toast's boundaries. Bug: 899147 Change-Id: I0f235ff6cff1c52b3505f6ffd9c5dc5e7bfb0a68 Reviewed-on: https://chromium-review.googlesource.com/c/1305212Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#603638}
-
Eugene But authored
Bug: 899779 Change-Id: I56f9f472f098bb5ab237180e626518ffbe5368c1 Reviewed-on: https://chromium-review.googlesource.com/c/1305313 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#603637}
-
Jordan Demeulenaere authored
This CL makes some UI improvements to match the latest UI mocks. The logic is the following: whenever a script should be highlighted, all chips are inflated as buttons and aligned on the right, in a reverse order (as shown in 2)). Otherwise, chips are inflated as assistive chips (as shown in 1)). 1) https://screenshot.googleplex.com/xc5kziwqqwj.png 2) https://screenshot.googleplex.com/tZisUAwb7aZ.png Screenshots: Bug: 806868 Change-Id: I8e187204cf38e79affb8737cbe0ac1207072b04c Reviewed-on: https://chromium-review.googlesource.com/c/1304553 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#603636}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I21f43b6f7c06c4fb638d6affa7b42e33167c11c4 Reviewed-on: https://chromium-review.googlesource.com/c/1304187Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#603635}
-
Sergey Ulanov authored
Scenic now expects allocation_size to be set for VMOs. That parameter wasn't set in chromium, so Scenic would fail when trying to use VMOs for images. Bug: 899922 Change-Id: I73c7c7dfa4d4a5e9ba76774c4b69d8125add05c2 Reviewed-on: https://chromium-review.googlesource.com/c/1306174 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#603634}
-
Becca Hughes authored
At the moment there can only be one custom notification view factory which is currently used for ARC. This adds a `custom_view_type` to Notification which can be used to differentiate between different factories. This is part of the media session notification work as we would like to show a notification with media controls and this requires having our own custom view. BUG=897836 Change-Id: I68ffadb3e6e04422a5522fdf302652046a9c5b0f Reviewed-on: https://chromium-review.googlesource.com/c/1294417 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#603633}
-
Yuly Novikov authored
TBR=kbr@chromium.org Bug: angleproject:2941 Change-Id: I041f83bab21f523a12b872e34c7a8b502b163794 Reviewed-on: https://chromium-review.googlesource.com/c/1305240Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Adam Langley authored
These devices are obsolete and undocumented. We can't parse the reply from them to replace the attestation so registration always fails when replacement is needed. Rather than fail, this change allows v1 devices to return their reply unaltered so that accounts.google.com can tell the user that they need to reflash the device. Change-Id: Ic3b41210bc7d167b9fe5b9285946b9a9b834d0f8 Reviewed-on: https://chromium-review.googlesource.com/c/1302702Reviewed-by:
Martin Kreichgauer <martinkr@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#603631}
-
Fady Samuel authored
It's no longer used. Bug: 893850 Change-Id: Ibbd613affd364dac728cf00230e0b017dde7d70f Reviewed-on: https://chromium-review.googlesource.com/c/1305882Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#603630}
-
Wei Li authored
Use user action metric UI_DevTools_Connect to record each time a connection to UI DevTools server is established. The frequency of such connections would help us gauge the usage of the UI DevTools. BUG=746562 Change-Id: Icd54da4f23b3cc0268113de48931a803af53632c Reviewed-on: https://chromium-review.googlesource.com/c/1299007 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#603629}
-
Anders Hartvoll Ruud authored
As of an imminent spec change, <color> values no longer compute to their specified value, but behave like <color> values in general. Note that color keywords are parsed as CSSIdentifierValue (holding a CSSValueID), and custom idents are parsed as CSSCustomIdentValue (holding a String), which is why the "tomato | <color>" works as it should. R=futhark@chromium.org Bug: 641877 Change-Id: I946536a9d54dbaa7af589cb99acdba72f37fe016 Reviewed-on: https://chromium-review.googlesource.com/c/1303365Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#603628}
-
Eric Karl authored
As written, the allowed namespace/classes list in audit_non_blink_usage.py does not allow for classes in the features:: namespace to be used. These are already frequently used in blink/renderer, however as they are almost always preceded by base::FeatureList::IsEnabled, and the checker only checks the first match on a line, they were previously ignored. This issue was encountered when trying to add a longer features::.+ element that was wrapped to the next line. However, moving any existing features::.+ string to its own line will trigger this issue. This seems like an oversight as the features:: namespace is already in common use in blink/renderer, and base::Feature.* is allowed already. Adding in features::.+ as well. Bug: 899415 Change-Id: I56d453e102988b463d91850d5aa843c93c274517 Reviewed-on: https://chromium-review.googlesource.com/c/1303395Reviewed-by:
-
David Bokan authored
This reverts commit f51a68b0. Reason for revert: breaks scrolling on some pages: https://crbug.com/899161 Original change's description: > Convert scrolling code to use Node > > In https://crrev.com/9f54d240af5d366b1d6a4d9b84438192a9f0a11c we moved > ScrollCustomization from using Elements to Node. This allows us to use > Nodes in the scrolling code which is much more natural since the > viewport scrolls using the LayoutView (document Node)'s scrollable area. > > The main change in this CL is letting the Document node be part of the > scroll chain, instead of using the documentElement in its place. This > removes some special-casing all the way through the scrolling pipeline. > > As a result the Global Root Scroller now sets the viewport scroll > callback on the document node. > > Bug: 897288 > Change-Id: I899e6007b676efb94675d94b3d97702c8f1f2a94 > Reviewed-on: https://chromium-review.googlesource.com/c/1299205 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: Steve Kobes <skobes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602935} TBR=bokan@chromium.org,skobes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897288,899161 Change-Id: Ic75c23a1bcde6d86e554c2b5bdb5548b37d57e5f Reviewed-on: https://chromium-review.googlesource.com/c/1305820 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#603626}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/12048c71501a..a0677d14c17f git log 12048c71501a..a0677d14c17f --date=short --no-merges --format='%ad %ae %s' 2018-10-29 Peter) Slatala Add MediaTransportSettings struct for configuring media transport. Created with: gclient setdep -r src/third_party/webrtc@a0677d14c17f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6b14125d7bfd82b22459e9ea8391576692453b73 Reviewed-on: https://chromium-review.googlesource.com/c/1305293Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603625}
-
Akihiro Ota authored
Talkback would previously report nesting level for single-level lists, which was considered unnecessary. Added functionality in the IsHierarchical() method to determine if a list contains other lists, or if it is contained within a list, to help determine if it is hierarchical. Also modified DumpAccessibilityTree test expected output files to check for new desired behavior. R=dmazzoni@chromium.org Bug: 591255 Change-Id: Idd995c5fae426b191825996cf02ee51bd6753607 Reviewed-on: https://chromium-review.googlesource.com/c/1300076 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#603624}
-
Koji Ishii authored
This patch revives the lost code during the refactoring in r603011 (CL:1299609). Bug: 834653 Change-Id: Ibbe49c00eb3623f5bcefbcfda28651400cc81090 Reviewed-on: https://chromium-review.googlesource.com/c/1304282 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Evan Stade authored
Tests fixed in 7768d47c Behavior fixed in 9cfb85d4 Bug: 640365 Change-Id: I92d955c5c450d672f5d8c6fd263c44169051eb66 Reviewed-on: https://chromium-review.googlesource.com/c/1303235Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#603622}
-
Peter Boström authored
This experiment is no longer intended to roll out and never made it past Dev / Canary. This change removes the animated icon from BrowserAppMenuButton and removes supporting classes. Bug: chromium:738608 Change-Id: I69e29ba29e4689b88913fcf17aff3d83eede5d81 Reviewed-on: https://chromium-review.googlesource.com/c/1299923 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603621}
-
Erik Språng authored
This CL adds support for the new GetEncoderInfo() method which will replace GetScalingSettings(), SupportsNativeHandle() and ImplementationName(). These methods will be removed in a follow-up cl. It also removes assignment of CodecSpecificInfo.codec_name, which is also going away. Bug: webrtc:9890 Change-Id: I9d910dde4fefb054a04f9585579992f1cfc696c6 Reviewed-on: https://chromium-review.googlesource.com/c/1301514Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Erik Språng <sprang@chromium.org> Cr-Commit-Position: refs/heads/master@{#603620}
-
David Bienvenu authored
This implements native window occlusion tracking on windows, under flag/experiment control. It uses WinEvent event hooks and EnumWindows to track and calculate occlusion. It is not yet hooked up to the code that treats occluded windows differently. Bug: 813093 Change-Id: Ic9b473b8cad38e7b1653566f28917164bc92e21c Reviewed-on: https://chromium-review.googlesource.com/c/1140752 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d65cf959e1d..b0874f87a68d Created with: gclient setdep -r src-internal@b0874f87a68d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790153,chromium:790158,chromium:790159,chromium:790163,chromium:790153,chromium:790158,chromium:790159,chromium:790163 TBR=mmoss@chromium.org Change-Id: I5ba0f9c3d55238531d4ebc835f60270386cd5702 Reviewed-on: https://chromium-review.googlesource.com/c/1305251Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603618}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ca9994a1..bb933756 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f1cb9400d33ca060da14987d4b375514b492a7d Reviewed-on: https://chromium-review.googlesource.com/c/1305210Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603617}
-
Vlad Tsyrklevich authored
This allocator is adapted from the GuardedPageAllocator in tcmalloc. The allocator is intended to be a 'debug' allocator to help catch memory errors like buffer overflows and use-after-frees. It does so by giving allocations an entire page and left- or right- aligning them between guard pages (to catch both underflows and overflows). It also sets pages inaccessible once they have been freed to detect use-after-frees and can also detect double frees. Forthcoming changes add an allocator shim to sample allocations to this allocator and to add additional debugging context when crashes due to GWP-ASan occur. GWP-ASan is going to be launched on Windows first; however, if it’s successful it will be ported to other platforms (and therefore also be used by different embedders.) Bug: 896019 Change-Id: I358e1b6f91569d1d448fc7ee16d5df27ed2467aa Reviewed-on: https://chromium-review.googlesource.com/c/1284699 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#603616}
-
Fabrice de Gans-Riberi authored
This adds the http service package to a new CIPD archive. Bug: 874155 Test: Locally, build still works. Change-Id: I44937c496a1af342d0bf7f67581cef4c0fb83cb9 Reviewed-on: https://chromium-review.googlesource.com/c/1300674 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/25224e786ffe..0da64b5e1009 git log 25224e786ffe..0da64b5e1009 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 tobine@google.com Add build-id to tests for Android Created with: gclient setdep -r src/third_party/angle@0da64b5e1009 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I0fdce42fd43316ffe506372fe4c3cc107ca033ec Reviewed-on: https://chromium-review.googlesource.com/c/1305894Reviewed-by:
-
Mark Pearson authored
It's enabled by default these days. Bug: 783500,364301 Change-Id: I72cedea29df687672bcc4e3a87cc984b1e3c42d5 Reviewed-on: https://chromium-review.googlesource.com/c/1066794 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#603613}
-
