- 01 Feb, 2019 40 commits
-
-
Antonio Gomes authored
This is a preliminary step to port AccountReconcilor and its unittests away from GaiaCookieManagerService::Observer BUG=926890 Change-Id: Ifa3b7e18cad45627e29730d2d422688c68a831ab Reviewed-on: https://chromium-review.googlesource.com/c/1446473Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#628333}
-
Egor Pasko authored
Chrome on Android/ARM relies on NEON. Counts for "No NEON support" are extremely low, and hence not useful overall. Bug: 489738 Change-Id: Ic96cdc4bc9274400d720b7e8f5c33b6887d04692 Reviewed-on: https://chromium-review.googlesource.com/c/1449659Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#628332}
-
Andreas Haas authored
This is part of our cleanup effort to remove deprecated API from V8. R=haraken@chromium.org Bug: v8:8562 chromium:913887 Change-Id: I5fee15e15d1ff42754650779c543e5ee712b6896 Reviewed-on: https://chromium-review.googlesource.com/c/1449673Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#628331}
-
Guido Urdaneta authored
Before this CL, the RTCIceCandidate constructor threw a nonstandard exception when the candidate field was an empty string. This CL removes this behavior and allows empty candidates. Bug: 683094 Change-Id: I95e1b47ce7909f53fea91e2046ac92723b7146d3 Reviewed-on: https://chromium-review.googlesource.com/c/1442236 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#628330}
-
Adithya Srinivasan authored
This is a reland of 9d473842 Original change's description: > Portals: Expose portalHost to portal's browsing context > > window.portalHost returns a PortalHost to script running inside the main > frame within a portal. > > Bug: 914117 > Change-Id: I26fb4ae9676261bee4446bfbc6ee34b28dc618b1 > Reviewed-on: https://chromium-review.googlesource.com/c/1399569 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624316} Bug: 914117 Change-Id: I2830cafac26928229d474fd91921fbf2f9a47952 Reviewed-on: https://chromium-review.googlesource.com/c/1425041 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#628329}
-
Antonio Gomes authored
... rather than SigninManager. The delegates now pass IdentityManager instances rather than SigninManager instances to SigninStatusMetricsProvider, and SigninStatusMetricsProvider interact with those IdentityManager instances. PS: In a later CL, both //chrome's SigninManagerFactory::Observer and //ios/chrome's SigninManagerFactoryObserver can be removed. BUG=927345 Change-Id: Ic007bffd658e112261a97cf7027c50f916ba470e Reviewed-on: https://chromium-review.googlesource.com/c/1449278Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#628328}
-
Julie Jeongeun Kim authored
This CL removes AccountTrackerService from ProfileDownloader and uses IdentityManager instead of it. As AccountTrackerService is going to be a part of IdentityManager, AccountTrackerService::Observer::OnAccountUpdated is replaced with IdentityManager::Observer::OnAccountUpdated. This CL adds IdentityManager::Observer at the constructor. It doesn't fetch OAuth2 access token on OnRefreshTokenUpdatedForAccount if |waiting_for_refresh_token_| is not set. Bug: 922757, 922758 Change-Id: I8e5743089e208d4abee697ace45fbc99bc41fcea Reviewed-on: https://chromium-review.googlesource.com/c/1436780Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#628327}
-
Julie Jeongeun Kim authored
This CL removes SigninManager from profile_window_browsertest.cc and uses IdentityManager instead of it. Bug: 927238 Change-Id: I3f2f962b00cb2bbbd91509be1fa2bfb2869f1a3d Reviewed-on: https://chromium-review.googlesource.com/c/1449433Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#628326}
-
Antonio Gomes authored
IdentityManagerFactoryObserver is a parallel interface to //ios/chrome's SigninManagerFactoryObserver. It will be used to replace usage of that observer in follow up CLs. BUG=927343 hange-Id: I5d32caf0fa0c24b692b6d5ccaf6f8d191818fd74 Change-Id: I801a883aa72ee69e3686fff58ddd4b5c893c799c Reviewed-on: https://chromium-review.googlesource.com/c/1448473 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#628325}
-
Guido Urdaneta authored
Intent to implement and ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/T6zlVFZhRVY Drive-by: Fix a few minor lint issues. Bug: 683094 Change-Id: I1c8cb27e8583f200d6e4d9fe6f2d1b633e8dab66 Reviewed-on: https://chromium-review.googlesource.com/c/1429969Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#628324}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87ab0aef9c54..7b80b951e0bf Created with: gclient setdep -r src-internal@7b80b951e0bf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I529304e74f8cccbeb0f5081d2767c43e672715ca Reviewed-on: https://chromium-review.googlesource.com/c/1449775Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628323}
-
Nico Weber authored
It looks like the dep on //content/public/browser:browser_sources isn't needed (and causes link problems); it was merely there to placate `gn check`. Instead, suppress `gn check` for this target and file a bug to fix the issues pointed out by `gn check` for real instead of incorrectly papering over them with this dep. Bug: 927713 Change-Id: If4d991a4961fd36937b75c442514d349d5d60ab0 Reviewed-on: https://chromium-review.googlesource.com/c/1449816 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#628322}
-
Vladislav Kuzkokov authored
Change-Id: I3fd7213c4ff62b17e6d2f101c35920e426f09763 Reviewed-on: https://chromium-review.googlesource.com/c/1448415 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#628321}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/569dda7216cd..3dc93896b3a9 git log 569dda7216cd..3dc93896b3a9 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 michaelludwig@google.com Narrow clear-as-draw workaround on D3D11 ANGLE Created with: gclient setdep -r src/third_party/skia@3dc93896b3a9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I016d42048d274934c6db35d84ef043afa0468354 Reviewed-on: https://chromium-review.googlesource.com/c/1449774Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628320}
-
Dave Tapuska authored
There use to be an abstraction in place because blink couldn't depend on chromium code. With relaxed restrictions now it is possible to remove some abstraction that isn't necessary. Change-Id: I3cafbbafbf9a5e260525c8ce5278d0a8ef9612e0 Reviewed-on: https://chromium-review.googlesource.com/c/1448559Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#628319}
-
chrome://invalidationTanja Gornak authored
Bug: 801985 Change-Id: Id091723d11c65b029387f63a30957b1adfb9ef23 Reviewed-on: https://chromium-review.googlesource.com/c/1447734 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#628318}
-
Mikel Astiz authored
Processors track sync metadata per sync entity which includes creation and modification timestamps. We now expose these fields to sync bridges via ModelTypeChangeProcessor. The immediate use-case we have in mind is the smarter detection of likely-duplicate DeviceInfo instances, which is deferred to later patches. Bug: 910390 Change-Id: I1066489865a18e56470cbd8e96a41f3a00eeaec8 Reviewed-on: https://chromium-review.googlesource.com/c/1449652 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#628317}
-
Antonio Gomes authored
IdentityManagerFactory::Observer is a parallel interface to//chrome's SigninManagerFactory::Observer. It will be used to replace usage of that observer in follow up CLs. BUG=927341 Change-Id: Id377b5b5e20e00b49811302b0ab26a611af1d3d4 Reviewed-on: https://chromium-review.googlesource.com/c/1448754 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#628316}
-
Gyuyoung Kim authored
As a step to make to use IdentityManager,this CL replaces all uses of ATS with IdentityManager's ones in authentication_service_unittest.mm. Bug: 922796 Change-Id: I74dd7a7b8d640da88c2f999a43fb1439b79e5c97 Reviewed-on: https://chromium-review.googlesource.com/c/1438734Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#628315}
-
Marina Ciocea authored
[Sheriff] Disable flaky test WebRtcVideoCaptureServiceEnumerationBrowserTest.RemoveVirtualDeviceAfterItHasBeenEnumerated Bug: 927714 NOTRY=true NOPRESUBMIT=true TBR=chfremer@chromium.org Change-Id: Idd761e6efd21aa06212a4e2f697951bfa2fdb396 Reviewed-on: https://chromium-review.googlesource.com/c/1449663 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#628314}
-
Dan Elphick authored
Replace uses of Get/Set with Context versions that return a Maybe/MaybeLocal and check their return value mostly using ToLocalChecked or Check. Bug: v8:7283, v8:8562 Change-Id: Id8614f6e599cad628f3de8614d5a600d2148eb76 Reviewed-on: https://chromium-review.googlesource.com/c/1449676 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#628313}
-
Thomas Tangl authored
- Google services in the service client are marked as not-supported, so they will *not* be turned on during opt-in. - UrlKeyedAnonymizedDataCollection is still part of the opt-in and will get turned on. Note: This CL is kept small for an easy merge back. In a follow up, all dead code will be removed. Bug: 927423 Change-Id: Ia853cef207dbbe86360de45c8a6bfd4195d1b3d2 Reviewed-on: https://chromium-review.googlesource.com/c/1449598Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#628312}
-
Hajime Hoshi authored
This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found actual JavaScript execution on some layout tests: e.g. external/wpt/IndexedDB/nested-cloning-large-multiple.html This CL passes a per-frame task runner whenever possible. This CL also passes IPC per-thread task runner at some places, and we plan to replace them with per-frame ones later. Bug: 913912 Change-Id: I847f0c7a804abc187ee78f1b5bef442d7f205c08 Reviewed-on: https://chromium-review.googlesource.com/c/1445952 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#628311}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6808c22d9e24..87ab0aef9c54 Created with: gclient setdep -r src-internal@87ab0aef9c54 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5ef3855f481c1a5b9490f892f8c9a67c973d67fa Reviewed-on: https://chromium-review.googlesource.com/c/1449772Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628310}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f1d1061e51ca..63470298753a git log f1d1061e51ca..63470298753a --date=short --no-merges --format='%ad %ae %s' 2019-02-01 srte@webrtc.org Removes usages of TaskQueueCongestionControl field trial. Created with: gclient setdep -r src/third_party/webrtc@63470298753a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I513e3996a28ed295f5f5232d80d0e77b98d5a209 Reviewed-on: https://chromium-review.googlesource.com/c/1449771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628309}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 74de54ad. With Chromium commits locally applied on WPT: c64e59c2 "Deflake RTCPeerConnection-track-stats.https.html." 2376792a "Enable analyser tests to run with Chrome" f62d379c "Revert "Enable analyser tests to run with Chrome"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I715cf4ce478c5f92d6e5a0ff47a0d1d41e2d7bb2 Reviewed-on: https://chromium-review.googlesource.com/c/1449046Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628308}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/72a0e3347cdf..569dda7216cd git log 72a0e3347cdf..569dda7216cd --date=short --no-merges --format='%ad %ae %s' 2019-02-01 reed@google.com hide SkFont::containsText Created with: gclient setdep -r src/third_party/skia@569dda7216cd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I2eea4df88ad185fe401dd43180d5a04fbc9fc24c Reviewed-on: https://chromium-review.googlesource.com/c/1449519Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628307}
-
Finnur Thorarinsson authored
Bug: 926845, 860467 Change-Id: I0acc16a3acdc0dffec5521a4fa58a01851b4ca02 Reviewed-on: https://chromium-review.googlesource.com/c/1446352 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#628306}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc911b7d1f81..387002d1535d git log fc911b7d1f81..387002d1535d --date=short --no-merges --format='%ad %ae %s' 2019-02-01 vapier@chromium.org sdk: re-add missing exclude_paths when creating sdk tarball 2019-02-01 zhihongyu@chromium.org image_test: whitelist lib/firmware binaries in SymbolsTest Created with: gclient setdep -r src/third_party/chromite@387002d1535d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3bbbf3d14ee3ec1266af4054b8f98194e3b868e2 Reviewed-on: https://chromium-review.googlesource.com/c/1449516Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628305}
-
Oleg Davydov authored
Change-Id: Icf0e005780283a07dd76f52972811dce4ebfaed8 Reviewed-on: https://chromium-review.googlesource.com/c/1448184Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#628304}
-
Henrique Ferreiro authored
IdentityTestEnvironmentChromeBrowserStateAdaptor is the only user of the method. This CL is a precursor to a follow-up refactoring. Bug: 926907 Change-Id: If53c761f0f28db48e61a486ddaa1efb3e37d9293 Reviewed-on: https://chromium-review.googlesource.com/c/1448214 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#628303}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4569cd332d83..6808c22d9e24 Created with: gclient setdep -r src-internal@6808c22d9e24 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0b4481fd60db79f3ffad5540db2bf79a86892612 Reviewed-on: https://chromium-review.googlesource.com/c/1449518Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628302}
-
Henrik Grunell authored
* Fail with NotAllowedError, this consolidates with audio capture error. * Trigger system dialog explicitly when authorization is not determined. This is needed so that the system gives the correct information when checking the authorization state later. Otherwise it incorrectly keeps returning "not determined" until browser restart. Bug: 885184 Change-Id: I5c984e24877942f5924b172584d88974e5b9dd50 Reviewed-on: https://chromium-review.googlesource.com/c/1447732 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#628301}
-
David 'Digit' Turner authored
Add a missing entry to this .gitignore file to avoid 'git status' displaying that directory as untracked, which is super annoying. BUG=NONE R=digit@chromium.org TBR=thakis@chromium.org Change-Id: I1e221e6bb5e3fb76bd1c0fef9510f88c00414c46 Reviewed-on: https://chromium-review.googlesource.com/c/1449654Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Auto-Submit: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#628300}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a2911fc50eb..f1d1061e51ca git log 4a2911fc50eb..f1d1061e51ca --date=short --no-merges --format='%ad %ae %s' 2019-02-01 oprypin@webrtc.org mb: Fix iOS config after the earlier CL Created with: gclient setdep -r src/third_party/webrtc@f1d1061e51ca The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic79e9fec0f42840f67fd8a1b1ab418ac73111e78 Reviewed-on: https://chromium-review.googlesource.com/c/1449517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628299}
-
Mohamed Amir Yosef authored
This CL adds a browser test that the progress marker is properly persisted across restarts. Bug: 902349 Change-Id: I6a116a132ac066fa388bd4f08eb7fe93540c0e2b Reviewed-on: https://chromium-review.googlesource.com/c/1448330 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#628298}
-
Guido Urdaneta authored
Bug: 921006 Change-Id: I3e9680104b62a3f2647d6bf83f09d73c69b12fc9 Reviewed-on: https://chromium-review.googlesource.com/c/1449592Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#628297}
-
Pedro Amaral authored
This CL undoes some of the changes that could impact CCT that was introduced in the MenuButton refactor CL: https://chromium-review.googlesource.com/c/chromium/src/+/1419203 Bug: 925271 Change-Id: Ifb9575f8cf52934981c12b1a6c5114993997cc5e Reviewed-on: https://chromium-review.googlesource.com/c/1447834Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#628296}
-
Julie Jeongeun Kim authored
This CL implements CancelAllLoginRequests with exposing it through identity_test_utils.h. Bug: 926869 Change-Id: Iee7ef6fafbd60d4f04da2d8469b60c3d29b0f538 Reviewed-on: https://chromium-review.googlesource.com/c/1448077 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#628295}
-
Matt Falkenhagen authored
It's not used in production code. The unit tests still make use of it though so it can't be removed completely. Bug: 927651 Change-Id: Iad597caf1dc637c0a2c0fa5c4c37746eef7ba13b Reviewed-on: https://chromium-review.googlesource.com/c/1449477 Auto-Submit: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#628294}
-