- 21 Jul, 2015 40 commits
-
-
ericrk authored
GpuChannel currently calculates current memory usage by iterating over all stubs and summing their individual memory usage. This results in double counting as a given stub may share its memory tracker with other stubs, if they are in a share group. To avoid double counting, we now iterate over stubs to collect a set of unique MemoryTrackers, then sum the memory usage of each unique tracker. BUG=512535 Review URL: https://codereview.chromium.org/1244843004 Cr-Commit-Position: refs/heads/master@{#339746}
-
sky authored
To avoid confusion with the ones in mandoline I'm renaming the html_viewer to be prefixed with html_. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/1246053003 Cr-Commit-Position: refs/heads/master@{#339745}
-
jclw authored
For resources not provided by the native theme (i.e. GTK2UI), fall back to desktop (not ash) resources by calling MapThemeImage in this case. BUG=383711 R=erg@chromium.org TEST=The shadow running along the top edge of the address bar to the right of the tabs is visible again, especially when using a bright GTK theme like Adwaita or Radiance. (see crbug.com/383711) Review URL: https://codereview.chromium.org/1243513002 Cr-Commit-Position: refs/heads/master@{#339744}
-
rockot authored
BUG=None Review URL: https://codereview.chromium.org/1245083005 Cr-Commit-Position: refs/heads/master@{#339743}
-
kkimlabs authored
Revert of [Andorid] Migrate to ClipDrawable progress bar. (patchset #35 id:670001 of https://codereview.chromium.org/1170843002/) Reason for revert: Chrome Shell tests flaky. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests I think I know where I made a mistake and it should be a simple few line fix but to make sure... Original issue's description: > [Andorid] Migrate to ClipDrawable progress bar. > > Using ClipDrawable progress bar helps future changes for > http://crbug.com/461148 as we only need pass to color parameters. > > Also it has minor performance benefit. > > BUG=466140, 455891, 461148 > > Committed: https://crrev.com/ee231168bb231ee117485ecd1e7cb16a1f632bae > Cr-Commit-Position: refs/heads/master@{#339598} TBR=tedchoc@chromium.org,dtrainor@chromium.org,newt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466140, 455891, 461148 Review URL: https://codereview.chromium.org/1249793003 Cr-Commit-Position: refs/heads/master@{#339742}
-
lgarron authored
This was accidentally missed in https://chromium.googlesource.com/chromium/src/+/a23713b67ee741e5bb026d99e86b8c97cc9ab84d BUG= Review URL: https://codereview.chromium.org/1238623003 Cr-Commit-Position: refs/heads/master@{#339741}
-
tfarina authored
Instead of making a series of calls to it, keep the model in variable and reuse it. BUG=None TEST=unit_tests --gtest_filter=BookmarkBarViewTest.* R=sky@chromium.org Review URL: https://codereview.chromium.org/1246833004 Cr-Commit-Position: refs/heads/master@{#339740}
-
avi authored
BUG=170921 TEST=everything still works Review URL: https://codereview.chromium.org/1242953004 Cr-Commit-Position: refs/heads/master@{#339739}
-
meek authored
* Defend against SecurityException in AlarmManager (allow retries in Clank to drive to completion when under quota again) * Misc. code cleanup: removing deprecated fields, removing unused fields, standard template type names, deterministic member order for generated proto code * Manifest cleanup BUG=483695 Review URL: https://codereview.chromium.org/1246033002 Cr-Commit-Position: refs/heads/master@{#339738}
-
jrw authored
The new implementation (CombinedHostListApi) attempts to keep the two directories in sync and present a merged view of the contents of the directories. BUG=503790 Review URL: https://codereview.chromium.org/1217643002 Cr-Commit-Position: refs/heads/master@{#339737}
-
geofflang authored
https://chromium.googlesource.com/angle/angle.git/+log/02df796..01c796a BUG=483282,510822 TEST=bots Review URL: https://codereview.chromium.org/1248863002 Cr-Commit-Position: refs/heads/master@{#339736}
-
zea authored
The condition wasn't necessary, and can cause problems if server created nodes don't set the time properly. BUG=512197 Review URL: https://codereview.chromium.org/1250503002 Cr-Commit-Position: refs/heads/master@{#339735}
-
bajones authored
BUG=389343 Review URL: https://codereview.chromium.org/1250723002 Cr-Commit-Position: refs/heads/master@{#339734}
-
penghuang authored
BUG=None Review URL: https://codereview.chromium.org/1249713004 Cr-Commit-Position: refs/heads/master@{#339733}
-
gunsch authored
Most functionality should be in cast_shell_common target for things like cast_service_unittests to run. R=slan@chromium.org,halliwell@chromium.org BUG=internal b/22465963 Review URL: https://codereview.chromium.org/1232313008 Cr-Commit-Position: refs/heads/master@{#339732}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/0278197..ae3714f CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=joshualitt@google.com Commits in this roll: ae3714f caryclark@google.com make varied_text* gm portable Review URL: https://codereview.chromium.org/1250703002 Cr-Commit-Position: refs/heads/master@{#339731}
-
krstnmnlsn authored
ConstructWithoutDefaultAdapter, and ConstructFakeAdapter tests now pass on Mac as well as Android. BUG=511008 Review URL: https://codereview.chromium.org/1232613004 Cr-Commit-Position: refs/heads/master@{#339730}
-
aurimas authored
- Roll to Android Support Library 22.2.1 - Add gyp target for multidex support library. - Revert the workaround for KEYCODE_MENU as 22.2.1 has the bug for it again. BUG=510128,272790 TBR=yfriedman@chromium.org Review URL: https://codereview.chromium.org/1226373010 Cr-Commit-Position: refs/heads/master@{#339729}
-
dongseong.hwang authored
Mac Developer Library [1] notes "In general, you should not include this header directly. Instead, include <IOSurface/IOSurface.h>." [1] https://developer.apple.com/library/mac/documentation/Miscellaneous/Reference/IOSurfaceAPI_header_reference/#//apple_ref/c/tdef/IOSurfaceRef Review URL: https://codereview.chromium.org/1227363005 Cr-Commit-Position: refs/heads/master@{#339728}
-
varkha authored
The CL that was supposed to fix that collided in CQ with https://codereview.chromium.org/1209033008. After that CL apps launched in a window have SHOW_STATE_DEFAULT initially and not SHOW_STATE_NORMAL as was assumed in https://codereview.chromium.org/1221193009. This patch makes the code path for docked state similar to maximized state and updates that unit test. BUG=271582 Review URL: https://codereview.chromium.org/1240393005 Cr-Commit-Position: refs/heads/master@{#339727}
-
oshima authored
BUG=512482 TEST=manual. Tab dragging works correctly with --force-device-scale-factor=2 Review URL: https://codereview.chromium.org/1247813002 Cr-Commit-Position: refs/heads/master@{#339726}
-
kalman authored
BUG=503402 R=rdevlin.cronin@chromium.org,asvitkine@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1245113005 Cr-Commit-Position: refs/heads/master@{#339725}
-
davidben authored
$ git log 7f15ff53d..209b25622 --date=short --format='%ad %ae %s' 2015-07-20 davidben Fix o2i_ECPublicKey documentation. 2015-07-20 davidben Surround immintrin.h includes with warning pragmas. 2015-07-12 davidben Simplify the AMD-specific codepath. 2015-07-11 davidben Replace cpuid assembly with C code. 2015-06-29 davidben Reserve ex_data index zero for app_data. 2015-07-11 davidben Remove incorrect TODO(fork). 2015-07-11 davidben Extra documentation. 2015-07-16 agl Fix typo in |HMAC_CTX_cleanup|. 2015-06-29 davidben ERR_LIB_USER should be the last error. 2015-06-29 davidben Remove the func parameter to OPENSSL_PUT_ERROR. 2015-06-28 davidben Get rid of err function codes. BUG=none Review URL: https://codereview.chromium.org/1244093002 Cr-Commit-Position: refs/heads/master@{#339724}
-
wfh authored
BUG=508738 TEST=components_unittests --gtest_filter=StorageMonitorWinTest.* Review URL: https://codereview.chromium.org/1250713002 Cr-Commit-Position: refs/heads/master@{#339723}
-
msw authored
Revert of Make AXProviderTest.HelloWorld bail without oopifs. (patchset #1 id:1 of https://codereview.chromium.org/1224103002/) Reason for revert: Sadrul landed a fix for the flaky timeouts: https://codereview.chromium.org/1228173003 Bailing didn't resolve these flakes anyway. Original issue's description: > Make AXProviderTest.HelloWorld bail without oopifs. > > This test times out flakily without oopifs enabled. > Effectively disable the test without oopifs for now. > This should unblock running apptests on the CQ/main. > > BUG=504917 > TEST=Test isn't run without oopifs for now... > R=jam@chromium.org > TBR=sky@chromium.org > > Committed: https://crrev.com/427c2f36770711c369a85f56c4a63b4036e735a9 > Cr-Commit-Position: refs/heads/master@{#338073} TBR=jam@chromium.org,sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504917 Review URL: https://codereview.chromium.org/1248873002 Cr-Commit-Position: refs/heads/master@{#339722}
-
sandersd authored
This should move the investigation of bug 495185 closer to the root cause. BUG=495185 Review URL: https://codereview.chromium.org/1246783003 Cr-Commit-Position: refs/heads/master@{#339721}
-
sbc authored
Initializing a pthread_t to NULL (or any value really) is not valid. This causes a compiler warning with the new arm glibc toolchain so needs to be fixed because we enable the new toolchain. Turns out the pid_ member was not even needed so this change removes it and adds a pthread_detach call which allows for freeing on the thread's resources (in the absence of pthread_join). CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk BUG=505885 Review URL: https://codereview.chromium.org/1243123002 Cr-Commit-Position: refs/heads/master@{#339720}
-
jyasskin authored
BUG=420284 Review URL: https://codereview.chromium.org/1248573002 Cr-Commit-Position: refs/heads/master@{#339719}
-
pkotwicz authored
BUG=505040 TEST=None TBR=aurimas Review URL: https://codereview.chromium.org/1250683002 Cr-Commit-Position: refs/heads/master@{#339718}
-
dbeam authored
R=esprehn@chromium.org BUG=511486 Review URL: https://codereview.chromium.org/1249623003 Cr-Commit-Position: refs/heads/master@{#339717}
-
jzern authored
msvc: fix pointer type warning in BitsLog2Floor _BitScanReverse() takes an unsigned long* http://msdn.microsoft.com/en-us/library/fbxyd7zd.aspx fixes: C4057: 'function': 'unsigned long *' differs in indirection to slightly different base types from 'uint32_t *' and -Wincompatible-pointer-types warning on Clang on Windows https://code.google.com/p/webp/issues/detail?id=253 Review URL: https://codereview.chromium.org/1245063002 Cr-Commit-Position: refs/heads/master@{#339716}
-
lalitm authored
Add plumbing code in content layer to allow revocation of permissions. NOTE: this is a part of a three sided patch: https://codereview.chromium.org/1234023002 https://codereview.chromium.org/1238673002 (this) https://codereview.chromium.org/1241133002 BUG=510405 Review URL: https://codereview.chromium.org/1238673002 Cr-Commit-Position: refs/heads/master@{#339715}
-
edwardjung authored
Tracks usage: + of promoted 'Google cached copy' link doctor button. + on each of the two button label variants. BUG=474848 Review URL: https://codereview.chromium.org/1214303003 Cr-Commit-Position: refs/heads/master@{#339714}
-
wittman authored
Revert of Remove race in DeclarativeContentApiTest.RulesPersistence test (patchset #1 id:1 of https://codereview.chromium.org/1222193006/) Reason for revert: Breaks linux clang tot bot (https://crbug.com/512506) and causes flakiness on Vista Tests bot (https://crbug.com/512431). BUG=512506, 512431 Original issue's description: > Remove race in DeclarativeContentApiTest.RulesPersistence test > > BUG= > > Committed: https://crrev.com/28218513bf9580515b03c73ab786c27844e9b40b > Cr-Commit-Position: refs/heads/master@{#339432} TBR=battre@chromium.org,matthewtff@yandex-team.ru NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1247743004 Cr-Commit-Position: refs/heads/master@{#339713}
-
boliu authored
Allow SyncPointManager instance to be set, and set the same instance in Android WebView. Also remove ref-counting and just guarantee SyncPointManager outlives running message loop. Also make SyncPointManager thread safe, and callbacks are no longer guaranteed to happen on the same thread. Make sure command buffer implementations handle it correctly. BUG=509702 Review URL: https://codereview.chromium.org/1231263003 Cr-Commit-Position: refs/heads/master@{#339712}
-
mariakhomenko authored
On Android, when merge tabs and apps is enabled, we need to ensure a new activity has been started before loading URL in web contents since the web contents delegate is not ready until then. We already have a code path to handle this for window.open() scenario. This completes the code path for when a link with noreferrer is clicked by saving OpenURLParams of the pending load and resuming the load when the activity is ready. BUG=508366 Review URL: https://codereview.chromium.org/1233453003 Cr-Commit-Position: refs/heads/master@{#339711}
-
nyquist authored
Currently the AccountManagerHelper always checks the GET_ACCOUNTS permission. This should instead be done directly by the AccountManagerDelegate. BUG=509826 Review URL: https://codereview.chromium.org/1247053002 Cr-Commit-Position: refs/heads/master@{#339710}
-
brettw authored
Adds manifest data for content shell. The result matches the GYP build. Attaches a default manifest to all tests in the GN build. The GYP build's tests have manifests that specify elevation only. In GN it also specifies Windows and common control compat that matches what we ship with Chrome. BUG=510612 TBR=dpranke@chromium.org Reland of https://codereview.chromium.org/1240893004/ with no cloud print or remoting changes Review URL: https://codereview.chromium.org/1238293005 Cr-Commit-Position: refs/heads/master@{#339709}
-
avayvod authored
BUG=412331 NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1228863005 Cr-Commit-Position: refs/heads/master@{#339708}
-
mvanouwerkerk authored
Currently Teardown is called twice on shutdown. The ServiceProcess is on the stack. It will call Teardown from its destructor when ServiceProcessMain returns. It looks like this redundancy has been there since the service process was first introduced in: https://codereview.chromium.org/2001009/ Review URL: https://codereview.chromium.org/1242873004 Cr-Commit-Position: refs/heads/master@{#339707}
-