GitLab

As per UI review request, adjust the style of history ClearBrowsingBar:
1. Horizontal margin: 16pt
2. Vertical margin: 8pt
3. Spacing between button: 8pt
4. Font size: (same as bookmark cell)
5. Font color
6. Shadow opacity and radius
7. Button text wraps across multi-lines when needed (and bar height will
   grow when text wrapped.)

Screenshot:
https://drive.google.com/file/d/1rRj-1fKsjRk8n0rG6C-XB2mXoyPooMC6

Bug: 788601
Change-Id: I9a0fbe68122e01301665a48ed77086be96d7de65
Reviewed-on: https://chromium-review.googlesource.com/790013
Commit-Queue: Marti Wong <martiw@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519535}

https://skia.googlesource.com/skia.git/+log/dfaa057c1518..c9c97b7fd5f9

$ git log dfaa057c1..c9c97b7fd --date=short --no-merges --format='%ad %ae %s'
2017-11-27 csmartdalton CCPR: Transform path points before parsing
2017-11-27 mtklein remove SkDebugCanvas clip query overrides
2017-11-27 csmartdalton Cleanup yes/no enums in Ganesh
2017-11-27 mtklein update SkJumper docs to Clang 5
2017-11-27 bsalomon Batch ops together in SkAtasTextTarget
2017-11-27 mtklein clean up SkDeferredCanvas
2017-11-27 csmartdalton Include opList ids in GrOnFlushCallbackObject::postFlush
2017-11-27 egdaniel Fix caps for advanced blend extension with regards to layout qualifiers
2017-11-27 robertphillips Revert "Make sure to visit clips and dst proxies during gather"
2017-11-27 mtklein roll GN
2017-11-21 csmartdalton Make sure to visit clips and dst proxies during gather
2017-11-27 ethannicholas added SkSL support for all blend mode layouts
2017-11-27 angle-deps-roller Roll skia/third_party/externals/angle2/ 994ee3f23..ebee5b3b7 (2 commits)
2017-11-27 mtklein Handle null colorspace in SkToSRGBColorFilter.
2017-11-27 liyuqian Add forceDAA parameter to AntiFillPath
2017-11-17 robertphillips Add Fiddle DrawOptions for the backend objects
2017-11-20 csmartdalton Delete an opList's clips when it survives a flush
2017-11-27 bsalomon Make EGL test context access GL via GrGLInterface
2017-11-27 caryclark bookmaker refresh
2017-11-27 reed saturate when converting float to fixed

Created with:
  roll-dep src/third_party/skia
BUG=787718


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: Ibfc18a318dfc01efeb3baefcd41127fc139fbbe6
Reviewed-on: https://chromium-review.googlesource.com/791996Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519534}

There are many places where WTF_MAKE_NONCOPYABLE is transitively defined. This
CL starts replacing these uses with DISALLOW_COPY_AND_ASSIGN and includes
base/macros.h as required.

Where required the declaration of DISALLOW_COPY_AND_ASSIGN is moved to
the end of the class definition.

Also, take the opportunity to use "= default" rather than {} for
ctors and dtors, in line with recent discussions on chromium-cxx@.

There are no logic changes in this CL.

Bug: 565932
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Idc53c473b134277cc2a079704648f99b3f9d47f1
Reviewed-on: https://chromium-review.googlesource.com/791870Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519533}

 Test: manually click (with ChromeVox using Search+Space) ARC++ notification; verify app opens.
Bug: 786981

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6809ff0371e5315e0fe6aaf01e9c567215c77fc4
Reviewed-on: https://chromium-review.googlesource.com/783669
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519532}

base::debug::Alias can only reliably trick the compiler into retaining
the values of local variables, not class member variables. Therefore it
is important to copy class member variables to locals before aliasing
them.

Bug: 756589
Change-Id: I5c67f386c2a6ad192af74fd9aefbc9103b355774
Reviewed-on: https://chromium-review.googlesource.com/792297Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519531}

This requires exposing a previously-local-to-the-file function as protected, but
this seems like an OK tradeoff.

In the process, also rejiggered a few things (e.g. eliminated a file-scope using
directive).

BUG=none
TEST=none

Change-Id: I5fafda5ce264370cbe6d67e39f24c58fef7543ee
Reviewed-on: https://chromium-review.googlesource.com/792123
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519530}

Add a method to ContentBrowserClient. Note this controls gpu process
"launch" for in-process GPU as well. The method still allows using an
existing GPU process, so in-process case should be minimally impacted so
probably not worth carving out special conditions for it.

For now, only call this new API from BrowserGpuChannelHostFactory, which
controls GPU clients in the browser process. Clients in child process is
more risky, so holding going to do that part in a follow up CL instead.

ChromeContentBrowserClient on android implements the API by checking if
there are running or paused activities. Paused activity may still be
visible, so allow it to launch GPU in that case.

Bug: 779211
Change-Id: Ic48acc9f9ab6134371d7f193d9031e912a05d947
Reviewed-on: https://chromium-review.googlesource.com/783495Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519529}

https://chromium.googlesource.com/catapult.git/+log/a1422259024f..884db2336247

$ git log a14222590..884db2336 --date=short --no-merges --format='%ad %ae %s'
2017-11-27 bokan Re-reland "Test that gestures scroll the correct distance"

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I9092c03768e4ec5b95f2d236e387052a2eca066d
Reviewed-on: https://chromium-review.googlesource.com/792008
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519528}

This makes sure nine-patch is updated when rounded corner radius
has changed and not only when elevation has changed.

WMTestSuite has also been updated to allow tests that call into
skia and use discardable memory (needed for corner radius test).

Bug: 788461
Tbr: sadrul@chromium.org
Test: wm_unittests --gtest_fiter=ShadowTest.AdjustRoundedCornerRadius
Change-Id: I4489fbf11416559a3da8ac3b194f96c59ed5801c
Reviewed-on: https://chromium-review.googlesource.com/789730
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519527}

This CL adds a new ChromeBroadcastObserver method for the toolbar
height.  It also creates FullscreenUIState, an object that holds the
broadcast properties for toolbar UI.

Bug: 785625
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibebff64db6c33ec5e7e0ca6eb24a96973a533b36
Reviewed-on: https://chromium-review.googlesource.com/773443
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519526}

this is in preparation for the libwebp-0.6.1 update; include paths were
changed from '../...' to 'src/...'.

BUG=788275
NOPRESUBMIT=true (due to presubmit confusion about local DEPS)

Change-Id: I608f0271d9132aae9f9681d9514dd61c951ee044
Reviewed-on: https://chromium-review.googlesource.com/792251Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Commit-Queue: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#519525}

Previously this was an enum declared in the TabStripModelObserver class. This
was incorrect layering since it was used by calls into the TabStripModel, which
shouldn't depend on that class' own observer definition.

With the experimental tab strip, the need for this enum to be at a more
fundamental layer becomes more obvious. This change adds the change type to the
experimental tab strip observer and uses it.

Bug: 778461
Change-Id: I12921deea21e264d7f7b883fd2c4c1557022eb61
Reviewed-on: https://chromium-review.googlesource.com/791990
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519524}

Fix ExoParts destruction order to ensure that WMHelper instance
is valid when exo::Display is destroyed.

Bug: 788731
Test: Running Chrome with DCHECKs no longer fails at shutdown.
Change-Id: I9bddecd863d92b600378488e04612cff87cef1ae
Reviewed-on: https://chromium-review.googlesource.com/792214
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519523}

In the few use cases that were using WebNonCopyable I followed the Google
C++ style guide, which explicitly states that to remove copy
operations "explicitly disable them using = delete in the public: section".
https://google.github.io/styleguide/cppguide.html#Copyable_Movable_Types

Most places were just including the header file without actually using
the type.

This CL contains no logic changes.

Bug: 788846
Change-Id: I991e4b9b548f67a41d79882723525a97f3625432
Reviewed-on: https://chromium-review.googlesource.com/792190Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519522}

Response's MIME type can change during the download and DownloadTask
should support the change. This will allow to report
DOWNLOAD_PASS_KIT_WRONG_MIME_TYPE_FAILURE metric for PassKit downloads.

Bug: 787943
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I137f9aa4ff966c140a9a6cb5b03dc026062bc0b7
Reviewed-on: https://chromium-review.googlesource.com/786265Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519521}

This applies to browser permissions checks, not app permissions. For
example: getUserMedia. If the permission is not requested by an
extension, or the extension name cannot be looked up, the origin from
the URL is shown as before.

Tested by launching an extension that attempts to access the mic with
getUserMedia and verifying the existing behavior for a web site.

Bug: 717625
Change-Id: I4e17c97f932ee163afa2fe972687259d794e4cfc
Reviewed-on: https://chromium-review.googlesource.com/677983
Commit-Queue: Adrian Elder <aelder@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519520}

This CL teaches WebMVideoClient to parse the |codec_private|
field, if present, to figure out the VP9 Profile if any. This
is a necessary step to support VP9.2 10b on Vaapi.

TEST=crosvideo.appspot.com/?codec=vp9.2&loop=true and newly
added unittests.

Bug: 778093, 592074
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic62519b32818fe409d15f54b6ddb9798deea88da
Reviewed-on: https://chromium-review.googlesource.com/786211
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519519}

Unbuffered dispatch mode is very analogous to the Android version. It
will send touchmove/mousemoves immediately while the pointer is down.
If the target is a HTML Canvas it is queried if it is in unbuffered
dispatch mode and if it is the mode is requested from the input queue.

BUG=788234

Change-Id: Ib92e9f52c9b32e52c6b90dd2c002adaedf361f96
Reviewed-on: https://chromium-review.googlesource.com/789550
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519518}

Passing these callbacks from the client process code means that MDM begins
owning the callback. However, these callbacks *must* be run before
destruction. While this is not a problem with MDM per-se as MDM is a
leaky singleton, MDM ocassionally passes ownership of this callback to
a thread loop.

On destruction of the thread loop with the callback posted, the callback
could be destroyed without being run which can cause problems.

To solve this, instead of passing the callback into a situation where
it could be destroyed, we instead store the callback inside the client
process itself. As the client is also a leaky singleton, the destructor
of these callbacks will no longer be run so we do not have the above problem.

Bug: 788658
Change-Id: I9dd65fe7748e0afaedd1bf5a3d25ac9cadfe9853
Reviewed-on: https://chromium-review.googlesource.com/790591Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519517}

This CL introduces the GattServicesWorkaround class with an
implementation and test double. The class is initialized as part of the
asynchronous shutdown flow and is invoked by BleConnectionManager when
GATT services are unavailable.

Bug: 784968, 672263
Change-Id: If81085bf9f8c7ac7f6715f93f9c3c07a8dbc13e2
Reviewed-on: https://chromium-review.googlesource.com/777983Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519516}

In various components/[a-c]* directories.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic42b2176db06d2adbf35d815932c54aed6d3c255
Reviewed-on: https://chromium-review.googlesource.com/776020Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519515}

Add individual closure compiler targets for data elements needed by new
UI.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If4f877da51d174e06b09ac4618f7ac1c56096cae
Reviewed-on: https://chromium-review.googlesource.com/792014Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519514}

The text diffs are due to the new layer tree structure.  The image
diffs are only on Win10, and they appear to be shading differences
due to antialiasing.  Most likely, this is caused by floating point
numerical differences when the printing code applies a zoom factor
to the page.

BUG=711468
R=pdr@chromium.org,skobes@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls

Change-Id: I0d33a98a98bdf5203f26f97ab7787c162619af1c
Reviewed-on: https://chromium-review.googlesource.com/792332Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519513}

Remove all the ATK implementation in BrowserAccessibilityAuraLinux, and
relay on the single implementation available in AXPlatformNodeAuraLinux.
This way we stop duplicating ATK implementation, and focus on a single
backend for the whole platform accessibility.

Some changes were needed in AXPlatformNodeAuraLinux to support the
requirements in BrowserAccessibility:
* Delegate AccessibilityTreeAuraLinux AddProperties on
  AXPlatformNodeAuraLinux::AddAccessibilityTreeProperties.
* Regenerate if needed the backing AXPlatformNodeAuraLinux ATK objects
  when OnDataChanged is called in BrowserAccessibilityAuraLinux.

Bug: 784583
Change-Id: I9538f09e5018a252e56c446270f8197742faa0d0
Reviewed-on: https://chromium-review.googlesource.com/788395
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519512}

See crbug.com/786608 for details - in this CL we CHECK the fields that
could possibly be causing a bad mojo message.

BUG=786608

Change-Id: I4b467653a24623da9a748306be6034e8d8a2d0a4
Reviewed-on: https://chromium-review.googlesource.com/790298Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519511}

Add some logging messages that are guarded by DEBUG = false.
With this, you can leave useful debugging messages without having to
resolve merge conflicts every time.

BUG=

Change-Id: Ic9b47bcd250e59021041bfe0ecfebb87a0a5182d
Reviewed-on: https://chromium-review.googlesource.com/792345Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519510}

Reland "Use TabPersistentStoreObserver.onMetadataSavedAsynchronously to background the Browser Actions tab creation service"

This relands commit 64565fd7.

Original change's description:
> Use TabPersistentStoreObserver.onMetadataSavedAsynchronously to
background the Browser Actions tab creation service
>
> Change the logic to background the Browser Actions tab creation
service
> based on TabPersistentStoreObserver.onMetadataSavedAsynchronously. The
> callback indicates that tab model lists are backuped so the saved tabs
> can be restored succesfully.
>
> Also for the notification when a new tab has not been created (tabId
is
> not available), the Intent to bind the notification will be a VIEW
> intent. This notification is necessary to make the service foreground.
>
> Bug: 766349
> Change-Id: I73d49e2a1e26410b2dd6e51a07f35e9965b9a38a
> Reviewed-on: https://chromium-review.googlesource.com/769852
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Lei Tian <ltian@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517492}

Bug: 766349
Change-Id: Icb35c3b0e3ed2186e48c7f0e77ceb6a07bc1f39f
Reviewed-on: https://chromium-review.googlesource.com/791392Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Lei Tian <ltian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519509}

The constants for recognizing Weblite URLs are now controlled by field
trial params, and the logic is handled in native code for easier unit
testing.

Bug: 717592
Change-Id: I4a853db2555d82ede32a95efd00ed3a224dc87ab
Reviewed-on: https://chromium-review.googlesource.com/786173Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519508}

Add Mount and Unmount.

CQ-DEPEND=CL:782708

Bug: chromium:757625
Change-Id: Idbc9ccc80da7872317f3a0bd05b72447e09de1d0
Reviewed-on: https://chromium-review.googlesource.com/745304
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519507}

https://chromium.googlesource.com/angle/angle.git/+log/ebee5b3b7de5..0b684ce3c9f5

$ git log ebee5b3b7..0b684ce3c --date=short --no-merges --format='%ad %ae %s'
2017-11-23 jmadill Vulkan: Move RenderPass init into a helper function.
2017-11-23 jmadill ContextImpl: Make flush/finish take a gl::Context.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ieea792672e8b9baa6149e48260fb81011c63c85c
Reviewed-on: https://chromium-review.googlesource.com/791861Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519506}

This is a reland of 7df6fead, which was
speculatively reverted as possible cause of crbug.com/788192, since the
CL originally landed only after that regression.

Original change's description:
> Migrate call-sites away from un-managed PlatformHandle[Vector]s.
>
> As the first step to merging ScopedPlatformHandle into PlatformHandle
> to have a single, always-managed container for platform handles, we:
>
> - Replace ScopedPlatformHandleVectorPtr and PlatformHandleVector
>   with vector<ScopedPlatformHandle>.
> - Replace PlatformHandle with ScopedPlatformHandle in some core APIs.
> - Use const& to pass handles to APIs without passing ownership, for
>   both individual platform handles, and vectors.
>
> Bug: 753541
> Change-Id: Id965dcf3770ef11bf36f78277fa7199ea779599e
> Reviewed-on: https://chromium-review.googlesource.com/742309
> Reviewed-by: Ricky Liang <jcliang@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
> Commit-Queue: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518343}

Bug: 753541
TBR: lhchavez, jcliang, dominickn, rockot
Change-Id: I9d50f06052b2118aec8872ca149504fbed245f1a
Reviewed-on: https://chromium-review.googlesource.com/792255Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519505}

Bug: 
Change-Id: Ifec62565e096220b53149fd77e9bc96e46caa7c1
Reviewed-on: https://chromium-review.googlesource.com/792390Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519504}

Previously, there were many spots in the UI unittests where we checked
that a set of UI elements (and only that set of UI elements) was
visible. This had regressed, however, and in the interim, elements had
been added that were not accounted for in the test expectations.

In this CL, I have switched back to exclusive visibility checks, and
have updated the appropriate expectations. I have also introduced the
notion of an owner elements. This both permits unit tests to refer to
unnamed sub-elements meaningfully and allows for better debug output
(the hierarchy dumps are much more meaningful).

This also permitted including these unnamed sub-elements in the
stacking unit test. I have also moved the remaining stacking unit
tests into the UI unittests.

I have also updated the backplane click test to simulate the response
to the click so we can check that the visuals update as we expect.

Bug: 782395
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8f4f0fb92df18dc6b8d7a8e086768d4a97136898
Reviewed-on: https://chromium-review.googlesource.com/789440
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519503}

https://pdfium.googlesource.com/pdfium.git/+log/9b93815edae6..e82af1a845c1

$ git log 9b93815ed..e82af1a84 --date=short --no-merges --format='%ad %ae %s'
2017-11-27 npm Make ConvertBuffer_* void
2017-11-27 dsinclair Convert CFX_GifContext::GetFrameNum to size_t

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I8783e80687aefb651c887ec2fde59b37c7f1ba80
Reviewed-on: https://chromium-review.googlesource.com/792291
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519502}

We were posting display rAF for magic window when there was no reason
to, which was making comparing window rAF and display rAF performance
difficult. This CL fixes that, and adds a test to make sure display
rAF is equivalent to window rAF in terms of scheduling.

This exposes the same race in getFrameData_oneframeupdate.html that was
found in WebVrTabTest#testPoseDataUnfocusedTab, namely that the pose
can start off being null, racily. The previous behavior of posting the
vrDisplay rAF was hiding this.

Bug: 734747, 734208, 787196
Change-Id: Ib6b657b1966359683b3c7aca16be26be9c3c54dd
Reviewed-on: https://chromium-review.googlesource.com/788240
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519501}

This probably "regressed" in r503368, which fixed a use case for
accelerator handling. But that meant that accelerator handling happened
before Textfield::OnKeyEvent() handling, resulting in a stray edit
command because Textfield::AcceleratorPressed() doesn't clear it.
However, Textfield::AcceleratorPressed() doesn't do the right thing on
Mac anyway.

On Mac, these always dispatch via the responder chain and the `Edit`
menu in the main menu bar. This ensures they obey custom key mappings
that a user may have set up in System Preferences via string matching
on the specific menu items.

Bug: 773565
Change-Id: Ic09db94866b6bd37791517505b24211c6c1105c4
Reviewed-on: https://chromium-review.googlesource.com/788632
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519500}

Fixes the issue of CCT/WAA NFC tests getting stuck in the DOFF flow.
This was somehow caused by the webpage listening for vrdisplayactivate,
but not actually presenting with it.

Also adds a sleep at the end of the test to prevent a possible race
condition with VrCore's 2 second NFC debounce timeout.

Bug: 787878
Change-Id: Ic5f16258cfa94ce3fac63781c1e225b8b2749f4e
Reviewed-on: https://chromium-review.googlesource.com/791938
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519499}

Records the time since last main frame navigation when a renderer OOM is
detected. On Android record only foreground OOMs.

BUG=736892

Change-Id: I71424844a7bfc9528a6ec865249b046e65275e07
Reviewed-on: https://chromium-review.googlesource.com/769234
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519498}

//ios/web_view has unittests for autofill which use TestWebState.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If6abe86f6bfb7bb3ab718aa1d5cc4e8fb180812a
Reviewed-on: https://chromium-review.googlesource.com/791816Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519497}

Using wpt-import in Chromium 87a4dbb1.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6423

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=rbyers

No-Export: true
Change-Id: I1fe90dda18eda2775a5eac729db7bb35165c2b39
Reviewed-on: https://chromium-review.googlesource.com/792070
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519496}