- 29 Nov, 2018 40 commits
-
-
danakj authored
This is a reland of eacb6ed3 The flaky test has been disabled. TBR=piman Original change's description: > Reland "Start gpu channel and compositor mojo pipe collection eagerly" > > This is a reland of 66794d00 > > In this reland we revert changes to RenderThreadImpl and mus to make > LayerTreeFrameSink creation asynchronous again. > > Then in RenderWidget we must remember that a warmup is underway, we do > so with a bool and a WeakPtrFactory. If it is aborted, we reset the bool > and invalidate the WeakPtrFactory. > > If a request for a frame sink beats the warmup completing, we save > the callback and run that instead of saving the frame sink on > RenderWidget when the warmup completes. > > This ignores some weird weird corner cases like where warmup is > aborted then we start another warmup or unfreeze the widget or something > and will just make redundant requests. Since these are so rare they > are not worth adding complexity for. > > Original change's description: > > Start gpu channel and compositor mojo pipe collection eagerly > > > > When a RenderWidget is frozen, its compositor is stopped. However when > > the main frame is being navigated, we want to start requesting mojo > > pipes for the gpu and display compositor immediately so that it can > > happen in parallel with the navigation loading. > > > > Previously, we just always did this when creating a RenderWidget, and > > left them active when freezing the RenderWidget. After 678f025f > > however, we don't, and this causes time-to-first-pixels regressions > > on navigation. > > > > So we add a WarmupCompositor() method to RenderWidget, and call this > > from RenderFrameImpl::CreateFrame() when it makes the provisional > > frame, and the WebFrameWidget, since we expect to make use of the > > main frame RenderWidget shortly. > > > > Then, if RenderFrameImpl::FrameDetached() occurs, due to the > > navigation failing, we will AbortWarmupCompositor() to drop the > > mojo pipes instead of holding onto them indefinitely. > > > > This recovers the loading regressions introduced, while also not > > allocating mojo channels for frozen RenderWidgets indefinitely. > > > > In order to do this reasonably, we drop the "callback" from the > > request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that > > it always returns something immediately. This way RenderWidget > > does not need to worry about having a task run to collect the > > new frame sink, and ordering with tasks from the compositor to > > collect it. > > > > R=piman@chromium.org > > > > Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0 > > Bug: 905191 > > Reviewed-on: https://chromium-review.googlesource.com/c/1341073 > > Commit-Queue: danakj <danakj@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#610909} > > Bug: 905191 > Change-Id: I6cb65e08a832a969156b96bece0f2e12eccd5b60 > Reviewed-on: https://chromium-review.googlesource.com/c/1351938 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611838} Bug: 905191 Change-Id: I0320c8604d50d5d83157c058c230b471c0898b26 Reviewed-on: https://chromium-review.googlesource.com/c/1355321Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#612253}
-
Brian Osman authored
This disables an "optimization" in Skia that appears to actually cause a performance regression. After looking, that optimization is probably unnecessary, and will probably be removed. To facilitate that, this CL switches it off so we can rebaseline the affected layout tests. Effectively reverts: https://chromium-review.googlesource.com/c/chromium/src/+/1334230 Bug: chromium:908566 Change-Id: I634814dabaed09b7f93390f7f4d5fba499317185 Reviewed-on: https://chromium-review.googlesource.com/c/1351761Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#612252}
-
Sebastien Seguin-Gagnon authored
This reverts commit eabc228b. Reason for revert: May have caused a compile error that closed the tree: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/2197 Original change's description: > Fix DownloadManagerTestCase flakiness. > > On iOS 12 URLSession:dataTask:didReceiveData: delegate method can be > called when task is in NSURLSessionTaskStateCompleted state. This > resulted in extra URLFetcherResponseWriter::Finish call (one from > didReceiveData: and one from didCompleteWithError:). > URLFetcherResponseWriter::Finish DCHECKs if Finish is called twice, so > the test was flaky. > > This CL changes DownloadTaskImpl to only call > URLFetcherResponseWriter::Finish from didCompleteWithError:. > > Bug: 873204 > Change-Id: Ie6b8757e2c5c5d35da088fd108d92ee3ed13244d > Reviewed-on: https://chromium-review.googlesource.com/c/1354233 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612249} TBR=sdefresne@chromium.org,eugenebut@chromium.org Change-Id: I1f7e7620911c73ce1f497fb6ae7b09ed16a2547f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873204 Reviewed-on: https://chromium-review.googlesource.com/c/1355600Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612251}
-
Benoît Lizé authored
v8::string::ExternalStringResourceBase -> StringResource{8,16} cast is undefined behavior, as there is now ParkableStringResource{8,16} and StringResource{8,16}. Add a common ancestor to these two classes, and cast to it to avoid UB. Bug: 909796 Change-Id: I94c65e03f283ca3c9fee344743e3f607686d2846 Reviewed-on: https://chromium-review.googlesource.com/c/1355046 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612250}
-
Eugene But authored
On iOS 12 URLSession:dataTask:didReceiveData: delegate method can be called when task is in NSURLSessionTaskStateCompleted state. This resulted in extra URLFetcherResponseWriter::Finish call (one from didReceiveData: and one from didCompleteWithError:). URLFetcherResponseWriter::Finish DCHECKs if Finish is called twice, so the test was flaky. This CL changes DownloadTaskImpl to only call URLFetcherResponseWriter::Finish from didCompleteWithError:. Bug: 873204 Change-Id: Ie6b8757e2c5c5d35da088fd108d92ee3ed13244d Reviewed-on: https://chromium-review.googlesource.com/c/1354233Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612249}
-
Jonathan Metzman authored
TBR=inferno@chromium.org Change-Id: I2bc6f5c7e165bba9bb4a0e02ca6535128cb59766 Reviewed-on: https://chromium-review.googlesource.com/c/1355481Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612248}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73b3bde2659f..f38fffb7aa2f Created with: gclient setdep -r src-internal@f38fffb7aa2f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:906654 TBR=mmoss@chromium.org Change-Id: I781599f8fc3ee65a6151606e25b935421aaeb03f Reviewed-on: https://chromium-review.googlesource.com/c/1355360Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612247}
-
Mounir Lamouri authored
Bug: None Change-Id: I5c695df177545dcfa69e0cb00cbfcc5f117c7883 Reviewed-on: https://chromium-review.googlesource.com/c/1117618Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#612246}
-
Jeremy Roman authored
It is unused, except for two calls to is AlignedTo which can be inlined. Change-Id: I4aa8b56548b2e217f3ed0eb03be5e7ae5a0d8c54 Reviewed-on: https://chromium-review.googlesource.com/c/1352987 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
Peter K. Lee authored
Bug: 909928 Change-Id: I0168a159049cd92db949d664f8e671f9ba0aee31 Reviewed-on: https://chromium-review.googlesource.com/c/1353956 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612244}
-
Ted Choc authored
Seeing if that will address this sort of crash: Not true that <null> is equal to <com.google.android.libraries.feed.host.storage.CommitResult@422779e0> at com.google.android.libraries.feed.testing.conformance.storage.ContentStorageConformanceTest.lambda$new$8$ContentStorageConformanceTest(ContentStorageConformanceTest.java:110) at com.google.android.libraries.feed.testing.conformance.storage.ContentStorageConformanceTest$$Lambda$8.accept(Unknown Source) at com.google.android.libraries.feed.common.testing.RequiredConsumer.accept(RequiredConsumer.java:32) at org.chromium.chrome.browser.feed.ConsumerSyncWrapper.blockAndWrappedAccept(ConsumerSyncWrapper.java:36) at org.chromium.chrome.browser.feed.ConsumerSyncWrapper.waitForConsumer(ConsumerSyncWrapper.java:56) at org.chromium.chrome.browser.feed.FeedContentStorageConformanceTest$ContentStorageWrapper.commit(FeedContentStorageConformanceTest.java:67) at com.google.android.libraries.feed.testing.conformance.storage.ContentStorageConformanceTest.storeAndDeleteAll(ContentStorageConformanceTest.java:258) See: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/KitKat%20Tablet%20Tester/20063 TBR=aluo@chromium.org,skym@chromium.org BUG= Change-Id: Ic4811ae94f2db270b7717ce04b7ff9a1fc18811e Reviewed-on: https://chromium-review.googlesource.com/c/1355335Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612243}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/81cbcd45e1a2..97b903782cf5 git log 81cbcd45e1a2..97b903782cf5 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 dgarrett@google.com binhost_test: Ignore boards from branch builders. Created with: gclient setdep -r src/third_party/chromite@97b903782cf5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I10b01f0474a15ce38af67d499bc4380cfdaa4000 Reviewed-on: https://chromium-review.googlesource.com/c/1355359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612242}
-
Devlin Cronin authored
APIPermission::CreateAPIPermission() returns a newly-created APIPermission object. Update it to return a unique_ptr rather than a raw c-style pointer. Bug: 907661 TBR=dominickn@chromium.org (mechanical change to chrome_apps_api_permissions.cc) Change-Id: Ia27e4d7da11fce00e30f0fd1720f110e22d74346 Reviewed-on: https://chromium-review.googlesource.com/c/1347796 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612241}
-
Jeremy Roman authored
As of refs/heads/master@{#608185}, it is no longer a DrawingDisplayItem. Change-Id: If25c6d41fdc15dd3bf3b21360eb3306105a1c75e Reviewed-on: https://chromium-review.googlesource.com/c/1355322 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612240}
-
Ned Nguyen authored
Bug: 906654 Change-Id: I08817df22c5043ec92ae51b7deeae15ceb1877ee Reviewed-on: https://chromium-review.googlesource.com/c/1354690Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#612239}
-
Yi Gu authored
Currently upon collecting the inputs for the mutation on main thread, we don't offset the current time by the start time which is incorrect. Note: The layout test animations/animationworklet/worklet-animation-currentTime.html fails the release build because AnimationClock::currentTime is often incorrectly ahead of rAF time so that when asking for the current time in a rAF via getComputedStyle it returns obsolete result. This bug is tracked by https://crbug.com/785940. Bug: 905405 Change-Id: I0b7e293ae942e47b96eb8a7a2a8fefd94be66773 Reviewed-on: https://chromium-review.googlesource.com/c/1343558 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#612238}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fc5105a0. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Ife778af6d81007e56deb6b68e7b5d12b946551d0 Reviewed-on: https://chromium-review.googlesource.com/c/1351265 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612237}
-
Sylvain Defresne authored
Uses IdentityManager API instead of using the soon to be private ProfileOAuth2TokenService and AccountTrackerService APIs. Bug: 908855 Change-Id: If533b43a698b2f2ea7c24ad43273b4ecba74091f Reviewed-on: https://chromium-review.googlesource.com/c/1354447Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612236}
-
Sergio Villar Senin authored
Migrated the SigninManager APIs to the identity APIs. Bug: 890815 Change-Id: Id145953cdece6f58222bedaadbf3358ac3491665 Reviewed-on: https://chromium-review.googlesource.com/c/1354198 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#612235}
-
Sylvain Defresne authored
Pass the account_id by const reference instead of requiring a new std::string each time (since this is invoked in a loop, it can cause lots of unnecessary allocations). Bug: none Change-Id: I5c2f2e53e12616ed5e518250fb965babbd9e68db Reviewed-on: https://chromium-review.googlesource.com/c/1350910Reviewed-by:
-
Dominik Röttsches authored
Removing the CTFont based construction when rolling to HarfBuzz' native AAT lead us to falling back to attempting the mmap'ed access to the font SkStreamAsset. However, the implementation for onOpenStream in SkTypeface_Mac is highly inefficient and synthesizes a font from copying all tables. Disable this type of instantiation on Mac and use the table copy method instead. This should address memory regression for the HarfBuzz AAT roll [1]. [1] https://chromium.googlesource.com/chromium/src/+/c67f53b0b70f33c47159d37f7e59bb44399b0d09 Bug: 908552 Change-Id: Ibf19ea6308f34fd4927e2b7fd59cdff20f3aad6d Tbr: eae@chromium.org, behdad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1355129Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Behdad Esfahbod <behdad@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#612233}
-
Kevin McNee authored
Now that we're using Shadow DOM v1, we have the option to make the shadow DOM unreachable by outside script by specifying a closed encapsulation mode. Now GuestViews will behave more like other elements defined by the browser which internally use shadow DOM. This also prevents script from interfering with our internal elements and producing unexpected behaviour. Bug: 892886, 803274 Change-Id: I57b2513e3ff7290e286b3d8391e7d93bac2bc4e9 Reviewed-on: https://chromium-review.googlesource.com/c/1342768 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#612232}
-
Jan Wilken Dörrie authored
This change modifies the "Passwords" entry in the settings page to link to the Google Password Manager if the necessary conditions are met. Currently this includes users that are syncing their passwords without a custom passphrase and for which the corresponding Google Password Manager experiment is active. Bug: 904821 Change-Id: If93ee671b1c1b9aee17467aa9382fe5e834ead55 Reviewed-on: https://chromium-review.googlesource.com/c/1350877 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#612231}
-
danakj authored
TBR=dmazzoni@chromium.org NOTRY=true Change-Id: Ib20e44b272d84612d480bf3cccf4bbf8dec20fa1 Bug: 498881 Reviewed-on: https://chromium-review.googlesource.com/c/1355323 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Lily Chen authored
This change allows the reprioritization of HttpProxyConnectJobs by adding a SetPriority method to the underlying HttpProxyClientSocketWrapper. Depending on the type of proxy client socket being requested, the reprioritization is passed down to the transport or SSL socket pool, or the SPDY or QUIC stream request. Bug: 166689 Change-Id: I593632a48ee43141277e5c50f81fda57662f523c Reviewed-on: https://chromium-review.googlesource.com/c/1343047 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#612229}
-
Sami Kyostila authored
The base perftests can take longer than the default 120 seconds to execute -- especially on low end Android devices. Increase the timeout on Android to 10 minutes. Bug: 906686 Change-Id: Iacfe08e3cbd1d6e7ef756a1a8c1028655a5d3918 TBR=fdoray@chromium.org Change-Id: Iacfe08e3cbd1d6e7ef756a1a8c1028655a5d3918 Reviewed-on: https://chromium-review.googlesource.com/c/1353922Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
Also adjusted the paddings to account for the different aspect ratio of the new image. Bug: 806868 Change-Id: I7bd161dfd8b74b784d934ba5ec1dce37793bfe85 Reviewed-on: https://chromium-review.googlesource.com/c/1352161Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#612227}
-
Doug Arnett authored
Records preview-type-agnostic counts for: Previews.OptOut.UserOptedOut, Previews.PageEndReason, and Previews.EligibilityReason Bug: 904009 Change-Id: I13506b3b002a83a78d38a79006a02afa13a1c29f Reviewed-on: https://chromium-review.googlesource.com/c/1354564Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#612226}
-
edchin authored
We need OWNERS for the commands folder, especially as they are actively being refactored. Change-Id: I106373a92ea59db68514546d5315a5e4110610a9 Reviewed-on: https://chromium-review.googlesource.com/c/1354495 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612225}
-
Shawn Gallea authored
Prevented ChromeOS-specific funcionality from compiling for other platforms. To be used for EXO on cast shell. This CL does not offer any additional functionality. Bug: 896710 Test: Run exo_unittests on ChromeOS Change-Id: I72678ae35efce395f932b7d0ade816d61dd6e992 Reviewed-on: https://chromium-review.googlesource.com/c/1327402 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#612224}
-
Vincent Boisselle authored
Change-Id: Id425ec396cd9d1779138133e725dfcd0c2ef0f2c Reviewed-on: https://chromium-review.googlesource.com/c/1354263Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vincent Boisselle <vincb@chromium.org> Cr-Commit-Position: refs/heads/master@{#612223}
-
chuanl authored
Bug: 882404 Change-Id: I3fc0c70ba2694dd2e513c1a882c505471db6fccf Reviewed-on: https://chromium-review.googlesource.com/c/1355161Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: John Lin <chuanl@google.com> Cr-Commit-Position: refs/heads/master@{#612222}
-
edchin authored
Bug: 905524 Change-Id: I7856854bada0ef0a0285a4f3b0d362f9c2113f97 Reviewed-on: https://chromium-review.googlesource.com/c/1354781Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5f01324fb627..a1442ecdf514 git log 5f01324fb627..a1442ecdf514 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 syoussefi@chromium.org Vulkan: Uber-shader support Created with: gclient setdep -r src/third_party/angle@a1442ecdf514 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ib215ad81b09d61c2a14339eb20274b0a40170b7d Reviewed-on: https://chromium-review.googlesource.com/c/1354984Reviewed-by:
-
Bo Liu authored
Add a java interface AwFunctor to so AwContents does not have to explicitly distinguish between GL and Vulkan functor. Rename some method names so they make more sense, and make AwGLFunctor inherit from the new interface. Bug: 900965 Change-Id: I39cfa73696ce71f2fd38b11240665176718a8941 Reviewed-on: https://chromium-review.googlesource.com/c/1354679 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#612219}
-
Peter E Conn authored
The Add to Homescreen feature will now consider "maskable" icons from the web app manifest [1]. If a maskable icon is present and we are on an Android O+ device, turn that "maskable" icon into an Android Adaptive icon [2]. The icon is scaled to ensure that the safe zone is preserved [3]. [1]: https://w3c.github.io/manifest/#purpose-member [2]: https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive [3]: https://github.com/w3c/manifest/issues/555#issuecomment-404097653 Bug: 904354 Change-Id: Iedfe61ace0fda4ca7f3ed3da6a5d07f2bff81443 Reviewed-on: https://chromium-review.googlesource.com/c/1341998 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#612218}
-
Chris Sharp authored
Also cleanup the test names to be more descriptive of what parameter were used. Bug: 907443 Change-Id: I4a42d1aad2856beda89911e63256ea8d0f67bb54 Reviewed-on: https://chromium-review.googlesource.com/c/1349751Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#612217}
-
Xida Chen authored
This CL is implementing the Phase 1 described in this doc: https://docs.google.com/document/d/1v-k8Ck7x_2kpBfgaVmqg2NvQRvD1PqyOt50rdO141Wc/edit# Basically, it redefines the StylePropertyMapReadOnly to be a pure interface. Then it renames the existing StylePropertyMapReadOnly to StylePropertyMapReadOnlyMainThread. Then it makes all subclasses of StylePropertyMapReadOnly to be subclasses of StylePropertyMapReadOnlyMainThread. This CL should not introduce any behavior change. Bug: 895579 Change-Id: I400981d1745ab3ee80b9ba9b77c3e3406cd0c1e7 Reviewed-on: https://chromium-review.googlesource.com/c/1354118 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#612216}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9b825600fd5..73b3bde2659f Created with: gclient setdep -r src-internal@73b3bde2659f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I08d3f91a6e9df0b9fae9c87647e6eef01b3fd175 Reviewed-on: https://chromium-review.googlesource.com/c/1354987Reviewed-by:
-
Nicolas Pena authored
This CL moves the tests in http/tests/event-timing to external/wpt/event-timing. The slow image is change from php based to python based. The click is now handled by test driver. and setTimeout is replaced with step_timeout. Bug: 841224, 908187, 907948, 907949 Change-Id: Ia6359878666cfb96645aa3b7cd7736ce9df97683 Reviewed-on: https://chromium-review.googlesource.com/c/1352617Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#612214}
-
