- 14 Sep, 2018 40 commits
-
-
Stefan Zager authored
Previously, IOv2 layout tests would enable IOv2 in script via: if (window.internals && internals.runtimeFlags) { internals.runtimeFlags.intersectionObserverV2Enabled true; } There are two problems with this approach: 1. By the time the above code runs, it may be too late: the prototype for the IntersectionObserverEntry javascript type may already have been created *without* the isVisible attribute. This was causing flaky test failures, because the exact timing of when the prototype is created may vary between runs. 2. Because the layout test runner re-uses content_shell processes for multiple tests, the side effects from turning on the feature flag affect tests that later use the same renderer process (see bug). This CL also adds DisableIntersectionObserverV2ThrottleForTesting, which eliminates the need to add a bunch of 100ms timers to the tests. Slow tests are bad. Finally, this CL reorders the handshake for cross-origin tests that rely on postMessage, to ensure that both the embedding frame and the child frame are properly initialized before starting the test procedure. BUG=882280,883676 R=chrishtr@chromium.org,foolip@chromium.org Change-Id: I18e62c2cf099bf74ef4afc43f46a794c7a322582 Reviewed-on: https://chromium-review.googlesource.com/1220044 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591483}
-
Ryan Tseng authored
So that builder pools can be merged in bots.cfg Bug: 868213 Change-Id: Iea69b964ad411c15ee5c79fb67af7dff61792449 Reviewed-on: https://chromium-review.googlesource.com/1227146Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#591482}
-
Johann authored
Fork the arm builds so we can enable vp9 profile 2 (high bit depth) on chromeos devices without affecting other arm devices. BUG=chromium:875773 Change-Id: I23a9c2875a8585e2fd4e45ecc2a0e8b3ab317585 Reviewed-on: https://chromium-review.googlesource.com/1227217Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#591481}
-
Sky Malice authored
Bug: 866125 Change-Id: I8f4da0990340d71342076f2d3ee5565267ad37f2 Reviewed-on: https://chromium-review.googlesource.com/1222683 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591480}
-
Lukasz Anforowicz authored
|window.opener| in main frame can point at a subframe (if the subframe called before |window.open('', '<name of the main frame>')|. If both frames are at about:blank, this can lead to an infinite loop in ScriptContext::GetEffectiveDocumentURL. Bug: 883526 Change-Id: I49b93b0bd068b1d0f2ea0241d0ede32ec6d6c689 Reviewed-on: https://chromium-review.googlesource.com/1222877 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591479}
-
Mike Wasserman authored
Touch selection editing handles use window targeting insets. (to let users more easily tap text above the visible handle) Adjust targeting of the handle's client root window in Mus. (otherwise events target the server's invisible root window) Bug: 872891 Test: KSV (Ctrl-Alt-/) touch edit handles don't block tapping text. Change-Id: I6d8614257dc4927a1562bc02c2eefef1f8ff2faa Reviewed-on: https://chromium-review.googlesource.com/1226877Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#591478}
-
Jian Li authored
This reverts commit d91dacc0. Reason for revert: Failed base_unittests Run on OS: 'Ubuntu-14.04' SequenceBoundTest.MultiplyDerivedDestructionWorksLeftSuper SequenceBoundTest.MoveAssignmentFromDerivedClass SequenceBoundTest.MoveConstructionFromSameClass SequenceBoundTest.MoveAssignmentFromSameClass SequenceBoundTest.PostBeforeConstruction SequenceBoundTest.MoveConstructionFromDerivedClass SequenceBoundTest.MultiplyDerivedPostToLeftBaseClass SequenceBoundTest.ConstructThenPostThenReset SequenceBoundTest.MoveAssignmentFromDerivedClassDestroysOldObject SequenceBoundTest.MultiplyDerivedDestructionWorksRightSuper SequenceBoundTest.MultiplyDerivedPostToRightBaseClass https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/10148 Original change's description: > SequenceBound<T> for classes with affinity to a sequence. > > SequenceBound<T> allows for easy creation, posting, and destruction > objects of type T on a designated Sequence. It does not expose the > underlying pointer to T, so it's hard to accidentally pass them around > in callbacks that are then run on the wrong thread. > > A SequenceBound<> may be created anywhere, passed (moved) between > threads, etc., safely. Destruction of the SequenceBound schedules > destruction of the underlying instance of T on the appropriate thread. > > Not implemented here (but prototyped elsewhere) are weak pointers > to these objects that may be passed and used between threads safely; > utility functions to generate thread-hopping callbacks; support for > strong shared ownership semantics. > > Tests: sequence_bound_unittest.cc > > Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I3bbf7e975884fce8e18f3bb15a0d211ead58a619 > Reviewed-on: https://chromium-review.googlesource.com/875241 > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591429} TBR=dcheng@chromium.org,dalecurtis@chromium.org,liberato@chromium.org,tzik@chromium.org Change-Id: I122ffbe8eb1670e7a252392fb7c28652672d1bc7 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1227356Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#591477}
-
Christian Biesinger authored
Use =default in some places where we can, to avoid hand-writing move constructors and move assignment operators. Also adds a move constructor to NG{Unp,P}ositionedFloat and adds a missed std::move call. R=eae@chromium.org,ikilpatrick@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8c3c850d495b455a9a6dddff0b62f3dcf1927c64 Reviewed-on: https://chromium-review.googlesource.com/1226008Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#591476}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/776a411b5267..a7914d3a8e3b git log 776a411b5267..a7914d3a8e3b --date=short --no-merges --format='%ad %ae %s' 2018-09-14 michaelludwig@google.com Implement textured gradients 2018-09-14 csmartdalton@google.com ccpr: Remove the dangling pointer from GrCCDrawPathsOp 2018-09-14 robertphillips@google.com Harden SerializedImageFilter fuzzer against filter creation failure 2018-09-14 robertphillips@google.com Preserve fLastMoveToIndex in SkPath::transform 2018-09-14 caryclark@skia.org fix error reporting for doc examples 2018-09-14 michaelludwig@google.com Implement dual interval gradients Created with: gclient setdep -r src/third_party/skia@a7914d3a8e3b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I7d0ec294f34b7e529cc1623651a44312662caf88 Reviewed-on: https://chromium-review.googlesource.com/1226387Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591475}
-
danakj authored
In WebKit there were multiple WebPopupType values, such as None, Select, Suggestion, Page, HelperPlugin. In Blink however there are only two: None - it's not a popup, it's a frame. Page - it is a popup. As such, when creating a popup widget, there is no need to specify the PopupType, as it would always be Page. And when creating a frame widget, there is also no need as it will be None always. To this end, we make a few changes: 1. WebPopupType is not needed in blink, so move to content/public/ and rename it to WidgetType (as it is indeed the type stored on RenderWidget and RenderWidgetHostViewBase. 2. Do not plumb WebPopupType through the RenderWidget's CreateForPopup() path, nor through the mojo calls to the browser when creating the widget and setting up the routing id. RenderMessageFilter::CreateNewWidget() is only called for popups so does not need the enum. 3. Thus plumbing continues being removed up through to WebContentsImpl where we do end up calling CreateNewWidget() with the enum for fullscreen widgets (which are frames) and for popup widgets, so we keep the enum there. 4. The mac RenderWidgetHostNSViewBridgeLocal class was receiving the popup type from the RenderWidgetHostViewMac when it is called (via mojo) to InitAsPopup(). This path is only used when making a popup widget, not a frame widget, so we: 4a. DCHECK and stop plumbing the WebPopupType over to the RenderWidgetHostNSViewBridgeLocal class. It had a TODO mentioning that the PopupType == Page should be equal to there being a popup_window_, which it is as they are set together. So change IsPopup() there to check the popup_window_ instead. 4b. Also stop plumbing the PopupType to PopupWindowMac, which was setting RenderWidgetHostViewCocoa::setCanBeKeyView to NO if the PopupType was Page, which it always would be. So just set it to NO always. 5. The RenderMessageFilter::CreateNewWidget() call returns a routing id which is never 0, however the RenderWidget was checking for 0 and returning nullptr in that case. Instead DCHECK and stop returning nullptr so callers also won't have to check. There are a bunch of function/variables named for WebPopupType instead of WidgetType that could change but will be done in a follow-up instead. R=awong@chromium.org, ccameron@chromium.org, dcheng@chromium.org Bug: 419087 Change-Id: I88d6eba93cf737b47b823dbead55664cb514fa4a Reviewed-on: https://chromium-review.googlesource.com/1225608Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#591474}
-
Alex Gaynor authored
A disassembly of CGSSetDenyWindowServerConnections indicates that it only actually does anything when there are no currently open WindowServer connections. There should be no open connections, so we call it and verify that we succeeded. Bug: 880886 Change-Id: I59bce619d1e684da1fc9356a89c129f990c8e91c Reviewed-on: https://chromium-review.googlesource.com/1150668 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#591473}
-
Joshua Peraza authored
a521447214be Use x30 register instead of LR, which GCC doesn't seem to understand 78bf924fa63d linux: Read /proc/<pid> files via PtraceConnection 9dcf4ab23efc arm/linux: Fix build after a5214472 b918119ca20a linux: Read thread IDs via a PtraceConnection 076d760d636a linux: Check for SO_PASSCRED on client sockets before setting 8595f4b4231d linux: allow collecting scheduler priorities to fail Change-Id: I548d90da4e2c6a85a3508b3fb7d84a8319977df6 Reviewed-on: https://chromium-review.googlesource.com/1226358Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#591472}
-
Krishna Govind authored
R=benmason@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4bb7b84d18dd9b625a795aaa873ff821756ea442 Reviewed-on: https://chromium-review.googlesource.com/1227227Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#591471}
-
Tarun Bansal authored
Reenable some of the flaky NoScript browser tests. This CL includes two fixes: 1. Ensure that some of thread unsafe variables are not referenced cross-thread. 2. Disables loading of blacklist database which is racy with the first page load. At least one of the test flakes that I reproduced locally was because of this. Change-Id: If3c7190532f5feebf686f02dd9a3003e7396f9f4 Bug: 869781 Reviewed-on: https://chromium-review.googlesource.com/1226851Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#591470}
-
Min Qin authored
When only running the service manager, a simple PrefService containing user PrefStore and commandline PrefStore can be created before BrowserProcessImpl. And it will be passed to the BrowserProcessImpl to create the local_state. The implementation has already landed here: https://chromium-review.googlesource.com/c/chromium/src/+/1148959 This CL makes it possible to migrate the simple PrefService to local state by adding new pref stores, rather than creating the latter from scratch. The benefit of doing this is that existing listeners to the simple PrefService won't need to handle the case of swapping PrefServices, re-registering PrefChangeRegistrar and default values, and verifying no pref value changes during the swap. Bug: 866028 Change-Id: I35b643d27ffabd9621f21f68a3261aa3482ca173 Reviewed-on: https://chromium-review.googlesource.com/1199944 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#591469}
-
W. James MacLean authored
This is a CL with temporary diagnostic code for https://crbug.com/882458. This CL will be landed and left in ToT long enough to collect data, and then reverted quickly, and certainly prior to the next stable branch cut. Bug: 882458 Change-Id: I5c5d1f2e26a032f743a86af6f335e6942f97e423 Reviewed-on: https://chromium-review.googlesource.com/1227130Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#591468}
-
gogerald authored
Change-Id: Ic76d28bc5f3e4b0165fc2f6f1433f08c9b3701a6 Reviewed-on: https://chromium-review.googlesource.com/1225282 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#591467}
-
Xiyuan Xia authored
Make AuraTestHelper take a given aura::Env and do the test setup for that Env. TestWs uses it to setup an aura::Env for WindowService when running in single process mode. Bug: 874089 Change-Id: I65914ed9942c6ce779cdde4a31ef04d727c8fb29 Reviewed-on: https://chromium-review.googlesource.com/1226365Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dba95ab0..41562c7c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I739c615c33187193f32f4f8f668bda6d95358155 Reviewed-on: https://chromium-review.googlesource.com/1227172Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591465}
-
Dave Tapuska authored
Current scroll chain was incorrectly using a deque of ints as opposed to a DOMNodeId chain (which is a 64 bit field) Use wtf_size_t when dealing with WTF containers. BUG=588506 Change-Id: I4f9e45062c931bee5014c9f3efad80147cf8a79c Reviewed-on: https://chromium-review.googlesource.com/1226363Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#591464}
-
Robbie McElrath authored
As more classes get migrated from NetworkChangeManager to NetworkConnectionTracker, more and more tests need a TestNetworkConnectionTracker instance set up, including many tests that are pulling in the NetworkConnectionTracker indirectly, so shouldn't need to set up the test instance themselves. To make sure all tests have access to the test instance, this CL makes TestNetworkConnectionTracker a singleton that is setup at the beginning of each test suite, which ensures only one instance is ever created, and it's torn down at the right time. Bug: 868015 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I90ca6ddfa1669f476b03fa7e27230288dfc4101e Reviewed-on: https://chromium-review.googlesource.com/1214081Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#591463}
-
Mitsuru Oshima authored
ImmersiveFullscreenController replaces the targeter to ResizeHandleWindowTargeter, which will make the input hit test not considering Chrome caption. BUG=b:113815571 TEST="Manual tests. exo_unittests." Change-Id: I9de803b24cf64034f2c0f60e04acf147a230ec95 Reviewed-on: https://chromium-review.googlesource.com/1226812Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#591462}
-
Xiaohan Wang authored
Bug: 883494 Test: Updated test case to make sure the value is passed through. Change-Id: I2d74978bd29c048b5aac8e51d12ef46db0009450 Reviewed-on: https://chromium-review.googlesource.com/1224597 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Rintaro Kuroiwa <rkuroiwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#591461}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c7d935899ab9..d574123c5035 git log c7d935899ab9..d574123c5035 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 buildbot@webrtc.org Roll chromium_revision 2c0c7dfd..1d75f6fc (591272:591373) 2018-09-14 sprang@webrtc.org Add hysteresis to enabling of simulcast streams. 2018-09-14 srte@webrtc.org Removes legacy PacketQueue implementation. Created with: gclient setdep -r src/third_party/webrtc@d574123c5035 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1875e88dcd3db697ee4df1f9121b7faceff0bb18 Reviewed-on: https://chromium-review.googlesource.com/1226389Reviewed-by:
-
Dana Fried authored
This change adds an object which can access the UWP accessibility settings and listen on change events. It is used by the Windows implementation of display::Screen to listen for text zoom changes, which we have made the decision to support by changing our overall scaling by the same percentage (as anything more thorough would be prohibitively expensive in the current architecture). We achieve compliance by multiplying DPI and text zoom scaling together, the approach recommended as a stopgap by both our engineers and those working on a11y at Microsoft. Note that while this affects *most* UI within Chrome, it does not affect *all* UI - some elements (such as resize frame) are drawn by the system and are only scaled by DPI. A side effect is that all zoom factors are rounded to the nearest 25%, so for instance, a net zoom of 190% will be rounded up to 200%. This will prevent DPI * Zoom factors that are not even multiples of 25% from creating blurry or smeared Chrome rendering or similar artifacts, which we have already seen as a result of problems with DPI scaling. Another effect is to decouple physical DPI from screen scaling, which has necessitated some small changes to the Windows Glass frame as well as the handler for the DPI changed Windows event. Without these changes serious visual artifacts and DCHECK failures can occur because systems are reporting/using different measurements for DPI. Changes to the Glass frame were necessary because Windows paints the resize handle around the window and does not use the text scale factor as part of its size calculation. Bug: 866513 Change-Id: Ia99d1f3c1b2aff973d63bd7ff637b01f166cd843 Reviewed-on: https://chromium-review.googlesource.com/1214747Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#591459}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4aefea51330c..7437f9dd69ca git log 4aefea51330c..7437f9dd69ca --date=short --no-merges --format='%ad %ae %s' 2018-09-14 athilenius@google.com Revert "Add tael and tatl to default PreCQ" Created with: gclient setdep -r src/third_party/chromite@7437f9dd69ca The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3aa70e3ada29591f79ac5325d6d3a5b7afb266e9 Reviewed-on: https://chromium-review.googlesource.com/1226388Reviewed-by:
-
liberato@chromium.org authored
This CL causes D3D11VideoDecoder to refuse to play back encrypted media, unless the D3D11EncryptedMedia flag is set. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia4c01c75ee84c37e047a548af18e8fe2bc3fce91 Reviewed-on: https://chromium-review.googlesource.com/1226100Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#591457}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0f4c772ee290..6d5f1bc2e846 git log 0f4c772ee290..6d5f1bc2e846 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 31666470+s-perron@users.noreply.github.com Allow merge blocks to merge two header blocks in some cases. (#1890) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@6d5f1bc2e846 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie522f1c01182645b80851be6b61d4b60001d15a9 Reviewed-on: https://chromium-review.googlesource.com/1227150Reviewed-by:
-
Charlie Harrison authored
This API is deprecated. Bind is replaced by BindOnce which is a semantics change, but shouldn't result in a behavior change. Bug: 884057 Change-Id: I06e728a88a84ed6e042e6f2e90f5a0ad9d40eecb Reviewed-on: https://chromium-review.googlesource.com/1225994Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#591455}
-
Xida Chen authored
In this CL, we append the unique_touch_event_id to a debug string, at the time when we get ACK for touch sequence start and touch sequence end, this way we'd know their correspondences. Bug: 851644 Change-Id: I2ee486bb2a2348a14e74a17e32f495aceaaab374 Reviewed-on: https://chromium-review.googlesource.com/1226820 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591454}
-
Vikas Soni authored
Bug: 838725 Change-Id: I379b72f1c1c3e428e9892d94a6c554da74bbf5db Reviewed-on: https://chromium-review.googlesource.com/1225971Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#591453}
-
Xiaohan Wang authored
Bug: 854943 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6c53ae4eac8526117cf2485f481302020f9bf0d7 Reviewed-on: https://chromium-review.googlesource.com/1225296Reviewed-by:
-
Robert Ogden authored
Adds the chrome-proxy auth header plumbed from DRP and the ect header to every lite page request. Also moves around some DRP testing functions to help with the browser test for this CL. Also fixes a small DRP bug which is tickled causing the chrome-proxy-ect header to be removed on HTTPS requests. Bug: 864652, 864654 Change-Id: I215d99591c4cf29cc373183dac2db694e6e75c3e Reviewed-on: https://chromium-review.googlesource.com/1223333Reviewed-by:
-
James Cook authored
During OOBE and normal user login, when SessionController::SetUserSessionOrder() is called there is an existing user session, so last_active_account_id.is_valid() returns true and the observer never fires. I suspect this breaks some accessibility features in kiosk mode (magnifier keyboard control) and for hotrod (long-press for spoken feedback). It's probably been broken since the observer was added in May: https://chromium-review.googlesource.com/c/chromium/src/+/1070771 Bug: 884275 Test: added to ash_unittests Change-Id: Idbe4f20b7426742703995a05c7ebb1c5c8f1a7c8 Reviewed-on: https://chromium-review.googlesource.com/1226876Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#591450}
-
Xianzhu Wang authored
The new name is the same as the existing name used in cc::EffectNode. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3eb99897797e849a4e6fd3a96181473d5eb03bf9 Reviewed-on: https://chromium-review.googlesource.com/1226018Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591449}
-
kylechar authored
When using InProcessCommandBuffer for OOP-D we weren't tracking texture memory correctly as there was no MemoryTracker instance created along with the ContextGroup. This CL fixes that by pulling GpuCommandBufferMemoryTracker out of CommandBufferStub into it's own header. GpuCommandBufferMemoryTracker is generalized a bit not to require a GpuChannel* on construction but otherwise functions the same. For platforms other than WebView, InProcessCommandBuffer will create a GpuCommandBufferMemoryTracker. Unfortunately just implementing MemoryTracker doesn't fix memory reporting. MemoryAllocatorDumps for the same texture from multiple instances of TextureManager aren't linked together. This is because ShareGroupTracingGUID() doesn't return a share group id, it returns a command buffer id, so TextureManagers for different command buffers won't generate the same GUID. Fix this by removing ShareGroupTracingGUID(). All contexts are expected to be in the same share group, or virtualized to the same context in ANGLE, so differentiating between share groups isn't necessary. Add CommandBufferId() for when the command buffer id is desired. Bug: 876508 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie084061d321ffa49ca7c31619707e60dfca3dd97 Reviewed-on: https://chromium-review.googlesource.com/1211955Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#591448}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b5e878155404..53f9d8726afd git log b5e878155404..53f9d8726afd --date=short --no-merges --format='%ad %ae %s' 2018-09-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@53f9d8726afd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I46d93d3a8fe5b24e0542a4f356905364aa9c0990 Reviewed-on: https://chromium-review.googlesource.com/1227230Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7f2329398fe8..4230d4847fdc git log 7f2329398fe8..4230d4847fdc --date=short --no-merges --format='%ad %ae %s' 2018-09-14 jmadill@chromium.org Finish fixing EGL enums. 2018-09-14 jmadill@chromium.org Vulkan: Fix cube map attachment clears and readpixels. Created with: gclient setdep -r src/third_party/angle@4230d4847fdc The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I76d85fbf89bdb85ec154df1c7c2f96b5dc1f00e4 Reviewed-on: https://chromium-review.googlesource.com/1226029Reviewed-by:
-
Chris Harrelson authored
To do this, use the base::Optional pattern instead of a scoped_refptr. Bug: 459810 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I64ada0722e1e04b1f0402c6d3e9d2ed4879164dd Reviewed-on: https://chromium-review.googlesource.com/1226072 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591445}
-
Vladimir Levin authored
My previous patch missed one spot where we can unalias a node which is actually null. This patch fixes up that spot. R=pdr@chromium.org, chrishtr@chromium.org Bug: 884081, 884083, 884084, 884186 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic12a21c429c4984cb18f92f6beac8c18c0f51f87 Reviewed-on: https://chromium-review.googlesource.com/1227147Reviewed-by:
-
