GitLab

This is a reland of e14722dd

Original change's description:
> Move the APIs using XRANR to ui/base/x folder
> 
> It creates x11_display_util.cc/h files and moves the APIs to
> get display information using XRANR from DesktopScreenX11 to
> share the implementation with Ozone/X11.
> 
> 'GetXrandrVersion' is to get xrandr version,
> 'GetFallbackDisplayList' is to get a fallback display and
> 'BuildDisplaysFromXRandRInfo' is to get a list of displays from
> the current screen.
> 
> It also moves 'GetICCProfileForMonitor' from DesktopScreenX11
> to x11_util.cc.
> 
> These APIs are required for Ozone/X11 as well. This change doesn't
> bring any behavioral changes.
> 
> Bug: 891175
> Change-Id: Idb42b1929b7bfab4501ced4403fc176342ebdada
> Reviewed-on: https://chromium-review.googlesource.com/c/1295762
> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602634}

Bug: 891175
Change-Id: I742eec8285b023adda84d28d68a21f7545a87f8c
Reviewed-on: https://chromium-review.googlesource.com/c/1301036Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603262}

GetNetworkChangeManager was incorrectly added in r577168 but was
never called. This change removes that vestigial code.

Bug: 836188
Change-Id: I618712829d04e94c1bb4e2c1d3fe5c16475daa6f
Reviewed-on: https://chromium-review.googlesource.com/c/1271556Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603261}

Adding the annotation makes it clear which fields are protected by
base::Lock, and enables compile-time analysis to verify this.

BUG=893739,887645
TEST=compiles

Change-Id: Ideddb22c0687168d25ceab9ad30f32797862fcfd
Reviewed-on: https://chromium-review.googlesource.com/c/1302323Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603260}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a4f6a37d..6cc0ff81

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I5cae1492c12250d85f78b246eb682391a2876b8f
Reviewed-on: https://chromium-review.googlesource.com/c/1302324Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603259}

This event will help figuring out a bug happening with sampling profiler.
We currently don't know if the event is emitted from tracing sampler
profiler or from UMA sampling profiler.

This event should be rare, only on error cases.

R=oysteine@chromium.org

Change-Id: Id761ef1744c6a2ec924992229ce55e8bc6deac87
Reviewed-on: https://chromium-review.googlesource.com/c/1301968Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603258}

With recent fixes for multi-display (crbug.com/892714), now
some tests in tab-dragging works. Still the test code needs
to wait for the bounds changes, since related display ID
change arrives asynchronously.

Two tests are still failing because of other reasons.

BUG=890071
TEST=single_process_mash_interactive_ui_tests

Change-Id: I2b73f5ded68fcf0431b67d03737cd137ea57e3d1
Reviewed-on: https://chromium-review.googlesource.com/c/1300689
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603257}

Bug: 895035
Change-Id: Ie95cd3888fad2a45d7f0946f1a5c21bbb482cae7
Reviewed-on: https://chromium-review.googlesource.com/c/1297245Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603256}

This is a reland of cb9c3091

R=dmazzoni@chromium.org,aleventhal@chromium.org
TBR=afakhry@chromium.org,ellyjones@chromium.org,sky@chromium.org
Bug: 811277

Original change's description:
Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants

Also renamed some methods to make interface more consistent.
In preparation for more changes in AXVirtualView.

Change-Id: I815d6d941f18ef84864636bc02423af20b0bbc97
Reviewed-on: https://chromium-review.googlesource.com/c/1303093Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603255}

The test takes a screen wake lock in an iframe, then navigates the
iframe to another origin, and verifies the lock is released.

The problem is the lock is released when the original iframe's renderer
tears down and sends FrameHostMsg_SwapOut_ACK to the browser. But
navigation in the iframe can complete before that (it's a race). So
the test now waits for the old frame's RenderFrameHost to be cleaned
up before verifying the lock is released.

R=avi@chromium.org

Change-Id: I4aed27d1a78b8fdf6451228e3ee125bd465f6f4f
Bug: 899384
Reviewed-on: https://chromium-review.googlesource.com/c/1303176Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603254}

If we set |compositor_| during AddedToWidget() and not call Play(), the
compositor could shutdown and we would never clear |compositor_| since
we're not registered as an AnimationObserver and will miss
OnCompositingShuttingDown().

BUG=899112

Change-Id: If1dbe4ae9db80d55d3d5db6d939da6008bf97160
Reviewed-on: https://chromium-review.googlesource.com/c/1300694
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603253}

My recent change on client_root actually had a side effect;
the window may change its display when the display is gone
(e.g. disconnected). Window server should send DisplayChanged
event even in such case.

BUG=890071
TEST=the new test case covers

Change-Id: I8566e6439bc8e87a0e3252aded8c9aa08cb1c7a9
Reviewed-on: https://chromium-review.googlesource.com/c/1302734
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603252}

Just using std::move appropriately is probably
sufficient for avoiding extra copies and it's
easier to understand what's going on. Also less code.

Bug: chromium:891377
Change-Id: I321e969bdede991c223cf842a6a572704d060f11
Reviewed-on: https://chromium-review.googlesource.com/c/1302109
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603251}

This includes things like old prefs, metrics and finch features.

Bug: 662944
Change-Id: Ib7199895bb3b588efcb88c8898eb696b75717fa8
Reviewed-on: https://chromium-review.googlesource.com/c/1294130
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603250}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f74d12074e19..d8ed054e9af7


git log f74d12074e19..d8ed054e9af7 --date=short --no-merges --format='%ad %ae %s'
2018-10-26 sammc@chromium.org chromite: fix cros_mark_as_stable --list_revisions.


Created with:
  gclient setdep -r src/third_party/chromite@d8ed054e9af7

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I07670c8742410463d5c3666a2261f755af5cb1d2
Reviewed-on: https://chromium-review.googlesource.com/c/1302713Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603249}

These tests do a navigation then open tabs, measuring the number of
RenderProcessHosts that exist. However the initial navigation
does not wait for the original RenderProcessHost being navigated away
from to be destroyed. Since that does not happen when the navigation
is completed, but once the old renderer does a SwapOut_ACK, this test
races with the SwapOut_ACK and counts the wrong number of processes if
it does not wait for that first.

R=avi@chromium.org

Change-Id: I844cef55bd8bce3abb5df2820976a7d14354dfbb
Bug: 442785
Reviewed-on: https://chromium-review.googlesource.com/c/1302860
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603248}

The decode ref is always released for an upload task, even if it is
cancelled. But the ref was being added only when the task runs in the
case of upload only tasks for bitmaps. Fix that.

R=ericrk@chromium.org

Bug: 899202,899198
Change-Id: I884755e6f4a7ad3bc7fcf93b762246695c732493
Reviewed-on: https://chromium-review.googlesource.com/c/1302495Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603247}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ef5883ceab7..e060ac16d2fc


Created with:
  gclient setdep -r src-internal@e060ac16d2fc

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1128b61428a4bedb2583aadbd8a657e115f4a8dd
Reviewed-on: https://chromium-review.googlesource.com/c/1302794Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603246}

We recently added error code to sampling profiler. This CL is whitlisting
it's args to get the error code.


see: https://cs.chromium.org/chromium/src/base/profiler/native_stack_sampler_win.cc?g=0&l=455


 if (error_code != NATIVE_STACK_SAMPLER_SUCCESS) {
    TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("cpu_profiler"),
                         "RecordStackFramesFailed", TRACE_EVENT_SCOPE_THREAD,
                         "error_code",
                         NativeStackSamplerErrorToString(error_code));
  }


R=oysteine@chromium.org

Bug: 867931
Change-Id: I1134ccdaaa0586d4102760d8cfc4df2869539f3d
Reviewed-on: https://chromium-review.googlesource.com/c/1301835Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603245}

We want to experiment with more aggressive throttling for BEST_EFFORT
tasks. With this experiment, there can be multiple seconds delay
before a BEST_EFFORT task is scheduled.

Because it is currently necessary to run a BEST_EFFORT task to stop
tracing, using the chrome://tracing UI is painful when the experiment
is enabled. This CL fixes this issue by changing the priority of the
tracing coordinator service backend TaskRunner from BEST_EFFORT to
USER_VISIBLE. Note that USER_VISIBLE is the appropriate priority for
a task that may affect the UI.

Bug: 831835
Change-Id: Iaebeddd006f802d8f73694ef4817ea976490b6a3
Reviewed-on: https://chromium-review.googlesource.com/c/1302321Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603244}

This involves changing SequenceSortKey from high == important to low == important, because IntrusiveHeap is a min-heap (as opposed to std::priority_queue, which is a max-heap).

Bug: 889029
Change-Id: Ieeb2707d0112389b6cb7f4d187ec447bc58bef5a
Reviewed-on: https://chromium-review.googlesource.com/c/1302319
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603243}

Talking with Bruce Dawson, it could be helpful to know all the
generated boundary values in order to discern if there is a
pattern.

Bug: 836238
Change-Id: I40ddda5e93d298508fb89fe828245fea39c98b6c
Reviewed-on: https://chromium-review.googlesource.com/c/1302315
Commit-Queue: Brian White <bcwhite@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603242}

For a composited object whose layout location is at (10.5, 10.5), we
snap the layer location to (11, 11), and keep a subpixel accumulation
(-0.5, -0.5). RoundIntPoint(LayoutUnit(-0.5, -0.5)) is zero to ensure
that the contents of the composited object will paint at correct
location.

Previously in CompositedLayerMapping::UpdateAfterPartResize() we used
FloatSize::RoundedIntSize() which rounded (-0.5, -0.5) to (-1, -1)
(which is based on the roundf() behavior), causing the iframe's document
layer to be placed at unwanted -1px offset.

Now use LayoutSize::RoundedIntSize() to keep consistent pixel snapping
behavior.

Bug: 898941
Change-Id: I50b27565850061aec9cffffbe77061570683610b
Reviewed-on: https://chromium-review.googlesource.com/c/1302327Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603241}

Moves functions to match their orderings in h and cc.
Also removes a little dead code.

Bug: 899297
Change-Id: I9c8202f5c24c811025db6dadf72edd9d2f73f4bc
Reviewed-on: https://chromium-review.googlesource.com/c/1302822Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603240}

The logic was moved to a legal message view class in the view_util.*,
and when removing, metrics logging was not correctly set.

Bug: 898724
Change-Id: I8f285b61003a49cdc884641a9ff526b1760abcb0
Reviewed-on: https://chromium-review.googlesource.com/c/1298713Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603239}

This splits AppShimHost into two separate structures, along its
mojo interface lines.

The AppShimHostBootstrap class is created as soon as a connection is
created with the app shim process, and awaits the LaunchApp mojo
call, through which the AppShimHostBootstrap will indicate its profile
and app id.

The AppShimHost class is created only after the LaunchApp call is
made, and takes ownership of the AppShimHostBootstrap.

The next patch in this sequence will allow the AppShimHost to be
created independently AppShimHostBootstrap, to support the situation
where Chrome launches the app shim.

Bug: 896917
Change-Id: I0d240a9ded78fcea3a0a6e26a2bad466402d08fb
Reviewed-on: https://chromium-review.googlesource.com/c/1299668Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603238}

Use of new macro and added base=true to avoid extra suffix histograms

Bug: 894043
Change-Id: I2f87f092a01897c43fcd8b61639967fed2330f50
Reviewed-on: https://chromium-review.googlesource.com/c/1283833
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Robert Kaplow (OOO until Nov6) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603237}

Fixes GLScaler::SupportsPreciseColorManagement() by using GL extension
strings to detect the required GLES2 extensions. Also, use of half-
floats in textures is governed by the "type" argument to glTexImage2d(),
and not the "internal format" argument.

Bug: 870036
Change-Id: I67e90cbadeb0b185025bce01c56b0f9e89e70a71
Reviewed-on: https://chromium-review.googlesource.com/c/1298643Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603236}

There are strange behaviors observed in the field with the sampling
profiler. It seems there are two running sampling profiler but only
one is reporting events.

This CL is adding trace events to help investigate this problem.

R=wittman@chromium.org

Bug: 882982
Change-Id: I70925e841b8a1f0e47564350d142f056d8b8ae99
Reviewed-on: https://chromium-review.googlesource.com/c/1302318Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603235}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I762ae359249c60481ba4866703aa1e7fbbc6552e
Reviewed-on: https://chromium-review.googlesource.com/c/1302330Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603234}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I824af75f53227fa0df93dbf34cbe6b64b565a96a
Reviewed-on: https://chromium-review.googlesource.com/c/1303044Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603233}

This is no longer used.

Change-Id: I395e5e28f987326011e82b81c27534f23a8e6c7d
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1302096
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603232}

https://android.googlesource.com/platform/external/perfetto.git/+log/57c89d98ac4c..f77475921e90


git log 57c89d98ac4c..f77475921e90 --date=short --no-merges --format='%ad %ae %s'
2018-10-26 primiano@google.com docs: fix (2) for github sites
2018-10-26 primiano@google.com docs: keep static/ folder
2018-10-26 primiano@google.com Docs: ignore node_modules in appengine yml
2018-10-26 primiano@google.com Merge "Remove CDN dependency from docs"


Created with:
  gclient setdep -r src/third_party/perfetto@f77475921e90

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I647c85f9c4f2522def1d18f24ca366711c6fadbb
Reviewed-on: https://chromium-review.googlesource.com/c/1302093Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603231}

It's dead code with no development, and Rouslan said to kill it with
fire. :)

Bug: 881343
Change-Id: I7c41130b4a1aa0e7a537e95a0b0e6aaac83aa591
Reviewed-on: https://chromium-review.googlesource.com/c/1300794Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#603230}

resource names are stored in the resources.arsc file to allow for
getIdentifier with the string name of the resource to work. This cl
obfuscates all of those resources to one name (and thus stored only
once) for all resources that are not accessed via getIdentifier.

This improves binary size by about 200KB.

Bug: 894208

Change-Id: I28c440c22b90cd045f53017073fdb88c7410d530
Reviewed-on: https://chromium-review.googlesource.com/c/1265897
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603229}

The regression was caused by 1px bigger visual rect of the
scrolling background.

Now snap PaintLayerScrollableArea::ScrollingBackgroundDisplayItemClient::VisualRect()
to whole pixels. This matches the original original visual rect
of scrolling background before crrev.com/c/1297131.

Bug: 898877

Change-Id: I7b8df7850a5a7fb680ea903064247d72fa9d9278
Reviewed-on: https://chromium-review.googlesource.com/c/1300593Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603228}

The crash seems to caused by a destroyed download.
But the only way to destroy a download is to have 2 download with the same id,
so the unique_ptr will demolish the first.
Dump some information when this happens
Will revert this once the problem is found on canary/dev

BUG=898859

Change-Id: I05474aba4ee98474ff99ce32747b763605d9d804
Reviewed-on: https://chromium-review.googlesource.com/c/1302673
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603227}

Implement UI view and model that renders available BLE
security keys to the WebAuthN UI.

Bug: 877344
Change-Id: Ie44c848799cf5a637f9c048d2e9ec292ddf845fc
Reviewed-on: https://chromium-review.googlesource.com/c/1257789
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603226}

This is the first of 3 CL's to replace the global static helper functions which manipulate the DOM with classes. In this CL, we:

- Replaced the functions createCellForPropertyAndRemoveProperty and addResultTableToOutput with OutputMatch, which is responsible for generating individual HTML rows from individual omnibox matches.

- Moved the data class PresentationInfoRecord and the constants array of PresentationInfoRecord's PROPERTY_OUTPUT_ORDER from omnibox.js to omnibox_output.js as that's where it's now used.

Bug: 891303
Change-Id: If653e16763a3956b0576bf677ede1570626007d7
Reviewed-on: https://chromium-review.googlesource.com/c/1293757
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603225}

Since bb1059e5 ("ozone: drm: Clean up error handling around page flips")
we only keep one set of framebuffers alive for a group of crtcs that are
mirroring (i.e., they should always be showing the same framebuffer).

It turns out it is not true that mirrors always show the same buffer;
when we modeset a crtc on entering mirror mode, we may allocate a new
framebuffer for that purpose and only set that framebuffer on one of the
crtcs. Until the first page flip, the two crtcs will show different
images.

To avoid a crash when we try to page flip, go back to keeping a modeset
buffer for each CRTC. This crash only happens if we have to allocate a
new buffer for modesettings; in some circumstances, we're able to reuse a
buffer and there's no crash.

Bug: 888553, b/117854747, b/117863342, b/117631111
Test: ozone_unittests; boot grunt with two hardware mirrored displays

Change-Id: Ib903e00a8975aac16e40ed685b809bbba8bb9124
Reviewed-on: https://chromium-review.googlesource.com/c/1302110
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603224}

Update owners to pauljensen@ and mef@ for all active *DNS* histograms.

Change-Id: Ib95d4488d408ab86b4723320c1074af92445150a
Reviewed-on: https://chromium-review.googlesource.com/c/1126173
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603223}