GitLab

This reverts commit 5db928ee.

The original issue was caused by additional scroll tree scroll offset
entries. DirectSetScrollOffset should not create new entries, but just
change existing entries, otherwise after a document lifecycle update,
the scroll tree may contain entries whose element ids don't correspond
any scroll node.

Original change's description:
> Revert "Ensure cc::Layer's NeedsPushProperties when blink directly sets scroll offset"
> 
> This reverts commit 617a9c19.
> 
> Reason for revert: Broke some browser tests. The tests flakily crash when pushing scroll properties at impl-side.
> 
> Original change's description:
> > Ensure cc::Layer's NeedsPushProperties when blink directly sets scroll offset
> > 
> > When blink directly sets scroll offset in the scroll tree, we need to
> > set the associated cc::Layer's NeedsPushProperties to ensure update of
> > cc::LayerImpl's scroll related properties
> > (see cc::LayerImpl::UpdateScrollable()).
> > 
> > This reverts the change about cc::LayerTreeHost::LayerByElementId() in
> > https://chromium-review.googlesource.com/c/chromium/src/+/2020554
> > because we still need it in layer list mode.
> > 
> > Bug: 1048113
> > Change-Id: I686beebcf54e96cc517700c0f987aaceec880c58
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036834
> > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#739043}
> 
> TBR=wangxianzhu@chromium.org,pdr@chromium.org
> 
> Change-Id: Ib52291c52f8bac3f4a3c9fe0248f55d0162c556c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1048113
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042763
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739183}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

Change-Id: Ie72b629bbdb20b0ed4c33746c33828f4d596a884
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1048113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043056Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739220}

https://chromium.googlesource.com/catapult.git/+log/7476ab6e9eff..8052d2973b2a

git log 7476ab6e9eff..8052d2973b2a --date=short --first-parent --format='%ad %ae %s'
2020-02-06 bsheedy@chromium.org [Telemetry] Remove GetStackTrace

Created with:
  gclient setdep -r src/third_party/catapult@8052d2973b2a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC sadrul@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1008075
Tbr: sadrul@google.com
Change-Id: I909d1b995a0a6588377637360903cd0a7aeb9a17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042662Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739219}

Also print the hash padded with leading 0's to 8 hex digits.

Bug: 1026522
Change-Id: I2f8f8db71619839beccd8723461f0842ea960240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042195Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739218}

Click to call dialogs needs to be closed if the tab navigates to a
different origin. In ChromeOS, click to call uses the same dialog as
intent picker. Intent picker dialog will show when tab navigates to a
different origin and there are Android apps that can handle this origin.

The click to call dialog closes cause the dialog to automatically closed
after briefly show up. This CL change the code to only close the dialog
for click to call. This CL also fix a issue the intent picker icon don't
show up for auto dialog pop up.

BUG=1045036

Bug: b/146227259
Change-Id: Iadb1db30c7e24108bee933eb93d57d73a206d3d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035821Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739217}

SafeBrowsingURLRequestContextGetter doesn't exist anymore, so remove the
friend class declaration.

Bug: 678653
Change-Id: If8e5105ff5e8178f3402372c4df43138e30c1a92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041887
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739216}

Also fix a spelling error: unitialized => uninitialized.

Bug: N/A
Change-Id: Ie61e8be22499660642ae7ab884c32b78b4e9763a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042323Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739215}

Passing this parameter will desotry all the contexts created by the session
upon session disconnect.

Change-Id: I6608ef672b41b922308bf71921a074faa037ae7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042279
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739214}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/816c2b3548fb..6c6827cbf27d

git log 816c2b3548fb..6c6827cbf27d --date=short --first-parent --format='%ad %ae %s'
2020-02-06 ehmaldonado@google.com git-cl: Simplify FetchDescription and UpdateDescription
2020-02-06 ehmaldonado@google.com git-cl: Remove GetDescriptionFooters and UpdateDescriptionFooters
2020-02-06 ehmaldonado@google.com git-cl: Simplify Change object construction.

Created with:
  gclient setdep -r src/third_party/depot_tools@6c6827cbf27d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1042324
Tbr: agable@chromium.org
Change-Id: I687d022f4e77369cd25805a9e24aedbbc838123f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042776Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739213}

Bug: 982014
Merge-With: eureka-internal/360834
Change-Id: I47b9995892f7141c6f76222a7fe1a437d541792a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040210Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739212}

iOS utilizes otool to analyze and distribute test case execution
against x number of shards. This logic was run in the recipe,
such that the sublist of test cases would be passed into the isolate
for execution. Chromium does not support recipe-level sharding.

To mitigate, we clone the otool sharding logic into the test runner.
Each swarming task (shard) is provided with two keys via env vars:
shard index, and total number of shards.

A given test on a given run should be broken down identically across
each swarming task, because the test bundle does not change and the
number of total shards is the same. Because each task also is provided
the index, it can select the corresponding index from the sublist
and execute that sublist of test cases.

There is minimal performance hit, and this logic is only invoked when
those env vars are present, which are only set by swaring for shards
greater than 1.

Change-Id: Id3b4c96cc68ef97b62ed79afc145bbbe55156063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040371Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739211}

This failure is caused by the same failure fixed here [1].
Checking the flake portal, seems to be stably passing since the fix [2].

[1] https://crrev.com/c/2040370
[2] http://screen/Gwwn5WLDahZ

Bug: 1048766
Change-Id: Ibb58dbd19c62be657c9c1ca1f90423bf7d73a0f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042741
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739210}

WebrtcVideoStream::OnFrameEncoded() expects that the |frame| parameter
might be null, but it tries to use it anyway. This CL adds a
null check before the dereference, preventing a host process crash.

Bug: 1049804
Change-Id: I3e02b7c5bced24611f2ba6a22025ff7ba173bd69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042138
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739209}

of it.

Bug: 1048587
Change-Id: Ic3c3c3761db6feb5191267a09fd1f3d4d6ef2273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037104
Commit-Queue: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739208}

Part of an effort to describe highlight paths as a round rect struct.
The first user will be the cros toast button.

Test: manual
Bug: 1042303
Change-Id: I0d3a784f2421ea2feb8e3f5d4fc2e50bbcb20e55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038084Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739207}

Remove the dark mode build flag and merge res_night/ into normal res/
directory. Also removes the dark mode flag from about://flags.

BUG=936275

Change-Id: Icd8df11f94ef9ab6314c4a2fcd47ecab261985a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031877
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#739206}

This interface represents methods that should only be called on the
MainFrame instance.

BUG=1046424

Change-Id: Id7372ec5962a35c3dc9dd8fe39e4a427bcb594ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036510Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739205}

Most fixes are simply ensuring that values are not undefined or null.

The most significant change is correctly grabbing the 'scanning' state
of the cellular DeviceState by way of injecting it into network-list
and then network-list-item (instead of shoving it into the
NetworkStateProperties). The change ensures that internet-subpage also
injects its DeviceState, which happens to fix crbug.com/1049775.

Tested by building webui_closure_compile with this CL based on top of
crrev.com/c/2006413, and manually testing with networking Settings UI.

Fixed: 1047850, 1049775
Change-Id: I370ae812430f31b7b856748c58f9f213014ecb88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040212Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739204}

This reverts commit 5b1e0dfc.

Reason for revert: Found the problem.

Original change's description:
> Add checks to find source of null requests
> 
> Somehow ReadPixelsContext::request is null once it reaches
> OnRGBAReadbackDone() done. Add some checks to figure out how that can
> happen.
> 
> Bug: 1048251
> Change-Id: If74854b5b332b1af347647c4c1c234e995afa944
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037846
> Reviewed-by: Jonathan Backer <backer@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738563}

TBR=backer@chromium.org,kylechar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1048251
Change-Id: I0ba8227e8f8b000ff9e761169c7e47134de6ad9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042536Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739203}

This CL fixes a bug where if the user swipes the toolbar immediately
after opening a new tab (easily reproducible w/ context menu > open in
incognito tab), top controls have the wrong offset and get hidden.

This is caused by ChromeFullscreenManager#onInteractabilityChanged()
which pushes offsets from TabBrowserControlsOffsetHelper even if the
offsets aren't initialized.

This is fixed by adding a simple check and returning early if the
offsets aren't initialized.

Bug: 1048596
Change-Id: I3db087db835f81067018f808ee03974fb4d1adc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042677Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#739202}

The argument we use to determine a crosvm process is for Plugin VM was
updated in https://crrev.com/c/1970098 to be prefixed by --param, so we
need to update our detection code for the task manager accordingly.

Bug: 1045295
Change-Id: I6390f8bf532766d77d32f339f5ef47607eab385c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040592Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Julian Watson <juwa@google.com>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739201}

The unexpected behavior change was introduced in crrev.com/2731283004.
After the change, reversing scroll direction disables the sticky key,
but doesn't send a key release event for it.

Bug: 1049492
Test: unit_tests
Change-Id: I2c57e70e7ecb9cf8d12c17cea9d38d45ff00db05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041211Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739200}

https://skia.googlesource.com/skia.git/+log/c90a8c72af60..046f9893b953

git log c90a8c72af60..046f9893b953 --date=short --first-parent --format='%ad %ae %s'
2020-02-06 westont@google.com Add ccache_mac cipd package scripts.
2020-02-06 egdaniel@google.com Have gpu yuv code speak in views.
2020-02-06 csmartdalton@google.com Convert DIRTY_AFTER_EDIT to SkPath::dirtyAfterEdit
2020-02-06 bsalomon@google.com Return after callback on failure in GrRenderTargetContext::asyncReadPixels
2020-02-06 benjaminwagner@google.com Remove extra semicolon
2020-02-06 egdaniel@google.com Add move assignment operator to GrSurfaceProxyView.
2020-02-06 brianosman@google.com Reland "In GrSkSLFP, always use a coord transform"
2020-02-06 brianosman@google.com Replace usage of SkTClamp with SkTPin

Created with:
  gclient setdep -r src/third_party/skia@046f9893b953

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1048251
Tbr: scroggo@google.com
Change-Id: I4dd09c2a6bd718c606ccf31d814b34150635fac7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042663Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739199}

This reverts commit e80df6f2.

Reason for revert: seems to have broken builder "Network Service Linux"

Original change's description:
> [Extensions] Revert changes to icon loading JS function.
> 
> Bug: 1049214
> Change-Id: I64018260d06070da03821bbcb72578de62359be3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042313
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Commit-Queue: David Bertoni <dbertoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739076}

TBR=lazyboy@chromium.org,dbertoni@chromium.org

Change-Id: I4cf9a417bdf5b13aad77d6a4cb054a27dbe6a42f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1049214, 1049467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043003Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739198}

All usages of the old RewriteEvent() method are removed from
event_rewriter_unittest.cc by this CL.

Bug: 1049489
Test: unit_tests
Change-Id: Id11990b3fa421df6de8d6ddefd60c96dae95b573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041151Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739197}

Updates the expires_after attribute for 39 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 30 days of 2020-08-24.

Change-Id: I9f5fee9ee82d0b76b50cd2b311cd07d9b6556646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042261
Commit-Queue: Brian White <bcwhite@google.com>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739196}

Bug: 1048790
Change-Id: Id9cecf0c6a621c4688fe8b4a8961d7dee5f466d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038079
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739195}

Currently even if hangs are detected they will not be reported. See https://crbug.com/440885.

Furthermore we are actively developing the replacement to this solution which aims to
eliminate the false positives that caused the deactivation in the first place.

Bug: 1034046
Change-Id: Ifc29ae961bc8b75d04fe6bdc6e205c72a763a9da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042292Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739194}

This is part of an ongoing effort to simplify heap collections
and limit the types they can support (specifically, this CL
removes the only existing non-member usage of HeapDeque).

Bug: 1047147
Change-Id: I55995763db8c36d893a57a32ea04e38981917d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013243
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739193}

This change allows the permissions for Web Bluetooth to go through the
BluetoothChooserContext when NewWebBluetoothPermissionsBackend is
enabled. Since the Web Bluetooth API implementation is in content/ a
delegate class is required to allow WebBluetoothServiceImpl to access
the BluetoothChooserContext in chrome/.

Design doc:
https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/edit?usp=sharing

Bug: 589228

Change-Id: Ie95bd78368d9891168a50c280ca06dd0d8feff9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949530
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739192}

These tests are having flaky timeouts very often.

Tbr=kbr@chromium.org

Bug: 1049138
Change-Id: I5e9ee1f4499c74b8c039e42077fad8210b0104b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042303Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739191}

Change-Id: If7c10365ff4b69c543150cd51dd74a50662bac07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042325Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739190}

If 'display' property value is one of 'inline-grid', 'grid',
'inline-flex', and 'flex', <button> doesn't use LayoutButton.

This behavior follows https://html.spec.whatwg.org/C/#button-layout .

Bug: 700029
Change-Id: I017734ad773eed6531e0dc665f80b99e8f14d1d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040796
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739189}

https://webrtc.googlesource.com/src.git/+log/4f68f5398d7f..f12231d74209

git log 4f68f5398d7f..f12231d74209 --date=short --first-parent --format='%ad %ae %s'
2020-02-06 mmoroz@chromium.org Add wildcard visibility to video_replay to make it buildable in Chromium.
2020-02-06 terelius@webrtc.org Move packet type enum from RtpPacketToSend to rtp_rtcp_defines.h
2020-02-06 sprang@webrtc.org Revert "Remove PlayoutDelayOracle and make RtpSenderVideo guarantee delivery"
2020-02-06 minyue@webrtc.org Add clock skew estimate between sender and receiver in RemoteNtpTimeEstimator.

Created with:
  gclient setdep -r src/third_party/webrtc@f12231d74209

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:942546
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I8fcb60c807f19a03b4379f2761a532373229fb2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042778Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739188}

This is a reland of 882f5709
There are no differences from the original CL, which was reverted
due to a dependency.

Original change's description:
> Remove GetText(), ClientPaddingLeft(), and ClientPaddingRight() of LayoutMenuList
>
> Fold them into their callsites.
> This CL has no behavior changes.
>
> Bug: 1040828
> Change-Id: Iac6c8c1e061993534e7f7ed45d60139ec9cd63e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038196
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Commit-Queue: Kent Tamura <tkent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738490}

Tbr: yosin@chromium.org
Bug: 1040828
Change-Id: Ifec8fec3ed80c1cdfc92661b8ea9387c8c5d1c17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041372Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739187}

Change-Id: Icedbb49a07fd4ba258b94d9bb30509adbfc42f9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039346Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739186}

https://chromium.googlesource.com/openscreen.git/+log/39dda173e881..7d8b92dfc7b5

git log 39dda173e881..7d8b92dfc7b5 --date=short --first-parent --format='%ad %ae %s'
2020-02-06 jophba@chromium.org Fix fuzzing
2020-02-06 jophba@chromium.org Add multithreaded decoding

Created with:
  gclient setdep -r src/third_party/openscreen/src@7d8b92dfc7b5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I5ee069ffd16023b972d8b8cb43bbd5949aa589e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042774Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739185}

I've been investigating why the realbox has such worse ToPaint metrics
than the omnibox. I discovered that the realbox is ignoring all
autocomplete results other than the final "done()" one, which won't come
in until we get results from the Suggest server, often 60ms away at the
fastest.

This CL makes the realbox paint incomplete results, just like the
omnibox does. For the user, it's going to make the realbox feel much
more responsive, like the omnibox, but also introduces the same
asynchronous result-changing-after-the-fact issue that the omnibox has.

I think it's best to just keep the behavior the same between the UIs.

It also improves the ToPaint time on my machine from ~70ms to ~15ms,
which is quite competitive with the actual omnibox.

Some history:
In the original implementation of the realbox, there was a one-time-use
callback, which is probably why the original implementer waited until
the autocomplete machinery was done().

This limitation was removed by this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1875030

This CL takes advantage of that new ability by reporting the incomplete
states as well. (i.e. history provider has returned but search suggest
has not gotten the remote results yet).

Bug: 1046561
Change-Id: I8f7fc5760bfefb0e9aa0d3642cde0e30185e71be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036259Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739184}

This reverts commit 617a9c19.

Reason for revert: Broke some browser tests. The tests flakily crash when pushing scroll properties at impl-side.

Original change's description:
> Ensure cc::Layer's NeedsPushProperties when blink directly sets scroll offset
> 
> When blink directly sets scroll offset in the scroll tree, we need to
> set the associated cc::Layer's NeedsPushProperties to ensure update of
> cc::LayerImpl's scroll related properties
> (see cc::LayerImpl::UpdateScrollable()).
> 
> This reverts the change about cc::LayerTreeHost::LayerByElementId() in
> https://chromium-review.googlesource.com/c/chromium/src/+/2020554
> because we still need it in layer list mode.
> 
> Bug: 1048113
> Change-Id: I686beebcf54e96cc517700c0f987aaceec880c58
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036834
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739043}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

Change-Id: Ib52291c52f8bac3f4a3c9fe0248f55d0162c556c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1048113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042763Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739183}

As above.
There should be no behaviour change.

Change-Id: I322c8878600e2044f2a9bd635f7005f471f5ba24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042318Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739182}

This CL changes the AhoCorasickNode class to store pointers to other
nodes directly instead of their index in the trie array. This makes the
code clearer and reduces redundant indirection. Also, add some code
comments related to the algorithm.

This should have no behavior change.

BUG=974391

Change-Id: I2e1d89556fb064bdb1643ab7e10005d674bc8d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037734
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739181}