- 10 Jul, 2020 40 commits
-
-
Antonio Gomes authored
This CL exposes MediaStreamVideoTrack::CreateVideoTrack() through a helper method, to be used from content/renderer/pepper. No functionality change, but it will allow t_p/blink/public/web/modules/mediastream/media_stream_video_track.h to be moved out of the Blink API altogether. BUG=704136, 919293 R=guidou@chromium.org, haraken@chromium.org Change-Id: I284b245bc24e43de4c59c7d0f498472840782d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292777Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#787425}
-
Matt Menke authored
URLFetcher and URLRequestStatus are deprecated and no longer used in production Chrome code, so code shouldn't be including those headers or using their constants. This CL also removes unused includes of url_request_context.h, url_request.h, cookie_manager.h, and a number of other net/ headers that shouldn't be used in the browser process, since the network code now runs out of process. Bug: 651119, 1010491 Change-Id: Id5963fbeb2f9fb4405fbebd6d8d09027b8df2f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289912Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#787424}
-
Reilly Grant authored
This change finishes converting callbacks in the platform-specific Linux and Chromecast implementations of BluetoothAdapter and BluetoothDevice. There should be no functional change. Bug: 834319 Change-Id: I3abedefa4df23d79f803bd4cd2cc7252ee193386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293156 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#787423}
-
Julian Pastarmov authored
These two new policies deprecate the old policies with less appropriate names. The old policies will still be used in the absence of the new ones for at least a few releases of Chrome. BUG=1095227,1095230 TBR=rohitrao,eugenebut Change-Id: Id1e5c0be5e5e2ed72547214f0669c0a2ae1440a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283163 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787422}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9af33fa208fb..8e404a7e4992 2020-07-10 kylixrd@chromium.org Added option to keep empty branches in rebase-update. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie375d5a2408edcc8deb0afdbea33b52fe2a04c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787421}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/27d352134c59..66ccc2b65ae8 2020-07-10 almuthanna@google.com Use strict equal to assert Console truncation scenario If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9eb0a71c536f31b82b0ebf47ca5581c0305ecfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293335Reviewed-by:
-
Collin Baker authored
FeaturePromoBubbleView requires a ThemeProvider in its parent Widget. So, for TabGroupsIPHControllerTest to instantiate it the anchor view must be inside a Widget with a ThemeProvider. TestWidget used internally to ChromeViewsTestBase serves this purpose. This CL extracts it as ChromeTestWidget to be used elsewhere. TabGroupsIPHControllerTest uses this as the parent Widget. Bug: 1102655 Change-Id: Ib0d8a290789c1af1c08adb9fb6afc816ee2eeb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289922 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#787419}
-
David Tseng authored
Previously, if a test did: this.newCallback(async function() {}); this.newCallback(async function() {}); the first call would immediately pass the test (and not decrement the expected number of callbacks). Correct this. R=anastasi@google.com AX-Relnotes: n/a Test: catches a ChromeVox test that instantiated a new MockFeedback (which creates a callback) that was never called. Change-Id: I158256031eb670b94be2918562d6dfafaa6819eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292854 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#787418}
-
Alexander Alekseev authored
This is first CL in series to make some viz debug flags dynamic. See the design document here: https://docs.google.com/document/d/1lWHJZK0LxLwN6y2YmPZTc0oTA-SXTo5PPM4OpieiI90/edit?usp=sharing Here we move some boolean debug flags from RenderSettings into a separate structure and add renderer API to modify them. Bug: 1085279 Change-Id: I802db6be7c1eb6dfe97dd4026547f7d7bb742eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234122Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#787417}
-
Donn Denman authored
Various updates to metrics recording for Contextual Search that are needed for the M85 experiments in progress. Some of the metrics are user actions that track the selection and how it is being adjusted. Existing actions that track manual adjusting of the selection was being done in the wrong part of the code making it not useful for the experiment that we need them for. Histograms for system resolve requests and responses are also added, along with a histogram for translation. Sometimes a histogram is used as a simple counter, but there doesn't seem to be a natural way to do that so a boolean histogram is used (with a signal that may not be very important). The new metrics entries are all in our UMA file, and they present a convenient bottleneck for future logging of selection adjustment for Smart Selection since it needs to know if the selection was adjusted by the system or the user. Metrics additions: UserAction: "ContextualSearch.SelectionEstablished" UserAction: "ContextualSearch.ManualRefineSingleWord" UserAction: "ContextualSearch.ManualRefineMultiWord" Histogram: "Search.ContextualSearch.SelectionExpanded" Histogram: "Search.ContextualSearch.ResolveRequested" Histogram: "Search.ContextualSearch.ResolveReceived" Histogram: "Search.ContextualSearch.TranslationNeeded" Also fix the logging of the CardTag. A regression caused the mapping from coca=>enum values to be called twice, which distorted the values. BUG = 1102670, 966203 Change-Id: I09f4941738e82c554f25ba9bfe0a7c417db9ba48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286480 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#787416}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. Bug: 1104273 Change-Id: I3a17b8da6c2e61f8033b01b1d31dc1b5de84a91d TBR: dominickn@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293075 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#787415}
-
Xing Liu authored
Download later dialog will be shown when these conditions are met: 1. Pref is enabled. 2. Not incognito. 3. Cellular network. Bug: 1099027,1078454 Change-Id: Ifdd8453c33d6ac647abd430a0183cec997b9d478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276508 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#787414}
-
Tomasz Wiszkowski authored
This change replaces AutocompleteMatch 'subtype_identifier' with a set of 'subtypes', and ensures the entire set is accurately propagated back to GWS via AQS. Per offline discussion: - the order of the subtypes is irrelevant, so reordering items is okay. - the change ensures that any repeated subtypes appended by Chrome would be deduplicated if a corresponding subtype already exists. Bug: 1103056 Change-Id: I483f4ab4d64ab4e2af6f42de398c75c11bb7c360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290754 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#787413}
-
Sammie Quon authored
This was previously animated after the main animation for performance reasons. With the improvements to overview, we think we run this animation at the same time as the window animation, and add it to the exit animation as well. Since we now need to animate removing clipping (clip rect = gfx::Rect()), this CL adds an observer which first animates the clip rect to the size of the layer, and the removes the clip. Otherwise the animation will contract hide everything before reshowing on the last frame. To help with this, windows with no clip in overview will have a clip the size of the window (visually equal to no clipping). This will avoid us changing to and from real no clip (clip = gfx::Rect()) which would make the logic more confusing and we would need to create more self deleting observers. Also refactors some logic so that this clipping, and the aspect ratio clipping (clips windows that will open in splitview so they have the same ratio as a splitview window), so they share more code. Test: manual Change-Id: I900f9a1801f9dd2e9847101e4c52d54f0ba41292 Fixed: 952158, 1103621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277331 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#787412}
-
Sahir Vellani authored
Currently the device pixel content box for SVG elements is reported as the same as content box and border box. We change this to report the device pixel content box size as the bounding box in device pixels. Bug: 1088497 Change-Id: Iae78c49deb214b516792cefd751a09d57202f9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240033 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#787411}
-
Adam Ettenberger authored
Adding helper class VariantVector which can be populated similarly to an STL container but without the compile-time requirement of knowing what type will be stored. Internally represented as a vector of Scopedvariants with a uniform VARTYPE. - Can release ownership of its contents as either a Scalar VARIANT or, as a SAFEARRAY wrapped by a VARIANT. - When the vector is destructed, any remaining managed contents are released automatically. Also improving the ScopedVariant::Compare method to be able to handle some types that ::VarCmp cannot. e.g. VT_I1, VT_UI2, VT_UI4, VT_UI8, VT_UNKNOWN, VT_DISPATCH. Split out from : https://chromium-review.googlesource.com/c/chromium/src/+/2188057 Bug: 928948 AX-Relnotes: (Should not be user facing) Adjusted VARIANT comparisons to be more type-strict and adds support for a few previously unsupported VARTYPEs. Change-Id: I1e300bae6004ba17986643916e0a182f3e400da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243839Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#787410}
-
Vikas Soni authored
Bug: 1031383 Change-Id: Iad752f19197fff7d351d360fc64f9c04380f1fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293256Reviewed-by:
-
Xi Han authored
Bug: 1092931, 1104351 Change-Id: Id403d7836e40870357c4adee51e4796291ca04e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292127Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787408}
-
Miriam Zimmerman authored
Feedback reports include a list of recent crashes, but only those that were already sent at the time the feedback report is generated. Since crash sender only runs periodically (rather than every time a crash happens) this results in feedback reports missing the most recent crashes, especially if the user is filing feedback because of that crash. To fix this, run crash_sender (and give it some time to finish) before getting the list of crashes. BUG=chromium:1096272 TEST=replaced crash_sender with script that logged and slept 15s; \ verified that UI did not hang on opening feedback window and that \ system log information was not available until after sender finished Change-Id: I49dcd776a266a4167f228ea89473d9a5cc3d3da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258678 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#787407}
-
Stefan Zager authored
This patch changes the numerical operations to match more closely the geometry code running in the renderer, to avoid rounding/precision errors. BUG=1092977 Change-Id: I1a8c887e07498813fcea31325745cb9a048c098b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290533 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#787406}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. The API surface between lacros-chrome and ash-chrome is named crosapi. This allows a cleaner separation of code, since the word "lacros" will only be used by lacros-chrome, not ash-chrome. Bug: 1104273 Change-Id: I543ac6a44ab0d85c7f3cb672defcd73bcbba3066 TBR: kerrnel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292995 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
David Schinazi authored
The QUIC netlog had not been updated when we changed how we handle versions and connection IDs. This broke searching by connection ID when using a version after 43. This CL fixes netlog to properly save connection IDs and versions. R=renjietang@chromium.org Change-Id: I8954a532df27770ae754d941f054324b650bef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290468 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787404}
-
Yaron Friedman authored
Fix: compare PS2 vs PS1. A conflicting refactoring went in at the same time. Original change: [Android R] Fix crash on tab restore with corrupt TabState. In the case where a corrupted tab state is created of a certain form (i.e. we map a 0-length byte buffer of contents state but don't hit EOF), getting the capacity in native of the empty ByteBuffer returns -1 causing us to construct an invalid Pickle and crash. Previously this would return 0 and would result in a failed tab restore / empty tab. https://android-review.googlesource.com/c/platform/art/+/1276315/ changed this in R. Update Chrome and a regression test. BUG=1094239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290055Reviewed-by:
-
Adam Norberg authored
This includes a large, complicated test helper named StateChangeTestEngine. It's a callback-driven simulator that takes a vector of state change events (and how they should translate between Objective-C and C++), sends them as a sequence of state change events as the XPC client would see them, and also provides a state change client to make sure we get the expected states back out. This test is a smoke test for Update and for StateChangeTestEngine itself. Further unit tests will be implemented using these moving parts in upcoming CLs. Change-Id: I2b00e3c41a481714a59481fbd018cd6d2bb86460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268462Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Adam Norberg <norberg@google.com> Cr-Commit-Position: refs/heads/master@{#787402}
-
Evan Stade authored
The notifications don't outlast the browser, so this shouldn't have any compatibility implications. Bug: none Change-Id: Ic065497b65b14a924df9c679d6a8c01d48afe105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291237Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#787401}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: I998cec68d2f27f7f6d12bfb10f70718aa1473e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284357Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ca0adda2..6e90ebc7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie4e5990c2cea30d05c4c887f38fcb2c5d4c7160d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292124Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787399}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I650fdd924a9f4fde26786c593629849af6826be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292823Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/73923522fd67..2b54e8352a1d 2020-07-10 mtklein@google.com add vtune support back 2020-07-10 jvanverth@google.com Simplify some Vulkan compressed texture setup. 2020-07-10 mtklein@google.com Revert "Enable effects deserialization except for npm build" 2020-07-10 johnstiles@google.com Convert the arithmetic runtime effect to a regular .fp effect. 2020-07-10 herb@google.com pullout text path drawing from drawGlyphRunList 2020-07-10 robertphillips@google.com Update the sk_app WindowContext to hold a GrDirectContext 2020-07-10 fmalita@chromium.org [skottie] Pucker & Bloat shape layer vector effect 2020-07-10 robertphillips@google.com Switch SkImage's & SkImageGenerator's isValid call over to GrRecordingContext 2020-07-10 guruji@google.com Exclude gl files for Fuchsia platform. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: Iaaf95166990fdd86be1849c8fafe0c4dab404485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293103Reviewed-by:
-
Dominic Farolino authored
This CL introduces LazyLoadFrameObserver::LoadType enum, and the LazyLoadFrameObserver is constructed with a member of this enum. This member directs the frame observer to load a once-deferred frame in one of two ways depending on whether or not this is the first navigation for the frame, or dynamic / subsequent navigations. R=kinuko@chromium.org, sclittle@chromium.org Bug: 993273 Change-Id: I75cda5fc38ebfa351b1ad30a9b9ba78351f64a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289436Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#787396}
-
Stefan Zager authored
MapAncestorToLocal and MapLocalToAncestor do not work for multicolumn unless they are mapping a point that lies within the boundaries of the local object. When mapping a rect rather than a point, the center of the rect is used as the implicit mapped point. But when computing the compositing rect for an iframe, we start with the viewport rect of the local root view, and the center point of that rect does not necessarily lie within the iframe's bounds. This patch sidesteps the problem by generating a transformation matrix from the iframe to the local root view and then inverting it. Because we start in the coordinate space of the iframe; and because the particular invocation uses an implicit mapped point of (0, 0) in the iframe's coordinate space, we satisfy the requirement that the mapped point must lie within the bounds of the local object. This change affects some rounding behavior, which exposes some numerical precision issues in the ScaledIframeRasterSize test. This patch makes the arithmetic in the test more like the arithmetic in the render process; and it correctly accounts for the 2px border on the iframe. BUG=1098779 Change-Id: I4b1f445da88ddb3e00b54450333072ce8354749f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285176Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#787395}
-
Dominic Farolino authored
This CL more accurately implements [1] and [2]. We should eagerly load an image not only when its loading attribute has been explicitly set to the eager state, but also when it is unset, and therefore is implicitly set to the eager state. [1]: https://html.spec.whatwg.org/multipage/embedded-content.html#the-img-element:attr-img-loading-2 [2]: https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:attr-iframe-loading-2 implements more accurately R=fs@opera.com, sclittle@chromium.org Bug: 1098062 Change-Id: I67fa11fc30be4cfba67c7e102abc0f6c87b62c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258853 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#787394}
-
Nigel Tao authored
Change-Id: Ic7eac66f327ced765ac56ecacd687ff67c97f366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291812Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#787393}
-
Chris Harrelson authored
Replace it with a check for direct compositing reasons. This is consistent with other related usage in the same class. Bug: 1100711 Change-Id: I6eb44fa7d55468df9e3bd94d7b24fb45e4e4b9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292696 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#787392}
-
Peter Kasting authored
Have each call its superclass explicitly. Replace one that's better- suited to being a property observer. Misc. other cleanup. Bug: none Change-Id: I17275c123fa262aa5700b818507f79b5c43b52e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292825Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#787391}
-
Will Harris authored
BUG=1089676, 1089675 Change-Id: Icd02d5cd727359c0a635e5656a624d4314a3a5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292864Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#787390}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5de74f3f4a9ea2a7504810b7b584cc2fd305c27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292781Reviewed-by:
-
David Tseng authored
Externs generation /closure compile requires this be done. Duplicated from automation_position.cc. R=nektar@chromium.org AX-Relnotes: n/a Change-Id: I1179d18ffc8ee2ede660abd0e0f5e0f0b5543a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289940 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#787388}
-
Robbie McElrath authored
crrev.com/c/2247154 introduced a regression that caused SeedStore::RecordLastFetchTime to be given a null time rather than the seed creation time because it attempted to read from the seed after it had been std::moved. Variations.SeedFreshness is based on the last fetch time, which is why it's be steadily climbing since that change landed. Bug: 1103003 Change-Id: Id8bef58cc755473eb99fe6dc0090b998c5566492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285505Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#787387}
-
Shengfa Lin authored
Do not truncate log for Command Send from client to ChromeDriver. Bug: chromedriver:3541 Change-Id: Ia6588fb4ab5b35f0ff7295e348295b2d72aaf1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292870Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#787386}
-
