- 22 Jan, 2021 40 commits
-
-
Colin Blundell authored
When SafeBrowsingTokenFetchTracker is destroyed, it runs all of its outstanding client callbacks. However, when an access token is fetched SafeBrowsingTokenFetchTracker calls the corresponding client callback (which is a base::OnceCallback) *before* it removes that callback from the set of outstanding callbacks. The combination of these facts means that if the SafeBrowsingTokenFetchTracker is destroyed from within a client callback, a crash will occur. This indeed occurs in production (see crashes linked in bug, and note that this is behavior that dates back from the introduction of this code in SafeBrowsingTokenFetcher). This CL adds a test that exhibits the problematic flow and fixes the crash by removing the callback from the set of outstanding callbacks *before* running that callback on access token fetch. The test crashes without the fix. Bug: 1168599 Change-Id: I006bde8e48531b9912fa779a5c6c6a27acaf6fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640375Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#846022}
-
Rushan Suleymanov authored
This CL slightly optimizes the code by changing the order of some operations during the initial merge. When trying to find the local matching node by semantics, the new order is: check matching GUID, check URL and then check for the same title (before current CL the order was reversed). In the real scenarios it should be more efficient because most of bookmarks already have GUID. This CL doesn't change behaviour. Bug: 1163257 Change-Id: If9a2371c7c3f28962c8565513487175482ce4104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640398 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846021}
-
rbpotter authored
No more need to manage a top toolbar, so support only a zoom toolbar in the toolbar manager. Also move toolbar manager to Print Preview build only, and move corresponding test to c/t/d/webui/print_preview. Remove isPrintPreview property from the zoom toolbar and related styles. Bug: 1164004 Change-Id: Icdc1eb894195d09d9913383c62d34786afcdee42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644291 Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#846020}
-
Tomasz Śniatowski authored
Add a null check in DownloadAsStreamBodyHandler::Resume to protect against a rare case where Resume is called right after hitting the timeout. To demonstrate the crash, add a unit test that explicitly keeps hold of the resume closure until after a timeout is hit. Without the added fix, the test crashes accessing body_reader_. While it looks odd in the test, this case seems possible in valid-looking SimpleURLLoaderStreamConsumer code that happens to get tasks queued in an unlucky way right when the timeout is hit. Credit to mruszczynski@vewd.com for investigation and initial UT. Bug: 1169018 Change-Id: Iff38fb1e3a4404ae006e1f6b76479cdf6ffafa85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641033 Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#846019}
-
Mitsuru Oshima authored
Bug: b/169014289 Test: covered by unittest Change-Id: I769addac4e172eb16d5c363c8edca96c1877a346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637415Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#846018}
-
Corentin Wallez authored
While compiling Dawn with MSVC python3 complained that startswith's arguments needed to be bytes. Bug: None Change-Id: Id6d1a1d536e4e235eacf1818d31e59a6b5b7e122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643277 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#846017}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611262248-73432c89b66dbe2013eb2cab3a4d4391b3f9edd9.profdata to chrome-win64-master-1611284384-7c6617d93ef1b9fc70abe71fb9acc556bc65d8e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If2010c143857e639ce9e9bf8a93bc693064ee3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643524Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846016}
-
Ken Rockot authored
Bug: 1004256 Change-Id: Iabfb2720513f11d539b51458e87a323e95f4b513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640932Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#846015}
-
John L Chen authored
They are not being used. BUG=b:177880754 TEST=build & unit tests Change-Id: Ice1d862d56cc6ebdb288515d7f941330e201ace6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639069 Commit-Queue: John L Chen <zuan@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#846014}
-
Michael Lippautz authored
Add mlippautz to - blink/ for BlinkGC.* - v8/ for general reviews Change-Id: I6957c8cdbb7e7dc9ecbd60e39192ba095aff3730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642324Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846013}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57fd09e1aad2..9a1550b6e356 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yosin@google.com Change-Id: I2fb7fae41e7dfa6b56042c0b82b0152b3f0fd413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643470Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846012}
-
Peter E Conn authored
Change-Id: Ib05e1ed766a8348086bda2e794d37823764c1858 Bug: 1146206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642361Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#846011}
-
Anastasiia N authored
Add GoogleServiceAuthError to account_manager.mojom and add to- and from- mojo conversion methods to account_manager_util. Bug: 1140469 Change-Id: I98d71e2c5e9fd7a205d52cfb98213bab789e446e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631502 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#846010}
-
Peter E Conn authored
Change-Id: I62e6216cb126a3a34ea23c4a5947bb6211d5e499 Bug: 1146206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642152Reviewed-by:
-
Jan Wilken Dörrie authored
This change removes the deprecated base::c16memcpy, base::c16len and base::c16memcpy, updates the comment ontop of string16.h to make clear it is only a type alias nowadays and removes obsolete tests or moves them in more appropriate locations. Bug: 911896 Change-Id: I5f66b8db5d81c962e040c79eed844136fd570ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642270Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#846008}
-
Maggie Cai authored
Currently when we try to automatically show bubble for intent picker, we will wait until the content of the bubble loaded before showing the intent picker icon. This CL updates the code to show the icon immediately when we find out there is app in the picker. BUG=853604 Change-Id: I32ed2b3e1368c2d6ff8f7032ffbea3fa820c5cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643424 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#846007}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/302f83f07614..5b2a5204087d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I80436305d8d6379dd43df5830a81489ad2976475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644497Reviewed-by:
-
Henrique Ferreiro authored
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1101837, 1164001 Change-Id: I9354ead3b5188c3fe2f0cde3911672f68d8e84df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640534 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Wojciech Bielawski authored
Python 3 distinguish butes and strings and strings are always unicode. That's why files need to be open in binary mode and proper encoding must be applied before write Bug: 1168119 Change-Id: I14b65600a736eda6ad263a011ab8886f1e521f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642679Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#846004}
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_SetupScriptedPrintPreview message to SetupScriptedPrintPreview() in mojom::PrintManagerHost. Bug: 1008939 Change-Id: I52a9a299f975e56f33cdfef65c8be8bfc65bb9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607979 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#846003}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b5cfe3a7746c..db383498c5c6 2021-01-22 jiawei.shao@intel.com Allow using DepthOnly aspect on the depth-only formats in T2T copies 2021-01-22 enga@chromium.org dawn_wire: Add an API to reclaim reserved devices and textures 2021-01-21 enga@chromium.org dawn_wire: Fix a bug with multiple injected devices If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: Ief959483b66453bf580deb08b3a54b3a81b3877a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643466 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Kai Ninomiya authored
Skips some tests because of shard timeouts on Mac. Also: - Tweaks expectations file comment format and how-to-roll README. - Adds --nohooks to gclient sync in roll script. Bug: None, dawn:614, dawn:615, dawn:603, 1161355, dawn:640 Change-Id: I37499f370b3ebbd9c266b38058287d52b3e4f635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601109 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#846001}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/028c0da21c9e..3f555b808fbf 2021-01-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibf1a3463f0c9309a4391238d899b65af7dc1e5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643468Reviewed-by:
-
Ken Rockot authored
This moves them from js-test to testharness and does some substantial cleanup of asynchronous logic at the same time. This is in preparation to move the tests into wpt_internal and use Mojo JS modules. Bug: 1004256 Change-Id: I47a53d3e88d777158c9ad1a65bf0500284abcb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639871Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#845999}
-
Wei Lee authored
We can use 'ended' event instead of timeout. Bug: b/172341904 Test: Manually Change-Id: I9f2704aa5edc41ba5a04c9d02e0824778d3d59e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640515 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845998}
-
Maksim Moskvitin authored
Bug: 1152279 Change-Id: I4e06d84d7687a7083025c08f2d235e71d2fba259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642453Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#845997}
-
Mike Wasserman authored
This came up in a recent CL review calling this function: https://chromium-review.googlesource.com/c/chromium/src/+/2628705/6..10/content/browser/renderer_host/display_util.cc#b51 Bug: 1169327 Test: None Change-Id: I33bae732cddb7345153f993b840dee29d22b2c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644109Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#845996}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e4652059389f..450f8565c7f3 2021-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from dac687f4 to 465f5609 (418 revisions) 2021-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f0286e636456 to ff5f715e5c4a (11 revisions) 2021-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 762814bd9229 to db383498c5c6 (15 revisions) 2021-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b3e5c440d239 to 22f14a877953 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Test: Test: Test: CopyOutputScalingPixelTest.ScaledCopyOfDrawnFrame/48Test: Test: FenceSyncTest.BasicOperationsTest: Test: angle_perftests --gtest_filter="*subway_surfers*" Change-Id: Iba3f0aea3721cba569b6228ab60d19767fb1de71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643467Reviewed-by:
-
Alex Rudenko authored
We already store the last hovered node in SearchingForNodeTool so we can skip sending duplicate Overlay.nodeHighlightRequested events if the hovered node does not change. Bug: 1169020 Change-Id: Id112e22127ec04d57695ab82a0bd4d41eb51793d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640408 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#845994}
-
Jason Lin authored
We don't actually need it in the header except for unit tests. For unit tests, 3 new functions `Set...()` are added so they can directly manupulated the states. Bug: b/167491603 Change-Id: I46ac5d32e92fcf17ae246ca8c419441c94129759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636743 Commit-Queue: Jason Lin <lxj@google.com> Auto-Submit: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#845993}
-
Yuta Hijikata authored
The change is in preparating to switching lacros-chrome from target_os="linux" to target_os="chromeos". Since currently lacros-chromes uses linux chrome's policy, we want to keep the behaviour for now after the target_os switch. Bug: 1052397 Change-Id: I0fd045f5bd0dc5524147545875b0446fd75dfca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636100 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#845992}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/561f5af9ef1e..048f670fd5b1 2021-01-22 tsepez@chromium.org Fix segv in CFXJSE_FormCalcContext::Time2Num(). 2021-01-21 tsepez@chromium.org Kill majority of remaining CFXJSE_Value usage in fxjs/xfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I57f357a645ef0d5259731dd28f285410bb1d7bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643172Reviewed-by:
-
Theresa Sullivan authored
The bookmark star is only shown in the app menu on phones; on tablets it is shown in the toolbar instead. Bug: 1169415 Change-Id: I52c267501eb2d67474ba8fbe2cdacc573fd83940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643936 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845990}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/12aab80c..f84a78cf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaf447239c22cd90bc10e1c7f14767bea89fe0557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643107Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845989}
-
Harvey Yang authored
This commit adds and uses LightProviderMojo and LightSamplesObserver when IIO Service is available. LightProviderMojo will request information and the target light sensor's samples from IIO Service instead of script: backlight_tool and reading raw values directly from sysfs. BUG=b:173485266, b:176871193 TEST=unit tests and run on nightfury(hatch) Change-Id: I8b7e23677def14261296378a9d205f3d310b47d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568999Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845988}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3efea38b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I9c39bcedd9ee6b42119039d0e0048b82b04e2280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643798Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845987}
-
Kent Tamura authored
In order to conform to the latest specification [1], this CL changes the type of 'states' attribute from 'DOMTokenList' to 'CustomStateSet', which is a 'setlike<DOMString>.' * dom_token_list.{cc,h} Remove 'virtual' from 'value()' and 'setValue()'. No one overrides them. * custom_state_set.{cc,h,idl} Added. * element_internals.{cc,h,idl} Switch 'states' implementation. Remove 'CustomStatesTokenList' class * wpt/custom-elements/state/tentative/ Update tests for the new interface This feature is not shipped yet. [1] https://wicg.github.io/custom-state-pseudo-class/ Bug: 1012098 Change-Id: I642d16f96449db93cc9c4dc1211c7f242e608192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639345 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#845986}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc8ef8034344..302f83f07614 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If917cdc178dbe546cbc49124946a1dea7a90d5e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643110Reviewed-by:
-
Jit Yao Yap authored
This CL adds GetPositionBeforeFirstItem which returns a syncer::StringOrdinal which is before the position of the first item in the item list. This position is used to allow inserting of app items to the front of the item list. Bug: 1167998 Change-Id: I89c41383e72c471723e1eb9457bb7d4508f85218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640379 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845984}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/212d6814bec1..57fd09e1aad2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1166926 Tbr: yosin@google.com Change-Id: I7aa016eb858873f679c55eb525528670bee87ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643249Reviewed-by:
-
