- 23 Aug, 2018 40 commits
-
-
Kevin McNee authored
Currently, app windows (possibly containing webviews): 1) suppress all pinch events which also suppresses the synthetic wheel event, but not touchscreen touch events, and 2) allow "smart zoom" on Mac which can change the page scale even though other means of changing the page scale are suppressed. As a result of (1), if we have, say, google maps in a webview, a user can pinch zoom with a touchscreen, but not with a touchpad. We now suppress gesture events to app windows based on whether they cause a scale change. So now touchscreen and touchpad pinching are consistent since the page has access to the events so that it may implement custom pinch zoom behaviour, but unhandled events still do not result in a scale change for the app window. Also, smart zoom is suppressed to be consistent with other touchpad pinching. Bug: 725970, 874132 Change-Id: I03dd2048002d69dc7c8a822fc727140c67d64706 Reviewed-on: https://chromium-review.googlesource.com/1174933Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#585489}
-
Ned Nguyen authored
This reverts commit 088dc9df. Reason for revert: breaking memory.top_10_mobile on android-go-perf BUG:chromium:877058 Original change's description: > DevTools: Restore GPU tasks recording in performance profiles. > > Add GPU process pid to the list of processes where tracing is enabled. > > Change-Id: Ic401ee4ea7d218cad36f687be226d092cd4e54a0 > Reviewed-on: https://chromium-review.googlesource.com/1182304 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585301} TBR=dgozman@chromium.org,kbr@chromium.org,alph@chromium.org Change-Id: I256ed424aa4af07ccd63b561b17d86a7d7c9dded No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1186841Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#585488}
-
Max Moroz authored
TBR=inferno@chromium.org,liaoyuke@chromium.org Bug: 817798,866943 Change-Id: Ibbd8117a8adc656defefaa776f6983dde9a13a4f Reviewed-on: https://chromium-review.googlesource.com/1186544Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#585487}
-
David Benjamin authored
Change-Id: I03095ea46e32d41def4a444ff1c8c41409209294 Reviewed-on: https://chromium-review.googlesource.com/1185972Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#585486}
-
Daniel Erat authored
Now that VirtualFileRequestServiceProvider lives in //chrome/browser/chromeos/dbus, it no longer needs a Delegate interface. Bug: 843392 Change-Id: Iaafc3d7d79c6c39cca0e8de2febe31bad07efd6e Reviewed-on: https://chromium-review.googlesource.com/1184159 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#585485}
-
Joe Mason authored
This reverts commit 0a12bc8f. Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1186241 reverted a related patch, but the error in the log was from pup.mojom, which is in this patch. Reverting both patches until I can find the root cause. Original change's description: > Add chrome_cleaner sandboxed engine Mojo interfaces > > R=wfh > > Bug: 830892 > Change-Id: I0a4b25b2ba04b65a80e2c03e9151b5ef55912432 > Reviewed-on: https://chromium-review.googlesource.com/1171737 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585025} TBR=joenotcharles@chromium.org,wfh@chromium.org Change-Id: Ieaf8c3d4e8557361e79084b18708f786b88c8473 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1186781Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#585484}
-
gogerald authored
Bug: 806868 Change-Id: Ic4628b11191d2be98e892fce107464ee694301ed Reviewed-on: https://chromium-review.googlesource.com/1184149 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585483}
-
Aga Wronska authored
Bug: 857525 Test: Manually Change-Id: I18789fe5973d97097829e8bdb260c2292aa7ddc3 Reviewed-on: https://chromium-review.googlesource.com/1159692 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#585482}
-
Ken Buchanan authored
When the browser uses InputTargetClient to perform a slow path hit test to an out-of-process iframe, it currently uses TransformPointToCoordSpaceForView to convert the event's target point into the OOPIF's coordinate space. This does not work correctly for iframes with perspective transforms applied or otherwise non-invertible transform matrices. This CL causes InputTargetClient to return the transformed point from the renderer process, which already covers such transforms. The browser uses that point for subsequent hit tests or passes it back to the renderer with the input event. It also changes HitTestQuery and SurfaceHitTest to always defer to slow path hit testing whenever any element with such a transform is encountered, because it can't determine accurately whether the point is within the bounds of the transformed element. Bug: 854247 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic9b69afe418bccdadab45480fc58b8942fccd09f Reviewed-on: https://chromium-review.googlesource.com/1118612Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#585481}
-
Ulan Degenbaev authored
This introduces four isolate types (main, worker, utility, test) and stores the isolate type in IsolateHolder. V8's memory dump provider will group memory dumps by the isolate type, which is necessary for UMA/UKM reporting of V8's memory metrics. Bug: chromium:852415 Change-Id: Id9a31404e6bc62562545518aaa4e35cae00a97d6 Reviewed-on: https://chromium-review.googlesource.com/1183194 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585480}
-
Matt Menke authored
Bug: 875253 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I44040a7f396954436f7dadcd6d80fa87a862328d Reviewed-on: https://chromium-review.googlesource.com/1185748Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#585479}
-
Benoit Lize authored
Test is no longer flaky locally. Bug: 864718 Change-Id: I79dcbf886b5365f6802144ef99a0a3ae024b3594 TBR: nednguyen@chromium.org Cc: mythria@chromium.org,ulan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1186469Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#585478}
-
Finnur Thorarinsson authored
This reverts commit 87182d18. Reason for revert: Breaks browser_tests and viz_browser_tests. Example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28716 Triggers DCHECK on line 859: https://chromium.googlesource.com/chromium/src/+blame/87182d18c9a56d1860288e4e92e726e1f399bf97/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc#859 Original change's description: > Avoid conversion between GURL and std::string > > ProfileDownloader::GetProfilePictureURL returns a std::string > corresponding to the representation of a GURL then immediately > converts it back to a GURL. > > This is wasteful, so convert this method to return a GURL > instead and convert GetCachedPictureURL to also cache the > GURL instead of the string representation. > > Convert static std::string to static char[] and use EXPECT_ > instead of ASSERT_ macros when possible in unit tests (since > the EXPECT_ macro do not stop the test in case of failure). > > Bug: none > Change-Id: Ibe73f28b38b2061b37cbdb0b9b0696b25ca8c41c > Reviewed-on: https://chromium-review.googlesource.com/1160645 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585426} TBR=bauerb@chromium.org,msarda@chromium.org,sdefresne@chromium.org,jdufault@chromium.org Change-Id: Ib1cc81bef47d279214f63528e78d4d885a7aa0e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/1186761Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#585477}
-
Amirhossein Simjour authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I81fca5889609d48f81b05d2394700787b6b56c44 Reviewed-on: https://chromium-review.googlesource.com/1186154Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#585476}
-
Christian Biesinger authored
This just runs blink_perf.layout with the NG flag. TESTED=tools/perf/run_benchmark run blink_perf.layout_ng --browser=release -v (and verified that the commandline includes the layoutng flag) Change-Id: I4302330462d52291d96d3d8509498337e267a1f4 Reviewed-on: https://chromium-review.googlesource.com/1185641Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585475}
-
Mugdha Lakhani authored
through various Background Fetch events. This also makes adding FailureReason to BackgroundFetchRegistration easy, since the plumbing to various service worker dispatcher classes won't have to be done again. Bug: 874092, 873630 Change-Id: I1ae3b2115b1b1c357efa67e3e684423e5f4cd060 Reviewed-on: https://chromium-review.googlesource.com/1176085 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585474}
-
Arthur Sonzogni authored
RenderFrameHostImpl are removed from the set of frame in fullscreen when they are deleted. It means they are still in this set in between their swap out and their deletion. As a result this test was flaky on slow devices: WebContentsImplbrowserTest.NotifyFullscreenAcquired_Navigate This CL: * Fix this issue by removing the frame immediatly when it is swapped out. * Renable the flaky test on Android. * Add a regression test. Bug: 855018, 609963 Change-Id: Ic858acd462cd8f80f39b76c09d5fbd8f9c3110b1 Reviewed-on: https://chromium-review.googlesource.com/1181433 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585473}
-
Ioana Pandele authored
This CL changes: - colors - spacing - tap animation on suggestions in the accessory sheet - keyboard accessory dividers Bug: 856180 Change-Id: Ieb0809f5c175a481bb5d9d0b0e0e8187c300f542 Reviewed-on: https://chromium-review.googlesource.com/1163612 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585472}
-
Justin Cohen authored
For historical reference, four years we started hiding this view "to prevent it from overlapping slightly with Most Visited after a device rotation when the omnibox is focused." per: https://chromereviews.googleplex.com/99937015 It doesn't appear this is necessary anymore, and hiding that view is causing some edge case bugs. Bug: 703024 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icb43e4a93b3e1675684267e2b8f4433a47acad17 Reviewed-on: https://chromium-review.googlesource.com/1185742Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585471}
-
Corentin Wallez authored
These are the initial suppressions because the webgl[2]_gl_passthrough_conformance_tests just got added on Win/Intel. TBR=kbr@chromium.org BUG=angleproject:2760 BUG=chromium:602688 BUG=chromium:809594 BUG=chromium:864524 BUG=chromium:876777 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I88cc85a313ab09fafca5f44129a7f85cc99ddcb2 Reviewed-on: https://chromium-review.googlesource.com/1186462Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585470}
-
Olivier Robin authored
Change the implementation of the WebFramesManagerImpl to use a map instead of a vector. WebFrames are uniquely identified by frameID, so having a map frameID -> WebFrame will ensure that there uniqueness and make lookup easier and faster (log(N) instead of N). Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If3c76acd8b1bd05a57821c87b571cffa7b8d3607 Reviewed-on: https://chromium-review.googlesource.com/1142781 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#585469}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5953a476d9f7..31629a8a3271 git log 5953a476d9f7..31629a8a3271 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 benjaminwagner@google.com [infra] Rename PowerVR jobs to be consistent. Created with: gclient setdep -r src/third_party/skia@31629a8a3271 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I97329ee7b8115615158b63446d2f0073bf8953ad Reviewed-on: https://chromium-review.googlesource.com/1186541Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585468}
-
Rayan Kanso authored
For any child frames, the permission model will follow that of worker contexts. Bug: 692647 Change-Id: Ibb9d8a0fde4f7f61188ae11edd8600f1775acd4c Reviewed-on: https://chromium-review.googlesource.com/1186331 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#585467}
-
Rayan Kanso authored
Bug: 692647 Change-Id: I780b7137f34ca444d4e47030eb96b17628931209 Reviewed-on: https://chromium-review.googlesource.com/1183669 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Reading List preference is moved to the persistent storage list for incognito mode. This CL does NOT make any change of behavior. Bug: 861722 Change-Id: Ie29e7c86cedc19842f64939a1acf60e7835bffc1 Reviewed-on: https://chromium-review.googlesource.com/1172132Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585465}
-
Pavol Marko authored
Instead of reverting the original CL. See CL:1186501 for details. TBR=mattm@chromium.org Bug: 787602 Change-Id: I71e48d675268c64fe989e3fea60c999ec74b37c3 Reviewed-on: https://chromium-review.googlesource.com/1186581Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585464}
-
Juan Antonio Navarro Pérez authored
This reverts commit 076b591c. Reason for revert: Root cause has been fixed. Original change's description: > [tools/perf] Disable youtube_pinch_2018 in smoothness benchmarks > > Stories have been consinstently failing on N5X and Pixel 2 bots. > > TBR=nednguyen@google.com > NOTRY=true > > Bug: 875859 > Change-Id: I9d41fa293a90e6961eabc6b29711d8b824d469ce > Reviewed-on: https://chromium-review.googlesource.com/1181140 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584440} TBR=perezju@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875859 Change-Id: Id8caf496237be5e80d9d0d6dbe36554e722f6689 Reviewed-on: https://chromium-review.googlesource.com/1186481Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#585463}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f23e8ba4..132145aa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If28b44c49821e7aa66b03e5914af56690635d47e Reviewed-on: https://chromium-review.googlesource.com/1186276Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585462}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46ef92275f43..de2476bcaacf git log 46ef92275f43..de2476bcaacf --date=short --no-merges --format='%ad %ae %s' 2018-08-23 primiano@google.com TraceProcessor: improve parsing performances to ~420 MB/s Created with: gclient setdep -r src/third_party/perfetto@de2476bcaacf The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If51d6952452a82e0ec8feab31eaa4a343992790a Reviewed-on: https://chromium-review.googlesource.com/1185698Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585461}
-
Kushagra Sinha authored
A design doc and sequence diagram are linked in the bug id. Bug: 871690 Test: browser_tests --gtest_filter="*ArcAuthServiceTest*" Change-Id: If62c7c06d107ac0b6ea73ffa8da9b7ca42365937 Reviewed-on: https://chromium-review.googlesource.com/1172123 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#585460}
-
Olivier Robin authored
Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I21750fb7373063c60db26d8ba742e09d201dfe6e Reviewed-on: https://chromium-review.googlesource.com/1184704 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
TBR: asanka Bug: 877026 Change-Id: I4ebda150350f73839e357497a66d3f4a8a252f71 Reviewed-on: https://chromium-review.googlesource.com/1186418Reviewed-by:
-
Kushagra Sinha authored
|ArcBackgroundAuthCodeFetcher| assumes that an auth code can only be fetched for the Device Account. This assumption is no longer true. Make |ArcBackgroundAuthCodeFetcher| accept |account_id| as a parameter so that it can be used for Secondary Accounts too. Bug: 871690 Test: browser_tests --gtest_filter="*ArcAuthServiceTest*" Change-Id: I6deb6cff545a516e1842c6cba3fb0cd68defd653 Reviewed-on: https://chromium-review.googlesource.com/1172122 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Kushagra Sinha authored
Move ownership of |ArcAuthContext| from |ArcSessionManager| to |ArcBackgroundAuthCodeFetcher|. ARC++ assumed that only one account will be synced between Chrome OS and ARC++, i.e. the Device Account. This assumption is no longer true because of the introduction of Chrome OS Account Manager (Design Doc is linked in the bug id). Syncing multiple accounts requires the ability to create multiple auth code fetchers which in turn require multiple |ArcAuthContext|s. This was not possible currently because of the ownership of a single |ArcAuthContext| by |ArcSessionManager|. |ArcSessionManager| does not really need an |ArcAuthContext|. It was needed only for: - Passing the context to |ArcBackgroundAuthCodeFetcher|: Not required if |ArcBackgroundAuthCodeFetcher| creates and owns the context. - Getting an instance of Token Service: Can be retrieved directly via |ProfileOAuth2TokenServiceFactory|. - |account_id| and |full_account_id|: Can be retrieved directly via |SigninManagerBase|. Bug: 871690 Test: browser_tests --gtest_filter="*ArcAuthServiceTest*" Change-Id: I78a6d2aa6693529f67f480967258c9fb00469e02 Reviewed-on: https://chromium-review.googlesource.com/1171237 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
AppInfo holds information about how the app should be installed e.g. window vs. tab, is default app, is policy-installed, should create shortcuts, etc. The installation task needs this information, so we could either pass it as arguments, i.e. one argument per property in AppInfo, or we could pass the AppInfo object directly. PendingAppManager has little use for AppInfo, so this CL implements the latter and passes the whole AppInfo object to BookmarkAppInstallationTask. Bug: 876173 Change-Id: I3d3c2e28ca2740b4149bae13263e798eaafa7eea Reviewed-on: https://chromium-review.googlesource.com/1184649Reviewed-by:
-
Friedrich Horschig authored
This CL prevents the keyboard accessory from triggering a keyboard that hasn't been requested. Example: Open youtube or chrome://flags Before this patch: The keyboard accessory controller detects that there are passwords for this site. Because the search field is focused by default, it will request openening the keyboard. Why this is wrong: The controller wrongfully assumed that a focused input field always triggers the keyboard. This is wrong, esp. for pageloads. After this patch: The controller requests to open the keyboard iff the accessory sheet is opened. Why has this become a problem now? Before https://crrev.com/c/1177361, the controller would just request the accessory to be closed. This caused nasty artifacts and bugs. Therefore, it requested to open keyboard to dismiss the sheet gently. This resulted in opening the keyboard too often. What is potentially impacted by this: - Performance tests with search bars: Confirmed --> smoothness.*/youtube_pinch_2018 not failing consistently - Health tests: Likely confirmed system_health.memory_mobile/browse.tools.maps debug run changed memory:chrome:all_processes:reported_by_chrome:effective_size by 7.7% - Startup with previously opened sites: Confirmed Following instructions in issue 876228 don't reproduce error. Bug: 875859, 876025, 876228 Change-Id: Ic5873c07cb8652bc0da5edcca8324f2680baac11 Reviewed-on: https://chromium-review.googlesource.com/1184847Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585454}
-
Kushagra Sinha authored
- Add Mojo APIs for account upsert and removal notifications. - Add implementation in ArcAuthService. Design doc is linked in the bug id. Bug: 871690 Test: browser_tests --gtest_filter="*ArcAuthServiceTest*" Change-Id: I83dea09c5d28da5c1cb9f9715eead17003ffcf2b Reviewed-on: https://chromium-review.googlesource.com/1169206 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit e00fddec. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 585387 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2UwMGZkZGVjOTJlNDliMWI1N2Y1ZGUyZjExMzQ2OTdmZDZiMWM3MDMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/8297 Sample Failed Step: browser_tests Original change's description: > Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker" > > This is a reland of a9ed46b7 > > ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange > was flaky in the original change. Added logic in the test to wait for the > connection type change. > > Only diffs from original are in chrome/browser/chrome_browser_main_browsertest.cc > > Original change's description: > > Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker > > > > A getter is used for NetworkConnectionTracker because some services that > > use ResourceRequestAllowedNotifier are initialized early in browser > > startup (e.g. VariationsService), and only perform the initialization > > of ResourceRequestAllowedNotifier later on the UI thread. The getter > > allows us to run get the connection tracker at that point so we don't get > > DCHECKs about being on the UI thread when running > > content::GetNetworkConnectionTracker(). > > > > This also moves the NetworkConnectionTracker in ios/ from BrowserState to > > ApplicationContext, which is available everywhere. It also matches non-IOS > > usage more closely, since we have it as a global there. > > > > Bug: 868021 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: I130c6b47feb90f0f7f0776ccc65666414a1ae802 > > Reviewed-on: https://chromium-review.googlesource.com/1180360 > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#584849} > > TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org > > Bug: 868021 > Change-Id: I5941b72474657159f0d4a1e6667fd77a3c475887 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1185602 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585387} Change-Id: Ie348785d70d6c9b7242a51f0370ee471f37c036d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868021 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1185922 Cr-Commit-Position: refs/heads/master@{#585452}
-
Alexander Hendrich authored
This CL makes sure all JSON device policies use DecodeJsonStringAndDropUnknownBySchema to decode the proto and adhere to the associated schema. Unknown properties are dropped. If the json string can't be decoded or does not comply with the associated schema in policy_templates.json, the policy value will be set to the original json string. This way, the faulty value can still be seen in chrome://policy along with any errors/warnings. Bug: 855054 Change-Id: I73a2bc7cc88a293b06339482437f88ac48932b83 Reviewed-on: https://chromium-review.googlesource.com/1163507Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
-
Sam McNally authored
When offline, Drive files should only be selectable in open dialogs if they are available offline. However, this is calculated after the ok button enabled state is updated, resulting in Drive files always being unselectable while offline. Wait until the available offline property of the selected files has been retrieved and used to set the allFilesPresent field on the selection before dispatching the CHANGED_THROTTLED event. Also update the ok button on drive-connection-change events so the button is updated when the network connectivity changes and a file in Drive, not available offline, is selected. Bug: 876973 Change-Id: I15fe35e18a15f3211f395c63b8c01b5a7c7846d7 Reviewed-on: https://chromium-review.googlesource.com/1186210Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#585450}
-
