GitLab

BUG=634418

Review-Url: https://codereview.chromium.org/2438403002
Cr-Commit-Position: refs/heads/master@{#427087}

Followup to https://codereview.chromium.org/2429523002

- Remove NTP_*_SIDE_SUGGESTION (replaced by LogMostVisitedImpression calls)
- Cleanup tests

BUG=656646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2435683003
Cr-Commit-Position: refs/heads/master@{#427086}

There are two main fixes:
-use the new NavigationHandle callbacks on WebContentsObserver which are compatible with PlzNavigate
-update the renderer side so that handles the new order of IPCs: while ReadyToCommitNavigation means the browser side can send its IPC before the internal content ones, with PlzNavigate one content IPC will fire both DidStartProvisionalLoad & DidCommitProvisionalLoad. So add extra logic to the renderer side to handle this.

This fixes
SubresourceFilterBrowserTest.MainFrameActivation
SubresourceFilterBrowserTest.MainFrameActivationOnStartup
SubresourceFilterBrowserTest.SubFrameActivation
with PlzNavigate.

BUG=504347, 653807

Review-Url: https://codereview.chromium.org/2446503002
Cr-Commit-Position: refs/heads/master@{#427085}

BUG=555865

Review-Url: https://codereview.chromium.org/2445513002
Cr-Commit-Position: refs/heads/master@{#427084}

iOS prompts the user to enable Bluetooth when the CBCentralManager object
is created. Setting the ShowPowerAlert option to NO suppresses the prompt.
This allows Chrome to check the Bluetooth enabled state without prompting
the user.

BUG=630769

Review-Url: https://codereview.chromium.org/2443733002
Cr-Commit-Position: refs/heads/master@{#427083}

This change is in preparation for adding "expanding" clip nodes,
which will involve adding a new ClipType.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=653631

Review-Url: https://codereview.chromium.org/2437923002
Cr-Commit-Position: refs/heads/master@{#427082}

This method is called by the cross-platform autofill code resulting in
regular log spam. The calling sites don't expect a non-null return value
so there's no need to log this as an error.

BUG=658299

Review-Url: https://codereview.chromium.org/2435343002
Cr-Commit-Position: refs/heads/master@{#427081}

The following methods in SVGLengthContext:

 convertValueFromUserUnitsToCHS
 convertValueFromUserUnitsToEXS
 convertValueFromEXSToUserUnits

needs the same treatment as convertValueFromCHSToUserUnits got in
https://chromiumcodereview.appspot.com/2445463002.

R=pdr@chromium.org,eae@chromium.org
BUG=657438,658585,658613

Review-Url: https://codereview.chromium.org/2449433002
Cr-Commit-Position: refs/heads/master@{#427080}

BUG=654738
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1914653002
Cr-Commit-Position: refs/heads/master@{#427079}

Add a version of GetPermissionStatus that takes a host_content_settings_map.
This method is guaranteed to be threadsafe.

BUG=658020

R=jochen, mlamouri

Review-Url: https://codereview.chromium.org/2439673004
Cr-Commit-Position: refs/heads/master@{#427078}

Currently, only Blink depends on payment_requet.mojom. Going
forward, all the platforms will, so moving it to a more generic
location.

BUG=

Review-Url: https://codereview.chromium.org/2406923002
Cr-Commit-Position: refs/heads/master@{#427077}

This test was flaky before.  It would just always "succeed" on the
second attempt.

Now it is still flaky.  It just sometimes succeeds outright and
sometimes fails on all attempts.

I'll disable for now until I can come up with a better fix for
these timing issues.

NOTRY=true
BUG=657839
TEST=none
TBR=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2448493002
Cr-Commit-Position: refs/heads/master@{#427076}

Switch the JNI generator sample code to use a JavaRef for java method
parameters instead of jobject.

BUG=506850

Review-Url: https://codereview.chromium.org/2418893003
Cr-Commit-Position: refs/heads/master@{#427075}

Because of crbug.com/657517 the original submit of the test for
NotificationImageLoader had a very loose timeout value. Now that the bug
was fixed (https://chromiumcodereview.appspot.com/2433323003), this CL
updates the timeout values to be tighter.

BUG=579137

Review-Url: https://codereview.chromium.org/2442323002
Cr-Commit-Position: refs/heads/master@{#427074}

Update table.deleteRow(-1) behavior to latest spec, the
change is that if there are no rows left to delete we do
nothing instead of throwing an IndexSizeError exception.

BUG=657837

Review-Url: https://codereview.chromium.org/2427963004
Cr-Commit-Position: refs/heads/master@{#427073}

https://chromium.googlesource.com/chromium/src/+/dba76ba32

BUG=657839
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/2442323003 .

Cr-Commit-Position: refs/heads/master@{#427072}

BUG=655498

Review-Url: https://codereview.chromium.org/2437923004
Cr-Commit-Position: refs/heads/master@{#427071}

This is implemented by using Daydream Api. After a headset is detected by phone,
instead of launch Daydream Home app, ChromeVR is launched iff Chrome was the foreground
app. Follow up CLs will trigger auto presentation if VR aware content was showing.

BUG=641401

Review-Url: https://codereview.chromium.org/2428563003
Cr-Commit-Position: refs/heads/master@{#427070}

Using update-w3c-deps in Chromium 3524bd79.

This is for rtcpeerconnection-constructor.html

BUG=658423

Review-Url: https://codereview.chromium.org/2448433002
Cr-Commit-Position: refs/heads/master@{#427069}

Payments apps can support multiple methods, and each method can
have associated data, so instead of passing on method associated
data as JSON string, pass a method -> method specific data map.

This CL also renames some methods to make it clear if we are dealing
with the PaymentApp or PaymentInstrument.

BUG=587995

Review-Url: https://codereview.chromium.org/2434333005
Cr-Commit-Position: refs/heads/master@{#427068}

The various libsecret methods have different contracts w.r.t. unlocking
keyring items. Of the currently used methods, only secret_service_store
will trigger unlocking as necessary. As a result, operations fail in
various ways until someone performs the first store operation.

With the CL, the libsecret native backend of Password Manager is set to explicitly
request unlocking of items on every call. OSCrypt avoids using
secret_service_lookup, which apparently ignores locked items.

BUG=657828,631171

Review-Url: https://codereview.chromium.org/2441653002
Cr-Commit-Position: refs/heads/master@{#427067}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/82319475..e64d0caf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2444833002
Cr-Commit-Position: refs/heads/master@{#427066}

This preserves behavior as far as possible and adds use counters for
cases that aren't per spec. One intentional change is that the first
argument of the RTCPeerConnection constructor is made optional, as that
is a very low risk change, and requiring the dictionary makes no sense
when providing null, undefined and {iceServers:[]} already work.

Without custom bindings it is unfortunately not possible to distinguish
{certificates:null} from no certificates specified, so that is not
measured.

BUG=649343

Review-Url: https://codereview.chromium.org/2442763002
Cr-Commit-Position: refs/heads/master@{#427065}

The old implementation doesn't handle possible overflows,
when year is too large, for example. It makes a result
to be larger than 2^63 - 1, which results in overflow.

Fix Posix: use safe_math.h for multiplication and addition. If
overflow occurs, return possibly maximum platform dependent
value.

Fix Mac and Win: if safe cast is impossible, return Time(0).

Fix media and components: use day of week as well, as long
as unused variable results in undefined behavior and overflow

BUG=653445

Review-Url: https://codereview.chromium.org/2405453002
Cr-Commit-Position: refs/heads/master@{#427064}

https://chromium.googlesource.com/skia.git/+log/7a86423c4243..826167111f80

$ git log 7a86423c4..826167111 --date=short --no-merges --format='%ad %ae %s'
2016-10-24 caryclark fix one more fuzzer
2016-10-24 borenet Roll recipe DEPS

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reed@google.com

Review-Url: https://codereview.chromium.org/2446583002
Cr-Commit-Position: refs/heads/master@{#427063}

Remove last references to non-custom IDR_THEME_TOOLBAR.
Remove some unused SHADE images.
Remove DropdownBarView, which is nothing but a bunch of dead code.

BUG=648281
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2441863002
Cr-Commit-Position: refs/heads/master@{#427062}

NOTRY=true
BUG=657839
TEST=none
TBR=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2443943002
Cr-Commit-Position: refs/heads/master@{#427061}

This makes SnippetArticle a pure model class that doesn't know about the adapter.

Goals of the overall refactoring:
1) Decoupling the various pieces of logic, by moving them from the adapter into
the tree structure. For example, dismissal is something that could be handled by
a TreeNode instead of doing the big switch statement we have right now in the
Adapter.
2) Stabilizing the structure of the tree. Right now we tend to throw away
everything and rebuild, which means we have to manually figure out what changes
exactly to notify about (cf. removeSuggestion). If we keep the tree structure
stable and just adjust the number of children below each node as necessary (like
SigninPromo already does), we get correct notifications for free, and it will
allow for some optimizations as well (we could cache the number of children for
each node and update it incrementally when a subtree changes. Right now we'd
have to contort ourselves a bit to make that work with things like
resetChildren()).

BUG=616090

Review-Url: https://codereview.chromium.org/2439683003
Cr-Commit-Position: refs/heads/master@{#427060}

BUG=556939

Review-Url: https://codereview.chromium.org/2430803003
Cr-Commit-Position: refs/heads/master@{#427059}

Removed ONC proxy policy applied check when the default network is
changed.

If proxy settings are bundled to the specific network and another
network is connected on startup, these settings are not
transferred to ARC on startup and should be transferred only when the network
becomes a default netowork.

BUG=657361
TEST=browsertest

Review-Url: https://codereview.chromium.org/2436753002
Cr-Commit-Position: refs/heads/master@{#427058}

Respect the ios_app_bundle_id_prefix and ios_automatically_manage_certs
when generating the Info.plist file for unit tests targets on iOS.

BUG=613543

Review-Url: https://codereview.chromium.org/2441793002
Cr-Commit-Position: refs/heads/master@{#427057}

- Remove all logging code from the multi-iframe NTP
- Remove NTPLoggingEventType.NTP_TILE, use NTP_*_SIDE_SUGGESTIONS instead
- Other small cleanups

BUG=656646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2429523002
Cr-Commit-Position: refs/heads/master@{#427056}

It is not defined in implementation, and it is not needed to be checked.
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md#LogActivity_m_a

BUG=650150

Review-Url: https://codereview.chromium.org/2439413002
Cr-Commit-Position: refs/heads/master@{#427055}

BUG=475439

Review-Url: https://codereview.chromium.org/2442563002
Cr-Commit-Position: refs/heads/master@{#427054}

Update code in ui to use JavaRef when calling Java methods via JNI,
instead of passing bare jobject. Various function parameter types are
converted from jobject to JavaRef to enable calls to obj() higher up the
call chain to be removed.

BUG=506850

Review-Url: https://codereview.chromium.org/2417263002
Cr-Commit-Position: refs/heads/master@{#427053}

When the browser encounters an error while reading a response body, it should
error the body stream with a TypeError.

BUG=656601

Review-Url: https://codereview.chromium.org/2439673002
Cr-Commit-Position: refs/heads/master@{#427052}

Currently, CreateSortKey in password_manager_presenter.cc assumes that domain
and registry name obtained from a hostname string is always a suffix of the
hostname string. This is true for ASCII-based examples like this:

hostname: subdomain.example.com
domain and registry: example.com

But it is not true for non-ASCII-based examples like this:
hostname: žřč.com
domain and registry: xn--bea5m6d.com

The reason is that to obtain the domain and registry, the hostname is being
canonicalized.

The domain and registry is used to create a sort key for a credential with the
given hostname. The idea is to start with the domain and registry part, and
then append the remaining subdomains (reversed). The remaining subdomains were
computed by taking the prefix of hostname of the length of the difference of
the length of the hostname minus the length of the domain and registry part.
This number may overflow in case the domain and registry is not a suffix of the
hostname.

This CL fixes the issue by appending the whole hostname to the domain and
registry part. The results look like this:

hostname: subdomain.example.com
old key: example.com.subdomain
new key: example.com.com.example.subdomain

hostname: žřč.com
old key: undefined
new key: xn--bea5m6d.com.com.žřč

This is safe (no assumptions about suffixes) and preserves the sorting order of
any two credentials before and after this change. It is potentially duplicating
the domain and registry part. An alternative solution could just canonicalize
the hostname before composing the key, but the code would be more complex for
an unclear benefit.

The CL also uses a more efficient call to GetDomainAndRegistry (avoiding
redoing the canonicalization of a known URL). It also introduces a test and
removes an unnecessary call to ASCIIToUTF16.

BUG=655949

Review-Url: https://codereview.chromium.org/2439953004
Cr-Commit-Position: refs/heads/master@{#427051}

Also recounted, updated and corrected total bit count.

Review-Url: https://codereview.chromium.org/2442283002
Cr-Commit-Position: refs/heads/master@{#427050}

The protected virtual 'AllSensorsRemoved' method is added to PlatformSensorProviderBase class.
Unit tests are also included.

BUG=606766

Review-Url: https://codereview.chromium.org/2434073002
Cr-Commit-Position: refs/heads/master@{#427049}

This doesn't have any effect on sendBeacon's credentials handling.

This code was introduced in https://codereview.chromium.org/1016373002,
but even since at this point, AllowStoredCredentials is passed to the
BeaconLoader constructor.

Replacing with DCHECK.

R=mkwst@chromium.org
BUG=636297

Review-Url: https://codereview.chromium.org/2336273003
Cr-Commit-Position: refs/heads/master@{#427048}