- 27 Aug, 2020 40 commits
-
-
Leonid Baraz authored
Bug: b:165851833 Change-Id: Id4d65e2426663783d510a72a8a1f298462e3d2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378655 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#802085}
-
chromium-internal-autoroll authored
Release_Notes:http://go/media_app-x20/relnotes/Nightly/media_app_202008260800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/NDPCcgJvuhM3F7KyVFnMa4mftVlWMdK9ysK3cuxhi2oC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/163669074,b/165878563 Tbr: media-app@grotations.appspotmail.com Change-Id: I9f32f007dc5d2f80af54e4d63a75c855e6c3dce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378933Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802084}
-
Rachel Wong authored
The privacy container score was previously set to INT_MAX to ensure that it was the first container, because other container scores could fluctuate. The app list config now consolidates the scores for all search result containers, see https://chromium-review.googlesource.com/c/chromium/src/+/2345924. Bug: 1079169 Change-Id: I1caf9a3bd94f2c71aed68fe79f2ec88fa4f39645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377185Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#802083}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/14a9bffb3e9e..ced41e1f394d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1f53c2b234ac21a8c10748bbeebc32487102ca96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378887Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802082}
-
Alan Screen authored
Advanced capabilities for ChromeOS are always strings, but those values can contain content that is to be interpreted as numbers or a boolean. These different types were previously distinguished by using the base::Value::ValueType enum, which is a superset of what ChromeOS requires for these capabilities. Use of this enum creates a hurdle in the effort to mojoify PrintBackend class for out-of-process print drivers. In particular, extending the mojo definition of base::Values has been deemed undesirable. [1] While the original reason for using base::Value::ValueType here is unknown, it seems that it should be replaced with something that reflects its more limited possible values. Rather than pull in CloudPrint-specific types into core printing code, introduce a type locally to reflect the expected capability types. [1] https://crrev.com/c/2368138 Bug: 809738 Change-Id: I42efff084a394cb6e0ac4e1f89ffd41aa58ae323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369496Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802081}
-
Kyle Horimoto authored
This class exposes the notifications which have been synced from the phone and provides APIs to dismiss notifications and send inline replies. The functionality to add notifications to this class and to implement dismissal/reply are not yet implemented. This CL also simplifies some logic in FakePhoneHubManager to avoid unnecessary unique_ptrs. Bug: 1106937 Change-Id: I9cc743bbb85aea64fe47f839ffa6b631f88e4e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378774 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802080}
-
Xinghui Lu authored
The SafeBrowsingExtendedReportingEnabled policy is supported on desktop platforms since M66. We should support this policy on Android as well. Screenshot: http://screen/AxEr3pc9q6s4KMi Bug: 1108604 Change-Id: I456de70a9a0435cbe3fa6e54e2648e7d834a42c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378542Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802079}
-
Danyao Wang authored
Allow origins enrolled in the Secure Payment Confirmation trial to use skip-the-sheet flow to trigger secure modal. Bug: 1122028 Change-Id: I8d9e41ad6ac3b8851e72fa5416562d85a8b14f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378446Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#802078}
-
Alexander Cooper authored
Oculus and OpenVR both have beta runtimes that will allow running their devices via OpenXR. In order to simplify the Chrome codebase, we will stop running Oculus and OpenVR against their own runtimes (which have not shipped), and run them via their OpenXR implementations. Note that with OpenVR being removed, the test macros needed to be modified to stop running against it, as well as a few OpenVR specific tests needing to be removed. Oculus runtime was never tested in an automatic fashion. Bug:1121624 Change-Id: Ibdf13532e922db1290062186fd5ec45885d5b46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373392Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#802077}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1752e62f5c2a..69ed1bc0165a 2020-08-26 brcui@microsoft.com Remove Settings from More tools menu 2020-08-26 michael.liao@microsoft.com [Accessibility - Console]: Adding SR alert for clearing the console If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1120065,chromium:1121312 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9e73541b8212b21c4d1cbf678bf190ae7416db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378666Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802076}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e7f2169b3665..c08c71bedfbb 2020-08-26 apolito@google.com don't let 'anyone' be a reviewer 2020-08-26 vadimsh@chromium.org Update lucicfg to the latest version. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1120999 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I11dc021bd00bd7b17d45d2f5ed8370a769e639ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802075}
-
Austin Tankiang authored
|stop_callback_| can no longer be used to indicate that Stop() has been called as running the callback will make it null, so add a |stopped_| field instead. Bug: 1007662 Change-Id: Ifea869fa1a80f1c6eeeced5abf8a56bf55808365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374911Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#802074}
-
Kurt Catti-Schmidt (SCHMIDT) authored
This change implements basic positioning and layout of grid children. It also allows for creation of NGGridLayoutAlgorithm from Blink outside of unit tests, so we now render actual grid content in Chromium for grids with fixed size rows and columns! There is still quite a bit of missing functionality, including for positioning in non-fixed sizes, grid-gap, etc, which will be covered in subsequent changes. This also includes some helper methods for dump tests, along with our first dump test for GridNG. A known limitation of this change is that there must be enough defined rows and columns for child elements. This will no longer be an issue once we handle the TODO comments regarding auto repeaters. For now, I've added additional row/column definitions to the existing tests to avoid this limitation. Bug: 1045599 Change-Id: I9efd14fd44eaf6cac7e93fa05be4c45810e64dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369673 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#802073}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8178c8db6335..aa79ac23ec8d 2020-08-26 mheikal@chromium.org Remove is_emulator check from DeviceUtils#pixel_density If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I12c80ce89236ee416d3a0b2b8285a237c9e77013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378661Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802072}
-
rbpotter authored
Add a preprocess_grit build rule and script. This will allow Web UI files to be preprocessed by grit without going through the pak/unpack process, and without requiring such files to be listed in a grd file. This simplifies the process of creating generated output folders with fully preprocessed files for bundling. Bug: 1071641 Change-Id: Ifd69f9d985083555987a7d968378a7f7aeff15c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369981Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#802071}
-
Austin Tankiang authored
This changes CryptAuthApiCallFlow and CryptAuthClient to use the newer callback classes, and updates users of CryptAuthClient's mock as needed. Bug: 1007662 Change-Id: I1a8acbcbd1ac6294165c2f6ece82571a324487f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377766Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#802070}
-
Kyle Horimoto authored
This class includes metadata associated with a notification which appears on the user's phone and has been synced to the Chrome OS device. Bug: 1106937 Change-Id: I2591ca19b8752346390c649d85f2c31978f1f37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378881Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#802069}
-
Oksana Zhuravlova authored
This reverts commit 279dbf78. Reason for revert: investigating a proper solution for https://crbug.com/1120959 might take a while Original change's description: > [mojo][bindings] Move Router exception to executor thread > > This change moves throwing the exception if Router was not closed to the > executor thread to make it crash instead of just logging. > > Bug: 1087098 > Change-Id: I65c510bdbadedc3a0589807843c57e925c0351c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321345 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800765} TBR=boliu@chromium.org,oksamyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1087098 Change-Id: Iabeda9f10d9fcffd9d9894b72506a55b43907455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378897Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#802068}
-
Josh Nohle authored
The Device proto |display_name| field is a relic of the past. It could also be a privacy concern. Remove all use of it. The device name will continue being included in the certificate's encrypted metadata. Fixed: b/166114548 Change-Id: I74b9ee2924ca80a707c1e0e25f68be6a2a94dab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378757 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#802067}
-
David Maunder authored
Bug: 1119856 Change-Id: Id9f07fb02232d8a6ed7cfedf2c144e6e3c3a82c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372923Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#802066}
-
Sunny Sachanandani authored
If only video is being presented in an overlay swap chain, then root surface damage is empty. However, we still enqueue an event query for presentation feedback. This keeps the 3D engine active and consumes power. This CL moves the vsync and presentation feedback logic to the root surface (DirectCompositionChildSurfaceWin) and only enqueues the event query if the root surface damage is non-empty. Bug: 1117214 Change-Id: I7fa205e44010558bd08fe6a0681c783529cd8c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360323 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#802065}
-
Noah Rose Ledesma authored
When an audio device is selected via the GMC UI that setting should persist for all media on that origin in that sesion until another selection is made. Bug: 1122134 Change-Id: Icbdd58db3c0e2233804004065958dcd544d37c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378450Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#802064}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1f2195b4..2a00f38a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I70ddc2d6f35c8ad166a434367ac411099dcf3aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378694Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802063}
-
Eugene Zemtsov authored
Bug: 1121793 Change-Id: Ia1e0cd7fb24bc004707485b57ff09672b8a3ae86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378882Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#802062}
-
Michael Crouse authored
This change enables LiteVideo to rely on the Optimization Guide for hints rather than using a Finch supplied set of hosts. This change maintains both code paths and puts the optimization guide behind a Finch parameter. A future change will add a global blocklist to limit hints from being served on subframes from origins that LiteVideos do not perform well on. Bug: 1117064 Change-Id: Iabfb48df4bed15fec0a56d1c790627453581b637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369262 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#802061}
-
chrome://flagsDale Curtis authored
Has been hidden since M76, so time to remove. R=cassew Fixed: 1110734 Change-Id: I4d07728d13b0df2420a58cae21ace36cba7af744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378632 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#802060}
-
Rakina Zata Amni authored
Currently we collect all DOMWrapperWorlds in a thread, so we might collect DOMWrapperWorld that don't have ScriptState (e.g. those with type kRegExp, created by text inputs) for hooking BFCache eviction, causing errors when trying to get the ScriptState. This CL makes sure we skip non-main/isolated worlds. Bug: 1117436 Change-Id: I6fa2f70446b18510bcfeb0997214b50086c4913a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377829 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802059}
-
Joe DeBlasio authored
This CL just adds a feature parameter to tune whether or not to use the keyword heuristic for eTLD+1 elision. The param defaults to true so that manually-opted-in users get the full elision behavior. Fixed: 1122309 Change-Id: I334305d9ada6044dadbdf39d283253aae51d26f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378739Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#802058}
-
Brandon Wylie authored
Bug: 1122310 Change-Id: I20a3aac84f4604c02c3744129a16394c8976bac1 TBR=fhorschig@chromium.org Change-Id: I20a3aac84f4604c02c3744129a16394c8976bac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378775Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#802057}
-
Frédéric Wang authored
This reverts commit 421d2ad9. The test was failing on linux-chromeos-chrome internal bot because the CSSOMViewScrollCoordinates flag had not been enabled yet on it. However, that should no longer be an issue after [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2310799 Original change's description: > Disable DirectoryTree/FilesAppBrowserTest.Test/directoryTreeExpandHorizontalScrollRTL > > Failin on linux-chromeos-chrome internal bot since > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3955 > > Error like "[FAIL] [directoryTreeExpandHorizontalScrollRTL]: Tree should not scroll right > > This is blocking src-internal rolls (for >1 day). > > Tbr: majidvp@chromium.org, noel@chromium.org > Bug: 1061821, 1061670 > Change-Id: I27dd3fca5a5d9154519680b748c6dd054f2dd021 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103012 > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750465} Bug: 1061821, 1061670 Change-Id: I12f490679d9d465b676318722282ef5f9fb190dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377489Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#802056}
-
Jonah Chin authored
PaintImage::GetSkImage() is being deprecated. This CL cleans up more GetSkImage() callsites by using the new GetSwSkImage() API, other APIs directly on PaintImage, or using SkImageInfo to obtain image metadata. Bug: 1018894 Change-Id: Iad80746565a2a9b8193a6025893c0beda6fc7cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355100 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#802055}
-
Victor Fei authored
Google drive expand/collapse state is not being announced due to excessive HIDE/SHOW/REORDER events flooding NVDA, and NVDA end up discarding most events. For example, if we remove aria-hidden="true" on an ancestor node, which would cause that many of its descendants to remove their IGNORED states which triggering too many EVENT_OBJECT_SHOW and causes NVDA to drop the events. In reality, we only want EVENT_OBJECT_SHOW to be generated on the ancestor node where aria-hidden="true" is removed, so not to flood and confuse NVDA with excessive events. This change fixes the above issue by firing EVENT_OBJECT_SHOW on the root should the nodes of the entire subtree remove their IGNORED states. https://crrev.com/c/2309450 implemented suppressing excessive HIDE events, of which this CL is based on. Suppressing excessive REORDER events will be addressed in follow up patches. AX-RelNotes: NVDA can now announce Google drive "My Drive" expand/ collapse state. Bug: 1019420 Change-Id: Icecf5d998ea666db4bf21a56f8b8b0b9a1e4aaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337404 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#802054}
-
Andrew Grieve authored
Bug: 1117222 Change-Id: Ifb7db199d0fb2b5d82cdef53f1eb5eccf2bb5363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377999 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#802053}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fdfdcf61cd4..14a9bffb3e9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4c867d0f3701b3c66a90c5bc467f6543c60318cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378595Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802052}
-
Christopher Cameron authored
Remove the option to specify a color space when calling createImageBitmap. Also remove the preserve_color_space parameter. None of these are used by existing behaviors. Their existence makes other cleanup harder. Bug: 1119507 Change-Id: I4ddcd76afff0a542c318a0035ad4559ff0022303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370727 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#802051}
-
Yuri Wiitala authored
Fixes issues with UTCExploded() on certain 32-bit systems, where Time's in the near and distant future would result in exploded calendar fields in "random years past." This change solves the Y2038 problem for those systems. Hardens the UTC/LocalExploded() API, to guarantee all platforms will explode from the years 1601 to 30828 (at least), and clarifies how callers should check for a valid conversion. For platforms whose standard libraries are insufficient, the icu::Calendar implementation is used to provide the needed functionality. Fixes/Simplification to ensure base::Time::ToRoundedDownMillis...() will never do math that overflows int64_t's. Minor other tweaks in touched files. Fixes to a couple of unit tests in net/der and net/cert/internal. Bug: 1104442 Change-Id: I5f0e45879b8ee18cc7c253fa4a204443fdc27ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317864 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#802050}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3d1609516687..68c8ed7aec14 2020-08-26 syoussefi@chromium.org Vulkan: More perf warnings 2020-08-26 geofflang@google.com Add support for P010 IOSurfaces 2020-08-26 jmadill@chromium.org Fix Linux build with Skia. 2020-08-26 jmadill@chromium.org Generalize zlib utils dir for Skia build. 2020-08-26 jonahr@google.com Fix SwANGLE suppressions of EGLIOSurfaceClientBufferTest 2020-08-26 ianelliott@google.com Vulkan: Fix TRex performance regression 2020-08-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from fb86cfb19849 to 94ee680cab4c (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1115621 Tbr: courtneygo@google.com Change-Id: Iac84acb5f79f5256104187a11e8d9932fdf23d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378654Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802049}
-
Ian Kilpatrick authored
Per: https://www.chromestatus.com/feature/5680142707851264 In M85 we switched -webkit-line-clamp over to LayoutNG which had the (indended) side-effect of removing support for: -webkit-box-flex -webkit-box-ordinal-group -webkit-box-align -webkit-box-pack -webkit-box-direction When used with -webkit-line-clamp. This patch removes the -webkit-box-flex from LayoutDeprecatedFlexibleBox Bug: 305376 Change-Id: I51b49eb6c7fd20d3f15d15e262a513e0cddadefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375943 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#802048}
-
Zhuoyu Qian authored
This CL rename the TextIteratorAlgorithm member GetText() to GetTextState(). Change-Id: I782bd5b8faaea7f220e15f5c3a8d929d40f17422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376928Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#802047}
-
Garrett Beaty authored
The master-only directory has been unwieldy and in order to support LTS an additional subset would be required which would make doing it by directory even more unwieldy. The addition of a library for conditionally defining LUCI resources depending on the branch means that the builders for a bucket can be located together and the branch_selector value controls which branches they are actually defined for. Bug: 1119446 Change-Id: I1dff1f8e6c0485e31fd902c383f02b37a3f0d138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378794Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#802046}
-