- 20 Oct, 2020 40 commits
-
-
Rachel Wong authored
The Suggested Content toggle has been approved in https://bugs.chromium.org/p/chromium/issues/detail?id=990279#c148. This CL enables the feature by default, and updates tests that need to take this into account. Bug: 990279 Change-Id: Icc2c8bdf72cff8734aa5941f3fbc2774b38e4c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462752Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#818758}
-
Fergus Dall authored
guest_os::GetHandler can be called on incognito and guest profiles which do not have a GuestOsRegistryService. This causes a null pointer deref crash. Fix this by returning base::nullopt in this case. Ran new unit test without change to verify the crash, and again with the rest of the change to verify the fix. Bug: 1139821 Change-Id: I943d2d7c06b2f897607784a046978a981ed2613e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485414 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#818757}
-
David Schinazi authored
R=renjietang@chromium.org Change-Id: I22beaebb6c757818f8c28129d63ae48ba8bdad8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485345 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818756}
-
Xing Liu authored
Chime needs to be initialized during ChromeApplication.java's startup code. This CL adds ChimeSession.initialize() entry point API, and a upstream placeholder function for Chime DFM. Also clean up the feature flag JNI call for Chime, now it can directly depends on chrome/browser/flags:java. Bug: 1136305 Change-Id: Id8424fc22d2f419860318b12bd8753da448cd50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466897Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818755}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c81dc527120b..f7dcbb7b3498 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC calamity@google.com,rdcronin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1117343 Tbr: calamity@google.com,rdcronin@google.com Change-Id: I7e569125522bc3e2f6af1dfd0efc10b9643ef094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486450Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818754}
-
Hoch Hochkeppel authored
Adding a class to represent the Windows Buffer class within tests, as well as basic unit tests to validate the test class behaviors. Bug: 1035527 Change-Id: Ib4507c66d7b9c975e7580b2053f23b1dc54f3402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485553Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818753}
-
Sammie Quon authored
There is similar OverviewAnimationStateWaiter which has a wrapper in ShellTestApi. Test: existing tests Bug: none Change-Id: I90755f59e4f246641f7b0fa1c1701ceb68651f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476617Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
Gang Wu authored
Bug: 1136677 Change-Id: Ia14627cfae1832710a8652b942718173abc7487b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482429Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818751}
-
minch authored
Bug: 1131543 Change-Id: Ib58a9069b740f692038d8031a55da74a0dfc3b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477525 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#818750}
-
Eugeny Aristov authored
For GCC it's important, otherwise in this specific case std::underlying_type is taken for incompatible types (int, char, etc.) before std::enable_if_t throws out inproper template. Error example (GCC 8.4.0): /usr/include/c++/8/type_traits: In instantiation of 'struct std::underlying_type<long unsigned int>': ../third_party/blink/public/common/privacy_budget/identifiable_token.h:121:13: ../chrome/browser/privacy_budget/privacy_budget_ukm_entry_filter.cc:61:73: required from here /usr/include/c++/8/type_traits:2009:38: error: 'long unsigned int' is not an enumeration type Bug: 819294 Change-Id: Ic4b329d12ca2c8899e62c65b2a327b227caa2c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480442Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#818749}
-
Yury Khmel authored
This adds ability to enforce throttling mode and adds obsever to receive throttling change updates. DD: go/arc_power_control TEST=Unit test + locally in context of prototype. BUG=b:170982650 Change-Id: I1fe3633ff5792355917c890280155a8b5d73892f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477454 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99620c4bfcfc..6bc78433f44f 2020-10-19 jalyn@microsoft.com Settings: Remove old ShortcutsScreen If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib54491ee10697045b9d3e5b36db27dcf8d8c80df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818747}
-
Tomasz Wiszkowski authored
This change addresses the problem, where the reordering suggestions in Java causes suggestions to be mis-reported by Native. The change enforces ordering consistency between Java and Native pools by forwarding the call to partially group suggestions by search vs URL to Native. The expected location that will be responsible for partial grouping is the Native AutocompleteResult class, where Java AutocompleteResult will simply serve as an interface, so this change aligns with our broader plan to move the suggestion ordering to Native. Bug: 1050813 Change-Id: I4b08d7c41dce4e4a580c8d0490fd4cfe6c11091b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481830 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#818746}
-
Jamie Madill authored
Sample approximate summed test run improvements: win-angle-deqp-rel-64: 100 shards, 300 minutes -> 27 shards, 50 minutes win-angle-deqp-rel-32: 8 shards, 45 minutes -> 2 shards, 5 minutes linux-angle-rel: 70 shards, 80 minutes -> 21 shards, 27 minutes Android should be unchanged. In total this may save almost 6 hours of bot time per ANGLE CQ run. Bug: angleproject:5124 Change-Id: I3be354058e32293c1360a2ed279666ecf19e41fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454401 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#818745}
-
James Zern authored
libwebp @ v1.1.0-37-g9f6055fc + sync fuzz_seed_corpus w/libwebp-test-data and delete unused local copy animdecoder_fuzzer.cc isn't built as all its dependencies aren't imported currently; WebPAnimDecoder is unused in chrome NOPRESUBMIT=true (due to include/nullptr warnings in third_party code) Bug: webp:409 Change-Id: Id41fd215652d0339af3410e7948350456ddce2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482388 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818744}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iad4f08b81d86af1b455105bedfaa0abfa859cbea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486446Reviewed-by:
-
Vadim Bendebury authored
This information is of interest, especially in case of Board ID flags misconfiguration incidents. BUG=chromium:1089267 TEST=none Change-Id: Ib93b0df5b58d08e72a1075a56c1bff24df53f6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446196Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vadim Bendebury <vbendeb@chromium.org> Auto-Submit: Vadim Bendebury <vbendeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#818742}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/aff4c0366314..c4593127cbdd 2020-10-19 dsinclair@chromium.org Include compiler header 2020-10-19 cwallez@chromium.org Roll third_party/swiftshader/ 2014e7b92..df17a7610 (79 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ife1ab7429ea37ad4ea138e777cee6e39a8e678fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486283Reviewed-by:
-
Frank Tang authored
ICU 68, to work with C++20, remove the #define of TRUE since the usage in libxml is as an int, use 1 instead. Bug: 1138555 Change-Id: I4c5955b3e80beccc8de071a129172af07c0ae0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478027Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818740}
-
Alex Newcomer authored
We had installed the accelerator via a PreTargetHandler, mainly because we did not realize AcceleratorController existed. Fix this, then fix a bug that was realized afterwards. - Prevent launcher from showing when non-related keys are pressed. - Send KEY_RELEASED events when sending synthetic key events as to not confuse AcceleratorHistory. - Fix some tests which do not send key release events. Change-Id: I31678cfd05e6ccf7f662aab2d8276d5eaefa1539 Bug: 1136201, 1131727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453918Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
tby authored
We're no longer using this flag or it's finch equivalent in code, this CL removes them. Bug: 1110580 Change-Id: I7c25e134ada13d415ab34ebe6f2527e076879d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485973Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#818738}
-
Daniel Murphy authored
Release team strongly prefers a kill switch for merges to stable. R=costan@chromium.org Bug: 1139902 Change-Id: I6b7f98c3d1032c1cf9098d2ded87413e89bdd530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486396 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#818737}
-
Dmitry Torokhov authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ebddc236e489..13e275d7e504 $ git log ebddc236e..13e275d7e --date=short --no-merges --format='%ad %ae %s' 2020-10-16 dtor system_api: add native error codes to Parallels dispatcher responses 2020-10-15 nverne permission_broker: remove unused OpenPathWithDroppedPrivileges 2020-10-05 kevinptt runtime_probe: add probe result format error Created with: roll-dep src/third_party/cros_system_api Bug: b/168829032 Change-Id: I87516d71d4ee99a1ad212713df5b903aa0baefe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486032Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#818736}
-
rbpotter authored
Bug: 1132403 Change-Id: I26395b161c9d9d7885e85ca83f297e032f56c362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477417Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#818735}
-
Austin Eng authored
Failing a CFI check in third_party/vulkan_memory_allocator Tbr: kbr@chromium.org Bug: 1139916 Change-Id: I588a5ce228b41ac386fb0a477ee4e889631c0a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485678Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#818734}
-
Shakti Sahu authored
This CL fixes 1 - Fixes the IPH config values for click and dismiss counts, i.e. IPH card disappears after one click or one dismiss. 2 - Summary card is sticky on NTP until explicilty dismissed 3 - Added finch provided image URL for summary card 4 - Reordered video tutorial IPH card to show below most visited tiles 5 - Fixed an issue in thumbnail generation for IPH and list items 6 - Changed video tutorial WebUIDataSource to be added only once. Change-Id: Ibce134248a35af555fb1d9e146cc8fce3a87e81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473345Reviewed-by:Min Qin <qinmin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Bill Budge authored
- Removes some 'pepper_flash_*' files that were removed from the build. - Removes PPB_Flash_File and PPB_Proxy_Private that are now unused. - Removes assorted things in content/ and ppapi/ that are no longer relevant without Flash. - Removes PepperPluginInstanceImpl::is_flash_plugin method. Bug: chromium:1064652 Change-Id: I6905b64de90a58668e007a1282a6b6b248506358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481283Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#818732}
-
Matt Wolenetz authored
MSE worker thread termination or worker removal of SourceBuffers can race the thread hopping of the OnMetadata signal. If MSE track removals win the race such that pipeline's reported metadata contains no audio or video, then when handling that metadata in WMPI, this change issues player load error instead of transitioning to HAVE_METADATA. This fixes a crash resulting otherwise because transition to HAVE_METADATA without MSE pipeline metadata having any A/V previously enabled beginning playback (in WMPI::Play()) without having a WatchTimeReporter. I tried reproducing similar failure first using MSE from the main thread (not MSE-in-Workers) and trying to get removeSourceBuffer to occur precisely in time to win the race, but was unable to get a repro with a bit of trying. However, I still suspect this issue could have pre-existed MSE-in-Workers. The change is not specific to MSE, since WMPI should prevent successful playback start if the resource has neither audio nor video metadata. This change also includes a test note to add a feature to MSE-in-Workers (feature-detection of MSE-in-Workers support from main/Window context) and to use it to deflake the test itself which could flakily fail (not crash as is fixed by this change) on implementations that do not support MSE-in-Workers yet. BUG=878133,1139854 TEST=Updated WebMediaPlayerImplTest.NoStreams (blink_media_unittests), and manually verified on linux locally: flaky crash appears fixed for .../dedicated-worker/mediasource-worker-play-terminate-worker.html Change-Id: I8a9d8428417555089c8b09f4bc1e19849bbe0162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486074Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818731}
-
minch authored
Bug: 1131543 Change-Id: I0a4be1040028c00f720d0396a2b1cfe88ee44a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480890 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Nate Chapin authored
Change-Id: I51dae7553c07f2f2ea1bc3aa9bb26cd2a3627447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481788 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#818729}
-
bttk authored
Out of 15 files referring to OmniboxFocusReason only 3 need the LocationBar itself: - CustomTabToolbar - ToolbarManager - ToolbarLayout Bug: 1139481 Change-Id: I3e6cc1da9d79a8e75fb4b2b456181ab18a251b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481926Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#818728}
-
Christopher Cameron authored
Change gfx::BufferHandle to use a gfx::ScopedIOSurface instead of a gfx::ScopedRefCountedIOSurfaceMachPort. Reason for using a mach port: It's the thing that goes over all forms of IPC. Reason for not using a mach port: The mach port's existence makes the IOSurface report that it is in use. This makes it so that things like CVPixelBufferPools will not re-use that IOSurface. The capture pipeline keeps lots of gfx::BufferHandles around, which causes the underlying CVPixelBufferPool to go haywire (in this case growing without bound, but another valid way to blow up is to just hang and never capture any more frames). Also remove some debugging code. Bug: 1139105 Change-Id: I1ffa11a325b6a8e1811a23b1c4d7dac00fad49db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485992Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#818727}
-
Kartik Hegde authored
Add optimizations to the HttpsLatency routine along with correct host resolution code. BUG=chromium:956783 TEST=unit_tests --gtest_filter=HttpsLatencyRoutineTest.* Change-Id: I60b4bfc47e973acf48c289bd0bc524d7b4490bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483032Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#818726}
-
Pranav Batra authored
Increase the rate limit to prevent pita tast tests from flaking Unlike cupsCopyDestInfo(), cupsDoRequest() does not appear to retry requests when the server is busy. If the tests still flake, this limit may have to be increased again. Bug: none Test: tast run -buildbundle pita <DUT> printer.* Change-Id: Idbd0f485cf47e059e9bd80a5b53e338887ba7d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470302Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Pranav Batra <batrapranav@chromium.org> Auto-Submit: Pranav Batra <batrapranav@chromium.org> Cr-Commit-Position: refs/heads/master@{#818725}
-
Clark DuVall authored
This patch has a few fixes needed before enabling isolated splits in canary: - Make module_installer load classes from the application context ClassLoader instead of using Class.forName, since that may be using the base ClassLoader and not have the chrome split classes - Fix some of the bundle smoke tests since the DFMs are merged into the chrome DFM. - Fix the chrome resources package (org.chromium.chrome.R) clashing with the base module's resources when the APK package name matches. - Ignore chime services which are not defined in the base module, since they will not be used with isolated splits. Bug: 1126301 Change-Id: Ib149894636863408c5fd37054eacb48c214b5b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472707Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#818724}
-
Maggie Chen authored
If the overlays are the only damages in the frame, we will get a zero root damage rect with the new way of calculating damage rect |use_overlay_damage_list_|, which is enabled by default. The old code of |use_overlay_damage_list_| == false is still working. It will be cleaned up once the new code is stable. Bug:1117235 Change-Id: Ibbede44056973a5ba9e052292673bbf0bcb4a50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434905 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#818723}
-
minch authored
Bug: 1133748 Change-Id: I33c8d0d97e20ba86943332d41a9ee68ae1fbf4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481463Reviewed-by:
-
minch authored
Bug: 1131543 Change-Id: I196eb050b6b6a91dba4da76ee9915a2011f1b57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480802 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Chait Pinnamaneni authored
Original PR https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841 Explainer for this feature is https://docs.google.com/document/d/14qJ1rZyMtnIa8hPJc1V8DJRxk4lVI3hlWYGvBDICog0/edit?ts=5f7c13ce Bug:1137050 Change-Id: I6b1dda29537e05c415b2f6479c03dee989281a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485849 Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Reviewed-by:
Kalon Hinds <kahinds@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818720}
-
Esmael El-Moslimany authored
"z-index: 1" was introduced to render the icons over the ripple when the ripple could be opaque. The opaque ripple feature has since been removed. Bug: 1140234 Change-Id: Icb1d8fbe9a40f89fe7a6593f22283671ecdbcbab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486386 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#818719}
-
