- 09 Jun, 2020 40 commits
-
-
Clark DuVall authored
The weblayer unittests needed a small fix to be able to run on Android, these should be running on the bots. This will be useful for adding site isolation unittests, which should be tested on both Android and desktop. Bug: 1058364 Change-Id: I7188a6140cff2811594bc7ab6d2e9b2dd58366ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235941Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#776359}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7c56f7ee. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" 101c532f "[css-lists] Fix list image gradient with dynamic zoom" a8a28083 "[Security][Coop] Browsing context switch reporting WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I8089a0b355a0bd9296077cd2803e2133191cf0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235736Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776358}
-
Emily Stark authored
This implements the flag omnibox-ui-hide-steady-state-url-path-query-and-ref-on-interaction. In this variation, the path is shown on page load until the user interacts with the page. Bug: 1090393 Change-Id: Ie21b67a0939dbc7938e00ba477c2c7abab59b61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234128 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#776357}
-
Jeff Yoon authored
The validation step already ensures that profraw files are good. When they are invalid, they are set aside, and the merge_error detection mechanism raises these. PGO skips the validation, so any failures merging should be raised directly. Bug: 1091310 Change-Id: Iea3460356f9ad7e5b914bd99f2b88bde5cb0bb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231263Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#776356}
-
Chris Lu authored
Bug: 1071914 Change-Id: Ieb1c78e1c6a771672c84ae7011ad7bf4815655c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236597 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#776355}
-
Tao Bai authored
No feature change. Bug: 949555 Change-Id: I73ccacc91694bfac3b1016de6310f628403805cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234016 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#776354}
-
Yoshifumi Inoue authored
This patch introduces tests for |{End,Start}OfLine()| to record current behavior to help implementing EditingNG. Bug: 707656 Change-Id: I0cbf1ecbbbf1fdfb0ed2647b78cde9d37f8554d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235224 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776353}
-
Nigel Tao authored
Bug: 1086733 Change-Id: If34d48c06619639470ba27de8ba003591219766a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235134Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#776352}
-
Aga Wronska authored
ManagedUsers.Whitelist.Count has some data for Chrome <= M77, so it extended. It should be removed together with the feature code when confirmed that it is obsolete. The following metrics have no data and are being marked obsolete: ManagedUsers.Whitelist.JsonParseDuration ManagedUsers.Whitelist.TotalLoadDuration ManagedUsers.Whitelist.ReadDuration Bug: 1088898 Change-Id: I965f33c75a710043768a0458bb4e5d249cd69bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227891 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#776351}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ac68fc0764f5..f19675c75eab 2020-06-08 lalitm@google.com Merge "tp: fix GetNonNull function for dense nullable vector" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie24eb5c18b6f4fbf2c16f570fe5a9df0d17917e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236380Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776350}
-
Nigel Tao authored
Bug: 1086733 Change-Id: I0eeab461cb147d8cd175fac15c8feb448f9aeffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235219 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#776349}
-
Nate Chapin authored
Bug: 1029822 Change-Id: I3b14ea528a0b82ca79a63566921d3c72abb141c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233493 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776348}
-
Xinghui Lu authored
Currently returning the expiration time of an access token is not supported on Android, because only a plain string is returned from the Java side. In this CL, we add support to return the expiration time by adding a holder class named AccessTokenData. If the API doesn't support expiration time, the time will be set to 0. In the external repository, the first party API is not available, so we continue setting the expiration time to 0. The CL for setting the expiration time will be added in https://crrev.com/i/3022086. Bug: 1070324 Change-Id: Ibb7ba5a47131af6046fdbd64725729486c07d753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209641 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#776347}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ief9379c061e91e8414b4bd6d78e54e326e98fbfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236677Reviewed-by:
-
danielng authored
Adding the basic UI requirements needed for plugin vm camera permissions and putting it all behind a feature flag whilst it's being worked on. Bug: 1071873 Change-Id: I2930f03eeb6dc23a65cf1ddbcaa534e25f27f379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230427Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#776345}
-
Xinghui Lu authored
This CL creates classes for enterprise real time URL lookup. chrome_content_browser_client injects an enterprise or consumer real time URL object based on the type of the user. A feature flag SafeBrowsingRealTimeUrlLookupEnabledForEnterprise is also added in this CL. It is disabled by default. The implementation for StartLookup will be added in a future CL. The enterprise policy for real time URL check will also be added in a future CL. Bug: 1085261 Change-Id: I3741bbcb326c6f17e3bc95b45f1366874e97a98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234794 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#776344}
-
Lukasz Anforowicz authored
This change has been generated by a clang tool developed for the go/miracleptr project. Bug: 1080832 Change-Id: Ie7f428c8ad300db1df95d873668163d0ac719a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231843Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#776343}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/93f2980477a5..1c7e7fdfb4d6 2020-06-08 joselea@microsoft.com Devtools personalization - Movable tabs 2020-06-08 chrche@microsoft.com [A11y] fix DOM breakpoint checkbox not announced by screen reader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1075732,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I95122b00d60e4b719a02a3dcd3546b3dd2b5d19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236379Reviewed-by:
-
Rakib M. Hasan authored
This will allow us to override the ability to cleanup expectations for deleted tests and renamed test names in Android expectations. This CL will also make the test importer clean up Android expectation files during WPT imports. TEST: Test import, crrev.com/c/2227490. That CL removes several tests and renames several tests. The test importer correctly updates the expectation files. Bug: 1050760, 1050754 Change-Id: If63308f56b667bfec55da4f52d46f5b18ab6e129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225466 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#776341}
-
Amy Huang authored
Currently this is causing debug info to be dropped in lldb on mac. Remove the flag on macOS builds until this is fixed. Bug: 1050118 Change-Id: Id6b60827408683a10428a779d7ebb29346e835ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236735 Commit-Queue: Amy Huang <akhuang@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#776340}
-
Jeremy Roman authored
This is more direct and avoids use of the legacy base::Value API, since nothing else is done with this base::Value anyway. Bug: 646113 Change-Id: I335ad2c355734cd8fff45be4996383f39f5bf678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233923 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776339}
-
Joel Hockey authored
Bug: 1091611 Change-Id: Ibbdae7456f83b43cfbba08b4b9962785583cd62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234041Reviewed-by:
François Degros <fdegros@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#776338}
-
tby authored
Currently we check whether a Drive file exists when it's first returned from the Drive API, but we don't check that it exists when we display it. This was mostly not an issue in the past, because because we displayed files immediately after receiving them. This is changing with suggested files. This CL uses the FileTasksNotifier API to check a file is 'available' just before we display it. The call should return OK whenever a file is usable right now, including correct handling of cached files in offline mode. Bug: 1072918 Change-Id: I7c48705f8a4bd81fc28559a60107314ea2f694ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164131Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#776337}
-
Yi Xu authored
In function Canvas2DLayerBridge::GetPaintCanvas(), it could return nullptr if Canvas2DLayerBridge fails to get CanvasResourceProvider. Add null check on canvas in ReplaceExisting2dLayerBridge: if the new Canvas2DLayerBridge fails, ReplaceExisting2dLayerBridge revert the replacement and use the old Canvas2DLayerBridge instead. Bug: 1079282 Change-Id: Ia6de9269afff07a6c4bf011d7447149a07b667cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191124Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#776336}
-
Dan Harrington authored
We were accidentally creating the service to check if it should be enabled. Bug: 1092633 Change-Id: I63013b4b11da3f5ce39f78cd0f3895a50e7af316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236638 Auto-Submit: Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#776335}
-
Joel Hockey authored
Bug: 1087776 Bug: 1091611 Change-Id: I28057a45009a23eea841074dca0477f28e53fc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233100Reviewed-by:
-
Weilun Shi authored
Pretty print the merged xml to make sure it follows our xml style before sending to our server. Bug: b/158215587 Change-Id: I6fd0776bd7a1db2e2f89db26399acdb2b1e36496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236681 Commit-Queue: Weilun Shi <sweilun@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Anastasia Helfinstein authored
Currently, there is no possible way for custom sliders to expose an increment/decrement action to the automation tree. This adds a fallback behavior of using simulated arrow key presses. AX-Relnotes: n/a. Bug: 958251 Change-Id: I2990a420228ee15fa94b58c29b0a586c17b2c639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230936 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#776332}
-
David Munro authored
I'm about 70% sure this is the cause. Still wasn't able to repro the same failure locally, however this is definitely a bug and I was able to trigger some different flakes by running under a debugger when running locally that are now fixed. Recent work on disk resizing introduced additional calls to getDiskInfo, where often they're unrelated to what we're specifically checking for in a given test e.g. one happens in the background when a page is loaded but we only care that the page is loaded, so we don't bother injecting mock data for it. This breaks the assumption the test browser proxy had of each call by the unit under test being paired with a call to inject data by the test, so you end up with orphan promises that never resolve. I fixed this by queuing up every call to getDiskInfo (or resizeDisk which uses the same technique), and then when we inject our test data resolves (or rejects) all promises with the same data, instead of only a single one and losing all the other promises. Test: Browser tests, both under a debugger and not Bug: chromium:1082575 Bug: chromium:1082027 Change-Id: I38aedc43f48e763b9355c27db2c9d6c55df7cdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232459 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#776331}
-
Josh Nohle authored
This is a mitigation put in place to handle 404 errors returned by the CryptAuth server during SyncMetadata requests. A 404 error is returned when the server cannot find an enrolled device with the same Instance ID. Theoretically, this should never occur assuming that 1) we never run a v2 DeviceSync until the device has successfully enrolled using v2 Enrollment and 2) the Instance ID does not rotate. Without this mitigation, the user will unsuccessfully try to sync until the next enrollment, which could be up to 30 days. This fix will be removed when the root cause is uncovered. Bug: 1092113, b/155642672 Change-Id: Ibc766ad21d83d1ace26c5e8c6c45f3eed835da74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234126Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#776330}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit f9d4d27d. Reason for revert: the offending CL is already reverted at http://crrev.com/c/2236946. Original change's description: > Disable flaky tests in StartSurfaceTest > > TBR=hanxi@chromium.org > > Bug: 1092642 > Change-Id: I434447c3a14e45a4ba6b6b1d911e03bd002239de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236737 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776322} TBR=hanxi@chromium.org,wychen@chromium.org Change-Id: Iab2fe6f269cf3bc6839719938495ccaf790a94f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236949Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776329}
-
Andrew Comminos authored
This updates the isInputPending implementation to delegate to LocalFrame::CanAccessEvent for checking whether or not information about the event's dispatch should be accessible. An event is deemed accessible if the origin of its target document may be accessed by the invoker's origin. Bug: 910421 Change-Id: I8903bdef4c38b3c7110afc8d9a22a5ad938ce1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205008Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#776328}
-
Jia Li authored
Adds a function OverrideTargetDecisionForTesting for OptimizationGuideKeyedService. Clients can use this to control the desired prediction outcome in tests. Bug: 1076075 Change-Id: I56ea2c7c1170c0b305b8f0870e22664460fd0806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233300Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Jia Li <jiakl@google.com> Cr-Commit-Position: refs/heads/master@{#776327}
-
Lloyd Pique authored
default.prop is being removed in a future version of Android. It should not be an error if it is not found. BUG=b:158035120 TEST=unittest Change-Id: Ic0e2f11904724706c44bfcbc01460c3b73de71a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233859 Commit-Queue: Lloyd Pique <lpique@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#776326}
-
Bao-Duy Tran authored
Everything at this path was deleted at https://crrev.com/c/2198861. Change-Id: I8eb31f7d614935fc39b68527e73a7f4c72bb32d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230434Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776325}
-
Patrick To authored
When initializing the OpenXR runtime, send the LUID of the GPU adapter the VR headset is plugged into back to the browser process. This change is one part of a series of changes to add multi-GPU support for VR. crrev.com/c/2216166 added the LUID of the GPU that the GPU process is using. A subsequent CL will compare these two LUIDs to determine whether the GPU process needs to be restarted and initialized on the correct GPU to be XR compatible. This change adds a XRDeviceData struct that wraps around a LUID so that the LUID is only enabled on Windows with minimal "#if defined(OS_WIN)" wrappers. A subsequent change specified by crbug.com/1090029 will consolidate all information about an XR device into this XRDeviceData struct. Bug: 792657 Change-Id: If38fd6d0b16c39b36d529d4aaa02c22fe0bcff0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225366 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#776324}
-
David Munro authored
* Warning icon in the low free disk case is yellow instead of black * Warning text is consistently indented per mocks Test: manual Bug: chromium:1090716 Change-Id: I791d5b214308641407283a893c9314c55081b42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231946 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
TBR=hanxi@chromium.org Bug: 1092642 Change-Id: I434447c3a14e45a4ba6b6b1d911e03bd002239de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236737Reviewed-by:
-
Kyle Milka authored
Move share sheet files to chrome/browser/share/... This move leaves two dependencies to be resolved: BottomSheet, tracked in crbug.com/1002277 SendTabToSelf, tracked in crbug.com/1090917. This should be fairly easy to resolve in a follow-up CL. Bug: 1022172 Change-Id: I65e3b983e9d773b4ee78cf65fcac369258ef1413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231542 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#776321}
-
rbpotter authored
This reduces the size of pdf_viewer.js, in preparation for making it a Polymer element that defines the UI of the PDF viewer. There will need to be two versions of this element, one for Print Preview, so moving shared code out of pdf_viewer.js itself will reduce the amount of duplication. Change-Id: I40e2a0565159bc028cab52fffb0eb8de8984da16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233487Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#776320}
-
