GitLab

This plumbs through multi advertising capabilities for the
instance. Instances can register and unregister advertisements.

Now with virtual destructors to prevent memory leaks in the
StructTraits conversion.

BUG=637171,653338
TEST=use nrf connect on remote device and verify that packets
  registered from the instance are visible on the remote device,
  run tests with ASAN/LSAN turned on and verify there are no
  memory errors

Review-Url: https://codereview.chromium.org/2394683007
Cr-Commit-Position: refs/heads/master@{#423672}

FrameView and PaintLayerScrollableArea may perform more work than
necessary if hide_scrollbars is true (e.g. trigger unnecessary
layouts), because they think that scrollbar existence has changed
even if it didn't.

For FrameView, we can avoid this by enforcing hide_scrollbars
in computeScrollbarExistence instead. For PLSA, we check for
hide_scrollbars in updateAfterLayout to determine if the
scrollbar existence will change.

Also fixes another potential bug in PLSA, which may incorrectly
assume existence of scrollbars if hide_scrollbars is true.

BUG=652317,639806
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2394163002
Cr-Commit-Position: refs/heads/master@{#423671}

BUG=563793
R=pdr@chromium.org

Review-Url: https://codereview.chromium.org/2391693004
Cr-Commit-Position: refs/heads/master@{#423670}

TBR=zmo@chromium.org
BUG=angleproject:1492
BUG=chromium:634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2397213002
Cr-Commit-Position: refs/heads/master@{#423669}

BUG=653668
TEST=built the test

Review-Url: https://codereview.chromium.org/2394223003
Cr-Commit-Position: refs/heads/master@{#423668}

This CL implements variations querying and control for the number of
days after an app banner is dismissed or ignored that the banner will
not be shown for that site.

BUG=653339

Review-Url: https://codereview.chromium.org/2397043002
Cr-Commit-Position: refs/heads/master@{#423667}

ScheduleNextFrame() has several entry points. Ensure capture
timer is not set with no valid callback.

BUG=

Review-Url: https://codereview.chromium.org/2398993004
Cr-Commit-Position: refs/heads/master@{#423666}

If the desktop browser is opened to a banner-eligible PWA, and then
"Add to homescreen" is run from the Devtools "Application" tab, a DCHECK
failure in HostContentSettingsMap is triggered. The cause of this is a
null validated_url; this variable is usually set in
AppBannerManager::DidFinishLoad, but this will not run since banners are
disabled by default on desktop and triggering add to homescreen manually
creates the AppBannerManager after DidFinishLoad is run.

This CL fixes the issue by manually setting the validated_url when the
banner pipeline begins if it is null. This bug should only manifest
itself in this exact instance; enabling banners via
chrome://flags#enable-add-to-shelf ensures that the AppBannerManager is
created.

BUG=None
TEST=Disable "Add to shelf" in chrome://flags in a desktop Chrome
instance. Navigate to a banner-eligible site, open Devtools, and trigger
"Add to homescreen" from the "Application" tab. No crash should happen
and the add to shelf banner should be seen.

Review-Url: https://codereview.chromium.org/2392313003
Cr-Commit-Position: refs/heads/master@{#423665}

The external protocol handler dialog currently presents users with
a very large amount of jargon-filled text. This CL simplifies the dialog
down to just a title containing the app name and the existing checkbox.

On Windows 7 and earlier, the registry is queried for an app path,
which is displayed in the dialog. This CL modifies the query to
retrieve a program name from the app path, falling back to just
the executable name if the retrieval doesn't succeed.

A new histogram to log the number of times users check the
checkbox in the dialog is also added.

BUG=601725

Review-Url: https://codereview.chromium.org/2076253002
Cr-Commit-Position: refs/heads/master@{#423664}

This reverts commit bdc8e1e4.
This is a top crasher that's blocking release.

BUG=653403
TBR=horo@chromium.org

Review-Url: https://codereview.chromium.org/2399903003
Cr-Commit-Position: refs/heads/master@{#423663}

This shouldn't result in any change in behavior. The purpose of this
CL is to make it clearer what arguments may be used by
copy-existing-baselines-internal and which aren't.

Review-Url: https://codereview.chromium.org/2395633002
Cr-Commit-Position: refs/heads/master@{#423662}

This reverts commit 64f8e6ee.

BUG=563793
R=ikilpatrick@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2398623003
Cr-Commit-Position: refs/heads/master@{#423661}

This CL contains an abstract interface for SyncManager and a private
class skeleton SyncManagerImpl with the method bodies stubbed out.

R=steimel@chromium.org,scf@chromium.org
CC=wez@chromium.org
BUG=650469

Review-Url: https://codereview.chromium.org/2377873002
Cr-Commit-Position: refs/heads/master@{#423660}

Review-Url: https://codereview.chromium.org/2400683002
Cr-Commit-Position: refs/heads/master@{#423659}

The real cost in validating signed modules is validating individual certificates. Since many certificates are provided en masse by catalogs, this counts catalogs as providing a single certificate.

BUG=617176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2384413004
Cr-Commit-Position: refs/heads/master@{#423658}

The viewport rect is always at 0,0 and the clip rect is always the
viewport rect now that WebView does external viewport/clip things via
embedding a SurfaceDrawQuad into another surface. So express this in
the code.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2399713003
Cr-Commit-Position: refs/heads/master@{#423657}

As some applications are providing multiple configurations for
compatability with previous versions, only check that at least
one capability is provided on success, as that is likely to fail
once Chrome starts following the EME spec strictly. This also
avoids the problem of counting both success and failure for the
same configuration (if multiple configs were provided).

BUG=616233
TEST=encrypted media layout tests pass

Review-Url: https://codereview.chromium.org/2397543002
Cr-Commit-Position: refs/heads/master@{#423656}

BUG=652467

Review-Url: https://codereview.chromium.org/2399113002
Cr-Commit-Position: refs/heads/master@{#423655}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6723c79f0772..a2738b13731a

$ git log 6723c79f0..a2738b137 --date=short --no-merges --format='%ad %ae %s'
2016-10-06 dtu [code health] Move request_handler.py and xsrf.py into common/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2387113007
Cr-Commit-Position: refs/heads/master@{#423654}

BUG=653289
TBR=grt

Review-Url: https://codereview.chromium.org/2394163003
Cr-Commit-Position: refs/heads/master@{#423653}

WebappInfo#create() returns null if either the id or the uri are null

BUG=None

Review-Url: https://codereview.chromium.org/2386383002
Cr-Commit-Position: refs/heads/master@{#423652}

This CL lands server change 135025499 by rogeeff.

BUG=488484

Review-Url: https://codereview.chromium.org/2400463002
Cr-Commit-Position: refs/heads/master@{#423651}

SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there except
cc unittests. So make them stop and remove the getter.

This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.

Also adds DCHECKs that the viewport rect is at 0,0 and the clip rect
given to DirectRenderer matches the viewport rect since that is what
Display does now. Followups can remove code to not need DCHECKs.

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2392183003
Cr-Commit-Position: refs/heads/master@{#423650}

Response start can be null or non-null in
BidirectionalStream.Callback#onStreamReady() step.

TBR=mgersh@chromium.org

BUG=653654

Review-Url: https://codereview.chromium.org/2400803002
Cr-Commit-Position: refs/heads/master@{#423649}

With this change, we have:
- A native API Javascript module, hiding details of the Native API.
- A scene helper class, to manage adding and removing elements and
  animations.
- The remaining UI Javascript.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2392683002
Cr-Commit-Position: refs/heads/master@{#423648}

R=dpranke@chromium.org

BUG=650482

Review-Url: https://codereview.chromium.org/2398633004
Cr-Commit-Position: refs/heads/master@{#423647}

Use Unicode instead of punycode for 'host' part of URL
in Format{Origin,URL}ForSecurityDisplay. This would only change
the way IDN(internationalized domain name) is displayed.

To be very conservative, continue to use punycode if there's any RTL
characters in the domain name. See the bug for more details on this issue.

Besides, change IDNToUnicode() to accept StringPiece instead of
|const string&|.

BUG=650760
TEST=components_unittests --gtest_filter=Format*Security*

Review-Url: https://codereview.chromium.org/2375803002
Cr-Commit-Position: refs/heads/master@{#423646}

DTLS 1.2 shipped some time ago and the control field
trials have expired. This should no longer be needed.

BUG=

Review-Url: https://codereview.chromium.org/2385623003
Cr-Commit-Position: refs/heads/master@{#423645}

Revert of 📰 Spacing and fixes for the sign in promo (patchset #2 id:20001 of https://codereview.chromium.org/2396863003/ )

Reason for revert:
Reverting due to test failures in chrome_public_test_apk

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36518

failures:
org.chromium.chrome.browser.widget.OverviewListLayoutTest#testCloseAllIncognito
org.chromium.chrome.browser.widget.OverviewListLayoutTest#testModelSwitcherVisibility

Original issue's description:
> [NTP Client] Spacing and fixes for the sign in promo
>
> - Fixes an exception when only the sign in promo is present on the NTP
> and we attempt to make it peek
>
> - Adds 20dp space between the promo and the status card if present
>
> - Fixes to the bottom space calculation related to the dismissal of
> sibling elements.
>
> Preview: https://goo.gl/photos/94hhXK5rygGamFqt7
>
> BUG=649670,652578
>
> Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8
> Cr-Commit-Position: refs/heads/master@{#423525}

TBR=bauerb@chromium.org,dgn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=649670,652578

Review-Url: https://codereview.chromium.org/2399983002
Cr-Commit-Position: refs/heads/master@{#423644}

https://chromium.googlesource.com/angle/angle.git/+log/d08f3b3..873d00f

BUG=chromium:653274,chromium:651493,chromium:653276,chromium:593024,chromium:634525

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2399933002
Cr-Commit-Position: refs/heads/master@{#423643}

Update laser icon color and automatically close the palette when enabling the magnifier or laser.

BUG=645312

Review-Url: https://codereview.chromium.org/2368713002
Cr-Commit-Position: refs/heads/master@{#423642}

We used 128 bit uuid for service uuid before. However this
caused buffer overflow problem when encounter with multiple
16 bit uuid for this field as the length of advertising data
would exceed the limit.

We mitigated that by forcing the service uuid to be 16 bit.
But this break the device that decide to advertised custom
128 bit uuids.

This CL properly fixes the above problems by send 128 bit
uuid to Android and let Android side deal with the overflow
problem.

BUG=653310,b:28670943
TEST=Android side can see 128 bit service uuid

Review-Url: https://codereview.chromium.org/2376873002
Cr-Commit-Position: refs/heads/master@{#423641}

https://pdfium.googlesource.com/pdfium.git/+log/f7ca7302bed8..ca03f7a1c654

$ git log f7ca7302b..ca03f7a1c --date=short --no-merges --format='%ad %ae %s'
2016-10-06 dsinclair Fixup MSan embeddertests

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2394283002
Cr-Commit-Position: refs/heads/master@{#423640}

When determining the end position for a selection ending on a
continuation's margin, we would incorrectly de-select all content
below the continuation's containing block.

This affects sites like hackernews, such as selecting text in:
https://news.ycombinator.com/item?id=347261

This patch is a buy-one-get-one-free with two fixes in one patch (both
fixes are required):
1) Continuations should be tested immediately because ancestors of a
continuation will not check them. In LayoutInline::positionForPoint, we
need to check our continuations first, before an early return, because
the containing block will not return to test the continuations.

2) Continuations do not need an adjustment for their position to
"translate the coords from the pre-anonymous block to the post-anonymous
block." This code was not tested and seems wrong because the point is
already in the correct coordinate space.

Here's an example of a layout tree dump (included as a new test as well):
LayoutView
  LayoutBlockFlow
    LayoutBlockFlow (anonymous)
      LayoutInline continuation=(next block flow) FONT
        LayoutText #text "AAAAAAAAAA"
      LayoutBlockFlow (anonymous) continuation=(next sibling block flow)
        LayoutBlockFlow P
          LayoutText #text "BBBBBBBBBB"
        LayoutBlockFlow P
          LayoutText #text "CCCCCCCCCC"
      LayoutBlockFlow (anonymous)
        LayoutInline FONT
This patch is solving a bug when selecting from the beginning of AA...AA
to the margin between BB...BB and CC...CC. Before this patch, BB...BB
would not be selected.

BUG=468497

Review-Url: https://codereview.chromium.org/2398583002
Cr-Commit-Position: refs/heads/master@{#423639}

BUG=649760

Review-Url: https://codereview.chromium.org/2397003002
Cr-Commit-Position: refs/heads/master@{#423638}

This reverts commit c42c0ddd.

Reason:
The PolicyTest.ForceSafeSearch test is failing on Windows bots.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/53375

TBR=ljusten@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590478

Review URL: https://codereview.chromium.org/2401733002 .

Cr-Commit-Position: refs/heads/master@{#423637}

Refactor goals (in descending order):
1. Consolidate the various places throughout startup where onboarding and other special-case tabs are added.
2. Reduce the massive number of branches, spaghetti calls, and seemingly-redundant checks into a manageable, linear flow.
3. Offload all policy logic (e.g., "Should we show the Welcome page?") for FRE to the more-appropriate first_run directory.
4. Where possible, consolidate code into testable units.

BUG=618454, 248883, 517248

Review-Url: https://codereview.chromium.org/2164033002
Cr-Commit-Position: refs/heads/master@{#423636}

BUG=650925
TBR=sadrul

Review-Url: https://codereview.chromium.org/2394483006
Cr-Commit-Position: refs/heads/master@{#423635}

BUG=652250

Review-Url: https://codereview.chromium.org/2392423002
Cr-Commit-Position: refs/heads/master@{#423634}

PathUtils used to store its own application context in a static
variable, assuming that the one it was initialized with was the
application context. This can lead to memory leak bugs and with
ContextUtils#getApplicationContext client code does not have to
store its own reference to the application context.

BUG=644377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2333713003
Cr-Commit-Position: refs/heads/master@{#423633}