- 24 Jul, 2019 40 commits
-
-
Will Cassella authored
VR mode does not support keyboard accessories, so they should be disallowed from appearing while in VR. This CL adds a check to do that. Bug: 983649 Change-Id: I3fa80224214654060c28ef000bfe5b30ccf82212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707428Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#680526}
-
Anupam Snigdha authored
There were way too many nested if statements which was really confusing and also harder to debug. This change just simplifies it by separating the conditions and have fewer nested ifs. Change-Id: I909c3dcdeab6366140cafe5250e016121e8c8cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716162Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#680525}
-
Xiaohui Chen authored
Bug: None Test: unittests Change-Id: Ia0dd24b72d0ad3d1eebcdd33b1124c97e4ee4365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716170 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680524}
-
Nicolas Ouellet-payeur authored
This CL deleted the annotation, but didn't update annotations.xml due to a broken presubmit check: https://chromium-review.googlesource.com/c/chromium/src/+/1715105 TBR=rhalavati@chromium.org Bug: 949382 Change-Id: I14d17d5323f1199a61ce43f80d339bfa9b695125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716034Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#680523}
-
Weiliang Chen authored
For each platform, we only use one overlay candidate type. Use build flags to manage that. This also helps unify different platform's ProcessForOverlay API. R=rjkroege Bug: 963597 Change-Id: Icf0de8b30928cb4e7c23a3573eb46591191fb804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664476 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#680522}
-
Shimi Zhang authored
WebContents#postMessageToFrame is only used to post message to main frame, all the call sites passed the |frameName| = null. The internal implementation of native MessagePortProvider::PostMessageToFrame is not for all frames either. Renamed postMessageToFrame to postMessageToMainFrame to make that explicit and get rid of the |frameName| parameter. Bug: None. Change-Id: Ib31bf02ad131bc91d10b8936c51e54a03fdf9ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711053Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#680521}
-
Felicia Lim authored
Apply patch from https://git.xiph.org/?p=opus.git;a=commit;h=812ae3fb5c589aaafe761b8ebf86bcbbb8f0ed76 Bug: 946351 Change-Id: I55f2abb3950ff86780a68ef7ee8d28e142c0fd23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713325Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#680520}
-
Kyle Milka authored
Bug: 984752 Change-Id: Ibaadf54deaad6078beef2812bfcb84883c82aeb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713296 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#680519}
-
Tim van der Lippe authored
The original behavior of build_debug_applications.py was to traverse all files recursively in the front_end folder and symlink each individual file to the version in third_party/blink/renderer/devtools/front_end. However, this requires rebuilding of Chrome when new files are added to the application. After this CL, the developer experience is more What-You-See-Is-What-You-Get. This CL is also in preparation to remove the logic in C++-land to remove the need for a separate debug folder. A follow-up CL will change the behavior of `debug_devtools` to symlink directly into out/[NAME]/resources/inspector, rather than an explicit sub-directory. As a nice side-effect of this change, we are no longer symlinking the debug folder for every version of the application. Previously, it would iterate through all `application_names` and symlink the full debug folder. This is time-consuming and did not provide any actual benefit. Since we now symlink directly to the local version, we no longer need to build the HTML files directly. Bug: 986365 Change-Id: I7e54ac3af57e0a3941b88a46b71b3ddacd5664f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713344Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> Cr-Commit-Position: refs/heads/master@{#680518}
-
Miguel Casas-Sanchez authored
This CL adds a TRACE to measure the time it takes between having an encoded chunk consumed by the VD and the associated VideoFrame being produced, at the level of the MojoVideoDecoder Client (renderer process). Bug: 950183 Change-Id: Ieaa86ee3210fa5ad84d30db4511bf67f4713671e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715231Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#680517}
-
Aleks Totic authored
Update failing tests Remove FlagExpectations/enable-blink-features=LayoutNG Change-Id: I3f096d78a51c22e7a77abd971b9fadfca81179f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714485 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#680516}
-
Yuwei Huang authored
gTalk used to distinguish between gmail and non-gmail accounts, so we hae a host_owner field to track the XMPP JID and a host_owner_email field to track the user's actual email address in the host config file. This logic is no longer needed after the signaling migration since FTL uses the user's actual email address for message routing even for non- gmail accounts. This CL simplifies the host code to only keep track of the host owner's actual email. In the future we should also update the website to always write the user's email address to host_owner and stop writing host_owner_email. Bug: 983282 Change-Id: Ia70f51a9340c01771c84b37fbe0c312bec9a4141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716093 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#680515}
-
Wez authored
Bug: 986544 Change-Id: I2ae6d3198a5ec362aa60aa4e76eba86df49f21b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715762 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680514}
-
Natalie Chouinard authored
These calls to addPreferencesFromResource were moved into onCreatePreferences in https://crrev.com/c/1707429 and https://crrev.com/c/1706540. Moving them back to their original methods, respectively, because the delay between adding and removing preferences was causing animation jank. onCreatePreferences is abstract in the base class, so it is still overridden here with a comment only. Bug: 985734 Change-Id: I53110f199b8fe39ad255273059cd4aee0a7ac83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710806Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#680513}
-
Shakti Sahu authored
Change-Id: I262b617cb35221db0f7dbae73b03502bf6257341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676946 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#680512}
-
Jacob DeWitt authored
This code was previously in XRSession and would call many methods on an XRInputSource object. Now, they are methods on the XRInputSource class. XRSession still needs pass-through methods such as OnSelect since the spec defines those event handlers on XRSession. Bug: 974912 Change-Id: Iacd407828faa7fc26dc50db7dc1c4b03bbf10488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716103 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Auto-Submit: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#680511}
-
Sebastien Marchand authored
Bug: 915714 Change-Id: I5fdd7b9a10bd2d8c9ada4f01f12a6a54d21040a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709072Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#680510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1fee49ba988e..b88be03bab49 git log 1fee49ba988e..b88be03bab49 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 yueherngl@google.com jacuzzi: add signing for factory shim Created with: gclient setdep -r src/third_party/chromite@b88be03bab49 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I722c2fdafa7cb6fd954797bb09064dcea6b4cf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716986Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680509}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/212a3bf6..c8b0c582 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I610109bbad1f68799b615b64b18b4cabeb86672f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715892Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680508}
-
Toni Barzic authored
Summary of changes: * Added methods for keeping track of currently selected action, and for moving the selection to SearchResultActionsView * Added SearchResultActionsViewDelegate:: OnSearchResultActionsUnSelected so the result view can handle the case where actions are un selected - primarily, it sends out a a11y notification that the default action (that activates the search result) is selected again * Renamed SearchResultBaseView::SetBackgroundHighlighted to SetSelected, and added logic for setting initial selected result action, or clearing action selection. (the latter is protected by SearchBoxSelectionEnabled feature). * Added SearchResultBaseView::SelectNextResultAction - used by result selection controller to move the action selection if needed. * Note: The SearchResultBaseView implementations are expected to call newly added set_actions_view to register their result actions - otherwise this method will be no-op * ResultSelectionController::ResetSelection avoids clearing and setting selection again if the view that should be selected is already selected BUG=986382 Change-Id: I9932e9c44abe546b71fbcbf1488c9ac076ae5c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713223 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: -
Evan Stade authored
Use BrowserListObserver::OnBrowserAdded instead. Bug: 268984 Change-Id: Ib006156034fb7b3b52d8c0ecad7f0189fe91e08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715097Reviewed-by:
-
Eric Seckler authored
Cloned from crrev.com/c/1715343 with a manual modification to track_event_thread_local_event_sink.cc. Original change description: -- Roll src/third_party/perfetto a3928b19e384..361d65fd752e (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/a3928b19e384..361d65fd752e git log a3928b19e384..361d65fd752e --date=short --no-merges --format='%ad %ae %s' 2019-07-24 treehugger-gerrit@google.com Merge "Add Perfetto protos for Chrome log messages" Created with: gclient setdep -r src/third_party/perfetto@361d65fd752e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Icd359c8c27f7c9443aa57d0d672ff4e95834001f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715069Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#680505}
-
Sam Goto authored
Bug: 982370 Change-Id: I2701189adbba30effe9ecc887fb2a488f6e9f144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715399Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680504}
-
Evan Stade authored
This CL also splits the IncognitoObserver class into separate implementations for Android and desktop. Bug: 268984 Change-Id: Ic59988fe8d08a5217400dffd78eff3d7838f7630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715533Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#680503}
-
Peter E Conn authored
Bug: 984249 Change-Id: I3363faf7b9c4fb6aa71de1557f0481550a269ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715275 Auto-Submit: Peter Conn <peconn@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680502}
-
Mustafa Emre Acer authored
Currently, the values for features with ORIGIN_LIST_VALUE type are read and set directly from the command line. This only works if the user clicks the "Restart" button on the chrome://flags page and only on desktop, as desktop codepath can pass modified command line arguments to the restarted browser instance. It doesn't work if the user manually closes the browser, or at all on Android. This CL persists ORIGIN_LIST_VALUE flags in a separate pref instead, so that they can be read on browser start. This works on Android, or when the user manually restarts the browser on desktop. This CL also merges values entered in chrome://flags and values passed directly via command line so that modifications to chrome://flags don't lose the command line values. Finally, it fixes the test flakes by modifying the command line switches only on browser starts. Bug: 972121, 937736 Change-Id: I7468cb1037e7a5050130302c5c796ea163ccb6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698989Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f874b8cc. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6a6b173b "Add type option to showToast helper" a148378d "KV Storage: rename storage export to default" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0979a98df1c982ef4420f84fd472bbffe66e4f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715737Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680500}
-
Kamila authored
Updated histograms that were previously set to expire in M77-78 to expire instead in M90, as they are needed for monitoring permission health. 975429, 975527, 975746 Bug: 986799, 969940, 969942, 969995, 974946, 975003, 975409, 975415, Change-Id: Iaf8651c819b7ddea6c95fc7b9d57f445b255ca1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713554 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#680499}
-
Justin DeWitt authored
Bug: 984787 Change-Id: Id4210690f5a09e91af106df70c58965bbaee8898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709702 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Auto-Submit: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#680498}
-
ssid authored
The traces collected are too small. To iterate faster make the buffer size configurable. To avoid collecting lot of threads, add an option to trace only browser process. Also increases the upload limit over network. This will depend on the buffer size set. Change-Id: I82551f23f48e4b85fc8e451a24a2ad8904c9cbef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715103 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#680497}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cfefa0aef329..f640b87f1c64 git log cfefa0aef329..f640b87f1c64 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 terelius@webrtc.org Populate y-axis categorical labels in event log visualizer. 2019-07-24 chxg@google.com Reland "Add plumbing of RtpPacketInfos to each AudioFrame as input for SourceTracker." 2019-07-24 mbonadei@webrtc.org Add usage message to event_log_visualizer. 2019-07-24 sprang@webrtc.org Move RtpPacketSender and merge it with RtpPacketPacer. 2019-07-24 eshr@google.com Add congestion window values to GoogCcPrinter 2019-07-24 sprang@webrtc.org Make WebRTC-Pacer-LegacyPacketReferencing default off 2019-07-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5e244999..fdd7489f (680219:680383) 2019-07-24 sprang@webrtc.org Reset packet history on ssrc/seqno reset 2019-07-24 sprang@webrtc.org Fix issue with TransmissionOffset using new pacer code path 2019-07-24 terelius@webrtc.org Add y-axis tick labels. 2019-07-24 srte@webrtc.org Allow AbsSendTime extension to be used for audio streams. 2019-07-24 srte@webrtc.org Adds remote estimate RTCP packet. 2019-07-24 chxg@google.com Add performance optimization for empty `RtpPacketInfos`. 2019-07-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 30f282ec..5e244999 (680117:680219) 2019-07-23 yvesg@webrtc.org [Unit test] Add check to prevent segfault on empty vector. 2019-07-23 sprang@webrtc.org Remove legacy/unused RtpPacketHistory::StorageMode::kStore 2019-07-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4a2e9a72..30f282ec (680003:680117) 2019-07-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 54f75614..4a2e9a72 (679885:680003) 2019-07-23 mellem@webrtc.org Only include payload in bytes sent/received. Created with: gclient setdep -r src/third_party/webrtc@f640b87f1c64 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:982260,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: Ia0506fa71d9e730c27c6cb0f5ecf8fd7086a30f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716985Reviewed-by:
-
Brian White authored
Adds expires_after attribute for 345 histograms that do not show any access in the past 120 days. Change-Id: If6a91f200567228dffc6694bbaf8e2423d116b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716032Reviewed-by:
-
Collin Baker authored
This removes placeholder colors and opacities, instead allowing the user to configure them. ToolbarButton configures its InstallableInkDrop to match its classic InkDrops as closely as possible. Bug: 933384 Change-Id: I3d328e0218793589f829a9187359c4ed21d780b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713865 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#680494}
-
Mustafa Emre Acer authored
Change-Id: I11b3c79308979fbd92aa303d64750d5f9af59e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715535Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#680493}
-
Shakti Sahu authored
Bug: 987052 Change-Id: Ibd4178eac4fd22d53f6bf80607fbbdecdd94378c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715728Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680492}
-
Simeon Anfinrud authored
CMA was made compatible with Android M and below in https://chromium-review.googlesource.com/c/chromium/src/+/1640788. Bug: Internal b/117838318 (Original reason for disabling) Bug: Internal b/138228866 (Motivation to restore) Test: Fling video to Android 23 emulator Change-Id: Iecd545e7e559477fe17ee29db6726079f146b0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715578 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#680491}
-
Natalie Chouinard authored
Migrate the Main, Sign In and Sync Preference settings pages from the deprecated Framework preferences to the Support Library. These are the last PreferenceFragments to migrate, so we recoup some of the binary size and method count regression here. Note: I migrated SyncCustomizationFragment and its tests before realizing they're now unused (https://crbug.com/978908). However, SyncCustomizationFragmentTest now fail on release builds (including try-bots) due to proguard shrinking, so I've @Ignored them all for now, rather than add unnecessary -keep flags until crbug.com/890847 is done. Bug: 968592, 972581 Change-Id: Ie928f54eae84bd3d56428271463ac55f627d9f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708895Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#680490}
-
Jun Cai authored
This CL adds a "Continue" button based on the following UI mocks: https://github.com/samuelgoto/sms-receiver#opt-in-ux This CL also updates SmsService to allow at most one pending SMS request. Bug: 983323, 985438 Change-Id: I34b6f3568cf4332030bed56ad1995e28f5e21376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703928Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Instead of creating a TestingProfile with custom factories, create fake for the required services and pass them directly to the code that is tested. This makes the tests simpler (as they do not have to create a full TestingProfile but only need to create the necessary services). It required adding an overload of sync_ui_util::GetStatusLabels() that received the services instead of accessing them via their factories. Bug: 984487 Change-Id: Ia596fb46b9915e240bfce2ef2e4ee888c99e16c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715297 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#680488}
-
googlechrome://...`Mike West authored
Bug: 831761 Change-Id: Ibebe1585d06f16a94bc7bdb47c952e3cbefd981c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705792Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#680487}
-
