- 09 Dec, 2019 40 commits
-
-
Aaron Tagliaboschi authored
Mobile is a boolean client hint that informs whether a "mobile" or "desktop" user experience should be supplied. Relevant changes to the spec can be found here: https://github.com/WICG/ua-client-hints/pull/8 That was manually added via this commit: https://github.com/WICG/ua-client-hints/commit/db6fab2569b78666c40e84e4d0458dbdf59d336b Bug: 928669 Change-Id: Ia983cfa516c28b6a747b270abcc44e71ed39e1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829793 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#723037}
-
Thomas Lukaszewicz authored
Fixed the issue with a stuck inkdrop on drag of a download item due to incorrect handling of the button's OnMouseDragged() and OnMouseCaptureLost() handlers. Prior to this change DownloadItemView attempted to intervene in the button's inkdrop display logic. Removed inheritance from InkDropHost for DownloadItemView as it is unnecessary due to the use of a transparent button overlay for the button effects. Bug: 1026384 Change-Id: I2436fab35f5334ca0bd947189c831f932ba1f0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955657 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#723036}
-
Aaron Tagliaboschi authored
A smidge of refactoring for the user agent string code as well. (Relanding crrev.com/c/1951446 after fixing MacOSX cpuinfo) Bug: 1001125 Change-Id: I237011f3d85bde2cfe8bcf40731b442df27fe481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955958Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#723035}
-
Daniel Murphy authored
TBR: rockot@chromium.org Bug: 1027737 Change-Id: Idcd669f2f91a542ced570beda300aad715055868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956066Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#723034}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/62836903bcc7..63be47c488aa git log 62836903bcc7..63be47c488aa --date=short --first-parent --format='%ad %ae %s' 2019-12-09 bsalomon@google.com Add testCompile function to SkRuntimeColorFilterFactory for Chrome test 2019-12-09 fmalita@chromium.org [skottie] Explicit seek(0) in tools 2019-12-09 bsalomon@google.com Support mirror-repeat in GrTextureDomain 2019-12-09 mtklein@google.com lift Wno-class-memaccess 2019-12-09 mtklein@google.com mark SkMD5->SkUUID copy as sane Created with: gclient setdep -r src/third_party/skia@63be47c488aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Ib8b8fb217755aaa50a69a27b3edb6ea2c73a121b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957403Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723033}
-
Tim van der Lippe authored
Necessary for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1953583 Follow-up on https://chromium-review.googlesource.com/c/chromium/src/+/1958116 TBR=mathias@chromium.org Bug: 1006759 Change-Id: Id6ae5e47b836443ccb7bdf83bc789cca786484ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953742Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#723032}
-
Asanka Herath authored
Bug: None Change-Id: Id6e91bdedc8015ec2b0fb451f53ba2ca30ba7d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957210Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#723031}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e9bf0dc..18d58583 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icb3a89e0588c0e572a8b23eb736ddbdd7133747f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956054Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723030}
-
Koji Ishii authored
This patch fixes inline offset in hit-testing when |FragmentItem| is enabled. |NGPaintFragment| has two kinds of offsets; one to the parent, another to the containing block. |FragmentItem| reduces this only to the containing block, the same as the legacy |InlineBox|. The hit-testing in |NGBoxFragmentPainter| uses the offsets to the parent, and that part needs to change to support |FragmentItem|. Hit-testing functions in |NGBoxFragmentPainter| already carry 3 arguments that do not change. Instead of adding the 4th argument that does not change, this patch adds |HitTestContext| and pass it by reference. 7 failures, ~180 passes. Bug: 982194 Change-Id: I840b0b3c63b2b1b58f10c8bf493e473d988ae0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954980 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#723029}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3cc87023. With Chromium commits locally applied on WPT: a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." eb00b4d6 "LazyLoad: move invisible-image.html test to WPT" c78acd51 "Expose support for (X)HTML in requiredExtensions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I61ee0cb824fe2b658557dd8118fb413c641529d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956055Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723028}
-
Ryan Hamilton authored
and to explicilty initialize the cache instead of calling InitializeBackend with the cache directory (thus removing a layer of indirection for test expectations). Change-Id: Icd528007dbd7d26d2eed119272d7acbf080b774f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958566Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#723027}
-
Chase Phillips authored
This CL adds scope manifest override tests. It also extends upgrade test cases to cover manifest data and scope data changes, which allows us to verify that scope changes result in differing cached manifests. While here, this changes override handling so relative paths are allowed. Bug: 999001 Change-Id: Ia3efef020432708c7546df88bcd12b41f9d0ccf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957385 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#723026}
-
Tricia Crichton authored
Pull latest atoms changes from SeleniumHQ. Also updated instructions for building atoms and the patch.diff. Modified the javascript conversion to cc code to enable use of char[] and string. This change has a pending PR at selenium HQ. Modified the isElementClickable source code prevent attribute renaming bazel conversion. Bug: chromedriver:1049 Change-Id: I3df9ef0b69da849e054c938a697753b72c8187a7 Fixed: chromedriver:1049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888531 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#723025}
-
Takumi Fujimoto authored
Enable the feature and remove some CastRemotingConnector tests that are deprecated. Bug: 956609 Change-Id: I4e5931ff0b2b8b1c455c53d9f1e2e865004d3095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929398Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#723024}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: Ib6ac3fcbe446c047bd846a0c775210fda7763b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953626Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#723023}
-
Lukasz Anforowicz authored
This CL adds an automated regression test that verifies that an NTP-replacement extension: manifest.json: "chrome_url_overrides": { "newtab": "ext_ntp.html" }, ext_ntp.html: <script src='ext_ntp.js'></script> ext_ntp.js: window.location = 'https://example.com' will result in the new tab focusing its content (rather than the location bar / omnibox). Bug: 1029161 Change-Id: I08c188535ac85759a2380581c01a332bff329a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946456 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#723022}
-
Azeem Arshad authored
This CL removes unnecessary navigation tab stops from the network-summary-item element. The Additional details in the item were added as an aria description for details button. Network name details were removed from the aria label since this will be announced as part of the description. Bug: 1025414 Change-Id: I00e4f94a28630367003ec6545baadc7cbc0603f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935413Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#723021}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/254d7a04716e..e87c0ece2871 Created with: gclient setdep -r src-internal@e87c0ece2871 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Id568c6f6d4bbe6c51732cd421ec486d1bda80201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957401Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723020}
-
zhaoyangli authored
Autofill automation egtest reads its "recipe" from JSON file, which is a blocking operation. This used to work when I/O was incorrectly allowed at setting up FakeServer, until a recent fix of FakeServer (crrev/c/1883630). This change allows blocking operations using base::ScopedAllowBlockingForTesting and should fix crashes at Autofill automation eg1 test. EG2 test was not affected as FakeServer is set on main thread. Although EG1 is being deprecated, this fix is still desirable as we can better observe EG2 stability issues of the framework with both EG1 and EG2 tests running on bots. Bug: 1024687 Change-Id: I3ca2197d203b84cc7067099d39532d17363b43e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956156Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#723019}
-
Manu Cornet authored
This is a pure renaming change with no expected visible effect. Change-Id: I93c5e546cc194a0be3251ddc91acf0cb1e283744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954799Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#723018}
-
Daniel Vogelheim authored
This follows the proposal at https://github.com/w3c/webappsec-trusted-types/pull/236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924523 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#723017}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If9f2530d7b7a629e4344b3b67d2e86b36fc7675b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957402Reviewed-by:
-
Koji Ishii authored
This was regressed but then fixed before the regression was reported. This patch adds a test to avoid future regressions. Bug: 1022641 Change-Id: I8bcda25fdcfcb2ed87d517a06c0e46699d4bb4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956975Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ff61c18f1bbc..1afa2b8cc57b git log ff61c18f1bbc..1afa2b8cc57b --date=short --first-parent --format='%ad %ae %s' 2019-12-09 johnkslang@users.noreply.github.com Merge pull request #2019 from KhronosGroup/fix-2014-dont-and-versions-extensions Created with: gclient setdep -r src/third_party/glslang/src@1afa2b8cc57b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliot@google.com Change-Id: I51447892dbe12ad4e0f2540b8e3e1d79ab1b287e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958334Reviewed-by:
-
Charlie Hu authored
Add Serialization and Parsing of DocumentPolicy with structured header Bug: 993790 Change-Id: Iebe56309ed46cf1e9914d80fbfdb4445509df008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846234 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#723013}
-
Christian Biesinger authored
This is a new feature in GDB 9.1 (not released yet) which provides major speedups when attaching to Chrome. This patch will make use of it if you build GDB from their Git repository or once GDB 9.1 is released (should be within the next few weeks, hopefully). Change-Id: Ic335b82e54dc409eceaaa600488bcd22b58288c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958446 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#723012}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=tbansal@chromium.org Bug: 1023677 Change-Id: I18c2e642f99bfa931d99242e5ec8c12090629f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957542 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#723011}
-
Joe Downing authored
The CRD Chrome app has been deprecated for a few months now and been replaced with a website. Since the Chrome app is no longer being used by anybody, it should not be allowed access to anything in Chrome (like sockets or the It2Me/Me2Me NMH). Change-Id: I4947caa9f17d63f70b1397f6f289af803743d214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958159Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#723010}
-
Aaron Gable authored
Most of this builder's configuration was removed in https://crbug.com/731972, but its buildbucket config remained. Since then, it has conducted a grand total of 8 builds, none of which have succeeded. Time to remove it entirely. Fixed: 1026223 Bug: 731972 Change-Id: I4ae241b86d794d2e2cdb194b47c085c9fed58353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929524 Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#723009}
-
Mitsuru Oshima authored
Bug: 1031927 Change-Id: I5c2c12a8b444cf1327d4438512e6c159ef9ad23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955073Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#723008}
-
Maks Orlovich authored
Previously it's been represented as a URL, which was misleading as it does not have this sort of precision guaranteed, and is often empty. Further, its computation and usage has special cases around non-http[s] which makes a central spot to put them in valuable. Non-coincidentally this change fixes SameSite=Lax cookies getting dropped in Android Webview apps trying to set them on file:/// iframes. This converts most[1] interfaces in net/, further CLs will push it further. (Which also means this doesn't help that much, and there are some temporary conversions at edges, but it keeps the CL size sane). [1] Exclusions are RedirectInfo, which makes sense to change the same time as Network::ResourceRequest, as there is a lot of copying over, and StaticCookiePolicy. Bug: 577565, 1025349 Change-Id: I0886c53864f43f08fd7ed7a20a2dbc47d1397f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925189Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#723007}
-
Abhijeet Kandalkar authored
The goal of this CL is to clean the element.h file and remove template version of ToElement to adopt new downcast helpers. This CL ports ToElement<T> and its dependent implementation as below - ToElement<ElementType>(n) to To<ElementType>(n) - ToElement<HTMLLinkElement>(n) to To<HTMLLinkElement>(n) - ToElement<HTMLVideoElement>(n) to To<HTMLVideoElement>(n) - ToHTMLTableColElement(n) to To/Dynamic<HTMLTableColElement>(n) - ToHTMLTableCellElement(n) to To/Dynamic<HTMLTableCellElement>(n) Bug: 00000 Change-Id: I1a69516cd7e6b64049b8737ff06ea6e8ec61ea26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955250Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#723006}
-
Devlin Cronin authored
Update ExtensionActionViewController tests to work with the ExtensionsMenu. This includes: - Parameterizing the UI for both the legacy UI and the extensions menu. Note that this means we are no longer parameterizing for both touchable and untouchable UI with the MaterialDesignControllerTestAPI. - Instantiating the right type of UI for the selected behavior. - Introducing a legacy toolbar helper for constructing overflow UI in overflow-specific unit tests (which only apply to the legacy toolbar). - Adding a new test specific to the ExtensionsMenu that's analogous to the ExtensionActionContextMenuVisibility for the legacy toolbar. With this change, all ExtensionActionViewController related tests pass with and without the ExtensionsMenu feature enabled. Bug: 984654 Change-Id: I825c20af39b6217259f63b7f34149d3bb7545eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941080 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1023677 Change-Id: Id9cb4a18e8eecfac2a39ad126fd67cfd37c4a21a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955077 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#723004}
-
Koji Ishii authored
Following bot results are included. 544 547 550 553 556 557 558 559 560 561 562 563 564 565 566 567 30 lines were removed and 13 lines were deflaked by consecutive results since 556. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I0f03694eeb29c4c85a70228d0d6e77cbd3f3078a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955251Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#723003}
-
Sebastien Marchand authored
Change-Id: I2298f001b2efa34cc76de2b036aba64fbc4b6184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951490Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#723002}
-
Aaron Colwell authored
- Adds about:blank to NavigationRequest::RequiresSourceSiteInstance() so that a source_site_instance_ is required for data: AND about:blank - Added OpenURLParams::IsValid() to verify that source_site_instance is set for about:blank and data: URLs if an initiator_origin is set and it is not anonymous. - Added IsValid() DCHECKs in various methods, that take an OpenURLParams object as a parameter, to make it easier to find problematic callers. - Fixed various places where the source_site_instance was not being set along with the initiator_origin. Change-Id: I0b16f5c53598a8f528008be19efcf4f445fac0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918673Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#723001}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=jennyz@chromium.org Bug: 1023677 Change-Id: I99965de8e7e73e48e91e4b11fbf949b44d9490d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957506 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#723000}
-
Anastasiia Nikolaienko authored
Remove secondary accounts for Child->Regular and Regular->Child type transitions. Bug: 1017160 Change-Id: Id3980899f3cae4b12125ddde67ab534eb22deba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917499 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Ana Salazar authored
This reverts commit 9403318c. Reason for revert: The culprit was found to possibly be http://crrev.com/c/1917941. The fix was addressed in http://crrev.com/c/1954355 and it seemed to land without new failures. Original change's description: > [CrOS] Disable heavily flaky ShelfLayoutManagerUnitTest > > It hurts to have to disable this test since it only started flaking on > Dec 3rd. But I absolutely couldn't find the culprit and its success rate > is less than 50%. > > Example failure: > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/10045 > > [ RUN ] All/ShelfLayoutManagerTest.NoShelfUpdateDuringOverviewAnimation/1 > [4901:5087:1203/034714.153751:21185573821:ERROR:accelerometer_reader.cc(507)] Failed to initialize for accelerometer read. > > Received signal 11 SEGV_MAPERR fffff87dedcff277 > \#0 0x55fd9d942aa9 (/b/s/w/ir/out/Release/ash_unittests+0x1947aa8) > r8: 00007ffd7610501d r9: 000015330856bdfa r10: 00153f612887a8e0 r11: 0000000000000001 > r12: 0000000000000002 r13: 00000780be2a83e0 r14: 00000000be167701 r15: 00000780bf39b068 > di: 00000780bd57c000 si: 0000000000000042 bp: 00007ffd760cb760 bx: 00000780be2a83c0 > dx: 00000000000ae0f6 ax: fffff87dedcff267 cx: 7fffffffffffffff sp: 00007ffd760cb710 > ip: 000055fd9dc64b6f efl: 0000000000010297 cgf: 002b000000000033 erf: 0000000000000005 > trp: 000000000000000e msk: 0000000000000000 cr2: fffff87dedcff277 > [end of stack trace] > Calling _exit(1). Core file will not be generated. > [ RUN ] All/ShelfLayoutManagerTest.NoShelfUpdateDuringOverviewAnimation/1 > [12479:12482:1203/034728.943872:21200363941:ERROR:accelerometer_reader.cc(507)] Failed to initialize for accelerometer read. > > Received signal 11 SEGV_MAPERR ffffde0c0ac9c95d > \#0 0x5572f4ad7aa9 (/b/s/w/ir/out/Release/ash_unittests+0x1947aa8) > r8: 00007fffb4fb501d r9: 00001536cf8597a6 r10: 000dd765335171fb r11: 0000000000000001 > r12: 0000000000000001 r13: 000021f15f70fd40 r14: 000000005ea0c901 r15: 000021f15e6e5e68 > di: 000021f15e7a15c0 si: 0000000000000021 bp: 00007fffb4ec30f0 bx: 000021f15f70fd20 > dx: 0000000000071637 ax: ffffde0c0ac9c94d cx: 7fffffffffffffff sp: 00007fffb4ec30a0 > ip: 00005572f4df9b6f efl: 0000000000010297 cgf: 002b000000000033 erf: 0000000000000005 > trp: 000000000000000e msk: 0000000000000000 cr2: ffffde0c0ac9c95d > [end of stack trace] > Calling _exit(1). Core file will not be generated. > > TBR=amusbach@chromium.org > > Bug: 1030222 > Change-Id: Ib96aa9208116465727cc0eabc96c526a313a9b4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948435 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720928} TBR=fhorschig@chromium.org,amusbach@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1030222 Change-Id: I4d950a5bc06336a869db6f0bb895459cbead6337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956239Reviewed-by:
Avery Musbach <amusbach@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#722998}
-
