GitLab

BUG=349436

Review URL: https://codereview.chromium.org/420033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287156 0039d316-1c4b-4281-b951-d872f2087c98

The Notification provider API will reroute the notifications that are supposed to be sent to the Chrome Notification Center, so an app can get the notifications and have its own implementation of notification center.

BUG=397197

Review URL: https://codereview.chromium.org/356673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287155 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354046
TEST=browser_tests WebstoreStartupInstallerTest.*

Review URL: https://codereview.chromium.org/437603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287154 0039d316-1c4b-4281-b951-d872f2087c98

UserManagerBase contains common methods extracted from UserManagerImpl.
UserManagerImpl was renamed to ChromeUserManager and inherits UserManagerBase.

Misc refactoring:
* Move HasBrowserStarted() to SessionManager
* Add generic getter SessionManager::Get() which makes it possible for concrete clients don't depend on instance ownership like g_browser_process->platform_part()->SessionManager().
* Moved CRLSet code out of UserManager::UserLoggedIn(), to UserSessionManager.

BUG=387614

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286187

Review URL: https://codereview.chromium.org/417623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287153 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332335,364724
NOTRY=true
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/436813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287152 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287146 0039d316-1c4b-4281-b951-d872f2087c98

The tests should only be disabled on Android to match the rule in
chrome_common.gypi.

BUG=none

Review URL: https://codereview.chromium.org/433133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287144 0039d316-1c4b-4281-b951-d872f2087c98

- Show Gaia signin page instead of account picker.
- Pre-fill owner email in Gaia signin page.
- Show only the enrollment message in Gaia screen right panel.
- Show only a cancel button (in addition to Shutdown) at the bottom.

BUG=chromium:353050
TEST=manually test the signin page.

Review URL: https://codereview.chromium.org/426153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287143 0039d316-1c4b-4281-b951-d872f2087c98

Removing the following unused RTCP messages:
* PLI
* NACK
* RPSI
* REMB
* BYE
* SDES

Deleted about 1200 lines of code. Tested with cast_unittests
and simulation shows no difference. Casting to a proper
receiver works as well.

BUG=393042

Review URL: https://codereview.chromium.org/427733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287142 0039d316-1c4b-4281-b951-d872f2087c98

to reflect recently-submitted cr/72364534

BUG=

Review URL: https://codereview.chromium.org/434993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287141 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287140 0039d316-1c4b-4281-b951-d872f2087c98

This picks up the clang_warning_flags changes I landed earlier today.

For libvpx and icu, nothing else is in their rolls.

For hunspell and flac, one other change is also in the range.
hunspell: https://codereview.chromium.org/306793002/
flac: https://codereview.chromium.org/254083004/

Both look like they don't have an effect in practice, so I'm including them in
this roll. (NSS is currently preparing a real roll – crbug.com/396377 – so I'm
not rolling that at this point.)

BUG=none
TBR=hans

Review URL: https://codereview.chromium.org/440513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287139 0039d316-1c4b-4281-b951-d872f2087c98

I missed a few targets that I though were deps'd in, but which (thankfully)
just live in the regular tree.

BUG=none
R=hans@chromium.org
TBR=cpu

Review URL: https://codereview.chromium.org/429793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287137 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit aca48d3e.

The original CL didn't cause issue 397656. It's caused by previous CLs and is
fixed by r286787. This CL simply reland the original CL.

TBR=gbillock@chromium.org
BUG=349211, 397656
TEST=Existing tests pass.

Review URL: https://codereview.chromium.org/435023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287136 0039d316-1c4b-4281-b951-d872f2087c98

Make the feedbackPrivate.getUserEmail not crash if
chromeos::UserManager has been initialized but no user is
logged in.

BUG=399749

Review URL: https://codereview.chromium.org/438963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287135 0039d316-1c4b-4281-b951-d872f2087c98

Adding synthetic field trial for the trial name DataReductionProxyEnabled and groups |true| and |false| that indicate whether the data reduction proxy proxy is turned on or not. The field trial was added so we can see if the data reduction proxy is turned on or not for PLT.PT_*_DataReductionProxy histograms, but can be viewed on any histogram.

BUG=394125

Review URL: https://codereview.chromium.org/421653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287133 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=hans@chromium.org
TBR=cpu

Review URL: https://codereview.chromium.org/439543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287132 0039d316-1c4b-4281-b951-d872f2087c98

This will allow development of the new design in parallel with the current implementation. The plan is to put new styles in local-ntp.css, which will be selected according to the class of the containing div.

This CL also adds a command-line flag, which will be tied to the Field trial from the server.

BUG=399388
TEST=using force-fieldtrials, confirmed that it works.

Review URL: https://codereview.chromium.org/435723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287131 0039d316-1c4b-4281-b951-d872f2087c98

Without this fix, if display info has changed while the settings page is running
the display info dialog will show stale data.

BUG=399690
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/436013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287130 0039d316-1c4b-4281-b951-d872f2087c98

This is to avoid a NOTREACHED in the RWHVBase implementation of that
virtual function. Actually fixing it will come soon.

BUG=368298,398282

Review URL: https://codereview.chromium.org/431183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287129 0039d316-1c4b-4281-b951-d872f2087c98

Tiles in chrome-search://local-ntp/local-ntp.html used to be arranged in
2 rows, and get reshuffled when screen resize causes number of columns
to change. However, detaching and reattaching elements with <iframe>s
cause the <iframe>s to reload, resulting in flickering.

This CL places all tiles in a single <div>, so no reshuffling is needed.
Instead, if number of columns change we resize the container width (and
also hide tiles beyond row 2), and let HTML layout place handle the
proper wrapping.

On blacklisting, we cannot compare identities between old tiles and new,
so a reload is necessary, which leads to some flickering.

Also tested for <body dir="RTL">

Additional cleanups:
- To show all tiles only after everything is loaded: using a Barrier
  counter instead of looping on every load, which was O(n^2).
- Broke apart onMostVisitedChange() and added more comments.
- Removed unused CSS for fakebox and tiles resizing (JS does resizing now).
- Using CSS visibility instead of hidden to show #mv-tiles, so it take
  up space and prevent content beneath tiles from jumping up briefly.
- Refactoring the logic to hide tiles during load and show all at once when
  everything loads (or timeout occurs). Using new class Barrier to do this.

BUG=399388

Review URL: https://codereview.chromium.org/412073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287120 0039d316-1c4b-4281-b951-d872f2087c98

Refactors the sync build target definition to fit the more common
pattern.  The old target was defined differently in component and
non-component mode.  This is brittle compared to the more standard
pattern of setting the target type to '<(component)'.

Introduces a shim target with type 'none'.  Any target that depends on
this shim will link inherit its dependency on the two sync libraries.

A note on the history of this, for those who are interested:

This pattern was recommended during the original componentization of
sync almost two years ago.  The pattern was, and still is, used by
content.gyp to ensure that dependency restrictions are being respected.

The difference with sync is that it doesn't actually make use of
fine-grained dependencies.  It's not unusual to see a target depend on
conent_renderer, content_browser, or some other static library
sub-component of content.  With sync, on the other hand, we have the
rule that other targets may depend only on the top level sync target.

Since no one aside from sync depends on sync_internal_api, sync_core, or
sync_api static library targets, and we have no intention of exposing
these sub-components outside of sync, there's no point in maintaining
them as separate targets.

BUG=397574

Review URL: https://codereview.chromium.org/425803013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287119 0039d316-1c4b-4281-b951-d872f2087c98

Currently if a user clicks thorough an invalid certificate, the decision is
remembered for the rest of the session, but after session restart, the decision
is forgotten. This implements a flag that remembers the decision for a specified
length of time across session restarts. Users can specific in the flag how long
decisions should be remembered, or they can specify that it should still be
reset on restart.

BUG=262615
NOTRY=true

Review URL: https://codereview.chromium.org/369703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287118 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to spell_check_client.

BUG=331299

Review URL: https://codereview.chromium.org/424183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287117 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370153

Review URL: https://codereview.chromium.org/434143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287116 0039d316-1c4b-4281-b951-d872f2087c98

BUG=312328

Review URL: https://codereview.chromium.org/428783007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287115 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398867

Review URL: https://codereview.chromium.org/431943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=356483,354553

Review URL: https://codereview.chromium.org/434693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287112 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/431533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287111 0039d316-1c4b-4281-b951-d872f2087c98

When the user disables or enables crash reporting in the settings menu
this CL adds a restart message very similar to the hardware acceleration
setting also in the setting menu.

It also clears the Breakpad pipe environment variable when the user is disabling crash reporting, so that the restarted Chrome, which inherits the current environment variable, won't be able to connect to the crash handler service and report crashes.

BUG=380700

Review URL: https://codereview.chromium.org/424833008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287110 0039d316-1c4b-4281-b951-d872f2087c98

The polymer_load measurement is one we intend to use for measuring other
Polymer apps loading (e.g., paper-calculator, Topeka).

R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/435043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287109 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=hush@chromium.org
BUG=399796

Review URL: https://codereview.chromium.org/433023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287108 0039d316-1c4b-4281-b951-d872f2087c98

This test is not applicable for iOS.

BUG=399384

Review URL: https://codereview.chromium.org/427433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287107 0039d316-1c4b-4281-b951-d872f2087c98

I've noticed on the perf bots that if we get a host_forwarder error
because it can't connect to the device, then all subsequent forwarder
operations will fail. Example:
http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/builds/1163/steps/Sharded%20Perf%20Tests/logs/stdio

This patch fixes that by killing the device forwarder (and ensuring it
isn't initialized) so that it can be re-initialized on the next
attempt.

BUG=294878

Review URL: https://codereview.chromium.org/427353005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287105 0039d316-1c4b-4281-b951-d872f2087c98

I made a bit of a blunder when writing the tile manager queues perftests
and made them use a variable number of tilings, instead of layers.

The important thing for us to test here is how the system behaves with
multiple layers. Multiple tilings case is tested at the tiling level
iterator level.

This patch fixes up all of this.

NOTE TO PERF SHERIFFS
=====================

Please disregard any performance changes in the tile manager perftests
as a result of this patch. This changes fundamentally what the
perftests are measuring.

R=reveman

Review URL: https://codereview.chromium.org/434713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287104 0039d316-1c4b-4281-b951-d872f2087c98

LayerAnimationController::MarkAnimationsForDeletion


MarkAnimationsForDeletion first checks if all the animations with the
same group ID as the current animation is finished or not. If no,
nothing is done. If yes, then in another iteration it again finds all
the animations after the current animation in the list with the same 
group ID and marks it for WaitingForDeletion.

This patch executes the MarkAnimationsForDeletion for animations with 
minimum iterations. While checking if all the animations with same ID
is finished also mark the animations which satisfy this condition. 
Later use these marked animations to reduce the iterations.

BUG=396562

Review URL: https://codereview.chromium.org/429223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
NOTRY=true

Review URL: https://codereview.chromium.org/439503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287102 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233971
NOTRY=True

Review URL: https://codereview.chromium.org/438963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287101 0039d316-1c4b-4281-b951-d872f2087c98

Fix a "managedUser" reference that was renamed to "supervisedUser" in https://codereview.chromium.org/403343002/, but incorrectly re-renamed in https://codereview.chromium.org/410293004

This was preventing the "import supervised user" link from working.

TBR=pam@chromium.org,michaelpg@chromium.org

BUG=385113,399539

Review URL: https://codereview.chromium.org/431303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287100 0039d316-1c4b-4281-b951-d872f2087c98

These margins used to come from the user agent stylesheet, and now they don't. This CL explicitly sets them.
Screenshots are on the bug.

BUG=389103

Review URL: https://codereview.chromium.org/435733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287099 0039d316-1c4b-4281-b951-d872f2087c98