- 06 Dec, 2019 40 commits
-
-
Sven Zheng authored
The test suite was renamed. Bug: 1010568 Change-Id: I59eb7bd581d29fdf886009cc4e476712d4b8e1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954928 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#722441}
-
Tim Schumann authored
We slice the metrics by minute to help with analyzing traffic peaks. Recording by minute is helpful as we see traffic spikes at certain minutes of the hour. Bug: 1031162 Change-Id: Idc45d1a9aedab8d4ed5171a26f944c6c39b06490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953604 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#722440}
-
Mike West authored
This patch introduces a "same origin-domain" check, distinct from `SecurityOrigin::CanAccess()`, and uses it to implement the latter. This is a small step towards auditing the points at which we're calling `::CanAccess()` to decide whether we ought to be performing a "same origin", or "same origin-domain" check instead. Bug: 1027191 Change-Id: If6007367da7e044d008f056e3f816ac422551e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951001 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#722439}
-
Antonio Gomes authored
BUG=787254 R=guidou@chromium.org Change-Id: I8f8a15ebe099c20ec56adf54a90a3562ee26ee69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950683 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#722438}
-
Oleg Davydov authored
This is an upgrade of UMA statistics related to force-installed extensions. Before this commit if download manifest has missing fetch URL or invalid one, we still report it as CRX_FETCH_FAILED, mixing with network-related error and failed HTTP requests. This commit adds two separate errors, URL_EMPTY and URL_INVALID, and provides them to the next generation of the ForceInstalledFailureReason histogram. Bug: 1030224 Change-Id: Iec0fa37d59945d3743f3d32bf5de11182c64b915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947737Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#722437}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1fce3f8e55a5..cec2433c477f git log 1fce3f8e55a5..cec2433c477f --date=short --first-parent --format='%ad %ae %s' 2019-12-06 srte@webrtc.org Exposing more features in the network emulation manager API. Created with: gclient setdep -r src/third_party/webrtc@cec2433c477f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I54cd78ad674638368c78f96d4336c7b9b1e86a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955242Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722436}
-
Marian Fechete authored
This CL adds a unit test that checks the overwrite logic in the collect user data action, specifically checking that the proto of a subsequent action overwrites the values in the controller user data. Bug: b/140019232 Change-Id: I825bf670315629f14be26d095a8903ea11cbe959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953208 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#722435}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/176b9884fdee..4b6d9afe2055 git log 176b9884fdee..4b6d9afe2055 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 szuend@chromium.org Fix broken link to Omahaproxy in README.md Created with: gclient setdep -r src/third_party/devtools-frontend/src@4b6d9afe2055 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8dd4ac8feb0122f27c99329bc5058ab7c753355c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955243Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 1012203 Change-Id: I91eb4f454cc899e444fda0f3983341c239ad6867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943233Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#722433}
-
Clemens Arbesser authored
This CL extends the java test service: - Test scripts can now contain more than one round trip, which will allow us to test complete flows. - Tests can now inspect and test the results of actions which would otherwise be sent to the backend. This CL includes a first proof-of-concept for how to use the new methods, but we should extend all our existing integration tests in the near future. Bug: b/144978160 Change-Id: I8188a50f0c600acecc687ad58cd4612d767a6dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953109 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#722432}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/11e6944ec5a8..b2c2d667d540 git log 11e6944ec5a8..b2c2d667d540 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src e72b61c7c20d..a3ee4384fb57 (2 commits) Created with: gclient setdep -r src/third_party/angle@b2c2d667d540 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Ic83aa3a07064b309ed89dba3604aa473874be145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955234Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9cec36038932..15a09a9cfafc git log 9cec36038932..15a09a9cfafc --date=short --first-parent --format='%ad %ae %s' 2019-12-06 primiano@google.com Merge "Prevent warnings in amalgamated builds" Created with: gclient setdep -r src/third_party/perfetto@15a09a9cfafc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5f6d72b80f5c0f4802b83757f8f0f8adbee97d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955240Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af5f9020e38b..651c01e838a0 Created with: gclient setdep -r src-internal@651c01e838a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iacff66ff9a49c0ee0bf3e21c1336289b42037bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955239Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722429}
-
Ken Rockot authored
This is a reland of e8d24f73 Original change's description: > Reland "Move Audio Service off Service Manager" > > This is a reland of a4d27f51 > > The reland moves the TestingApi binder support into a component > library to avoid duplicate definitions that resulted in browser > test failures in component builds. > > Original change's description: > > Move Audio Service off Service Manager > > > > All the details around if/when a service instance is started and whether > > it's in- or out-of-process have been centralized into the implementation > > of a single GetAudioService() helper in Content. > > > > A few other helpers are added to ease the transition off the Service > > Manager, though they aren't necessarily ideal APIs. For example, > > client library APIs which once took a Service Manager Connector may now > > take a RepeatingCallback to bind a specific type of interface. > > > > In addition to GetAudioService(), Content provides helpers for > > AudioSystem construction and StreamFactory binding from any sequence. > > > > Because all timeout/lifetime management logic is now generically > > supported within Mojo and Content and requires no service implementation > > details to get right (and because unit tests launching service processes > > is no longer supported outside of Content), all Audio Service test > > coverage relevant to lifetime management is deemed superfluous and has > > been removed. > > > > Bug: 977637 > > Change-Id: I4c59948eafce2322547bf2b0479961e095b3edee > > Tbr: oshima@chromium.org > > Tbr: guidou@chromium.org > > Tbr: vollick@chromium.org > > Tbr: xiaohuic@chromium.org > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941280 > > Commit-Queue: Ken Rockot <rockot@google.com> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#721832} > > Bug: 977637 > Change-Id: I183e79042c99458f2abf9423d8f9bbefedf5b374 > No-Presubmit: true > Tbr: oshima@chromium.org > Tbr: guidou@chromium.org > Tbr: vollick@chromium.org > Tbr: xiaohuic@chromium.org > Tbr: avi@chromium.org > Tbr: rsesek@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952601 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#722373} Bug: 977637 Change-Id: I1b803e57632bd92f2b1e093c3d1c1731de8338f0 No-Presubmit: true Tbr: oshima@chromium.org Tbr: guidou@chromium.org Tbr: vollick@chromium.org Tbr: xiaohuic@chromium.org Tbr: avi@chromium.org Tbr: rsesek@chromium.org Tbr: dalecurtis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954772Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#722428}
-
Hajime Hoshi authored
This CL adds new metrics for all websites, besides the existing metrics. The existing metrics are recorded only when the domain is allowed in the experiments, while the new metrics are recorded for all the websites. The new metrics are useful to see e.g., the tendency of the reasons why the page is not cached if we enable back-forward cache in all the sites, and such information will help us to prioritize our works to enable back-forward cache in all websites. Bug: 1004676 Change-Id: I30cf343bb685a0e462364bb2b6d6b03302032fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950731 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#722427}
-
Bret Sepulveda authored
When ExtensionsToolbarMenu is enabled, the test was failing because it was expecting a "Hide in Chrome menu" label, rather than the new "Unpin" label. This patch fixes that expectation. Bug: 984654 Change-Id: I146d84522beaef09337799260f6e7dc051f5a70c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942344 Auto-Submit: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
When producing Path objects, arcs are converted to conic segments, and when iterating those with Path::Apply(...) they are converted to quadratic beziers. So the arc semantics are lost when SVGMarkerDataBuilder gets the resulting segment. Thus it produces markers for each quadratic bezier, which is incorrect. Teach SVGMarkerDataBuilder to operate on the original path data too by accepting SVGPathByteStreams, and contort the arc segments into single (faux) beziers with matching properties (same start/end tangents). This allows reuse of the rest of the marker data builder machinery. Use the new code-path for the cases which can contain arc segments (<path> elements with 'd'). Bug: 583097 Change-Id: I20d772bb2ab67cd686160ab437d7d16fbc81e3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950999 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#722425}
-
Anatoliy Potapchuk authored
This cl hides shelf during splash screen, so users can't crash chrome anymore :) Bug: 1026638,1015383 Change-Id: I005006d470429176e4bb7830b80149a54e5ac691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926481Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#722424}
-
Ricky Liang authored
Bug: 982201 Bug: b:144805331 Change-Id: I8c038c8912aaae48744d318398d85ce6c8fdfa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954822Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722423}
-
Omar Morsi authored
This CL adds an option for generating test certificates with custom subject alternative name (SAN). This is important e.g. for testing of SAN matching in isolation. Bug: 1030652 Test: Metadata of generated certificates has not changed (inspected manually). Change-Id: I95c5003b46e4a78fb176c4d330571e22fc2b5f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949797 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#722422}
-
Oriol Brufau authored
In r720875 I changed the pseudo type of the style used for markers with 'content: normal' from kPseudoIdNone to kPseudoIdMarker. This had the side effect that they started to propagate style to its children, producing a 90.6%-99.9% performance regression in the flexbox_with_list_item test. This patch prevents that style propagationg for normal markers, fixing the perf regression. Markers with 'content' different than 'normal' are still propagated since it's necessary in that case. Bug: 1030884, 457718 Change-Id: Ia8341b605366ebdfd117cf569d030b38862348dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953723Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#722421}
-
Oriol Brufau authored
The spec has added 'white-space' to the list of properties that apply to ::marker pseudo-elements. Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo BUG=457718 TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html Change-Id: Iaf05bb568d0127b2aae4219715bb8839620101a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954384Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Pavol Marko authored
It was only enabled recently and has been consistently failing across multiple bots. TBR=dcheng@chromium.org, etienneb@chromium.org, erikchen@chromium.org Bug: 843467 Test: browser_tests --gtest_filter=*MemlogBrowserTest* Change-Id: Iee8db1833b3e58013b5522d02dd6ca8b9ab579ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954006Reviewed-by:
-
Olivier Robin authored
With slim navigation, the navigation manager items are only restored when the tab is displayed. Before that point, use the session_storage to sync the tab. Bug: 1024750 Change-Id: Ie22d46065f28d172980175e3d8468712579a8ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943241Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722418}
-
Navid Zolghadr authored
This makes moving ComputedStyle to Oilpan in these classes that are referencing it in the future easier. Firstly it replaces a const & reference of ComputedStyle in BoxInfo with a cached value needed in that class. Secondly it makes a local FloatObject class public so that it can be stored in a HeapVector and have WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS on it and later have a trace function for its CompuetedStyle reference. Bug: 1030176 Change-Id: Iff63d1fb385bbb5ac85fc5445caf7dfd775352ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946051Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#722417}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/69d1054db47b..af5f9020e38b Created with: gclient setdep -r src-internal@af5f9020e38b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie02c7b5bdfbb2109ffde20dbe9cfa6045efe4d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955237Reviewed-by:
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: Id933fc47dbc7a9b3efcf939b0ac3cf3b93d0b259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952568 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#722415}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7d04c75b577b..51a024f7d973 git log 7d04c75b577b..51a024f7d973 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 dberris@chromium.org Remove unnecessary assertion Created with: gclient setdep -r src/third_party/catapult@51a024f7d973 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1031431 Tbr: oysteine@google.com Change-Id: I99b0ebc2b07e9fa9eb8feacd03cd55b5debe032f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955236Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=bartfab@chromium.org Bug: 1023677 Change-Id: I945eb1ac77ffaf199afffb799717444515d427af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926923 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#722413}
-
Alexander Timin authored
Restarting bfcached navigations (e.g. when we evict after the document was restored) is potentially problematic - add trace events to ensure that the problems are easy to diagnose. R=alexmos@chromium.org Change-Id: Ia1a888889e52d9e9a0aaec7119833a851060d234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930151 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#722412}
-
Miyoung Shin authored
This CL cleans up WebContentsObserver inheritance from classes that had only overridden OnInterfaceRequestFromFrame but removed during the conversion to BrowserInterfaceBroker. Bug: 1030327 Change-Id: If38d1f96779bd7badd47712b059b7b05939f8c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950263Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#722411}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1256d9bcac50..1fce3f8e55a5 git log 1256d9bcac50..1fce3f8e55a5 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 yvesg@webrtc.org Remove custom constructors for AudioProcessing::Config. Created with: gclient setdep -r src/third_party/webrtc@1fce3f8e55a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibee7f9e82474b9ca9a885de6132e22b63e537bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955235Reviewed-by:
-
Ramin Halavati authored
Google Docs Offline extension has some web-accessible resources that can be requested by websites, as a measure of browsing in incognito mode. This CL adds UKM metrics to measure the usage of these resources by docs and other websites. Note that the imports are double counted since they are counted once in preload and once in actual load. Privacy review doc: https://docs.google.com/document/d/1be0us3OZjXfr4bfj5NUxKfuXDy6ESu_ClcrfeyyfVZI/ Bug: 588766 Change-Id: Ib2cfafa53207ad6406b971c8fcb85091345b0726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901035 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: b/141518780 Change-Id: I3b92965cf0da978e9a8820e86c236a752e565a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954995 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Umut Baris Oztunc authored
This removes the calls to the base::FilePath copy constructor which is called explicitly while passing arguments to the FileSystemWatcher constructor inside CreateAndStartFileSystemWatcher function. Bug: 1030575 Test: Manually tested. Change-Id: If5ae4da8904f8beeb3c9e4eb38a988a146290793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949833Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Umut Barış Öztunç <umutoztunc@google.com> Cr-Commit-Position: refs/heads/master@{#722407}
-
Kenichi Ishibashi authored
This isn't used. Bug: N/A Change-Id: Icf6f869a04b17bd2656ca05797092427fcb8657e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955244 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#722406}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/828b56268225..7d04c75b577b git log 828b56268225..7d04c75b577b --date=short --first-parent --format='%ad %ae %s' 2019-12-06 dberris@chromium.org Fix typo (input_ref -> inputs_ref) 2019-12-06 dberris@chromium.org Set the default empty lists in serialisation Created with: gclient setdep -r src/third_party/catapult@7d04c75b577b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1031421,chromium:1031426 Tbr: oysteine@google.com Change-Id: I107a386972a4b9cbf143a079aac2fc885f93ad0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955229Reviewed-by:
-
sangwoo authored
Interpose views::AnimationDelegateViews using gfx::AnimationDelegateNotifier, which helps to adapt align animation to the Compositor's frame. There's no intended behavior change. Bug: 824026 Change-Id: I2cb9a06e89b9627a933a83c5d44eac19a3792c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953240Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#722404}
-
Roman Sorokin authored
Added CHECK in the ScreenLocker Bug: 1024555 Change-Id: I4cf76bff08b6911a914be20619767f5c4ad1a72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939709Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722403}
-
Maksim Sisov authored
Instead of attaching already attached buffer once again, it's just enough to provide damage and commit the surface. Also, the test was extended. Original change's description: > ozone/wayland: Complete submission of a buffer submitted more than once > > This CL fixes a corner use case that was caught by one of the users > of Ozone/Wayland. > > The problem appeared when the Chromium compositor sent a next frame into > the same buffer that had just been submitted and a OnSubmission callback > had been sent to the viz process located WaylandBufferManager. This > happened only when the remote inspector was attached and the screencast > was enabled. > > In this case, Wayland compositor will not send an OnRelease callback > and we should not wait for that. Instead, we must complete the > submission immediately and set the |WaylandBuffer::released| > member to be false. Once another buffer is committed, Wayland compositor > will release the previous buffer. > > Bug: 1029777 > Change-Id: Ib74c16f41f128298998bc9699f8d9ded3697cd43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946479 > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720878} TEST: WaylandBufferManagerTest.SubmitSameBufferMultipleTimes Bug: 1029777 Change-Id: If429fa5626e6276a72bb0ed97385cb26c01ab591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951018 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#722402}
-
