GitLab

This warns on code of the form:
#endif RANDOM_TEXT
MIDL generated code tends to emit code in this pattern, so suppress
this warning when compiling MIDL generated files.

BUG=504663
R=thakis@chromium.org
TBR=dtseng, robertshield, weitaosu

Review URL: https://codereview.chromium.org/1233453008

Cr-Commit-Position: refs/heads/master@{#338435}

0 configs already ran on Swarming
7 used to run locally and were converted:
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.win.json: Vista Tests (1)
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)
- chromium.win.json: XP Tests (1)

Ran:
  ./manage.py --convert sbox_validation_tests

R=cpu@chromium.org,thakis@chromium.org
BUG=98637

Review URL: https://codereview.chromium.org/1212003003

Cr-Commit-Position: refs/heads/master@{#338434}

Note: I am not in AUTHOR files yet. Please help by verifying that I have sign the CLA.

Please also help by submitting the try jobs.

Review URL: https://codereview.chromium.org/1226253005

Cr-Commit-Position: refs/heads/master@{#338433}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/05e9c31..d6595eb

TBR=rjwright@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1230303002

Cr-Commit-Position: refs/heads/master@{#338432}

The reverted commit broke i18n-values substitution in OOBE UI.

This reverts commit b163dffb.
> Author: dbeam <dbeam@chromium.org>
> Date:   Wed Jul 8 20:33:13 2015 -0700
>
>     Teach i18nTemplate.process() to handle <link rel=import> and
>     <template>
>
>     This is required to support Polymerized web UI until we figure out
>     a
>     more flicker-resistant solution (see: crbug.com/506009)
>
>     BUG=425626
>     R=arv@chromium.org
>     TBR=yoshiki@chromium.org
>
>     Review URL: https://codereview.chromium.org/1229573003
>
>     Cr-Commit-Position: refs/heads/master@{#337980}

BUG=425626,509087
TBR=dbeam
NOPRESUBIT=true

Review URL: https://codereview.chromium.org/1234753002

Cr-Commit-Position: refs/heads/master@{#338431}

BUG=501146

Review URL: https://codereview.chromium.org/1204943002

Cr-Commit-Position: refs/heads/master@{#338430}

Cr-Commit-Position: refs/heads/master@{#338429}

BUG=

Review URL: https://codereview.chromium.org/1236643002

Cr-Commit-Position: refs/heads/master@{#338428}

BUG=420315
TEST=unit test

Review URL: https://codereview.chromium.org/1228763002

Cr-Commit-Position: refs/heads/master@{#338427}

BUG=504666

Review URL: https://codereview.chromium.org/1226163009

Cr-Commit-Position: refs/heads/master@{#338426}

Renderer main thread will run ChannelProxy::SetListenerTaskRunner()
to set listener task runner, but the task runner may be accessed on
IPC thread at the same time.
This CL is to fix the race condition.

TBR=nasko@chromium.org
BUG=479684

Review URL: https://codereview.chromium.org/1227303002

Cr-Commit-Position: refs/heads/master@{#338425}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b4ed8a0..05e9c31

TBR=rjwright@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1223323014

Cr-Commit-Position: refs/heads/master@{#338424}

Aidls' urls has been switched from strings to uri objects.

Patch included in this roll:
https://chromium-review.googlesource.com/#/c/284878/1

BUG=NONE

Review URL: https://codereview.chromium.org/1236623003

Cr-Commit-Position: refs/heads/master@{#338423}

BUG=508652
TEST=no change to functionality

Review URL: https://codereview.chromium.org/1228993005

Cr-Commit-Position: refs/heads/master@{#338422}

Ninja takes care of creating output directories already

BUG=

Review URL: https://codereview.chromium.org/1223273005

Cr-Commit-Position: refs/heads/master@{#338421}

In ES3, dimensions of images are no longer required to match.

BUG=429053
TEST=gpu_unittests, webgl_conformance2
R=piman@chromium.org

Review URL: https://codereview.chromium.org/1231273002

Cr-Commit-Position: refs/heads/master@{#338420}

BUG=396738
TBR=dtrainor@chromium.org

Review URL: https://codereview.chromium.org/1230933005

Cr-Commit-Position: refs/heads/master@{#338419}

0 configs already ran on Swarming
7 used to run locally and were converted:
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.win.json: Vista Tests (1)
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)
- chromium.win.json: XP Tests (1)

Ran:
  ./manage.py --convert sbox_unittests

R=cpu@chromium.org,thakis@chromium.org
BUG=98637

Review URL: https://codereview.chromium.org/1219403002

Cr-Commit-Position: refs/heads/master@{#338418}

TBR=kmarshall
BUG=504938

Review URL: https://codereview.chromium.org/1230793010

Cr-Commit-Position: refs/heads/master@{#338417}

This is gives Chromium developers visibility into what features are active, but hidden behind field trial testing while developing Chromium.

There is already a JSON file in Chromium with which field trials should be active. The goal is make a code generator to output a struct based off the contents of this JSON file. The next step after this is to create a mechanism to activate the trials defined by this generated struct.

BUG=504075

Review URL: https://codereview.chromium.org/1209743002

Cr-Commit-Position: refs/heads/master@{#338416}

After a user selects accept on a Chrome infobar, Chrome will potentially
show a androind runtime permission dialog.  If after accepting chrome
they hit deny on the android dialog, then we will show a warning dialog
that Chrome in fact needs the permission to grant it to the site.

BUG=499393

Review URL: https://codereview.chromium.org/1236703002

Cr-Commit-Position: refs/heads/master@{#338415}

Fixed the Touchscreen.TouchEventsEnabled histogram to record the correct values on X11 and Ozone based builds.

The Touchscreen.TouchEventsEnabled histogram was being recorded before
the X11 and Ozone sub-systems had a chance to scan all the devices. This
caused the recorded value to be incorrect.

TEST=ChromeBrowserMainExtraPartsMetricsTest.VerifyTouchEventsEnabledIsNotRecordedAfterConstruction
TEST=ChromeBrowserMainExtraPartsMetricsTest.VerifyTouchEventsEnabledIsNotRecordedAfterPostBrowserStart
TEST=ChromeBrowserMainExtraPartsMetricsTest.VerifyTouchEventsEnabledIsRecordedWhenDeviceListsComplete
TEST=ChromeBrowserMainExtraPartsMetricsTest.VerifyTouchEventsEnabledIsOnlyRecordedOnce
TEST=ChromeBrowserMainExtraPartsMetricsTest.VerifyTouchEventsEnabledIsRecordedAfterPostBrowserStart

BUG=499476

Review URL: https://codereview.chromium.org/1182303005

Cr-Commit-Position: refs/heads/master@{#338414}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/abe694c..b4ed8a0

TBR=rjwright@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1230933006

Cr-Commit-Position: refs/heads/master@{#338413}

The recovery heuristic doesn't work with --disable-gpu-vsync
since it ends up skipping every BeginFrame we get (a lot)
before the swap ack arrives.

BUG=406158
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1223403004

Cr-Commit-Position: refs/heads/master@{#338412}

* Pulls out PendingDocumentData from the DocumentTabModelSelector and makes
  it a standalone thing.  The new AsyncTabCreationParamsManager acts as the
  DocumentTabModelSelector did and stores a mapping of Tab IDs to pending
  data, which are now stored in AsyncTabCreationParams.

* Callsites are all changed to use the new AsyncTabCreationParams instead.

* AsyncTabCreationParams now stores a LoadUrlParams instead of random fields
  from the LoadUrlParams.

* Fields in the AsyncTabCreationParams are clearly marked exclusive, based
  on how they are constructed.

BUG=508333

Review URL: https://codereview.chromium.org/1235523003

Cr-Commit-Position: refs/heads/master@{#338411}

This fixes crash when chrome.management.uninstall() is called from background
page. The logic is copied from CreateAppShortcutFunctionDelegate(). The dialog
will show in the browser instead of in a new window.

BUG=505236
R=kalman,mek

Review URL: https://codereview.chromium.org/1225693009

Cr-Commit-Position: refs/heads/master@{#338410}

BUG=501961

Review URL: https://codereview.chromium.org/1189413003

Cr-Commit-Position: refs/heads/master@{#338409}

Previously GN would put object files in a similar place to GYP. They would go in a corresponding directory as the source file and would be prefixed with the target name for uniqueness.

Since GN target names are not unique, this doesn't work as well. Instead use a simpler scheme and put all the object files in a directory for each target.

This causes a few object file name collisions which this patch fixes in various ways:

- Renamed chrome/browser/ui/views/find_bar_host_interactive_uitest.cc to have "views" in the name (collided with chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc)

- Renamed chrome/browser/apps/speech_recognition_browsertest.cc to have "app" in the name (collided with chrome/browser/speech/speech_recognition_browsertest.cc).

- Renamed chrome/common/extensions/api/extension_api_unittest.cc to have "common" in the name (collided with chrome/browser/extensions/extension_api_unittest.cc which is actually a test harness with that name).

- Moved the extensions files that were in the chrome interactive UI tests and browser tests to source sets in the extensions directory. These are things that should be cleaned up and moved there anyway.

- Net has some messy duplication in quic files. I made a dummy target for them. Apparently each copy of this file (same code, different namespace) is supposed to match something different upstream and this should be fixed.

- Moved chrome/browser/chromeos unit tests to its own target.

- Renamed chrome/browser/favicon/favicon_helper to favicon_utils. It conflicted with chrome/browser/android/favicon_helper which has an actual class named "FaviconHelper.

- Renamed service.* and service_factory.* in chrome/browser/chromeos/launcher_search_provider to have a launcher_search_provider prefix to avoid collisions with the file_system_provider one.

- Added a "chromeos" prefix to chrome/browser/chromeos/first_run/first_run_browsertest.cc to avoid collisions with the one in browser/first_run.

- Added "chromeos" to chrome/browser/chromeos/preferences_browsertest.cc to avoid collision with browser/ui/webui/options.

- Rename "chrome/browser/chromeos/drive/test_util.*" to "drive_test_util.*". Update includes. Rename chrome/browser/chromeos/file_manager/drive_test_util* to mount_test_util to avoid colliding with above new file.

The deps->public_deps changes in components/policy and content/test is because those targets were used externally in a way that this patch uncovered.

Review URL: https://codereview.chromium.org/1208963003

Cr-Commit-Position: refs/heads/master@{#338408}

Wallet address server ID is not valid UTF-8, so it cannot be used as a
sync tag or as metadata server ID. This patch base64 encodes the sync
tags and the server ID.

BUG=481595

Review URL: https://codereview.chromium.org/1220093003

Cr-Commit-Position: refs/heads/master@{#338407}

This reverts commit 3a6a03bd.

Note: Also removes now-stale dependency on "aura_test_support".

BUG=b/22410943

Review URL: https://codereview.chromium.org/1232213002

Cr-Commit-Position: refs/heads/master@{#338406}

Provider::GetString is intended to return a plain-text representation of the
contents of the paste board. On OSX, it was possible for the paste board to
contain an NSURL, but not an NSString, and as a result Provider::GetString was
incorrectly returning the empty string.

This bug manifests itself when Chrome is compiled against the OSX 10.10 SDK. I
didn't trace down the exact source of the bug, although it is likely related to
https://codereview.chromium.org/1128173004.

BUG=463170

Review URL: https://codereview.chromium.org/1235713004

Cr-Commit-Position: refs/heads/master@{#338405}

BUG=460136
TEST=manual

Review URL: https://codereview.chromium.org/1229883003

Cr-Commit-Position: refs/heads/master@{#338404}

In crrev.com/325156 I moved event invalidation logic from JavaScript into C++,
but I missed out filtered events. This CL also does some cleanup.

BUG=503913
R=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1227093008

Cr-Commit-Position: refs/heads/master@{#338403}

Currently the isolate_driver.py which creates the dependency files
used by the isolate system, does a simple split on all spaces when
trying to identify targets.

This can fail if the target name contains a space in the name. In
ninja, spaces are escaped with a $-prefix. An example would be
'Content$ Shell$ Helper.app'.

This CL adds support for such target names and ensures that they
stay as one item. Doing this uncovered a few missing dependencies
and a missing file in some .isolate-files for the component build
on Mac.

1st try: https://codereview.chromium.org/970203003/
1st revert: https://codereview.chromium.org/985753002/
2nd try: https://codereview.chromium.org/1103793002/
2nd revert: https://codereview.chromium.org/1129493003/
3rd try: https://codereview.chromium.org/1130523003/
3rd revert: https://codereview.chromium.org/1131363003/
BUG=462248

Review URL: https://codereview.chromium.org/1221333013

Cr-Commit-Position: refs/heads/master@{#338402}

Usages of MessageLoop::current() in GCM production code have been
replaced with ThreadTaskRunnerHandle::Get(). Usages of MessageLoop
in some test codes have also been replaced, but not all since we
don't have alternative to replace RunLoop.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1232193002

Cr-Commit-Position: refs/heads/master@{#338401}

aa575d4 Make CJBig2_Object::operator delete accept nullptr
07bb09f Remove a superfluous qualifier. No behavior change.

TBR=thestig
BUG=508197

Review URL: https://codereview.chromium.org/1228203005

Cr-Commit-Position: refs/heads/master@{#338400}

A custom tab client project has been mirrored in third_party. We
should add a gyp target to compile it in upstream, and delete the
downstream one.

This CL also updated java.gypi to let it take customizable
src suffix, just like java_apk.gypi.

BUG=NONE

Review URL: https://codereview.chromium.org/1222403005

Cr-Commit-Position: refs/heads/master@{#338399}

Previously a default theme could overwrite a custom theme if the default
was already synced. Now, when a user signs in to sync on a new device,
custom themes will have priority.

BUG=440232

Review URL: https://codereview.chromium.org/1229953004

Cr-Commit-Position: refs/heads/master@{#338398}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/abaaf1d..abe694c

TBR=rjwright@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1228203004

Cr-Commit-Position: refs/heads/master@{#338397}

Using --gtest_filter=-AudioInputTest.* currently results in no tests being
run, instead of "all tests except for AudioInputTest".

R=skyostil@chromium.org,cjhopman@chromium.org

Review URL: https://codereview.chromium.org/1235713003

Cr-Commit-Position: refs/heads/master@{#338396}