- 22 Aug, 2014 40 commits
-
-
jam@chromium.org authored
BUG=406574 TBR=wfh@chromium.org Review URL: https://codereview.chromium.org/475173006 Cr-Commit-Position: refs/heads/master@{#291503} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291503 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=405686 Review URL: https://codereview.chromium.org/501513003 Cr-Commit-Position: refs/heads/master@{#291500} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291500 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Revert of Omnibox: Make URLs of Bookmarks Searchable (patchset #2 of https://codereview.chromium.org/489373005/) Reason for revert: Broke interactive_ui_tests on mac: https://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20(dbg)(1)/builds/52199 Original issue's description: > Omnibox: Make URLs of Bookmarks Searchable > > This used to be controlled by a field trial created in > https://codereview.chromium.org/184663002 > > After evaluating this change, we've decided to launch it. > This change turns the flag on by default and removes the field trial code. > It also removes the index_urls_ parameters everywhere because those will > always be true forevermore. > > I tested this interactively. > Also, all the unit tests still apparently pass. And yes some of these do > exercise this feature. > > TBR=joaodasilva > (for trivial change to components/policy/core/browser/managed_bookmarks_tracker_unittest.cc ) > > BUG=157204,378854 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291445 TBR=pkasting@google.com,sky@chromium.org,pkasting@chromium.org,mpearson@chromium.org NOTREECHECKS=true NOTRY=true BUG=157204,378854 Review URL: https://codereview.chromium.org/485483003 Cr-Commit-Position: refs/heads/master@{#291496} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291496 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
BUG=406406 R=zea@chromium.org Review URL: https://codereview.chromium.org/497123002 Cr-Commit-Position: refs/heads/master@{#291494} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291494 0039d316-1c4b-4281-b951-d872f2087c98
-
pshenoy@chromium.org authored
This change also checks for another credential error message if gsutil commands were run before 'gsutil config'. BUG=399029 NOTRY=True Review URL: https://codereview.chromium.org/497823003 Cr-Commit-Position: refs/heads/master@{#291492} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291492 0039d316-1c4b-4281-b951-d872f2087c98
-
tommycli@chromium.org authored
As part of making component_updater a component, we are now moving over all the tests. Before we do that, we're copying the test data over. We are deleting it from the original spot in a separate CL. This patch will need to be dcommitted, since component1.dll file is executable bit, and CQ chokes on that. Review of this change is here: https://codereview.chromium.org/497803002/ BUG=371463 R=waffles@chromium.org Review URL: https://codereview.chromium.org/499633002 Cr-Commit-Position: refs/heads/master@{#291490} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291490 0039d316-1c4b-4281-b951-d872f2087c98
-
markdittmer@chromium.org authored
BUG=377978 Review URL: https://codereview.chromium.org/495853002 Cr-Commit-Position: refs/heads/master@{#291489} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291489 0039d316-1c4b-4281-b951-d872f2087c98
-
ericzeng@chromium.org authored
https://codereview.chromium.org/475543003/diff/160001/chrome/browser/resources/extensions/extension_list.js#newcode198 BUG=386842 Review URL: https://codereview.chromium.org/491703003 Cr-Commit-Position: refs/heads/master@{#291488} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291488 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
Now that its expected that extensions will be modifying bookmarks, we should attempt to coalesce more of their writes into a single sync cycle. BUG=401600 Review URL: https://codereview.chromium.org/478853003 Cr-Commit-Position: refs/heads/master@{#291486} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291486 0039d316-1c4b-4281-b951-d872f2087c98
-
pilgrim@chromium.org authored
Collapse fileapi, webkit_blob, webkit_database, quota, and webkit_common namespaces into single storage namespace As discussed here: https://groups.google.com/a/chromium.org/forum/#!topic/storage-dev/aQall8GOrS4 BUG=338338 TBR=cevans NOTRY=true Review URL: https://codereview.chromium.org/492873002 Cr-Commit-Position: refs/heads/master@{#291485} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291485 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
Previously, if a raster task had a resource size that was larger than the throttling limit for the raster worker, that task would never get scheduled. This leads to starvation for that task, preventing tree activation, and causing freezes. The fix is to always allow such large tasks if it is the first task. R=reveman@chromium.org BUG=403446 Review URL: https://codereview.chromium.org/489293002 Cr-Commit-Position: refs/heads/master@{#291484} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291484 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Adds os_exchange_data_win_unittest.cc to Windows (it was incorrecly excluded before). Fixed a compilation error in that file. Reland of 291154 R=sky@chromium.org Review URL: https://codereview.chromium.org/488173003 Cr-Commit-Position: refs/heads/master@{#291483} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291483 0039d316-1c4b-4281-b951-d872f2087c98
-
a.renevier@samsung.com authored
On some linux distributions, the DISTRIB_RELEASE field of /etc/lsb-release cannot be parsed as a float. In that case, consider it will be 0 R= BUG=393022 Review URL: https://codereview.chromium.org/381293003 Cr-Commit-Position: refs/heads/master@{#291481} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291481 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
This change uses a NaCl embedder interface for getting the exit status inside the loader process instead of receiving that information over SRPC. The IPC message introduced here must be synchronous so that we're guaranteed to report the exit status before the loader process exits. BUG=397161 TEST=NaClBrowserTest.ExitStatus* R=dmichael@chromium.org, jschuh@chromium.org, mseaborn@chromium.org Review URL: https://codereview.chromium.org/484783002 Cr-Commit-Position: refs/heads/master@{#291480} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291480 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
The details toggle only happens when you actually click the button now, and it no longer resizes columns and modifies the page when expanded. Instead, the details column takes over the whole row, so its easier to view and select text. R=rlarocque@chromium.org TBR=bauerb@chromium.org BUG=401323 Review URL: https://codereview.chromium.org/454573002 Cr-Commit-Position: refs/heads/master@{#291478} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291478 0039d316-1c4b-4281-b951-d872f2087c98
-
brianderson@chromium.org authored
BUG=380889 R=vmpstr Review URL: https://codereview.chromium.org/470803007 Cr-Commit-Position: refs/heads/master@{#291477} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291477 0039d316-1c4b-4281-b951-d872f2087c98
-
mek@chromium.org authored
BUG=395376 Review URL: https://codereview.chromium.org/501513002 Cr-Commit-Position: refs/heads/master@{#291476} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291476 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#291474} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291474 0039d316-1c4b-4281-b951-d872f2087c98
-
niklase@chromium.org authored
Try jobs run in https://codereview.chromium.org/501483002/ TBR=hellner@chromium.org BUG= Review URL: https://codereview.chromium.org/502563002 Cr-Commit-Position: refs/heads/master@{#291473} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291473 0039d316-1c4b-4281-b951-d872f2087c98
-
agable@chromium.org authored
TBR=szager@chromium.org NOTRY=True BUG=406454 Review URL: https://codereview.chromium.org/503453002 Cr-Commit-Position: refs/heads/master@{#291472} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291472 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
chrome://downloads. R=benjhayden@chromium.org BUG=none TEST=browser_tests Review URL: https://codereview.chromium.org/492323003 Cr-Commit-Position: refs/heads/master@{#291471} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291471 0039d316-1c4b-4281-b951-d872f2087c98
-
tommycli@chromium.org authored
As part of making component_updater a component, we are now moving over all the tests. Before we do that, we're copying the test data over. We are deleting it from the original spot in a separate CL. BUG=371463 Review URL: https://codereview.chromium.org/497803002 Cr-Commit-Position: refs/heads/master@{#291470} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291470 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
When a directory substitution in a toolchain definition expands to the empty string (i.e. it's the same as the root build directory), expand the name to "." instead of the empty string to avoid corrupting filenames. For example, if you specified "{{target_out_dir}}/foo" without this it would expand to "/foo" for the default toolchain. This removes the previous special-case hack for this case. That code only worked when the entire string expanded to the filename (when the directory was at the beginning of the string). When generating command lines, the directories will be in the middle of the string and the previous special case didn't catch them. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/497193002 Cr-Commit-Position: refs/heads/master@{#291469} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291469 0039d316-1c4b-4281-b951-d872f2087c98
-
dbdaniel42@gmail.com authored
BUG=378090 Review URL: https://codereview.chromium.org/465203002 Cr-Commit-Position: refs/heads/master@{#291468} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291468 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#291467} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291467 0039d316-1c4b-4281-b951-d872f2087c98
-
hshi@chromium.org authored
RTC video encoder and decoder now recognize H264 as a supported webrtc codec type. For H264 encoder we are required to parse NALU information to correctly populate the RTP fragmentation header. BUG=360262 TEST=trybot, manual testing see bug report R=dalecurtis@chromium.org, posciak@chromium.org, wuchengli@chromium.org Review URL: https://codereview.chromium.org/457733002 Cr-Commit-Position: refs/heads/master@{#291466} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291466 0039d316-1c4b-4281-b951-d872f2087c98
-
blink-deps-roller@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180780:180783&mode=html TBR=wibling@chromium.org,gavinp@chromium.org BUG= Review URL: https://codereview.chromium.org/502493003 Cr-Commit-Position: refs/heads/master@{#291465} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291465 0039d316-1c4b-4281-b951-d872f2087c98
-
cjhopman@chromium.org authored
Mostly just a refactoring of build rules to support prebuilt jars. Adds support for proguard preprocessing of both prebuilt and non-prebuilt java libraries. Adds definitions of all (but for android.jar) of the prebuilt jars that we need from the sdk. BUG=359249 Review URL: https://codereview.chromium.org/484813002 Cr-Commit-Position: refs/heads/master@{#291464} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291464 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
By default, PopupWindows dismiss when the user touches outside the window. The only way to avert this behavior when using a ListPopupWindow is to rely on a hidden API. This manifested as the linked bug because each tap dismissed the popup and detached it from the anchor view. C++ didn't realize the popup was dismissed, and tried to update it, but there was no anchor view. BUG=400601 Review URL: https://codereview.chromium.org/442933002 Cr-Commit-Position: refs/heads/master@{#291463} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291463 0039d316-1c4b-4281-b951-d872f2087c98
-
mpearson@chromium.org authored
Omnibox extensions don't need a default match from SearchProvider, and indeed they no longer get them following some refactoring I did last week ( https://codereview.chromium.org/476263002/ ). BUG=406026 Review URL: https://codereview.chromium.org/490383002 Cr-Commit-Position: refs/heads/master@{#291461} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291461 0039d316-1c4b-4281-b951-d872f2087c98
-
jdduke@chromium.org authored
Previously, a rect was used to convey selection bound edge geometry. This proved confusing and problematic, particularly for non-axis-aligned text. Instead, start using the bound edge points provided by Blink. This depends on the Blink change http://codereview.chromium.org/495673003/. BUG=405666 Review URL: https://codereview.chromium.org/494823002 Cr-Commit-Position: refs/heads/master@{#291460} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291460 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=305722 TBR=ben@chromium.org,pauljensen@chromium.org Review URL: https://codereview.chromium.org/498793002 Cr-Commit-Position: refs/heads/master@{#291459} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291459 0039d316-1c4b-4281-b951-d872f2087c98
-
tmandel@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/499563004 Cr-Commit-Position: refs/heads/master@{#291458} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291458 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
Review URL: https://codereview.chromium.org/486193003 Cr-Commit-Position: refs/heads/master@{#291456} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291456 0039d316-1c4b-4281-b951-d872f2087c98
-
dconnelly@chromium.org authored
BUG=394303 Review URL: https://codereview.chromium.org/489493002 Cr-Commit-Position: refs/heads/master@{#291455} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291455 0039d316-1c4b-4281-b951-d872f2087c98
-
skuhne@chromium.org authored
Functionality: The |AppRegistry| has for each running application an |AppActivityRegistry|. The |AppActivityRegistry| knows all activities associated with the application it represents. It can furthermore shut the app entirely down upon resource manager request. It will then create an |AppActivityProxy| for the overview mode which shows a placeholder for an unloaded app. This placeholder can then ask the |AppActivityRegistry| to restart the application again. A shutdown request for the application is only performed when all activities were marked for UNLOAD. If there were multiple activities upon shutdown for one app, the app has to take care of re-creating all windows and thus re-creating all activities. Since an activity match cannot be performed, the |AppActivityProxy| will only be shown once and it will show in the location of the most recently used activity of that app. If we later on find an app which really uses multiple windows and it is imperative to keep the history for all of them tact & the app is recreating them properly, (a lot of if's) we can revisit the single |AppActivityProxy| and try to address it in a cleaner way, but at this time that seems rather un-useful since it is not known if required. BUG=388085 TEST=AppActivityTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291221 Review URL: https://codereview.chromium.org/477523002 Cr-Commit-Position: refs/heads/master@{#291454} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291454 0039d316-1c4b-4281-b951-d872f2087c98
-
hubbe@chromium.org authored
Adds new call on cast_sender: SetTargetPlayoutDelay Caller is responsible for negotiating with the receiver if the extension is actually supported or not. BUG=405339 Review URL: https://codereview.chromium.org/493823002 Cr-Commit-Position: refs/heads/master@{#291453} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291453 0039d316-1c4b-4281-b951-d872f2087c98
-
petarj@mips.com authored
Use double underscore in the preprocessor symbol. Fixes build breakage caused by r291315. Review URL: https://codereview.chromium.org/495333003 Cr-Commit-Position: refs/heads/master@{#291452} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291452 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
All compositors that use SingleThreadProxy are left calling composite synchronously and now pass a flag to indicate that this is their intention. This patch doesn't remove synchronous composite, but now makes it mutually exclusive with scheduling. Only cc unittests are exercising this code at this point, although it also unifies a lot of the code for CompositeImmediately with the scheduled path. BUG=329552, 287250 Review URL: https://codereview.chromium.org/134623005 Cr-Commit-Position: refs/heads/master@{#291451} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291451 0039d316-1c4b-4281-b951-d872f2087c98
-
byungchul@chromium.org authored
1) HttpServer gets ServerSocket instead of StreamListenSocket. 2) HttpConnection is just a container for socket, websocket, and pending read/write buffers. 3) HttpServer handles data buffering and asynchronous read/write. 4) HttpConnection has limit in data buffering, up to 1Mbytes by default. 5) For devtools, send buffer limit is 100Mbytes. 6) Unittests for buffer handling in HttpConnection. BUG=371906 Review URL: https://codereview.chromium.org/296053012 Cr-Commit-Position: refs/heads/master@{#291447} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291447 0039d316-1c4b-4281-b951-d872f2087c98
-