- 31 Jul, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/88aae3b05111..471a922d82ca git log 88aae3b05111..471a922d82ca --date=short --no-merges --format='%ad %ae %s' 2019-07-31 rnasri@google.com Rename file containing speed index utility functions Created with: gclient setdep -r src/third_party/catapult@471a922d82ca The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:982025 Change-Id: I7326abfa707e9dcba356c042eeda4b3fb6381bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728314Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682793}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/34ebecc19c6b..3e493c48d2da git log 34ebecc19c6b..3e493c48d2da --date=short --no-merges --format='%ad %ae %s' 2019-07-31 lujc@google.com Vulkan: Optimize memory allocation offset rounding Created with: gclient setdep -r src/third_party/angle@3e493c48d2da The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ie43f5bfbad43a4532de66b97d3c8d903328cad46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728315Reviewed-by:
-
Alberto Herrera authored
Use the existing PeripheralBatteryNotifier to show low battery notifications of connected device::BluetoothDevice objects. This CL adds functionality to trigger for GATT connections that support the Battery Service. Also added DeviceBatteryChanged() to device::BluetoothAdapter::Observer so device::BluetoothDevice can notify about battery level changes and PeripheralBatteryNotifier gets notified about those changes. Also modified BluetoothDevice to make the battery percentage property OS_CHROMEOS-only. Design doc at go/cros-bt-battery. Bug: 785758 Change-Id: I325e6bf47032fe5fc2a7471d2a1be9850fd89030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703341 Commit-Queue: Alberto Herrera <ahrfgb@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#682791}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/da479f0f..f99c5871 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I780029053456bc56208d9de89c711651d6cd64b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729569Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682790}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=fdoray@chromium.org Bug: 968047 Change-Id: I3451c35ce8c86d97fadac722781c92142be0d905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728586 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Gabriel Charette <gab@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#682789}
-
Sergio Villar Senin authored
It's using doubles to represent seconds in StartPageScaleAnimation(). Switched to base::TimeDelta to represent durations. This change in the interface forced the updates of specific implementations as RenderWidget::StartPageScaleAnimation or WebViewImpl::StartPageScaleAnimation. This also had the nice side effect of forcing some other changes in other interfaces that had to be replaced as well, see WebView::SmoothScroll(). Bug: 988343 Change-Id: I9510d059e6612c99a5c8de865e59186a5ff9ac20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724750 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#682788}
-
Wei-Yin Chen (陳威尹) authored
Bug: 964406 Change-Id: I90568c78ebd510cd540074daf0a3adeb2c089da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726833 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#682787}
-
Vasiliy Telezhnikov authored
Bug: 987278 Change-Id: I59c71cecba1d0e14d1977230148db0bde477a1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728431 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#682786}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/97e015fa8e5a..d0b67c2a70b3 git log 97e015fa8e5a..d0b67c2a70b3 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1443fbac..6ba1e902 (682581:682701) 2019-07-31 hta@webrtc.org Make ID of datachannel stats not depend on dc.id Created with: gclient setdep -r src/third_party/webrtc@d0b67c2a70b3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I0815a7953f37d36f4a91061daa9665c8114baf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729199Reviewed-by:
-
John Budorick authored
This allows //build/android/test_runner.py to run an AVD on which it can run tests. Change-Id: I653a9e2e351ced1914c471e83aab3f6c0dc8d508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699274Reviewed-by:
Yun Liu <yliuyliu@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#682784}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: I8672f3c6c091b287c90c8d9dfcd1ff4881770c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728409 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682783}
-
Robert Liao authored
//chrome/browser/ui/views/hats/OWNERS points to //chrome/browser/ui/hats/OWNERS BUG=979530 Change-Id: Iada4ec0c50bedd28ab148de93384522b03cc4300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726662 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#682782}
-
Arthur Hemery authored
This CL removes most of the references to PlzNavigate in the comments of chrome/. Some problematic cases where further expertise is needed are left out, but this covers more than 90% of the references. Change-Id: Ibc3876e07bf9bf8eef0838757ae1db4a77d38eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729161Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#682781}
-
David Bokan authored
This helps specifically with <select> drop downs as they listen for the mouse events rather than click. Likely to help in a few other cases as well. Bug: 988925 Change-Id: Ia3ae3c447caff6bc0d47303cda4dcd74ee5d1555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726668Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#682780}
-
Owen Min authored
Disable CredentialProviderSigninDialogWinIntegrationDesktopVerificationTest .DialogFailsToLoadOnIncorrectDesktop because it's flaky. Bug: 987508 Change-Id: Ibd3da5b371edd7d7bb7add7d3d71da607229a7a1 Tbr: tienmai@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729510Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682779}
-
Eugene But authored
Replaced code which waits for PassKit UI presentation for EG2. EG1 still relies on checking for presented UIViewController, while EG2 can use XCUITest API to test that "Toy Town Membership" element (pkpass title) is displayed. Bug: 987646 Change-Id: I7295aa58538100957eb438ea5d5972ec9628a5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727732 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682778}
-
Toni Barzic authored
This is a reland of d4425b7d TBR=xiyuan@chromium.org Original change's description: > app_list: Make search result actions views keyboard accessible > > Summary of changes: > * Added methods for keeping track of currently selected action, and > for moving the selection to SearchResultActionsView > * Added SearchResultActionsViewDelegate:: > OnSearchResultActionsUnSelected so the result view can handle the > case where actions are un selected - primarily, it sends out a > a11y notification that the default action (that activates the > search result) is selected again > * Renamed SearchResultBaseView::SetBackgroundHighlighted to > SetSelected, and added logic for setting initial selected result > action, or clearing action selection. (the latter is protected by > SearchBoxSelectionEnabled feature). > * Added SearchResultBaseView::SelectNextResultAction - used by result > selection controller to move the action selection if needed. > * Note: The SearchResultBaseView implementations are expected > to call newly added set_actions_view to register their result > actions - otherwise this method will be no-op > * ResultSelectionController::ResetSelection avoids clearing and > setting selection again if the view that should be selected is > already selected > > BUG=986382 > > Change-Id: I9932e9c44abe546b71fbcbf1488c9ac076ae5c84 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713223 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680507} Bug: 986382 Change-Id: Ie15d7bf6ac7ff82597e876619d451ee2d9466840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726411Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#682777}
-
Matt Menke authored
Bug: 966896 Change-Id: I3487a844817f307ebeb1a830f27910fe21dea635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721433 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682776}
-
Tomasz Wiszkowski authored
Purpose of this histogram is to tell us how frequently each entity decoration type is selected. Current decorations include Image (expected to be most common), fallback dominant color and search icon (dominating on low-end devices where we plan to show no images). Bug: 987752 Change-Id: I43d1fdd331ecebee09327a7f6a1728abf2244c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719306 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#682775}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. TBR=caseq@chromium.org Bug: 968047 Change-Id: Icec07c2acaf89d4a2fc7d833f8144e31bbef6ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729212 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#682774}
-
Stepan Khapugin authored
Currently when a user pastes into the omnibox when it's pre-editing, it exits pre-edit from -textField:shouldReplaceCharactersInRange:withString: delegate method. Exiting pre-edit either erases the text, or selects all text. However, this confuses the textfield's undo manager, making it believe that the paste's undo action is replacing an incorrect previous string with the pasted string. Attempting to undo after paste can cause a crash. By exiting pre-edit before the paste happens, the undo manager handles paste's undo correctly and doesn't crash. Bug: 984615 Change-Id: I3e8f5317c9db1279a1955c23fe3f0ac08db9aefd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729071 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682773}
-
Matt Simmons authored
R=wychen@chromium.org Bug: 988095 Change-Id: I5b8cc46911e6e417d8d76cc3dce246c2327415f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726910Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#682772}
-
Lei Zhang authored
Several files includes gmock.h but does not use GMock. Remove the gmock.h include, or replace it with gtest.h. Change-Id: Id1c1928365ff0124c80c0f7baaaa2388c530472a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727471Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#682771}
-
Pâris MEULEMAN authored
This is a quickfix for the linked bug. The exact root cause (why the certificate is empty) is unknown but it seems related to HTTP 302s. Bug: 989478 Change-Id: I056ab03fb26d5acceb878826b856fed76af2fae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729228 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#682770}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe125a11032d..1a607e7b6e9a git log fe125a11032d..1a607e7b6e9a --date=short --no-merges --format='%ad %ae %s' 2019-07-31 robertphillips@google.com Add LUM8 case to GrGLCaps::getYUVAColorTypeFromBackendFormat Created with: gclient setdep -r src/third_party/skia@1a607e7b6e9a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I7483cf7a57829d773c96b0c1a726894961e47a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729318Reviewed-by:
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=joedow@chromium.org Bug: 968047 Change-Id: Ibb470fb0045a08ad87237d4a07961182b6eb27e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729215 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#682768}
-
Maxim Smirnov authored
This feauture allows to reload broken (substituted with alt-text and placeholder) images with "Load image" context menu item. Experiment with this feature was successfully conducted in Yandex.Browser so it is suggested to turn this feature on by default. R=avi@chromium.org Bug: 603 Change-Id: I5fe9854ed46b94b2528c376a4d112faa1e0e8494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715809Reviewed-by:
-
Peter K. Lee authored
This adds an experimental settings (via iOS Settings) to test the display of a "Updated ToS" notification using What's New promo space on NTP. Also replaced antiquated use of NULL with nullptr. Bug: 989351 Change-Id: Icb5adf49237f62ff6808e6dbebd0848a75278f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727690Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#682766}
-
Michael Liao (WPT) authored
Changes: - Fixing grdp strings in ui_strings and profiler_strings Reason: - Profiler string needed an update to remove 'bytes' - Two CLs requiring a 'var1, var2' localized string checked in at the same time, so we need to remove one. Change-Id: I4a32629959453048229784b4efdc445960273385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726952Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Michael Liao <michael.liao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#682765}
-
Wez authored
This reverts commit 053b22e8. Reason for revert: This appears to have made CacheStorageManagerTest.TestErrorInitializingCache flaky - see https://crbug.com/989313 Original change's description: > CacheStorage: Write index after simple disk_cache. > > When we load the cache_storage index we try to determine if its fresh > or stale by comparing its timestamp against the timestamp of the > various simple disk_cache directories. Both cache_storage and simple > disk_cache write their index files out using a delay. The > cache_storage delay is 5 seconds and the simple disk_cache delay is 20 > seconds. This means that the simple disk_cache index is always written > last and as a result the cache_storage index is almost always > considered stale. > > This CL fix this by extending the cache_storage delay to match the > simple disk_cache delay. It also implements a shorter delay on android > when in the background like simple disk_cache uses to avoid losing > data when the app is killed by the operating system. Finally, the CL > also now properly flushes the index to disk if there is a pending write > when the cache_storage subsystem is torn down. > > Over time this should cause ServiceWorkerCache.UsedIndexFileSize to > show more cases where the index file is used to provide the size. > > Bug: 988001 > Change-Id: Idaa09b956edcfa9e70ac1fdb9b43adcd73ec0508 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721389 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682409} TBR=dmurph@chromium.org,wanderview@chromium.org Change-Id: Ic0c766da0b704c6f0c48ed8a46dd97133d09b290 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 988001, 989313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729057Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#682764}
-
Sean Gilhuly authored
vulkan_swiftshader_content_browsertests is a copy of vulkan_content_browsertests above it, but with --use-vulkan=swiftshader. Run this test on the Linux Viz fyi bot. Previously, this test would fail if GPU compositing was blacklisted. Mark |use_swift_shader| if SwiftShader Vulkan is used to force enable GPU compositing for tests. Bug: 969848 Change-Id: Ibcdb3c560bf36fe4ec0e60c035b5f8f71c7027c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692029 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit bfca9d67. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 682731 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JmY2E5ZDY3NWM1MjQ4NDNiOGJiNmEwZDAxNGUyOWQ0ZDY4NTkwNTYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win-archive-rel/3468 Sample Failed Step: compile Original change's description: > Remove references to MessagePump::Type > > It is going away soon, replace with the real thing: MessagePumpType > > Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h). > > This is a mechanical change that will be reviewed according to > https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes > > Bug: 891670 > TBR=gab@chromium.org > > Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682731} Change-Id: Idf6e0f69a07267d3a322c700882d2b3f65dcf021 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729553 Cr-Commit-Position: refs/heads/master@{#682762}
-
Kristyn Hamasaki authored
-SetPlaceholderText, GetInvalid, SetSelectedRange, and GetAccessibleName Bug: 979037 Change-Id: I0a8430aa85cddc6543345869ca7c0fe47d3cc7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680918Reviewed-by:
-
Antonio Gomes authored
BUG=NONE R=haraken@chromium.org Change-Id: I07e5d3c33561fb9075846b9e4be416e195f6f169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729390 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#682760}
-
Owen Min authored
This reverts commit e9ddea61. Reason for revert: AppWindowBrowserTest.ShouldShowStaleContentOnEviction is flaky. https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVwsSBUZsYWtlIkxjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEFwcFdpbmRvd0Jyb3dzZXJUZXN0LlNob3VsZFNob3dTdGFsZUNvbnRlbnRPbkV2aWN0aW9uDA Original change's description: > Fix evicted app windows showing as empty in overview > > The Files app, as well as other apps, if they're evicted due to > being occluded by other windows, will show as empty for a second or > more in overview until reloaded. > > This CL makes them behave the same way as browser windows, that is > they show stale contents until reloaded. > > BUG=986085, 866622 > TEST=Manually, follow steps on bug, and note the issue no longer shows. > > Change-Id: If9a2b26b914fe55672d15d4b560cbe6d7e996591 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711843 > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682390} TBR=sky@chromium.org,kenrb@chromium.org,lazyboy@chromium.org,rockot@google.com,afakhry@chromium.org,kylechar@chromium.org Change-Id: I7772e1ab6134a02d2cd6ad1d312623b424339693 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986085, 866622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729511Reviewed-by:
-
Abhishek Bhardwaj authored
This change checks for network presence before doing an update check. This prevents for unnecessary tries and time outs when the device wakes up in response to a scheduled update check policy and the policy server is queried incessantly without any network being associated immediately. BUG=924762 TEST=Unit tests. Change-Id: I28ce4bd1be306d52e8561238da63421d725b6869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722152 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#682758}
-
Chase Phillips authored
This reverts commit 6053bbb2. Reason for revert: <INSERT REASONING HERE> Original change's description: > IndexedDB: Refactor AddCursorBinding into CreateCursorBinding > > As part of cleanup from CL https://crrev.com/c/1626660, this CL > moves creation of CursorImpl into IndexedDBDispatcherHost by > refactoring AddCursorBinding into CreateCursorBinding. > > As a result, the OpenCursor calling path no longer needs to pass > the origin and sequenced task runner into the OpenCursorOperation > task and ownership of CursorImpl and the mojo binding steps is > made simpler. > > Bug: 988868 > Change-Id: Iab0be1d24d98fc6b0088d01c67c1b778c5c13318 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725318 > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Commit-Queue: Chase Phillips <cmp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682428} TBR=cmp@chromium.org,dmurph@chromium.org Change-Id: Ibb40173fcc8941794663af59ec4beee48d073cf3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 988868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729552Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#682757}
-
Yun Liu authored
Bug: 988056 Change-Id: Ib35a813214ef429213f2c05cccc6d62a63f7ecbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725256Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#682756}
-
Orin Jaworski authored
This CL enhances the chrome://omnibox batch export data to include variation and path info provided by VersionHandler. It also cleans up the use of private |loadTimeData.data_| by using |getValue| with an explicit selection of relevant fields. Bug: 964528 Change-Id: I531a001cdf2e4985b82b206fc52fcad28b0e05ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725551 Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#682755}
-
Ben Pastene authored
R=jbudorick, dpranke, tikuta, agable Change-Id: Ia2a8f2965781fc2d71f14f3142f6e8e155d49dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728038Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#682754}
-
