- 05 Feb, 2019 40 commits
-
-
Kunihiko Sakamoto authored
Bug: 813452 Change-Id: I4e267b3815eb111b0149a26652b2d80aac2ff64c Reviewed-on: https://chromium-review.googlesource.com/c/1454101Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#629093}
-
Julie Jeongeun Kim authored
This CL only migrates OAuth2LoginManager production code away from ProfileOAuth2TokenService. It uses IdentityManager instead of directly accessing to OAuth2TokenService and AddOrUpdateAccount instead of UpdateCredentials. Bug: 905282 Change-Id: I76722ae693285844f774856d2e0a0a5cd303f422 Reviewed-on: https://chromium-review.googlesource.com/c/1412776Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim(Holidays Feb 04-06) <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#629092}
-
Morten Stenshorne authored
TBR=eae@chromium.org Bug: 915204, 928405 Change-Id: I23d5df06b57b0699735b80179f24d11bb8a34a10 Reviewed-on: https://chromium-review.googlesource.com/c/1454517Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#629091}
-
Askar Aitzhan authored
It was crashing because there was no primary user so we got a nullptr dereference when using GetPrimaryUser(). TBR=poromov@chromium.org Bug: 928596, 875205 Change-Id: I47cd1e2b002bc37a2170fc5c355c1df205444197 Reviewed-on: https://chromium-review.googlesource.com/c/1454499Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#629090}
-
Makoto Shimazu authored
Flipping the flag revealed a couple of issues which were fixed: - OnTransferSizeUpdated(): https://crrev.com/c/1454344 - One more PostTask() made tests more flaky: https://crrev.com/c/1454345 I hope third try will go well. Bug: 894819 Change-Id: Icc6159622aacd5c4a4c250a0834bf4c3641d916a Reviewed-on: https://chromium-review.googlesource.com/c/1454062 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Change internals of components/prefs to use base::Value by value instead of wrapped in std::unique_ptr<> (as a step towards using base::Value as value everywhere). Add new override for RegisterListPref and RegisterDictPref that takes the base::Value by value instead. Remove unused parameter in OnPrefRegistered virtual method (the only override was not using it) as passing a pointer to the newly inserted base::Value required an additional query of the store. Bug: 646113 Change-Id: I631157155f39ef269fb89f896f527b5899637ebf Reviewed-on: https://chromium-review.googlesource.com/c/1451934Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#629088}
-
Lowell Manners authored
FakeGaiaCookieManagerService has been eliminated in favor of setting expectations using TestURLLoaderFactory. This is part of step 6 of the plan to eliminate FakeGCMS entirely: https://docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit TBR=treib@chromium.org,pkasting@chromium.org,thakis@chromium.org Change-Id: Ie56970341e6309e5fb3d6cb561ecda657c2d373f Bug: 907782 Reviewed-on: https://chromium-review.googlesource.com/c/1448151 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#629087}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Idb748b2f95c82c89e0e4a2a6846fb6221cdf5586 Reviewed-on: https://chromium-review.googlesource.com/c/1451884Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#629086}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I01545fd1e2a96ecbb12592449323355a3f062dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1451920Reviewed-by:
-
Eric Seckler authored
Change-Id: If0008c4455008050764efa1935af2473d438c063 Reviewed-on: https://chromium-review.googlesource.com/c/1451857 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#629084}
-
Hiroki Nakagawa authored
This CL renames ServiceWorkerProviderInfoForSharedWorker to ServiceWorkerProviderInfoForWorker so that it's reusable for dedicated workers. Bug: 906991 Change-Id: I2337d0674c07fe48f0f5f6896e7a86c9e498f26e Reviewed-on: https://chromium-review.googlesource.com/c/1454162Reviewed-by:
-
Sami Kyostila authored
This patch removes the experiment to enable the SequenceManager on the renderer main thread (i.e., in Blink). Since the old MessageLoop implementation was recently removed, the "disabled" arm of this experiment is now testing a nonsensical configuration (SequenceManager-on-SequenceManage). TBR=bcwhite@chromium.org Bug: 891670 Change-Id: Ic3607bef3de356491a433a6bff50a74331adf821 Reviewed-on: https://chromium-review.googlesource.com/c/1451849Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#629082}
-
Yuki Shiino authored
This reverts commit 350d5c9f. Reason for revert: This patch is suspicious to have caused failure at PrerenderBrowserTest.PrerenderHttpAuthentication in network_service_browser_tests on Linux. Not 100% sure, but allow me to try to revert this patch. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/56211 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8922409938287938432/+/steps/network_service_browser_tests/0/logs/PrerenderBrowserTest.PrerenderHttpAuthentication__status_CRASH_/0 Original change's description: > Make content::LoginDelegate single-threaded and uniquely-owned > > After all the preceding cleanup, every LoginDelegate is now a > straightforwardly-owned UI-only loader with an ad-hoc IO/UI proxy > in front. Shift the //content interface to just the former and drop > all the ad-hoc proxy bits. Within //content... > > In the ResourceLoader path, this pushes the IO/UI hop to RDH. It's > the same thread hops, but only written once. > > In the network service path, we don't need a thread hop at all, so > this simplifies things and saves a UI/IO round-trip. > > Bug: 908926 > Change-Id: Ica47c94f1e20cf071687b5ac413e79328ccf4fc8 > Reviewed-on: https://chromium-review.googlesource.com/c/1388164 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628925} TBR=davidben@chromium.org,jam@chromium.org,torne@chromium.org,mmenke@chromium.org,carlosil@chromium.org Change-Id: I3cfbbc126490dfb0d156725c4cab59b3eb36b3a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908926 Reviewed-on: https://chromium-review.googlesource.com/c/1454167Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#629081}
-
yoshiki iguchi authored
We have decided not to ship this for M73, so this CL disables it by default. I will revert this CL after it gets merged in the M73 branch. R=tetsui@chromium.org TBR=oshima@chromium.org (as owner) TBR=manucornet@chromium.org Bug: 938666 Test: none Change-Id: I496b0c2c312b96ce6b8a7dd3fd1bd4a66a478bf2 Reviewed-on: https://chromium-review.googlesource.com/c/1454063Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Auto-Submit: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#629080}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d8591790. With Chromium commits locally applied on WPT: c64e59c2 "Deflake RTCPeerConnection-track-stats.https.html." 14c11107 "Implement `Sec-CH-Lang`" c49d046d "Initial support for WorkletAnimation.playbackRate" 70938d55 "Fix remaining preload tests flaking on wpt.fyi" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If54786317ff8a685113b86fca831bd8bb99cbbae Reviewed-on: https://chromium-review.googlesource.com/c/1454219Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629079}
-
Fredrik Söderquist authored
CSSPrimitiveValue::ComputeLength<Length> does not handle a mix of percentages and non-percentages (treating them all as the latter). The right function for that is ConvertToLength. However, since we're handling <length-percentage> | auto here (after checking for <number>), just forward to StyleBuilderConverter::ConvertLengthOrAuto. This should fix all the properties that use the CSSQuadValue representation for nine-piece images and have a <length-percentage> in their syntax (border-image-width and -webkit-mask-box-image-width). Bug: 918994 Change-Id: Ic29c8ec023d29d1e64eca2e0372e9e90611bbe73 Reviewed-on: https://chromium-review.googlesource.com/c/1451978Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#629078}
-
Yuki Shiino authored
This reverts commit d8ec7dbd. Reason for revert: This patch is suspicious to have caused failure at Dav1dVideoDecoderTest in media_unittests. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/12634 Original change's description: > Reland: Add dav1d decoder and build configurations. > > PS#1 is the original change, the latest PS disables assembly > for MSAN and fixes up the .gitignore file. > > -----------[Original Description Below]----------- > We're planning to experiment with av1 decoders, so this change > adds support for dav1d in Chromium. > > This sets up the dav1d repo per modern 3rd party style: It's a > read-only clone of dav1d's GitHub mirror with the build config > and helper scripts living in the main Chromium src.git repo. > Due to this configuration, no local patches can be made. > > Two helper scripts have been added "generate_configs.py" and > "generate_source.py". The former requires a few dependencies > spelled out in the README.chromium. The latter works simply > by globbing some source patterns into GN variables. > > Thus far it seems all posix configurations (mac, linux, CrOS) > can share the same config, so only support linux and windows > in x86, x64 configurations has been added. > > ARM support is not enabled yet since we haven't enabled libaom > for ARM and similarly dav1d is lacking much of the SIMD code. > > To wire everything up this also: > - Adds a media::VideoDecoder based implementation and unit test. > - Adds a disabled-by-default Dav1dVideoDecoder base::Feature. > > TBR=jam,liberato,mmoroz > > Bug: 924370, 928357 > Change-Id: I0e921599830d6e52019106e3ad42672873c94ece > Reviewed-on: https://chromium-review.googlesource.com/c/1452782 > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628921} TBR=dalecurtis@chromium.org,jam@chromium.org,liberato@chromium.org,mmoroz@chromium.org Change-Id: I08a969e9d221bf8a3b2128f83cd14080da8c7139 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924370, 928357 Reviewed-on: https://chromium-review.googlesource.com/c/1454100Reviewed-by:
-
Yuki Shiino authored
Bug: 865477, 923269 Change-Id: Ic94ab753e1bdf2cf910f8e2147be94bb886831b0 TBR: yukishiino@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/1454166Reviewed-by:
-
Robbie McElrath authored
Bug: 911287 Change-Id: I60032f514adb17310e9341e2dbeec490323fd11e Reviewed-on: https://chromium-review.googlesource.com/c/1453336 Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Fix screenshot being saved on MyFiles instead of MyFiles/Downloads for new users. CrOS in the device, new user starts with default download folder as: /home/chronos/user which has to be migrated, to /home/chronos/u-${HASH}/MyFiles/Downloads once DownloadPrefs is aware of user's profile. Before this CL it was migrating to /home/chronos/u-${HASH}/MyFiles which is the new volume root, but isn't user's Downloads folder. Note that in the unit_test and browser_tests the initial download ISN'T /home/chronos/user but a temp generated directory e.g.: /tmp/.org.chromium.Chromium.F0Ejp5. For this reason moved |old_base| to be an parameter in |MigratePathFromOldFormat| to make testing easier and the only user of this function is DownloadPrefs which actually provides the value for |old_base| from method: GetDefaultDownloadDirectory(). Bug: 926128 Change-Id: Iece20f635068998198934956a81323029e37ee74 Reviewed-on: https://chromium-review.googlesource.com/c/1447262Reviewed-by:Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629074}
-
Makoto Shimazu authored
This is cherry-picking the change made on https://crrev.com/c/1449441, expect for enabling ResourceLoadViaDataPipe. TBR=yhirano@chromium.org, kinuko@chromium.org Bug: 894819, 927184, 926849 Change-Id: I229d09a68bd08722b42046c15e5a5243695eff94 Reviewed-on: https://chromium-review.googlesource.com/c/1454345Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#629073}
-
Jun Mukai authored
I've noticed that this SetCanFocus() method has been there for a while but nobody is using it. I believe this is not used anymore. Bug: none Test: none Change-Id: Ifb041c696ce4c08a6fc0b45bea35ee3b6c3516f9 Reviewed-on: https://chromium-review.googlesource.com/c/1447315Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#629072}
-
Yusuf Ozuysal authored
This adds a new UI component that shows the current tabs in a TabModel in a grid layout. The component allows the tab list within the model to be resetted via a public call. The classes that start with TabList- can be used for other UI that are based on a list of tabs. The changes here are to be moved to its own module in a follow up CL before branch cut. Change-Id: I60a332df8e6f3f69a07742ad29f94debabf9dd03 Binary-Size: Increase is temporary until this experimental feature is moved to a dynamic feature module Reviewed-on: https://chromium-review.googlesource.com/c/1423162 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#629071}
-
Makoto Shimazu authored
This CL fixes URLLoaderClientImpl::NeedsStoringMessage() by taking |accumulated_transfer_size_diff_during_deferred_| into consideration. I hope this fix crashes around NotifyResourceTransferSizeUpdated() when ResourceLoadViaDataPipe is on. Test: ./third_party/blink/tools/run_web_tests.py -t Debug -f external/wpt/webvtt/parsing/file-parsing/tests/header-regions.html --iteration=100 Bug: 926849, 894819, 927184 Change-Id: If5da458dd9eba29c0b47b458a5a09f90b3646b38 Reviewed-on: https://chromium-review.googlesource.com/c/1454344 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
We removed MemoryCoordinator from codebase. Let's remove the flag too. Change-Id: I458b1d12b7415163437b439b1cb0208412a2223e Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/c/1454098 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 14573 14575 14577 14579 14583 14603 14608 14635 14640 14646 14664 14677 14686 14693 14699 0 lines were removed and 2 lines were deflaked by consecutive results since 14579. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I6d3cb955d3f09804cec72045f3ca238b1b6e1945 Reviewed-on: https://chromium-review.googlesource.com/c/1449476Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629068}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/afc37154aa31..e62d2e1b75b0 git log afc37154aa31..e62d2e1b75b0 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 ahassani@chromium.org cros_flash: Add an --experimental-au flag 2019-02-05 saklein@chromium.org Build API: Add chroot assertion options Created with: gclient setdep -r src/third_party/chromite@e62d2e1b75b0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8d77fa5ea027a36c0415f110e74cfa73a6072603 Reviewed-on: https://chromium-review.googlesource.com/c/1454416Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629067}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb890a49b67c..0f9db0f81173 Created with: gclient setdep -r src-internal@0f9db0f81173 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I75bb932987af569d0892c74ecf22de917062091d Reviewed-on: https://chromium-review.googlesource.com/c/1454417Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629066}
-
Yuki Shiino authored
This reverts commit 8bd694d0. Reason for revert: This patch is suspicious to have caused failure at WorkingSetTrimmerTest.K32EmptyWorkingSet in unit_tests. https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/74695 Original change's description: > RC: Move the graph to chrome/browser/performance_manager. > > This moves the resource coordination graph implementation from > the resource coordinator service into > chrome/browser/performance_manager and redirects users thereof. > This is a first enabling step in refactoring, renaming and > consolidating the resource coordinator implementation. As such, > this CL aims for minimal code churn. > > Bug: 910288 > Change-Id: I322a6a1ee3704384838abc3e1953a885ba038466 > Reviewed-on: https://chromium-review.googlesource.com/c/1446814 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628911} TBR=nasko@chromium.org,thakis@chromium.org,rockot@google.com,fdoray@chromium.org,siggi@chromium.org Change-Id: I7ed1553923c517184a2665ac22f4b72bbc27771e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910288 Reviewed-on: https://chromium-review.googlesource.com/c/1454197Reviewed-by:
-
Yuki Shiino authored
This reverts commit 27bdec41. Reason for revert: This patch is suspicious to have caused failure at ManagedUIHandlerTest in unit_tests. https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20CFI/builds/12632 Original change's description: > Disable managed UI for Unicorn accounts > > Bug: 924836 > Change-Id: Ib03b926e770adcfe8678ee64ec2094c117724314 > Reviewed-on: https://chromium-review.googlesource.com/c/1436141 > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628790} TBR=msw@chromium.org,michaelpg@chromium.org,menegola@chromium.org,nicolaso@chromium.org Change-Id: I1cadade31b09cbc6290b41686811f9630ec24c7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924836 Reviewed-on: https://chromium-review.googlesource.com/c/1454343Reviewed-by:
-
Robbie McElrath authored
Migrate FileManagerPrivateSearchDriveFunction from NetworkChangeNotifier to NetworkConnectionTracker Bug: 911287 Change-Id: Id7ee3577f6ec2cbab2b676ddfaed81db7ee971f3 Reviewed-on: https://chromium-review.googlesource.com/c/1453360Reviewed-by:
-
Alli Murray authored
Change-Id: I6bd0a19e85718f5def3694786cc1b52be5d659d8 Reviewed-on: https://chromium-review.googlesource.com/c/1454096 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#629062}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bb60677d5244..0783aca7ba31 git log bb60677d5244..0783aca7ba31 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@0783aca7ba31 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I48c0f7dcd3c5bffb33e9841151486bc7a4168e65 Reviewed-on: https://chromium-review.googlesource.com/c/1454276Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbd0f4fe6259..cb890a49b67c Created with: gclient setdep -r src-internal@cb890a49b67c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0517f11c3956e6dbdf08b3507d8d8b1aa84ff75e Reviewed-on: https://chromium-review.googlesource.com/c/1454079Reviewed-by:
-
Kenichi Ishibashi authored
This isn't used. Change-Id: Ic0b07db67891859bcca1afa0b3e937cd0b84accc TBR: chrisha@chromium.org Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/c/1454338Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#629059}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/edbea46295b8..30b182aca08a git log edbea46295b8..30b182aca08a --date=short --no-merges --format='%ad %ae %s' 2019-02-05 nisse@webrtc.org New methods for registering network change callbacks in MediaTransport 2019-02-05 sukhanov@webrtc.org Make AudioSendStream to be OverheadObserver 2019-02-04 dminor@webrtc.org Compare GetStreamCaps against S_OK 2019-02-04 mbonadei@webrtc.org Remove TCPPort incoming_only_ member. 2019-02-04 nisse@webrtc.org Delete VCMNackFecTable; appears unused for a long time. Created with: gclient setdep -r src/third_party/webrtc@30b182aca08a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1e0a5a43daf0cb8c23d1402566d0a7f195db9681 Reviewed-on: https://chromium-review.googlesource.com/c/1453583Reviewed-by:
-
Eugene But authored
Test verify that |UpdateCertificatePolicyCache| correctly updates CertificatePolicyCache from another BrowserState. Bug: None Change-Id: I8b44fa7a391f0935ed256e3aaf2143fb125ad043 Reviewed-on: https://chromium-review.googlesource.com/c/1451423Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#629057}
-
Joel Hockey authored
Support replacing $i18nRaw{} in addition to $i18n{}. Fix 'textDirection' as used in text_defaults.css. Change-Id: I1f9b5c97ba28e69f35c42f55ae08b12df9eb9842 Reviewed-on: https://chromium-review.googlesource.com/c/1454059 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by: -
Rakina Zata Amni authored
Some callers might pass null/collapsed ranges to FindBuffer, which ends in a crash due to non-existing StartPosition. This change makes the callers check before calling. Bug: 927034 Change-Id: Ie0c3c121161b418f0cd2d1902e15e8f50384f4f6 Reviewed-on: https://chromium-review.googlesource.com/c/1452016Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#629055}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7085305f6eda..d01c504e0c18 git log 7085305f6eda..d01c504e0c18 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 jmadill@chromium.org Fix issues with config whitelisting. 2019-02-05 courtneygo@google.com Do not call eglMakeCurrent with invalid parameters Created with: gclient setdep -r src/third_party/angle@d01c504e0c18 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:928583 TBR=geofflang@chromium.org Change-Id: If151d780532cdd4728795b331c1f898faa5f7d49 Reviewed-on: https://chromium-review.googlesource.com/c/1454077Reviewed-by:
-
