GitLab

TBR=oilpan-reviews
BUG=488628
NOTRY=true

Review URL: https://codereview.chromium.org/1327193002

git-svn-id: svn://svn.chromium.org/blink/trunk@202004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

... so that Device Pixel Ratio does fit.

BUG=529744
TBR=caseq

Review URL: https://codereview.chromium.org/1310873005

git-svn-id: svn://svn.chromium.org/blink/trunk@202003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=504537

Review URL: https://codereview.chromium.org/1327593005

git-svn-id: svn://svn.chromium.org/blink/trunk@202002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201990

BUG=492871
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/1323313005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@202001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201968

TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1329063004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@202000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201961

TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1310513012 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201962

BUG=529530
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1322933007 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201983

BUG=492871
TBR=szager@chromium.org

Review URL: https://codereview.chromium.org/1311543007 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When https://codereview.chromium.org/1329863002 landed the flakyness has
been fixed. This CL is updating the expectations accordingly.

BUG=528110

Review URL: https://codereview.chromium.org/1305933008

git-svn-id: svn://svn.chromium.org/blink/trunk@201996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Disable SVG tests that exercise zero length path segments
with round or square end caps that change the drawing
when Skia is patched to perform the same actions natively.

R=fmalita@chromium.org
BUG=529845

Review URL: https://codereview.chromium.org/1315883003

git-svn-id: svn://svn.chromium.org/blink/trunk@201995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch extends compositions to be able to span multiple nodes.  This involves
two main changes: first, compositions are switched to being stored as a Range, not
a Node plus two offsets.  Second, the underline painting now uses DocumentMarkerController
(which is already multi-node) instead of a custom composition-specific path.

As a result, we can remove the hack in setCompositionFromExistingText that clobbered
the text to shoehorn it into a single node, which would cause style loss.  This
is now able to span the existing text regardless of how complicated it is.

TEST=webkit_unit_tests --gtest_filter=DocumentMarkerControllerTest.UpdateRenderedRectsForComposition
TEST=webkit_unit_tests --gtest_filter=WebViewTest.SetCompositionFromExistingTextInRichText
BUG=488628

Review URL: https://codereview.chromium.org/1325563002

git-svn-id: svn://svn.chromium.org/blink/trunk@201994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change is about being more strict about applying style changes in tree
order: first adjust the relationship to the ancestry, THEN adjust the children.

This order is important if a multicol container has a child out-of-flow
multicol container with a spanner, and this child is changed to become in-flow
at the same time as it ceases to be a multicol container, and instead becomes a
spanner. If we change it from multicol to spanner first (instead of making it
part of the outer multicol container first), the outer multicol container is
going to believe that it contains the inner spanner, and we'd end up with a
spanner inside another spanner, which isn't allowed.

#a - multicol
  #b - abspos multicol, changing it to static spanner
    #c - spanner (but it should become a regular block once #b becomes a spanner)

The effect of this fix is that we swap the ordering of notifying the flow thread
about descendant style changes (flowThreadDescendantStyleWillChange(),
flowThreadDescendantStyleDidChange()), compared to when handling style changes
locally on the object (styleWillChange(), styleDidChange()) takes place. More
specifically, we need to get to flowThreadDescendantStyleDidChange() first
(which registers or unregisters descendants in the flow thread - i.e. updates
the LayoutMultiColumnSet / LayoutMultiColumnSpanner placeholder structure), and
THEN to evacuateAndDestroy() (via LayoutBlockFlow::styleDidChange() and 
createOrDestroyMultiColumnFlowThreadIfNeeded()), instead of the other way around.
This way we register #b (now a spanner) in #a first. That will prevent #a from
seeing anything inside #b (spanners are rather opaque).

Since we're now notifying the flow thread from LayoutBox instead of
LayoutObject, we can change the style change notification methods to take
LayoutBox instead of any kind of LayoutObject. The flow thread only cares about
LayoutBox or better here anyway. This allows for some cleanup in the
notification methods, since we no longer need to worry about computed style
weirdness on text layout objects.

BUG=516532
R=eae@chromium.org,jchaffraix@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/1320843005

git-svn-id: svn://svn.chromium.org/blink/trunk@201993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

libxml 2.9.0 (we updated from 2.7.x to 2.9.2 for M45) added a
default-on abort on > 10,000,000 byte documents which is a bit
arbitrary and is causing problems for users. The _HUGE option
makes it not do this. My assumption is that this is reasonable
behaviour security-wise as: 1) we were doing it this way until
recently; and 2) it shouldn't be any worse in the renderer than
just doing `for (;;) x+='y';`

(There's a big trivial xml file in
LayoutTests/http/tests/xmlhttprequest/resources/big.xml
that goes with the test, but git cl upload won't upload it. I
guess I'll dcommit just that file first?)

R=dominicc@chromium.org
BUG=528078,463958
TEST=LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-big-document.html

Review URL: https://codereview.chromium.org/1316673007

git-svn-id: svn://svn.chromium.org/blink/trunk@201992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL updates all callers in InlineFlowBox.

BUG=499321

Review URL: https://codereview.chromium.org/1312713005

git-svn-id: svn://svn.chromium.org/blink/trunk@201991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=492871
TBR=szager@chromium.org

Review URL: https://codereview.chromium.org/1329713003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1329823002

git-svn-id: svn://svn.chromium.org/blink/trunk@201989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL updates callers in LayoutText.cpp.

BUG=499321

Review URL: https://codereview.chromium.org/1330433003

git-svn-id: svn://svn.chromium.org/blink/trunk@201988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Modifies V8WrapperInstantiationScope::SecurityCheck to only call BindingSecurity::shouldAllowAccessToFrame if m_context's world is the main world.

BUG=529667

Review URL: https://codereview.chromium.org/1323453005

git-svn-id: svn://svn.chromium.org/blink/trunk@201987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=szager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1309313011 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We will fix the removed expectations after the chromium
side change (crrev.com/1317733006) is in.

BUG=529807

Review URL: https://codereview.chromium.org/1320863005

git-svn-id: svn://svn.chromium.org/blink/trunk@201985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/MyINCevjAJA

The NetInfo spec changed as follows:

1) wimax is now a connection type
2) connection.ontypechange has moved to onchange (we will deprecate ontypechange once onchange is shipped)
3) connection.downlinkMax has been added

This CL adds Blink support for those changes. ontypechange is deprecated in favor of onchange. Tests are updated to use onchange. downlinkMax support is added but defaults to 0.0 until the browser process starts sending real values.

Patch 1) https://crrev.com/1308943005 (this)
Patch 2) https://crrev.com/1306423004
Patch 3) https://crrev.com/1309903006

BUG=412741

Review URL: https://codereview.chromium.org/1308943005

git-svn-id: svn://svn.chromium.org/blink/trunk@201984 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This also gets rid of a bug in clampScrollOffset that sometimes caused it to use a maximum offset that was one pixel too small, so a few tests need to be rebaselined.

BUG=492871
R=skobes@chromium.org

Review URL: https://codereview.chromium.org/1223173006

git-svn-id: svn://svn.chromium.org/blink/trunk@201983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The old implementation was "allocate or die".  It's not good for
ImageData, which may try to allocate a huge memory block.  This CL
makes ImageData gracefully returns nullptr optionally raising an
exception in case of out of memory.

BUG=528898

Review URL: https://codereview.chromium.org/1328343002

git-svn-id: svn://svn.chromium.org/blink/trunk@201982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follows the same approach as BMPImageDecoder: Use a
FastSharedBufferReader to avoid consolidation.

Add an optional offset to PNGImageDecoder for ICOImageDecoder, so that
PNGImageDecoder can read a PNG subimage in an ICO without copying the
data. This eliminates another call to SharedBuffer::data(), as well as
a copy to create the separate SharedBuffer for PNG.

BUG=467772
BUG=528625

Review URL: https://codereview.chromium.org/1316203008

git-svn-id: svn://svn.chromium.org/blink/trunk@201981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=529776

Review URL: https://codereview.chromium.org/1330163005

git-svn-id: svn://svn.chromium.org/blink/trunk@201980 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |startOfDocument()| by
templatizing original |startOfDocument()| to work both DOM tree position and
composed tree position version for introducing composed tree version of
|VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1324123003

git-svn-id: svn://svn.chromium.org/blink/trunk@201979 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These APIs are intended to support spatial scheduling and task attribution.

Chromium implementation: https://codereview.chromium.org/1314903007/

BUG=510398

Review URL: https://codereview.chromium.org/1316233010

git-svn-id: svn://svn.chromium.org/blink/trunk@201978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

V8 posts idle tasks explicitly.

BUG=chromium:490559

Review URL: https://codereview.chromium.org/1320073005

git-svn-id: svn://svn.chromium.org/blink/trunk@201977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=529753
TBR=rbyers@chromium.org,eae@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1312633007

git-svn-id: svn://svn.chromium.org/blink/trunk@201976 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Don't do base level clamp for generateMipmap. Generate error message for
generateMipmap if base level texture is not specified.

BUG=295792

Review URL: https://codereview.chromium.org/1306343007

git-svn-id: svn://svn.chromium.org/blink/trunk@201975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We weren't properly performing the bypass check for inline style
attributes, nor were we correctly bypassing CSP for inline event
handlers. Of course, extensions shouldn't use either of these, but
they do. Because of course they do.

BUG=524356
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1318153009

git-svn-id: svn://svn.chromium.org/blink/trunk@201974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The two users can be trivially replaced with queries on the layout tree
instead.

Review URL: https://codereview.chromium.org/1317563010

git-svn-id: svn://svn.chromium.org/blink/trunk@201973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Fix virtual vs resident size reporting in the "size" column:
  Prior to this change the PartitionAlloc dumper was reporting the
  mmap-ed (virtual address spave) size in the "size" column.
  This is inconsistent with the rest of the dumpers, which strive
  to report an estimation of actually resident memory in the "size"
  column.
  This change moves the PA resident size into "size".   
- Remove the "thread_1234" sub-node: turns out that there can be at
  most one PartitionAlloc instance per-process, even in single-process
  mode.
- Improve reporting of allocated_objects:
  - Each bucket gets a column "allocated_objects_size", previously 
    called "active_size" (confusing), which reports the size of bytes
    requested by PA clients.
  - The per-bucket "allocated_objects" sub-rows are removed: they just
    added visual clutter and didn't add any extra information than an
    extra column.
  - A global allocated_objects node is introduced. This will be required
    by subsequent CLs to properly account memory reporter by other pieces
    of blink. This will be to avoid that WebCache memory that is 
    allocated via PA gets double-counted in the effective_size.
- Improve other column names for sake of clarity:
   - committed -> virtual_committed
   - num_{active,full,...} -> {active,full,...}_pages. The previous name
     didn't make it clear that they count pages and not objects.

BUG=488472

Review URL: https://codereview.chromium.org/1312843010

git-svn-id: svn://svn.chromium.org/blink/trunk@201972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See spec change: https://github.com/w3c/presentation-api/issues/184

BUG=529051

Review URL: https://codereview.chromium.org/1311003004

git-svn-id: svn://svn.chromium.org/blink/trunk@201971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch expands two version of |endOfLine()| which changes behavior with
|mode| parameter into callers, one parameter version of |endOfLine()| and
|logicalEndOfLine()| to simplify implementation as a preparation for
templatizing |endOfLine()| and |logicalEndOfLine()| to introduce composed tree
version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1326403003

git-svn-id: svn://svn.chromium.org/blink/trunk@201970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We should never get to a point where a `chrome-extension:` resource
shows up in the stack trace for a blocked resource. That said, we're
apparently hitting that scenario somewhat often.

This patch at least ensures that our brokenness isn't spamming reporting
endpoints, and revealing the extensions that users have installed to the
site owners.

BUG=524356

Review URL: https://codereview.chromium.org/1302363004

git-svn-id: svn://svn.chromium.org/blink/trunk@201969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eae@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1326183005

git-svn-id: svn://svn.chromium.org/blink/trunk@201968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |rightPositionOf()|
by templatizing original |rightPositionOf()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch also templaizes |rightVisuallyDistinctCandidate()| used by
|rightPositionOf()|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311803004

git-svn-id: svn://svn.chromium.org/blink/trunk@201967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fold FormDataList::getEntry() and getAll() into DOMFormData.  So, no one uses
FormDataList::Entry.
This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1312333005

git-svn-id: svn://svn.chromium.org/blink/trunk@201966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |ComposedTreeTraversal::previousPostOrder()| which is
composed tree version of |NodeTraversal::previousPostOrder()| as a preparation
of implementing composed tree version of |startOfParagraph()|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1308063008

git-svn-id: svn://svn.chromium.org/blink/trunk@201965 bbb929c8-8fbe-4397-9dbb-9b2b20218538