GitLab

This allows for cases where the request complete callback is invoked outside a message loop,
for e.g. in TestPostChunkedDataAfterStart(). Quit() can only be invoked inside a message
loop whereas posting a QuitTask to the message loop can be done from anywhere.

BUG=none
TEST=TestPostChunkedDataAfterStart passes through the tsan bots and net_unittests in general runs fine.

Review URL: http://codereview.chromium.org/6329019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72493 0039d316-1c4b-4281-b951-d872f2087c98

Recommit of r72380.

BUG=23581
TEST=no visible changes; all tests pass

Review URL: http://codereview.chromium.org/6306011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70665, 70643
TEST=none, these are tests themselves.

Review URL: http://codereview.chromium.org/6309015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=compile failure with touchui=1
TEST=fix compile with touchui=1
TBR=rjkroege@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72490 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces preference settings for incognito windows. The semantics are the following:

- An extension can set regular preferences as before. These affect regular and incognito windows.

- An extension can set regular preferences *and* incognito preferences. In this case, the incognito preferences affect only incognito windows.

- If extension A sets reg+incognito, extension B sets reg but no incognito, extension B has higher precedence than A --> B's preferences hold for all regular and incognito windows.

- Incognito preferences are never persisted to disk.

In order to realize this, the ExtensionPrefs class allows setting regular and incognito extension controlled preferences. It allows creating an incognito version of the PrefService with an independent PrefValueStore. This (incognito) PrefValueStore and the original PrefValueStore share several of their PrefStores (i.e. DefaultPrefStore, CommandLinePrefStore, Configuration PrefStores) but differ in two pref stores:

- We maintain two separate ExtensionPrefStores containing the effective preferences for regular and incognito windows.

- We maintain two separate user pref stores. The regular JsonPrefStore is expanded by an OverlayPersistentPrefStore that maintains all write-operations in an in-memory overlay. Therefore, incognito changes are not visible in the file-backed JsonPrefStore.

The two ExtensionPrefStores retrieve their effective values from a shared ExtensionPrefValueMap.

The OffTheRecordProfileImpl provides a request_context_ that uses the new PrefService already.

BUG=66027,69057
TEST=unit tests, will be fully testable once the Proxy Settings API allows incognito settings.

Review URL: http://codereview.chromium.org/5915004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72489 0039d316-1c4b-4281-b951-d872f2087c98

The suppresion in the test list is way too general and will mask
almost anything V8 related.

Review URL: http://codereview.chromium.org/6271020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72488 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60211
TEST=bots

Review URL: http://codereview.chromium.org/6265024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72487 0039d316-1c4b-4281-b951-d872f2087c98

In CL http://codereview.chromium.org/6134003 I did a find/replace for all places in testserver.py
that read the request body and incorrectly replaced this one as well. The intention was only to
make the change to methods of TestPageHandler and not SyncPageHandler.

BUG=none
TEST=sync_integration_tests builds fine in the buildbots.

Review URL: http://codereview.chromium.org/6391003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72486 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:70608
TEST=None

Review URL: http://codereview.chromium.org/6377006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72485 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72481 0039d316-1c4b-4281-b951-d872f2087c98

Landing the patch from http://codereview.chromium.org/6265020/ written by
Evgeniy Stepanov (eugenis@chromium.org), who doesn't have committer access yet.

BUG=70379
TBR=erg

Review URL: http://codereview.chromium.org/6304020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72479 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromiumos:7214
TEST=Run desktopui_ChromeFirstRender autotest and verify that it passes.

Review URL: http://codereview.chromium.org/6353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72478 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
TBR=tony.chromium,rniwa

Review URL: http://codereview.chromium.org/6383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70569
TEST=manually

Review URL: http://codereview.chromium.org/6282014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72475 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:11244
TEST=manually

Review URL: http://codereview.chromium.org/6374012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72474 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium-os/issues/detail?id=6923
TEST=manual

Review URL: http://codereview.chromium.org/5758002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72473 0039d316-1c4b-4281-b951-d872f2087c98

For the record, the layout was broken due to the two changes:

http://src.chromium.org/viewvc/chrome?view=rev&revision=71836
caused each language name to have a weird button-like shadow.

http://src.chromium.org/viewvc/chrome?view=rev&revision=72085
broke the two-column layout.

BUG=crosbug.com/11241
TEST=on chrome os, open the language selection overlay. confirm that the layout is nice.

Review URL: http://codereview.chromium.org/6393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6134003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72471 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=tony.chromium,rniwa

Review URL: http://codereview.chromium.org/6371012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72470 0039d316-1c4b-4281-b951-d872f2087c98

Pass user agent to InvalidationClientImpl as client_info.

Pick up fix for bug that was causing increased server traffic.

BUG=70674
TEST=none

Review URL: http://codereview.chromium.org/6310015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72468 0039d316-1c4b-4281-b951-d872f2087c98

Currently chromeos::InputMethodMenuButton is derived from both StatusAreaButton and InputMethodMenu, which violates the Chrome coding guideline. This change removes the multiple inheritance by adding InputMethodMenu object to InputMethodMenuButton as a member variable.

BUG=chromium-os:7572
TEST=manually & try bot

Review URL: http://codereview.chromium.org/6262012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72467 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=tony.chromium,rniwa

Review URL: http://codereview.chromium.org/6248018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6268013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72465 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none



Review URL: http://codereview.chromium.org/6321019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72464 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tony,yuzo

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67101

Review URL: http://codereview.chromium.org/6327017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72459 0039d316-1c4b-4281-b951-d872f2087c98

[SYNC] Speculative fix for autofill change processor destroying on the wrong thread. The data type manager should now tell any datatype controller that is not already stopping or not running to stop. Namely, this covers the MODEL_STARTING and ASSOCIATING cases, which weren't being covered before. Tests that can reproduce these race conditions still needed.

BUG=61804
TEST=unit,sync_integration,self

Review URL: http://codereview.chromium.org/6273011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72458 0039d316-1c4b-4281-b951-d872f2087c98

This CL assumes keyword query is always synchronous.

BUG=70527
TEST=See bug report.

Review URL: http://codereview.chromium.org/6281011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72457 0039d316-1c4b-4281-b951-d872f2087c98

[linux] When the user has the notification options menu, delay system-initiated closing of the notification.

BUG=51177
TEST=open the notification options menu on a notification which will be auto-closed by the page.

Review URL: http://codereview.chromium.org/6273010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72456 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:10180, chromium:70450, chromium:70451
TEST=Verified strings and link were changed.

Review URL: http://codereview.chromium.org/6314014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72455 0039d316-1c4b-4281-b951-d872f2087c98

Cached forms might not match submitted forms, but the logging code had been assuming that they always do.

BUG=70374
TEST=unit_tests --gtest_filter=AutoFillMetricsTest.SaneMetricsWithCacheMismatch

Review URL: http://codereview.chromium.org/6259017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72453 0039d316-1c4b-4281-b951-d872f2087c98

Disable IndexedDBBrowserTest.TransactionTest and IndexedDBBrowserTest.DoesntHangTest on all platforms because they're now causing crash and/or hang on Mac.

TBR=jorlow, japhet, andreip
BUG=70665

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=green tree
TBR=tfarina

Review URL: http://codereview.chromium.org/6264014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72449 0039d316-1c4b-4281-b951-d872f2087c98

(A second try after being reverted.)

Review URL: http://codereview.chromium.org/6279009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72445 0039d316-1c4b-4281-b951-d872f2087c98

time_slice_hrs is being used uninitialized at line 459, and this was causing a Run-Time Check failure and crash in Debug versions on Windows.

I don't know whether 0 is the the correct value in this case, but this fixes the crash. mirandac@ will need to review the behavior.

BUG=None
TEST=Run debug version of Chrome on Windows and wait a few seconds.
Review URL: http://codereview.chromium.org/6385004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72444 0039d316-1c4b-4281-b951-d872f2087c98

UI Layout tests are not flaky, so delete the FLAKY label from
linux and windows.

BUG=56364
TEST=test no longer marked flaky
TBR=scherkus

Review URL: http://codereview.chromium.org/6324010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72442 0039d316-1c4b-4281-b951-d872f2087c98

Page title can leak privacy information hence we don't really want it.

BUG=66716
TEST=Sent a report to confirm page title is no longer being sent.

Review URL: http://codereview.chromium.org/6366007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72441 0039d316-1c4b-4281-b951-d872f2087c98

Pritchard for suggesting these mappings.

Review URL: http://codereview.chromium.org/6372012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72440 0039d316-1c4b-4281-b951-d872f2087c98

Windows-native implementation of the TTS API.

BUG=none
TEST=manual testing

Review URL: http://codereview.chromium.org/6249014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72439 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70631
TEST=none

TBR=kkania@chromium.org

Review URL: http://codereview.chromium.org/6317013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72438 0039d316-1c4b-4281-b951-d872f2087c98