GitLab

We are trying to track down a negative error code (-50) but the current implementation logs negative values as zero. This patch maps all -50 error codes into one bin and all other error values into a second (unspecified/trash) bin.

BUG=428706

Review URL: https://codereview.chromium.org/702453003

Cr-Commit-Position: refs/heads/master@{#302434}

This allows autoconnect to policy pushed networks without the user having to manually trigger a successful connect once.

BUG=424036

Review URL: https://codereview.chromium.org/647783005

Cr-Commit-Position: refs/heads/master@{#302433}

Also make a global more const.

BUG=82385

Review URL: https://codereview.chromium.org/699453002

Cr-Commit-Position: refs/heads/master@{#302432}

We currently have code that ensures that if the last used profile is Guest, we should
open the User Manager. This doesn't work if, for example, you download a file
in the Guest browser, and then click on it top open it. In this case, it's fine
to open a new Guest browser window, as one already exists (and opening the User
Manager is a very weird experience)

BUG=423118
TEST=Start Chrome with --enable-new-avatar-menu. From the avatar menu, choose "Switch person"
and launch a new Guest browser. In the Guest browser, download a file, and then click on
it from the dwonload shelf at the bottom of the browser. The file should open in a
new tab of the Guest window.

Review URL: https://codereview.chromium.org/691063002

Cr-Commit-Position: refs/heads/master@{#302431}

This required for the new CertDatabaseService
  https://codereview.chromium.org/419013003/
which will (at least temporarily) depend on net/.
Without this change, that would lead to a cyclic dependency between net/ and cert_database/ .

This makes several tests in client_cert_store_chromeos_unittest, like cross-reading between user slots and the system slot, unnecessary.
These are already covered in the unit tests for NSSProfileFilterChromeOS.
This also removes this knowledge about users and the system slot from net/, which are Chrome/ChromeOS details that don't belong into net/.

BUG=413219

Review URL: https://codereview.chromium.org/663583006

Cr-Commit-Position: refs/heads/master@{#302430}

This fixes the following issue:
- allow forwarder2 to compile with clang
- Makes android executables position independant so that they can be run
  on android devices
- Add missing BUILD.gn

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/684133002

Cr-Commit-Position: refs/heads/master@{#302429}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d8aa7b7..f1b471a

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/697103003

Cr-Commit-Position: refs/heads/master@{#302428}

Since sync may cause a profile to become signed out, we cannot assume
a signing out profile is unlocked. Thus, forcibly unlock it.

BUG=426174

Review URL: https://codereview.chromium.org/698543002

Cr-Commit-Position: refs/heads/master@{#302427}

This CL changes the way that device disabling is expressed in the
DeviceStateRetrievalResponse proto. Instead of being implied when
the |device_state| field is present, it is now explictly set as a
|restore_mode|.

BUG=425574
TEST=Updated unit and browser tests

Review URL: https://codereview.chromium.org/690643002

Cr-Commit-Position: refs/heads/master@{#302426}

These are mostly mechanical changes found while attempting to compile
the Android build with libc++.

BUG=427718
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/693773003

Cr-Commit-Position: refs/heads/master@{#302425}

Cr-Commit-Position: refs/heads/master@{#302424}

Also enable it on Windows, Linux, and Mac.

BUG=422235
R=sergiyb@chromium.org

Review URL: https://codereview.chromium.org/663253005

Cr-Commit-Position: refs/heads/master@{#302423}

The Blink side already handles these policies; this CL is just plugging them
into Finch.

BUG=

Review URL: https://codereview.chromium.org/697673002

Cr-Commit-Position: refs/heads/master@{#302422}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/699563002

Cr-Commit-Position: refs/heads/master@{#302421}

The getter for the printing.enabled preference was improperly
testing for whether the property was managed. The value of the
property and the managed status are now obtainable through separate
functions

BUG=423886

Review URL: https://codereview.chromium.org/695773004

Cr-Commit-Position: refs/heads/master@{#302420}

BUG=421894

Review URL: https://codereview.chromium.org/695753002

Cr-Commit-Position: refs/heads/master@{#302419}

Currently, if the control key is held down on non-mac platforms then we will never check whether the rotation keys are pressed (we will enter the first branch of the if-statement and so never enter the else-branch). This change ensures both branches are tested sequentially.

BUG=429483

Review URL: https://codereview.chromium.org/689393002

Cr-Commit-Position: refs/heads/master@{#302418}

Currently the webstore API can ask for an incognito profile to be loaded
into the app list, which isn't supported. This change makes the app list
service robust against that. Instead, if an incognito profile is
requested, initialize the app list with the original profile.

This same codepath could be used to trigger an "impossible" crash
without incognito being involved. This can happen when the app launcher
is "shown" without ever being "enabled" (i.e. if it is disabled via
command line flag or editing prefs). If it is then enabled by installing
an app to a profile different to the one that was shown, the "Create*"
codepaths were not checking for a current profile at all. This would
lead to the original app list "leaking", and a crash on browser shutdown
when 2 windows are observed to close instead of just one.

To fix this and to consolidate incognito profile checks in the right
place the create functions now check profiles. Show functions just
always "create" and assume it will be a no-op if it's already created.

BUG=358135, 373689
TEST=Added regression tests AppListControllerBrowserTest.* (or see
http://crbug.com/358135 for involved repro).

Review URL: https://codereview.chromium.org/219383006

Cr-Commit-Position: refs/heads/master@{#302417}

It is safer to use the C++11 foreach operator to iterate over this
vector. On Windows gfx::ScreenWin gets the the display count from a
different place from the display list.

BUG=427931

Review URL: https://codereview.chromium.org/689223002

Cr-Commit-Position: refs/heads/master@{#302416}

To make the dialog more accessible, auto-focus the first button in the
dialog when it opens so focus is already on an element inside the
dialog. This behaviour is more consistent with existing dialogs in
Chrome, and helps users using screen-readers and similar with navigating
the dialog after it opens.

BUG=425311

Review URL: https://codereview.chromium.org/689833004

Cr-Commit-Position: refs/heads/master@{#302415}

For example, after uploading this CL, I just ran:

./try.py mac.bisect.blink_perf.cfg linux.perf_test.tab_switching.cfg. I expect it should only start two try jobs.

If you run ./try.py (with no arguments), it prints usage help and a "too few arguments" message.

BUG=415890

Review URL: https://codereview.chromium.org/687733003

Cr-Commit-Position: refs/heads/master@{#302414}

Revert of Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions (patchset #2 id:20001 of https://codereview.chromium.org/688633004/)

Reason for revert:
caused crashers. see bug 429576

Original issue's description:
> Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions
>
> Currently, PasswordAutofillAgent (in renderer) prepares password autofill suggestions for PasswordAutofillManager (in browser) and sends them via IPC.
>
> But the manager has the data to generate the suggestions itself, so this CL makes it derive the suggestions from that data instead of hauling it through IPC.
>
> This CL also adds one more test case to the PasswordAutofillManager unittest, to compensate for the coverage lost in the PasswordAutofillAgent browsertest by moving some logic out of the agent to the manager.
>
> BUG=400186, 377422, 118601
>
> Committed: https://crrev.com/86cc798cc2947dd88aa73505d716f93538dffa5b
> Cr-Commit-Position: refs/heads/master@{#302245}

TBR=gcasto@chromium.org,tsepez@chromium.org,jww@chromium.org,vabr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400186, 377422, 118601

Review URL: https://codereview.chromium.org/695233002

Cr-Commit-Position: refs/heads/master@{#302413}

BUG=420746

Review URL: https://codereview.chromium.org/633233002

Cr-Commit-Position: refs/heads/master@{#302412}

The network cache is not safe for usage by multiple processes at the same
time like when sky tests are running many mojo_shell instances in parallel.
To work around this we store the cache in memory. In the future we should
consider file system partitioning for mojo services.

This CL originally reviewed and landed in the Mojo repo in
https://codereview.chromium.org/679403002/. Re-landing in the Chromium repo
because this code is canonically developed here.

TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/697883003

Cr-Commit-Position: refs/heads/master@{#302411}

Add sashab@ to the OWNERS file in the views/apps/app_info_dialog
directory.

Review URL: https://codereview.chromium.org/276293002

Cr-Commit-Position: refs/heads/master@{#302410}

BUG=397019, 390086

Review URL: https://codereview.chromium.org/686333002

Cr-Commit-Position: refs/heads/master@{#302409}

BUG=426679

Review URL: https://codereview.chromium.org/675133002

Cr-Commit-Position: refs/heads/master@{#302408}

Adds hi-res assets.
Adds new error asset.
Removes audio history step.
Updates audio history 'learn more' link.

BUG=390086

Review URL: https://codereview.chromium.org/695703002

Cr-Commit-Position: refs/heads/master@{#302407}

Based on formatting a few java files in base/ and comparing before/after.

BUG=429372
NOTRY=true

Review URL: https://codereview.chromium.org/697893002

Cr-Commit-Position: refs/heads/master@{#302406}

Added alt-text and focusability to the revoke buttons in the App Info
dialog so they can be navigated to with the keyboard. This allows
permissions to be revoked for apps for users who are navigating with a
screen reader or only using the keyboard.

BUG=425311

Review URL: https://codereview.chromium.org/689863002

Cr-Commit-Position: refs/heads/master@{#302405}

BUG=428557
TEST=None

Review URL: https://codereview.chromium.org/697863002

Cr-Commit-Position: refs/heads/master@{#302404}

Blink's actual implementation preserves keyIdentifier='Enter'
when Enter is pressed. To make sure that the test framework
behaves like the actual implementation, this CL makes sure that
keyIdentifier is set to 'Enter' when the Enter key is simulated.

BUG=423270

Review URL: https://codereview.chromium.org/649343002

Cr-Commit-Position: refs/heads/master@{#302403}

Revert of Clean up the page state saving mechanism. (patchset #2 id:20001 of https://codereview.chromium.org/689163002/)

Reason for revert:
This is a likely candidate for having broken lots of layout tests...

Original issue's description:
> Clean up the page state saving mechanism.
>
> BUG=416184
> TEST=as in bug
>
> Committed: https://crrev.com/133fac58dfe9ac1d2b0071ce107825adaad67cc7
> Cr-Commit-Position: refs/heads/master@{#302372}

TBR=creis@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=416184

Review URL: https://codereview.chromium.org/694963003

Cr-Commit-Position: refs/heads/master@{#302402}

BUG=423019

Review URL: https://codereview.chromium.org/691183002

Cr-Commit-Position: refs/heads/master@{#302401}

Blink roll 2842c5f8ea181eb3415ae3b124b873eb4355e6e2: c51b33ed3d9bc7d1ccc45231a5d48432a2be6740 (svn 184758:184775)

TBR=morrita

Review URL: https://codereview.chromium.org/699533002

Cr-Commit-Position: refs/heads/master@{#302400}

Cr-Commit-Position: refs/heads/master@{#302399}

These objects don't have the same lifetime and we were using raw pointers to them  in a few places, which could lead to use-after-free.

BUG=429477
TBR=perkj@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/698803002

Cr-Commit-Position: refs/heads/master@{#302398}

Disable WebViewInteractiveTest.NewWindow_OpenInNewTab on OS_MACOSX, until the problem to miss keyup event with command key is fixed

BUG=425859
R=avi@chromium.org
R=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/692113002

Cr-Commit-Position: refs/heads/master@{#302397}

Cr-Commit-Position: refs/heads/master@{#302396}

This addresses the issue of getStats blocking the UI thread for excessive amounts of time and also opens the door for us to do other heavy-lifters such as setRemoteDescription and setLocalDescription asynchronously.

This CL builds on several others that have landed this week (see bug for details), but here are the key changes:

- PeerConnectionDependencyFactory has a separate signaling thread instead of using the UI thread.
- Classes that join WebRTC and Blink objects need to be aware of the signaling thread being different.  This means that callbacks will come in on the signaling thread from webrtc and need to be sent to the UI thread for javascript callbacks.

BUG=369796

Review URL: https://codereview.chromium.org/675013005

Cr-Commit-Position: refs/heads/master@{#302395}