GitLab

BUG=65547, chromium-os:9559
TEST=none

Review URL: http://codereview.chromium.org/6269016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72433 0039d316-1c4b-4281-b951-d872f2087c98

It seems this file was left when all the other animation files were moved
to ui/base/animation/.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6376010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=NaCl SDK pi_generator example encounters this
Review URL: http://codereview.chromium.org/6384009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72430 0039d316-1c4b-4281-b951-d872f2087c98

Dropped the DCHECk since it seems some Windows version don't initialize the unused variable.

BUG=27400
TEST=none

Review URL: http://codereview.chromium.org/6242011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72429 0039d316-1c4b-4281-b951-d872f2087c98

The other layout files under views directory will be moved later.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6360014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72428 0039d316-1c4b-4281-b951-d872f2087c98

because they seem to be causing the entire browser test to hang or crash.

BUG=70665
Review URL: http://codereview.chromium.org/6339010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72427 0039d316-1c4b-4281-b951-d872f2087c98

45s until first TCP Keep-Alive and 45s in between keep alives.

BUG=27400
TEST=Run Wireshark, make sure TCP Keep-Alive packets are sent.

Review URL: http://codereview.chromium.org/6300013

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/6371010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72426 0039d316-1c4b-4281-b951-d872f2087c98

This is to pick clang warning / miscompile fix in r760.

r756, 757, 758 were edits to the breakpad wiki, not code changes.

r759 added a new file to libreakpad.a on linux

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6357016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72424 0039d316-1c4b-4281-b951-d872f2087c98

flag in https://bugs.webkit.org/show_bug.cgi?id=53041 .
ENABLE_3D_CANVAS will be removed once we roll WebKit past the landing
of the upstream patch.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6256013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72423 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Test Cloud Print Proxy.

Review URL: http://codereview.chromium.org/6356007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72422 0039d316-1c4b-4281-b951-d872f2087c98

45s until first TCP Keep-Alive and 45s in between keep alives.

BUG=27400
TEST=Run Wireshark, make sure TCP Keep-Alive packets are sent.

Review URL: http://codereview.chromium.org/6300013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72421 0039d316-1c4b-4281-b951-d872f2087c98

Make new chrome UI security model the default.

allows us to update URL in chrome://settings when the user navigates within it.

BUG=57485
TEST=manual

Review URL: http://codereview.chromium.org/6277018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72420 0039d316-1c4b-4281-b951-d872f2087c98

Moved bodies of test functions into .cc files.

Remove sync_service() accessors from various model associators.

Renamed GetUserShareHandle to GetUserShare() and removed typedefs for its return types.

Added plenty of TODOs for future improvements.

BUG=None
TEST=unit_tests

Review URL: http://codereview.chromium.org/6375007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72419 0039d316-1c4b-4281-b951-d872f2087c98

Avoids throwing an exception when git isn't installed.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70344
TEST=See bug report.

Review URL: http://codereview.chromium.org/6380012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72417 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a basic TouchTabStrip for touch_ui builds.  It is intended to be a placeholder for further work towards a more refined TouchTabStrip.  It is modeled after the existing TabStrip and tries to make use of BaseTabStrip and BaseTab where appropriate.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5572007
Patch from Chad Faragher <wyck@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72416 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70576
TEST=none
Review URL: http://codereview.chromium.org/6247020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72414 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70636
TEST=Manual

Review URL: http://codereview.chromium.org/6299016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72413 0039d316-1c4b-4281-b951-d872f2087c98

Only eat the event in subPageClosingClickHandler_ if it happens on the narrow strip part.

BUG=chromium-os:11202
TEST=Verify the radio/checkbox on overlay page works again per chromium-os:11202.

Review URL: http://codereview.chromium.org/6371009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72412 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70576
TEST=none
Review URL: http://codereview.chromium.org/6282012

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6340015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70576
TEST=none
Review URL: http://codereview.chromium.org/6282012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72408 0039d316-1c4b-4281-b951-d872f2087c98

allows us to update URL in chrome://settings when the user navigates within it.

BUG=57485
TEST=manual

Review URL: http://codereview.chromium.org/6266017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72405 0039d316-1c4b-4281-b951-d872f2087c98

This patch moves the experiments settings from the user profile to the browser's local state, since these settings correspond to command line switches. It restores 6267009 http://codereview.chromium.org/6267009/ which got reverted because it broke ChromeOS tests.  The patch also removes some migration code for ChromeOS experiments. Users' settings should be migrated by now.
This is a release blocker for NaCl, so we are pushing this through. 
TEST=manual 
BUG= http://code.google.com/p/nativeclient/issues/detail?id=1322
Review URL: http://codereview.chromium.org/6389002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72404 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=visual

Review URL: http://codereview.chromium.org/6354011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72403 0039d316-1c4b-4281-b951-d872f2087c98

Currently, about: links all go to about:blank. This fixes that for left clicks and middle clicks, although context menu navigations (e.g. open in new tab) still won't work.

This also "fixes" file: links in the same way. Currently, file links already work as is, but after we make --new-chrome-ui-security-model the default, they will cease to work without this fix. Context menu navigations will, however, continue to work.

The fix is currently applied to the history page and one link in settings.

BUG=69140
TEST=manual

Review URL: http://codereview.chromium.org/6269015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70665
Review URL: http://codereview.chromium.org/6258019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72399 0039d316-1c4b-4281-b951-d872f2087c98

Although |ChromeURLDataManager::DataSource|s are |RefCountedThreadSafe|, at least two derived classes contain |CancellationFlag| members, which check that they are deleted in the same thread as they are created.

Normally, the |DataSource|s are destructed when |ChromeURLDataManager| (instanced via a Singleton) is destroyed, on the main thread.  This is not an issue as the classes with a |CancellationFlag| are created on that thread too.

However, occasionally (see the bug) |AddDataSource()| is called when there is already an entry in |data_sources_|, leading to a |DataSource| being released and destructed in the IO thread.

To fix this problem, I've incremented the reference count and posted a task to the main (UI) thread that will release the reference and so destruct it there.

BUG=49121
TEST=none

Review URL: http://codereview.chromium.org/6285002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72398 0039d316-1c4b-4281-b951-d872f2087c98

user's profile.

Review URL: http://codereview.chromium.org/6381007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72397 0039d316-1c4b-4281-b951-d872f2087c98

I'm TBRing as this is just a removing of unneeded CHECKs.

BUG=34135
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/6291011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70592
TEST=All downloads tests pass

Review URL: http://codereview.chromium.org/6327016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72395 0039d316-1c4b-4281-b951-d872f2087c98

1. Map the free space on the last row of the app launcher to the last valid app position.
2. Transition the app opacity smoothly.
3. Fix JS errors when starting drag from certain areas.
4. Make sure drag and drop works when the window / apps section is scrolled.

BUG=53977
TEST=none.

Review URL: http://codereview.chromium.org/6264012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72394 0039d316-1c4b-4281-b951-d872f2087c98

testZipInIncognito occassionally fails because the download hasn't finished
yet. fix it.

BUG=
TEST=

Review URL: http://codereview.chromium.org/6275016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72393 0039d316-1c4b-4281-b951-d872f2087c98

Modify chrome to accept a pdf file on the command line and upload it to Cloud Print via the Cloud Print dialog
Contributed by abodenha@google.com
BUG=none
TEST=Run Chrome on Windows with --cloud-print-file=<Path to PDF> and --cloud-print-job-title

Review URL: http://codereview.chromium.org/6038008
Patch from Albert Bodenhamer <abodenha@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72392 0039d316-1c4b-4281-b951-d872f2087c98

Disabling find_in_page.FindMatchTests.testSearchInPDF
Review URL: http://codereview.chromium.org/6280014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72391 0039d316-1c4b-4281-b951-d872f2087c98

We should only use FilePath when working with real paths on disk.

Note:  I made a minor semantic change to downloads -- we no
longer preserve backslashes in server-suggested paths on non-Windows.
I think the previous behavior is crazy but from looking at the
blame I'm the one who wrote it originally, so I don't feel bad
about changing my mind.

BUG=69467
TEST=existing test still passes

Review URL: http://codereview.chromium.org/6241001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72390 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70659

TEST=

Review URL: http://codereview.chromium.org/6375011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72389 0039d316-1c4b-4281-b951-d872f2087c98

Add HANDLE_CRASHES to Linux callback functions, since they are plugin entry points too. This makes no difference right now because we currently don't gate Linux crash uploading on HANDLE_CRASHES, but once we change that we'll want these in all the right places.

TEST=loaded O2D on Linux, verified it works
BUG=none

Review URL: http://codereview.chromium.org/6348018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581
TEST=no visible changes; all tests pass

Review URL: http://codereview.chromium.org/6258015

TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6256010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72385 0039d316-1c4b-4281-b951-d872f2087c98

TBR


TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6271016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72382 0039d316-1c4b-4281-b951-d872f2087c98

TBR


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72381 0039d316-1c4b-4281-b951-d872f2087c98