GitLab

Revert of Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. (patchset #2 id:20001 of https://codereview.chromium.org/2352213002/ )

Reason for revert:
http://crbug.com/653330 This shortcut
conflicts with some web pages, and there's
no consensus on the proper fix (let web pages
override, or switch to another key).

Original issue's description:
> Add Ctrl+Alt+H as global shortcut to toggle high contrast mode.
>
> BUG=644758
>
> Committed: https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e
> Cr-Commit-Position: refs/heads/master@{#419884}

TBR=jamescook@chromium.org,mpearson@chromium.org,suppasitaung6@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=644758

Review-Url: https://codereview.chromium.org/2448663002
Cr-Commit-Position: refs/heads/master@{#427293}

show_ssl_decision_revoke_button_ field was never assigned when
constructing WebsiteSettings with about:blank url.

BUG=

Review-Url: https://codereview.chromium.org/2440183002
Cr-Commit-Position: refs/heads/master@{#427292}

This CL updates the layout/colors to match the following latest spec:
https://folio.googleplex.com/md-storage-management-spec

BUG=629438
TEST=manually confirmed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2435033003
Cr-Commit-Position: refs/heads/master@{#427291}

WebContentsViewCocoa has a hook to resize all subviews to match its
size. The problem is that the size of a RenderWidgetHostViewCocoa is
allowed to get out of sync with its superview while waiting for a
WebContents paint to be committed. If an autolayout is triggered while
waiting for that commit, the WebContents thinks it's been resized and
spawns a new paint.

Since r424609, for 10.11+, Chrome stopped replacing the NSThemeFrame
(which AppKit does not support) and instead started using
NSFullSizeContentViewWindowMask. This seems to opt the window into
additional autolayout triggers, coming from CoreAnimation. This can
engage the code to "re-sync" the sizes of the RenderWidgetHostViewCocoa
and WebContentsViewCocoa when it wasn't done previously.

To fix, "re-sync" sizes in an override of -setFrameSize: rather than
-resizeSubviewsWithOldSize:. This ensures a re-sync only occurs when the
size of the WebContentsViewCocoa changes.

BUG=655112, 655665, 264207
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2442573003
Cr-Commit-Position: refs/heads/master@{#427290}

rotate() and rotateSelf() function
1. If rotY and rotZ are both missing,
 set rotZ to the value of rotX and set rotX and rotY to zero.
2. If rotY is still missing, set rotY to zero.
3. If rotZ is still missing, set rotZ to zero.
4. If rotX or rotY are non-zero,
 set is2D of the current matrix to false.
5. Post-multiply a rotation transformation on the current matrix around the vector 0, 0, 1
 by the specified rotation rotZ in degrees.
6. Post-multiply a rotation transformation on the current matrix around the vector 0, 1, 0
 by the specified rotation rotY in degrees.
7. Post-multiply a rotation transformation on the current matrix around the vector 1, 0, 0
 by the specified rotation rotX in degrees.
8. Return the current matrix.

rotateFromVertor() and rotateFromVertorSelf() function
1. Post-multiply a rotation transformation on the current matrix.
 The rotation angle is determined by the angle between the vector (1,0)T and (x,y)T
 in the clockwise direction.
2. Return the current matrix.

spec list:
- https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateself
- https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotate
- https://drafts.fxtf.org/geometry/#dom-dommatrix-rotatefromvectorself
- https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-rotatefromvector

BUG=388780, 645878, 645882

Review-Url: https://codereview.chromium.org/2444733002
Cr-Commit-Position: refs/heads/master@{#427289}

This CL disables clicks in the date header of cards as this was causing
the first item to be selected when the date was clicked.

BUG=654998
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2420583003
Cr-Commit-Position: refs/heads/master@{#427288}

Chrome for iOS does not present URL spoofing error after switching to
WKWebView.

BUG=579697

Review-Url: https://codereview.chromium.org/2424643002
Cr-Commit-Position: refs/heads/master@{#427287}

When a color chooser is closed, we dispatches a 'change' event asynchronously.
Some tests need to be updated due to this behavior change.

BUG=658535

Review-Url: https://codereview.chromium.org/2447653002
Cr-Commit-Position: refs/heads/master@{#427286}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/cbc5a0a3ff3f55f5059b1ce3fd0712084a6a4ea8 use_goma_module=True in chromium_libfuzzer_clang_tot (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2446973002
Cr-Commit-Position: refs/heads/master@{#427285}

This is split out of the work for async stylesheet updates [1], but is
also part of the work on componentized style resolving in general.

The moved resetAuthorStyle method on StyleEngine may soon be gone
altogether as it does so in [1].

The plan is that TreeBoundaryCrossingScopes will also be completely
gone when we remove support for Shadow DOM v0. For Shadow DOM v1 we can
look up the scoped resolvers for the affecting scopes directly like we
already do in StyleResolver::matchScopedRules for the pure v1 case.

The documentation of the special casing of VTT and custom pseudo
elements is updated to not suggest that these rules are handled as part
of boundary crossing scopes as the current solution is better once v0
shadows go away.

[1] https://codereview.chromium.org/1913833002

R=meade@chromium.org
BUG=567021,401359

Review-Url: https://codereview.chromium.org/2443933002
Cr-Commit-Position: refs/heads/master@{#427284}

Move FakeFileRefInterface from fake_pepper_interface_html5_fs.{cc,h} to
fake_file_ref_interface.{cc,h} to share the code with the future code.

depot_tools/clang-format was run so the formatting of code is accepted
in the code review by policy. It was run in all the {.cc,.h} files.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Review-Url: https://codereview.chromium.org/2435323002
Cr-Commit-Position: refs/heads/master@{#427283}

BUG=344834

Review-Url: https://codereview.chromium.org/2445253002
Cr-Commit-Position: refs/heads/master@{#427282}

|idl_name| comes from filename but it's a bad idea to control code
generation by using filename. Fortunately we no longer use it, so let's
remove it.

BUG=658098

Review-Url: https://codereview.chromium.org/2446923002
Cr-Commit-Position: refs/heads/master@{#427281}

This patch gets rid of flat tree version of |createVisibleSelection()| taking
one |Position| by replacing with |SelectionInDOMTree| version to reduce number
of overloads for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2442673002
Cr-Commit-Position: refs/heads/master@{#427280}

This test was initiating a navigation to the chrome\test\data folder and performing a
number of find requests on the page returned. With PlzNavigate the request to navigate
to chrome\test\data folder would get blocked in ResourceLoader::OnReceivedRedirect because
the process id (-1) did not have access to the url being navigated to. In the non PlzNavigate
case this is not an issue because the child process is given access to the URL during
navigation.

Proposed fix for PlzNavigate is to not do the ChildProcessSecurityPolicy check in
the ResourceLoader::OnReceivedRedirect function and instead do this check on the UI thread
in the NavigationRequest::OnRedirectChecksComplete function. Additionally we also grant
access to the URL in the NavigatorImpl::RequestNavigation function.

The above test is now enabled for Windows.

BUG=175711

Disabled due to crbug.com/175711
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2436253002
Cr-Commit-Position: refs/heads/master@{#427279}

BUG=646083
TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html

Review-Url: https://codereview.chromium.org/2440243002
Cr-Commit-Position: refs/heads/master@{#427278}

Currently ArcSupportHost is the ARC's implementation of
NativeMessageHost. Because of the system structure, the instance
is created and managed by the module outside of ARC.

This CL extracts the implementation of that part into
ArcSupportMessageHost so that the ArcSupportHost, which will
be the main interface to show UI things for ARC, can be managed
along with the ARC's life-time.

There is a plan to extract non authorization related part from
ArcAuthSerivce. Meanwhile, the instance is managed by
ArcAuthService, temporarily.

BUG=657687, 636218, 633258, b/31079732
TEST=Ran on test device. Ran trybots.

Review-Url: https://codereview.chromium.org/2436903003
Cr-Commit-Position: refs/heads/master@{#427277}

BUG=389343

Review-Url: https://codereview.chromium.org/2445083002
Cr-Commit-Position: refs/heads/master@{#427276}

1. Change |output| from vector<uint8_t> to uint8_t*.
2. Add param |data_offset|.

BUG=internal b/31219712
TEST=build cast_shell

Review-Url: https://codereview.chromium.org/2450563002
Cr-Commit-Position: refs/heads/master@{#427275}

This is a follow-up of https://codereview.chromium.org/2445123002/
Removed the file first in the CL and re-add here to avoid problems
on platforms using case-insensitive file names.

TBR=pdr@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2448633002
Cr-Commit-Position: refs/heads/master@{#427274}

CL reasoning:
(1) in line with the pref setting name prefs::kEnableAutoScreenLock
(2) making it more generic for other call usages

BUG=658390
TEST=trybot test

Review-Url: https://codereview.chromium.org/2446453002
Cr-Commit-Position: refs/heads/master@{#427273}

A test is allowed to request a 200% resource and fallback to a 100%
resource. Currently only the last-added 100% data pack provides
fallbacks, which may only be a small supplement.

Instead, scan through all 100% data packs. But only when
InitSharedInstanceWithPakPath() has invoked
ResourceBundle::LoadTestResources().

BUG=636995

Review-Url: https://codereview.chromium.org/2406763002
Cr-Commit-Position: refs/heads/master@{#427272}

According to codesearch, there are no usage of setMemoryCacheCapacities from
JavaScript in the tests.

BUG=603462

Review-Url: https://codereview.chromium.org/2416803002
Cr-Commit-Position: refs/heads/master@{#427271}

Also, wptserve.py shows a warning before certificate expiration.

BUG=623613
NOTRY=true

Review-Url: https://codereview.chromium.org/2443863002
Cr-Commit-Position: refs/heads/master@{#427270}

Ran `tools/clang/scripts/upload_revision.py 284979`.

BUG=656667

Review-Url: https://codereview.chromium.org/2443963002
Cr-Commit-Position: refs/heads/master@{#427269}

BUG=658089
R=dgozman

Review-Url: https://codereview.chromium.org/2435043003
Cr-Commit-Position: refs/heads/master@{#427268}

Preparation for removing didAccessDecodedData()
in https://codereview.chromium.org/2411243004.

BUG=603462

Review-Url: https://codereview.chromium.org/2435873003
Cr-Commit-Position: refs/heads/master@{#427267}

Remoting requires control over the security descriptor used for its
named pipes. This adds this as an option when creating server handles
from named pipes on Windows.

BUG=604282

Review-Url: https://codereview.chromium.org/2444793002
Cr-Commit-Position: refs/heads/master@{#427266}

Currently, there are two important API calls for OffscreenCanvas, which
are transferToImageBitmap and commit. This CL adds usage counter to these
two API calls.

BUG=653599
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2411703004
Cr-Commit-Position: refs/heads/master@{#427265}

BUG=656121, 652345

Review-Url: https://codereview.chromium.org/2416333003
Cr-Commit-Position: refs/heads/master@{#427264}

BUG=648686
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2401853005
Cr-Commit-Position: refs/heads/master@{#427263}

This patch sets the font family for the "system-ui" generic font family
added in [1] on Linux.

With this change, all platforms use the correct font. On Windows, the
browser already pass menu_font_family_name to the renderer. On Mac and
Android, the render can find the system font without needing the
browser to set.

On Linux and Chrome OS, gfx::Font() calls LinuxFontDelegate to figure
out the current system font. On the default Ubuntu, this resolves to
"sans", which Skia resolves to "DejaVu Sans", or "Arial" in
run-layout-test.

[1] http://crrev.com/2137483004

BUG=654679

Review-Url: https://codereview.chromium.org/2138613002
Cr-Commit-Position: refs/heads/master@{#427262}

Adds mobile responsive device list to bluetooth internals page.
Lists device name, address, and latest RSSI.
Refreshes when devices are discovered, removed, or advertising packets are received.

Screenshots
Desktop: https://goo.gl/photos/bot7JsdTuf8P2A328
Mobile: https://goo.gl/photos/G9bb9s4ih5KT3PJw8

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2418343002
Cr-Commit-Position: refs/heads/master@{#427261}

These one were placed incorrectly because of duration is NaN.
drive-by: get rid of highlightTimeRange function.

Review-Url: https://codereview.chromium.org/2445173002
Cr-Commit-Position: refs/heads/master@{#427260}

Cr-Commit-Position: refs/heads/master@{#427259}

BUG=angleproject:1555
TEST=webgl2_conformance on windows
TBR=jmadill@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2445233002
Cr-Commit-Position: refs/heads/master@{#427258}

Please see https://crbug.com/658759 for more context.

The TL;DR is I broke some subtle behavior in
https://crrev.com/425358, and this fixes it. Here's what happens
in ProcessDied, in this order:

  1. We reset channel_ so that future Send() calls throw away
     messages. Note that at this point, any Channel-associated
     interfaces remain valid but are intentionally dropping
     all messages as well.

  2. We fire various notifications about the death of the process.

  3. We re-initialize channel_, allowing subsequent Send() calls
     and associated interface calls to be queued and eventually
     delivered to the new process once it's restarted.

The subtlety here is that if a RenderViewHostImpl is created at any
point during step (2) above, we must re-initialize channel_ and
start allowing messages to be queued on it. Formerly this was
accomplished by EnableSendQueue() setting is_initialized_ to
false. This CL establishes the same behavior by restoring
EnableSendQueue() to essentially have the same effect by re-
initializing the channel earlier.

This is likely not the precise behavior we want, since it seems like
this can cause messages intended for the old process to end up getting
delivered to the new process, but it is the behavior we already had in
place before https://crrev.com/425358 and we apparently rely on it.

BUG=658759

Review-Url: https://codereview.chromium.org/2446543004
Cr-Commit-Position: refs/heads/master@{#427257}

https://chromium.googlesource.com/skia.git/+log/3d3a65c48816..5934646b4937

$ git log 3d3a65c48..5934646b4 --date=short --no-merges --format='%ad %ae %s'
2016-10-24 msarett Help msvs compile SkColorSpaceXform faster
2016-10-24 scroggo Move third_party/gif's license into its own file GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2448573002
2016-10-24 scroggo Differentiate animated image results
2016-10-24 brianosman Populate ALL copies of a command line flag during parsing

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=reed@google.com

Review-Url: https://codereview.chromium.org/2452473002
Cr-Commit-Position: refs/heads/master@{#427256}

This patch simply cleansup some DataGrid a little.

R=dgozman,lushnikov
BUG=None

Review-Url: https://codereview.chromium.org/2445923002
Cr-Commit-Position: refs/heads/master@{#427255}

In order for the browser to correctly reason about suborigins, this adds
support to url::Origin to parse and understand suborigins. It separates
requests for hosts and schemes from the embedded suborigin
serialization, while keeping the same-origin policy checks intact so a
suborigin is a different origin from other suborigins at the same
physical origin.

This updates url/origin.* so that given a suborigin encoded in a GURL,
will correctly deserialize the suborigin and store it accordingly, while
the scheme/host/port tuple is left with the real scheme/host/port.
Additionally, removes the content/public/common/origin_util.h functions
for using suborigins since url::Origin should now be used in their
stead.

BUG=336894,649893

Review-Url: https://codereview.chromium.org/2403713002
Cr-Commit-Position: refs/heads/master@{#427254}