- 06 Feb, 2019 40 commits
-
-
Justin DeWitt authored
When we added a helper function to compute enabled state from the variation the boolean condition was reversed, causing clients that are enabled to cancel their background task (and not do any processing) and the clients that are disabled to continue to do work. Bug: 929371 Change-Id: I168b01644d0248c98a9af78cc7f674d541584fa4 Reviewed-on: https://chromium-review.googlesource.com/c/1456985Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#629762}
-
Tatiana Buldina authored
Bug: chromedriver:2768 Change-Id: I767f85b03941e3b5ff99beae216e08cb7ba40d0a Reviewed-on: https://chromium-review.googlesource.com/c/1456291Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#629761}
-
Tatiana Buldina authored
Change-Id: I73234122c72b45b68b1d42e1d32a56f6f46b8f37 Reviewed-on: https://chromium-review.googlesource.com/c/1454905 Commit-Queue: Tatiana Buldina <buldina@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#629760}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eeb21ab0411e..11e283fea253 git log eeb21ab0411e..11e283fea253 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 achuith@chromium.org cros: No longer need --disable-logging-redirect. 2019-02-06 charliea@chromium.org Fix ftrace clock sync errors on CrOS Created with: gclient setdep -r src/third_party/catapult@11e283fea253 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:928547,chromium:925366 TBR=sullivan@chromium.org Change-Id: I76a487aa87cfb4c3b3505d03a4ab9790f9d91f47 Reviewed-on: https://chromium-review.googlesource.com/c/1456770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629759}
-
Jazz Xu authored
This issue is cause by an empty space between volume slider and the container. When user hover on mute button in a small video/audio frame, the volume slider shoot out towards right, which makes the mouse ended up in the empty space which will close the volume slider. Fixed by adding a container class around mute button and volume slider and close the volume slider only if user is not hovered on the container rather than mute button/volume slider. Bug: 921918 Change-Id: Ida2d943104fca3ab74290e58674856ada25555d5 Reviewed-on: https://chromium-review.googlesource.com/c/1413395 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#629758}
-
Sylvain Defresne authored
The override of RegisterDictionaryPref taking a std::unique_ptr<base::Value> is deprecated in favor of the method taking the base::Value by value. Convert client code to either not pass default value if the value is just an empty dictionary (as there is an override doing this). If the dictionary is not empty, convert the code to create and pass it by value. This CL was uploaded by git cl split. Bug: 646113 Change-Id: I63568d465b7244af4cd687097380c628c54da7e6 Reviewed-on: https://chromium-review.googlesource.com/c/1454366 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#629757}
-
Nicolas Pena authored
Bug: 928887, 581518 Change-Id: I16a5de5e9784a817a37c33f972726e61c68e19d3 Reviewed-on: https://chromium-review.googlesource.com/c/1455342Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#629756}
-
Jun Cai authored
The initial upload of this CL is the same as: https://chromium-review.googlesource.com/c/chromium/src/+/1454633 New changes in the CL from the above original CL: Modifies the output histogram filename to be "histograms.json" This CL modifies the network service performance tests to generate histograms instead of chartjsons so that the Pinpoint can automatic bisect CLs. TBR=crouleau@chromium.org, jam@chromium.org, simonhatch@chromium.org, benjhayden@chromium.org Bug: 927155 Change-Id: I7b9dcd9fdabe7b5e59d7d5143b1ec1e2ffd9606e Reviewed-on: https://chromium-review.googlesource.com/c/1456694Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#629755}
-
Lei Zhang authored
It does not need to live in content/common/. Run git cl format along the way. Change-Id: I04e063334b7df182f0c5fa4eb235e61f49e77beb Reviewed-on: https://chromium-review.googlesource.com/c/1456947Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#629754}
-
Lucas Furukawa Gadani authored
The function was removed in r628003. Change-Id: If72ba5754166b9c6a904e93b001fd8fb5ee45fcb Reviewed-on: https://chromium-review.googlesource.com/c/1457005 Commit-Queue: Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629753}
-
Scott Violet authored
ConstrainedWebDialogSurfaceSynchronizationBrowserTest is also flaky BUG=928924 TEST=test only change TBR=takumif@chromium.org Change-Id: I1a5d343e4b8011708da29704dce3bc697478a373 Reviewed-on: https://chromium-review.googlesource.com/c/1456953Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#629752}
-
Ryan Haining authored
Looks like this happened by copying the complete version and then removing parts of it. Change-Id: If9b0e2fb9ebd5e8abc18cb41baae09c5d9c79574 Reviewed-on: https://chromium-review.googlesource.com/c/1371185Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ryan Haining <haining@google.com> Cr-Commit-Position: refs/heads/master@{#629751}
-
Takumi Fujimoto authored
TBR=hbos Bug: 929355 Change-Id: I480ccde178157b0ff3728257839cf25b789b0519 Reviewed-on: https://chromium-review.googlesource.com/c/1456983Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#629750}
-
Nico Weber authored
The file existed to work around a gyp quirk; in gn there's a better approach, so use that. Also fix the `set_sources_assignment_filter()` pattern in content/renderer/BUILD.gn which was failing to restore the default pattern in one place. No intended behavior change. Bug: none Change-Id: If8eecb3a527853a8e155d20bc1576d52d30dc2af Reviewed-on: https://chromium-review.googlesource.com/c/1456284 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629749}
-
Jimmy Gong authored
- Adds RequestUpdatedSharePathCallback to SmbProvider. - Allows the callback to be passed down to SmbFileSystem at construction. Bug: chromium:922273 Test: compiles Change-Id: If88e7d79ea7b473b8c76ccbc56e8cef8c6ea5b30 Reviewed-on: https://chromium-review.googlesource.com/c/1444596 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#629748}
-
Ryan Haining authored
Change-Id: Ib731061f295c9b79736d20c2a602d4a5abe3314b Reviewed-on: https://chromium-review.googlesource.com/c/1371204Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ryan Haining <haining@google.com> Cr-Commit-Position: refs/heads/master@{#629747}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bac45cb2d283..971e4cb2b43d git log bac45cb2d283..971e4cb2b43d --date=short --no-merges --format='%ad %ae %s' 2019-02-06 cjmcdonald@chromium.org chromeos_config: Disable unittests in grunt P PFQ builder 2019-02-06 manojgupta@google.com chromeos_config: Add arm64-generic to pfq. Created with: gclient setdep -r src/third_party/chromite@971e4cb2b43d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ida15ae5d97275be80d85d48c9560c3c4c0731569 Reviewed-on: https://chromium-review.googlesource.com/c/1456765Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629746}
-
Nicolas Pena authored
Bug: 922195, 898769 Change-Id: I565daad1da5e64576c7c588f77be7f7ff2bb1a1f Reviewed-on: https://chromium-review.googlesource.com/c/1452482Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#629745}
-
Takumi Fujimoto authored
Disabled for flakiness in webui_polymer2_browser_tests on Linux CFI TBR=dpapad Bug: 929288 Change-Id: I9b9fe5e93d720eac8863b3d3a4b387d8223d5eca Reviewed-on: https://chromium-review.googlesource.com/c/1456689Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#629744}
-
Florin Malita authored
SkMatadata is being deprecated in Skia. Its only use in Chromium is to attach a printing::MetafileSkia raw pointer to a PaintCanvas. Replace all SkMetadata dictionaries in PaintCanvas/GraphicsContext with explicit MetafileSkia pointers. Also remove printing::MetafileSkiaWrapper, which only exists as an adapter for the SkMetadata ref-count API. Change-Id: Ic505398a043a3e080b76b72f8defd67a66bbc6ff Reviewed-on: https://chromium-review.googlesource.com/c/1452713Reviewed-by:
Mike Reed <reed@google.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#629743}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0f4bf0720a9c..117a1fd11f11 git log 0f4bf0720a9c..117a1fd11f11 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 33432579+alan-baker@users.noreply.github.com Validate variable pointer related function call rules (#2270) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@117a1fd11f11 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I41ab2266b53fcaa7b1b09cbe4c4959679b6d8f9b Reviewed-on: https://chromium-review.googlesource.com/c/1456762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629742}
-
Jon Kunkee authored
Now that Windows has cross-compilation and symlinking, targets with custom output naming need to provide the correct '.exe' file name to the symlink script. Bug: 893460 Change-Id: I54f3c69c78479fdde7fa52b04d03fc01a2bb4518 Reviewed-on: https://chromium-review.googlesource.com/c/1447252 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#629741}
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Patch is migrating VariationsPlatform to @IntDef with form common with other Chrome @IntDef: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface BUG=919666 Change-Id: Ia098410f3d85c8eb4e6c83422d9705e59363ef4d Reviewed-on: https://chromium-review.googlesource.com/c/1450129Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#629740}
-
Karan Bhatia authored
Support "generate_error_messages" compiler option for idl files. This is needed to enable error generation for types used by the Declarative Net Request API. BUG=926609 Change-Id: I2ee6f467cc2ea0880aa1922fd22c04862a25fe32 Reviewed-on: https://chromium-review.googlesource.com/c/1454292 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629739}
-
Oystein Eftevaag authored
Effectively temporarily reverting https://chromium-review.googlesource.com/c/chromium/src/+/1412016 Bug: 914579, 929142 Change-Id: I443e41fee17f6f09ca5cf5c243dbf330bafef6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1456871 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#629738}
-
Ken Rockot authored
Wipes out services/service_manager/runner. Most of the references to this (specifically to runner/common) were already unused remnants of Mash logic that no longer exists. Stuff that's still relevant only really matters to Service Manager internals or the service executable helper library, so it's been moved accordingly. Bug: 904240 Change-Id: I4e65e2c58d13b2137d455ac3b306db81b846be1c Reviewed-on: https://chromium-review.googlesource.com/c/1453545Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#629737}
-
Mounir Lamouri authored
Bug: 928434 Change-Id: I68195a0faa4484ae0cd7923a4550f86ea1dd9585 Reviewed-on: https://chromium-review.googlesource.com/c/1455045 Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#629736}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/eb47e2c4bd08..740db7fd2795 git log eb47e2c4bd08..740db7fd2795 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 spang@chromium.org Vulkan: Add support for loading layers from DisplayVk Created with: gclient setdep -r src/third_party/angle@740db7fd2795 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I0ae6f09c8e4cff8d378ca6438cd7922f322bb4d4 Reviewed-on: https://chromium-review.googlesource.com/c/1456606Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629735}
-
Ted Choc authored
Looking at the Android CFI bot, I was seeing some failures of testSelectItem with messages like: java.lang.AssertionError: Not all items have a view; positions may be incorrect. expected:<2> but was:<4> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) The problem was the phone had ended up in landscape and thus could not show the full list. This changes the test to support showing a subset of the items and scrolling to the desired position. This also changes the exemption of the constant state drawable to N_MR1 because it was failing constantly for me with the same problem that was previously added for O. BUG=773043,912316 Change-Id: I2719a36deb4852a9922922d8728fde04b7c79afb Reviewed-on: https://chromium-review.googlesource.com/c/1456692Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#629734}
-
Mike Reed authored
Bug: skia:4783 Change-Id: I02c4388dd5c998d132a089caf7f6244c46030d00 Reviewed-on: https://chromium-review.googlesource.com/c/1456978 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#629733}
-
Steven Bennetts authored
This provides an API for the Chrome NetworkPortalDetector to flag a network as in a captive portal state, independent of the portal state provided by Shill. This will allow the UI to properly indicate suspected portal state without an additional direct query to the chrome portal detector. Bug: 862420 Change-Id: I27678477e9bbc5ff2ac2a352ad31919f564f7770 Reviewed-on: https://chromium-review.googlesource.com/c/1449106 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#629732}
-
Yuke Liao authored
This CL adds additional env vars for running webkit_layout_tests on cq coverage trybot so that coverage metadata can be properly emitted. Bug: 929245 Change-Id: I7d597de0a4a937504719a5383abe6f10d76391fa Reviewed-on: https://chromium-review.googlesource.com/c/1456865 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#629731}
-
Gabriel Charette authored
We get frequent questions about these terms and it's time we document them explicitly. "thread-compatible" is a new term we haven't used in the past (we just used initialized-once-read-only-forever-after) but let's use that from now on as it's more consistent with the internal docs: https://engdoc.corp.google.com/eng/doc/devguide/cpp/primer.md?cl=head#thread_safety R=fdoray@chromium.org Change-Id: Ia20eadfb1910d54524bd0c08eb70dd60d94eae39 Reviewed-on: https://chromium-review.googlesource.com/c/1456642 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#629730}
-
Lukasz Anforowicz authored
r613774 started applying CORB to AppCache requests initiated by AppCacheSubresourceURLFactory (which covers requests from the renderer process that are not cached and that fall back to the network). This CL ensures that CORB is also applied to requests that are trigerred by AppCache manifest (even without renderer-originated fetches). Such requests are initiated by AppCacheUpdateJob::UpdateURLLoaderRequest::Start. Bug: 927471 Change-Id: I4e0a8438c646ae7b5e757b48e7d7514e8519c6bb Reviewed-on: https://chromium-review.googlesource.com/c/1448975Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#629729}
-
Xiaohui Chen authored
Bug: b:123939389 Test: locally build and run Change-Id: I6e89f7c622d71ab7862e2c3c25d56778b37eac2c Reviewed-on: https://chromium-review.googlesource.com/c/1455475 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#629728}
-
Robert Ogden authored
Bug: 928891 Change-Id: Icdcf8774a6d6d52444a79c765ba6b353b0fffd45 Reviewed-on: https://chromium-review.googlesource.com/c/1455315Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#629727}
-
Andrew Grieve authored
Bug: 873714 Change-Id: I61144ba0e7bd3a8211e55b5febfc4ee592cf2095 Reviewed-on: https://chromium-review.googlesource.com/c/1456943 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#629726}
-
rbpotter authored
Bug: 928858, 924889, 923914 Change-Id: Iadea7005f5d4b9ddfb18e0883c26f0d0f8865e89 Reviewed-on: https://chromium-review.googlesource.com/c/1454081Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#629725}
-
Sylvain Defresne authored
The override of RegisterListPref taking a std::unique_ptr<base::Value> is deprecated in favor of the method taking the base::Value by value. Convert client code to either not pass default value if the value is just an empty list (as there is an override doing this). If the list is not empty, convert the code to create and pass it by value. This CL was uploaded by git cl split. Bug: 646113 Change-Id: I93f664a5f400f7a89e233417ea630919eb964c56 Reviewed-on: https://chromium-review.googlesource.com/c/1454489 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#629724}
-
Vlad Tsyrklevich authored
In preparation for enabling GWP-ASan on macOS, I've broken out whether it's enabled into its own buildflag/gn build argument. This saves duplicating the GWP-ASan dep into numerous build artifacts for the respective platforms and controls enabling it in a single place. Bug: 912286 Change-Id: I9ccb01580370404dcd07eeaf541face40e94c414 Reviewed-on: https://chromium-review.googlesource.com/c/1453197Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#629723}
-